80857 2012-03-12 10:47:08 -0700 Web Inspector: in protocol make field "securityOrigin" in type Page.Frame mandatory 2013-02-26 05:53:10 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prybin apavlov apavlov bweinstein graouts joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 576263 0 prybin 2012-03-12 10:47:08 -0700 Currently field "securityOrigin" in type Page.Frame is optional. It makes more sense to make it non-optional. 841916 1 190266 apavlov 2013-02-26 05:33:19 -0800 Created attachment 190266 Patch 841931 2 apavlov 2013-02-26 05:53:10 -0800 Committed r144049: <http://trac.webkit.org/changeset/144049> 190266 2013-02-26 05:33:19 -0800 2013-02-26 05:43:04 -0800 Patch bug-80857-20130226172933.patch text/plain 5043 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWFlYjY0ZThkOTg3MmJi MzgwNWU2ZGVhZWI0YmJmYmI0MDg4ODZlNy4uMTg3YjM5ZTFjNmYzYjBiYTA5MDQ5MmM3YmMzZTBl YTYzZTBiYzRhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAyLTI2ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogaW4gcHJvdG9jb2wgbWFrZSBmaWVsZCAic2VjdXJpdHlPcmlnaW4iIGluIHR5cGUgUGFn ZS5GcmFtZSBtYW5kYXRvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgwODU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRnJhbWUuc2VjdXJpdHlPcmlnaW4gaGFzIGFsd2F5cyBiZWVuIHNldCB0byBhIHZh bGlkIHZhbHVlLCBzbyB0aGlzIGNoYW5nZSBqdXN0IGZpeGVzCisgICAgICAgIHRoZSBwcm90b2Nv bCBmbGF3LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uOgorICAgICAgICAq IGluc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5z cGVjdG9yUGFnZUFnZW50OjpidWlsZE9iamVjdEZvckZyYW1lKToKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1Jlc291cmNlVHJlZU1vZGVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlJlc291cmNlVHJlZUZyYW1lKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZVRyZWVG cmFtZS5wcm90b3R5cGUuX25hdmlnYXRlKToKKwogMjAxMy0wMi0yNiAgSmFtZXMgV2VhdGhlcmFs bCAgPHdlekBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAga2V5ZG93biBhbmQga2V5dXAgZXZlbnRz IGhhdmUgemVybyBrZXljb2RlIGZvciBzb21lIG51bWVyaWMgcGFkIGtleXMgdW5kZXIgQ2hyb21p dW0gb24gTGludXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3IuanNvbiBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbgppbmRleCBm MjdmNTRjMDNkNDk3MDU4MzQyOThhZWJjYzM2ODExZTUzYWE3NzRmLi5mMjZkNGU2YzgxY2RjMzVk MzI4NjY1OGYyNjk3NGI3MGE2MTAyYjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yLmpzb24KKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3Rvci5qc29uCkBAIC0xMTEsNyArMTExLDcgQEAKICAgICAgICAgICAgICAgICAgICAgeyAibmFt ZSI6ICJsb2FkZXJJZCIsICIkcmVmIjogIk5ldHdvcmsuTG9hZGVySWQiLCAiZGVzY3JpcHRpb24i OiAiSWRlbnRpZmllciBvZiB0aGUgbG9hZGVyIGFzc29jaWF0ZWQgd2l0aCB0aGlzIGZyYW1lLiIg fSwKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJuYW1lIiwgInR5cGUiOiAic3RyaW5n IiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9uIjogIkZyYW1lJ3MgbmFtZSBhcyBzcGVj aWZpZWQgaW4gdGhlIHRhZy4iIH0sCiAgICAgICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAidXJs IiwgInR5cGUiOiAic3RyaW5nIiwgImRlc2NyaXB0aW9uIjogIkZyYW1lIGRvY3VtZW50J3MgVVJM LiIgfSwKLSAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJzZWN1cml0eU9yaWdpbiIsICJ0 eXBlIjogInN0cmluZyIsICJvcHRpb25hbCI6IHRydWUsICJkZXNjcmlwdGlvbiI6ICJGcmFtZSBk b2N1bWVudCdzIHNlY3VyaXR5IG9yaWdpbi4iIH0sCisgICAgICAgICAgICAgICAgICAgIHsgIm5h bWUiOiAic2VjdXJpdHlPcmlnaW4iLCAidHlwZSI6ICJzdHJpbmciLCAiZGVzY3JpcHRpb24iOiAi RnJhbWUgZG9jdW1lbnQncyBzZWN1cml0eSBvcmlnaW4uIiB9LAogICAgICAgICAgICAgICAgICAg ICB7ICJuYW1lIjogIm1pbWVUeXBlIiwgInR5cGUiOiAic3RyaW5nIiwgImRlc2NyaXB0aW9uIjog IkZyYW1lIGRvY3VtZW50J3MgbWltZVR5cGUgYXMgZGV0ZXJtaW5lZCBieSB0aGUgYnJvd3Nlci4i IH0KICAgICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgICJoaWRkZW4iOiB0cnVlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUGFnZUFnZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCmluZGV4 IDFkZDZiNmVmMmMzNDA4N2UzZDhmZjc0YTIzZWJhYmE2Yjk3NzMwZGMuLjY5OWNjOTg3YTU0Mjcw MmVkYThiOTM2N2MzMzlhZjU2OTA3YWQ0ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCkBAIC0xMDc0LDEwICsxMDc0LDExIEBAIHZvaWQg SW5zcGVjdG9yUGFnZUFnZW50OjpzY3JpcHRzRW5hYmxlZChib29sIGlzRW5hYmxlZCkKIFBhc3NS ZWZQdHI8VHlwZUJ1aWxkZXI6OlBhZ2U6OkZyYW1lPiBJbnNwZWN0b3JQYWdlQWdlbnQ6OmJ1aWxk T2JqZWN0Rm9yRnJhbWUoRnJhbWUqIGZyYW1lKQogewogICAgIFJlZlB0cjxUeXBlQnVpbGRlcjo6 UGFnZTo6RnJhbWU+IGZyYW1lT2JqZWN0ID0gVHlwZUJ1aWxkZXI6OlBhZ2U6OkZyYW1lOjpjcmVh dGUoKQotICAgICAgICAgLnNldElkKGZyYW1lSWQoZnJhbWUpKQotICAgICAgICAgLnNldExvYWRl cklkKGxvYWRlcklkKGZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKSkpCi0gICAgICAg ICAuc2V0VXJsKGZyYW1lLT5kb2N1bWVudCgpLT51cmwoKS5zdHJpbmcoKSkKLSAgICAgICAgIC5z ZXRNaW1lVHlwZShmcmFtZS0+bG9hZGVyKCktPmRvY3VtZW50TG9hZGVyKCktPnJlc3BvbnNlTUlN RVR5cGUoKSk7CisgICAgICAgIC5zZXRJZChmcmFtZUlkKGZyYW1lKSkKKyAgICAgICAgLnNldExv YWRlcklkKGxvYWRlcklkKGZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1lbnRMb2FkZXIoKSkpCisgICAg ICAgIC5zZXRVcmwoZnJhbWUtPmRvY3VtZW50KCktPnVybCgpLnN0cmluZygpKQorICAgICAgICAu c2V0TWltZVR5cGUoZnJhbWUtPmxvYWRlcigpLT5kb2N1bWVudExvYWRlcigpLT5yZXNwb25zZU1J TUVUeXBlKCkpCisgICAgICAgIC5zZXRTZWN1cml0eU9yaWdpbihmcmFtZS0+ZG9jdW1lbnQoKS0+ c2VjdXJpdHlPcmlnaW4oKS0+dG9SYXdTdHJpbmcoKSk7CiAgICAgaWYgKGZyYW1lLT50cmVlKCkt PnBhcmVudCgpKQogICAgICAgICBmcmFtZU9iamVjdC0+c2V0UGFyZW50SWQoZnJhbWVJZChmcmFt ZS0+dHJlZSgpLT5wYXJlbnQoKSkpOwogICAgIGlmIChmcmFtZS0+b3duZXJFbGVtZW50KCkpIHsK QEAgLTEwODYsOCArMTA4Nyw2IEBAIFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6OlBhZ2U6OkZyYW1l PiBJbnNwZWN0b3JQYWdlQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9yRnJhbWUoRnJhCiAgICAgICAgICAg ICBuYW1lID0gZnJhbWUtPm93bmVyRWxlbWVudCgpLT5nZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpp ZEF0dHIpOwogICAgICAgICBmcmFtZU9iamVjdC0+c2V0TmFtZShuYW1lKTsKICAgICB9Ci0gICAg Ly8gRklYTUU6IE1ha2UgdGhpcyBmaWVsZCBub24tb3B0aW9uYWwuIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg1NwotICAgIGZyYW1lT2JqZWN0LT5zZXRTZWN1cml0 eU9yaWdpbihmcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmlnaW4oKS0+dG9SYXdTdHJpbmco KSk7CiAKICAgICByZXR1cm4gZnJhbWVPYmplY3Q7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVHJlZU1vZGVsLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVRyZWVNb2RlbC5qcwppbmRleCBiMWVj MTJmYmI3ZDQ0YjcwYjU2NDY4NDZlZTY1MjY4ZGQ2Y2MzNzU3Li4yNmIzZDdiYWQzMzU1YzM1ZGZi MzBmOTc4OWQwMjZmYjYyMGQyY2IxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1Jlc291cmNlVHJlZU1vZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VUcmVlTW9kZWwuanMKQEAgLTQyMyw3ICs0MjMsNyBA QCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VUcmVlRnJhbWUgPSBmdW5jdGlvbihtb2RlbCwgcGFyZW50 RnJhbWUsIHBheWxvYWQpCiAgICAgdGhpcy5fbG9hZGVySWQgPSBwYXlsb2FkLmxvYWRlcklkOwog ICAgIHRoaXMuX25hbWUgPSBwYXlsb2FkLm5hbWU7CiAgICAgdGhpcy5fdXJsID0gcGF5bG9hZC51 cmw7Ci0gICAgdGhpcy5fc2VjdXJpdHlPcmlnaW4gPSBwYXlsb2FkLnNlY3VyaXR5T3JpZ2luIHx8 ICIiOworICAgIHRoaXMuX3NlY3VyaXR5T3JpZ2luID0gcGF5bG9hZC5zZWN1cml0eU9yaWdpbjsK ICAgICB0aGlzLl9taW1lVHlwZSA9IHBheWxvYWQubWltZVR5cGU7CiAKICAgICAvKioKQEAgLTUx Myw3ICs1MTMsNyBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VUcmVlRnJhbWUucHJvdG90eXBlID0g ewogICAgICAgICB0aGlzLl9sb2FkZXJJZCA9IGZyYW1lUGF5bG9hZC5sb2FkZXJJZDsKICAgICAg ICAgdGhpcy5fbmFtZSA9IGZyYW1lUGF5bG9hZC5uYW1lOwogICAgICAgICB0aGlzLl91cmwgPSBm cmFtZVBheWxvYWQudXJsOwotICAgICAgICB0aGlzLl9zZWN1cml0eU9yaWdpbiA9IGZyYW1lUGF5 bG9hZC5zZWN1cml0eU9yaWdpbiB8fCAiIjsKKyAgICAgICAgdGhpcy5fc2VjdXJpdHlPcmlnaW4g PSBmcmFtZVBheWxvYWQuc2VjdXJpdHlPcmlnaW47CiAgICAgICAgIHRoaXMuX21pbWVUeXBlID0g ZnJhbWVQYXlsb2FkLm1pbWVUeXBlOwogCiAgICAgICAgIHZhciBtYWluUmVzb3VyY2UgPSB0aGlz Ll9yZXNvdXJjZXNNYXBbdGhpcy5fdXJsXTsK