80848 2012-03-12 08:57:23 -0700 [TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer. 2012-03-13 14:21:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte noam oldest_to_newest 576166 0 jturcotte 2012-03-12 08:57:23 -0700 [TexMapGL] Pixel-align the transform of textures that fit pixel-for-pixel on the frame buffer. 576167 1 131333 jturcotte 2012-03-12 09:05:59 -0700 Created attachment 131333 Patch 576224 2 jturcotte 2012-03-12 10:10:02 -0700 Committed r110439: <http://trac.webkit.org/changeset/110439> 577782 3 tonikitoo 2012-03-13 13:50:55 -0700 did this make qtwebkit test resuts very flaky? http://build.webkit.org/builders/Qt%20Linux%20Release?numbuilds=50 577783 4 tonikitoo 2012-03-13 13:51:12 -0700 (In reply to comment #3) > did this make qtwebkit test resuts very flaky? > > http://build.webkit.org/builders/Qt%20Linux%20Release?numbuilds=50 results 577816 5 noam 2012-03-13 14:21:06 -0700 (In reply to comment #4) > (In reply to comment #3) > > did this make qtwebkit test resuts very flaky? > > > > http://build.webkit.org/builders/Qt%20Linux%20Release?numbuilds=50 > > results I doubt it. This code path only applies to API tests, not to layout-tests. 131333 2012-03-12 09:05:59 -0700 2012-03-12 09:07:38 -0700 Patch bug-80848-20120312170505.patch text/plain 7244 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFjODNkNGU5YjFiMWE4 NjY5NzZiNjExMjE4YWJhMWVhMGEyYTg4YS4uM2U0ODg3ZDQyODliMGE2ZDIwNDcwMDQ3MWY5ZTAw OWU5NGJkYzVjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEyLTAzLTEyICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKKyAgICAgICAgW1Rl eE1hcEdMXSBQaXhlbC1hbGlnbiB0aGUgdHJhbnNmb3JtIG9mIHRleHR1cmVzIHRoYXQgZml0IHBp eGVsLWZvci1waXhlbCBvbiB0aGUgZnJhbWUgYnVmZmVyLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4NDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHJlbmRlcmluZyBhIHRyYW5zZm9ybWVkIHRl eHR1cmUgb24gdGhlIHNjcmVlbiB3aXRoIGEgZnJhY3Rpb25hbAorICAgICAgICBjb29yZGluYXRl IHdpdGggbGluZWFyIGZpbHRlcmluZywgdGhlIHJlc3VsdGluZyBwaXhlbCB3aWxsIGJlIGJsZW5k ZWQgZnJvbQorICAgICAgICB0aGUgdGV4ZWxzIGFyb3VuZCB0aGlzIGZyYWN0aW9uYWwgcG9zaXRp b24gYWNjb3JkaW5nIHRvIHRoZWlyIGNvdmVyIHJhdGlvLgorICAgICAgICBUaGlzIHByb2R1Y2Vz IGEgc2xpZ2h0IGJsdXIgb2YgcGl4ZWxzIHdoaWNoIGdpdmUgbm8gYmVuZWZpdCB3aGVuIHJlbmRl cmluZworICAgICAgICBhIHRleHR1cmUgdGhhdCBpc24ndCBzY2FsZWQuCisKKyAgICAgICAgVGhp cyBwYXRjaCBvZmZzZXRzIHRoZSB0cmFuc2Zvcm0gYnkgcm91bmRpbmcgdGhlIHRyYW5zbGF0aW9u IHBhcnQgb2YgdGhlCisgICAgICAgIGxheWVyJ3MgdHJhbnNmb3JtIHRvIGFsaWduIHRoZSByZXN1 bHQgdG8gaW50ZWdlciBjb29yZGluYXRlcy4KKyAgICAgICAgQXBwbHlpbmcgdGhlIGFkanVzdG1l bnQgb24gdGhlIGxheWVyIHRyYW5zZm9ybSBtYWtlcyBzdXJlIHRoYXQgYWxsIHRoZSB0aWxlcwor ICAgICAgICBnZXQgdGhlIHNhbWUgYWRqdXN0bWVudC4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0M0RQcml2YXRlOjpwYWludFRvVGV4dHVyZU1hcHBlcik6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpUZXh0dXJlTWFwcGVyR0w6OmRyYXdUZXh0dXJlKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmg6CisgICAgICAgIChXZWJDb3JlOjpC aXRtYXBUZXh0dXJlR0w6OnRleHR1cmVTaXplKToKKworMjAxMi0wMy0xMiAgSm9jZWx5biBUdXJj b3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEuY29tPgorCiAgICAgICAgIFtUZXhNYXBHTF0g VXNlIHRleHR1cmVzIHNpemVkIGV4YWN0bHkgdG8gdGhlaXIgY29udGVudHMuCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg0NQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dDNEUXQuY3BwCmluZGV4IGJmNjFjOGI1MGQ5MzkyNzBmZDAwY2EwMjFlYTllOWViNGVjZTBiZmIu LmY4ZjkwNTJiMzAzNzlmYWZlOTM4NjQ4MjA2YTIxMDRkOWE5OWVmNTQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dDNEUXQuY3BwCkBAIC0xMjQsNyArMTI0LDggQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRFByaXZh dGU6OnBhaW50VG9UZXh0dXJlTWFwcGVyKFRleHR1cmVNYXBwZXIqIHRleHR1cmVNYXBwZXIKICAg ICBpZiAodGV4dHVyZU1hcHBlci0+YWNjZWxlcmF0aW9uTW9kZSgpID09IFRleHR1cmVNYXBwZXI6 Ok9wZW5HTE1vZGUpIHsKICAgICAgICAgVGV4dHVyZU1hcHBlckdMKiB0ZXhtYXBHTCA9IHN0YXRp Y19jYXN0PFRleHR1cmVNYXBwZXJHTCo+KHRleHR1cmVNYXBwZXIpOwogICAgICAgICBUZXh0dXJl TWFwcGVyR0w6OkZsYWdzIGZsYWdzID0gVGV4dHVyZU1hcHBlckdMOjpTaG91bGRGbGlwVGV4dHVy ZSB8IChtX2NvbnRleHQtPm1fYXR0cnMuYWxwaGEgPyBUZXh0dXJlTWFwcGVyR0w6OlN1cHBvcnRz QmxlbmRpbmcgOiAwKTsKLSAgICAgICAgdGV4bWFwR0wtPmRyYXdUZXh0dXJlKG1fY29udGV4dC0+ bV90ZXh0dXJlLCBmbGFncywgdGFyZ2V0UmVjdCwgbWF0cml4LCBvcGFjaXR5LCBtYXNrKTsKKyAg ICAgICAgSW50U2l6ZSB0ZXh0dXJlU2l6ZShtX2NvbnRleHQtPm1fY3VycmVudFdpZHRoLCBtX2Nv bnRleHQtPm1fY3VycmVudEhlaWdodCk7CisgICAgICAgIHRleG1hcEdMLT5kcmF3VGV4dHVyZSht X2NvbnRleHQtPm1fdGV4dHVyZSwgZmxhZ3MsIHRleHR1cmVTaXplLCB0YXJnZXRSZWN0LCBtYXRy aXgsIG9wYWNpdHksIG1hc2spOwogICAgICAgICByZXR1cm47CiAgICAgfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdM LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyR0wuY3BwCmluZGV4IDAyNjEyZmU3ZWZkNTYwOWI4NWRmZDhiZjJiOTc0YTY4OWQ0NmYzODAu LmM4YjhjZDliMDQ2OTQzZjhkMGQwZmIyYjBmOGU0ODBjNTlkZDAwMjUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyR0wuY3BwCkBAIC0zMTMsMTAgKzMxMywxMCBAQCB2b2lkIFRleHR1cmVNYXBwZXJHTDo6ZHJh d1RleHR1cmUoY29uc3QgQml0bWFwVGV4dHVyZSYgdGV4dHVyZSwgY29uc3QgRmxvYXRSZWN0Jgog ICAgICAgICByZXR1cm47CiAKICAgICBjb25zdCBCaXRtYXBUZXh0dXJlR0wmIHRleHR1cmVHTCA9 IHN0YXRpY19jYXN0PGNvbnN0IEJpdG1hcFRleHR1cmVHTCY+KHRleHR1cmUpOwotICAgIGRyYXdU ZXh0dXJlKHRleHR1cmVHTC5pZCgpLCB0ZXh0dXJlR0wuaXNPcGFxdWUoKSA/IDAgOiBTdXBwb3J0 c0JsZW5kaW5nLCB0YXJnZXRSZWN0LCBtYXRyaXgsIG9wYWNpdHksIG1hc2spOworICAgIGRyYXdU ZXh0dXJlKHRleHR1cmVHTC5pZCgpLCB0ZXh0dXJlR0wuaXNPcGFxdWUoKSA/IDAgOiBTdXBwb3J0 c0JsZW5kaW5nLCB0ZXh0dXJlR0wuc2l6ZSgpLCB0YXJnZXRSZWN0LCBtYXRyaXgsIG9wYWNpdHks IG1hc2spOwogfQogCi12b2lkIFRleHR1cmVNYXBwZXJHTDo6ZHJhd1RleHR1cmUodWludDMyX3Qg dGV4dHVyZSwgRmxhZ3MgZmxhZ3MsIGNvbnN0IEZsb2F0UmVjdCYgdGFyZ2V0UmVjdCwgY29uc3Qg VHJhbnNmb3JtYXRpb25NYXRyaXgmIG1vZGVsVmlld01hdHJpeCwgZmxvYXQgb3BhY2l0eSwgY29u c3QgQml0bWFwVGV4dHVyZSogbWFza1RleHR1cmUpCit2b2lkIFRleHR1cmVNYXBwZXJHTDo6ZHJh d1RleHR1cmUodWludDMyX3QgdGV4dHVyZSwgRmxhZ3MgZmxhZ3MsIGNvbnN0IEludFNpemUmIHRl eHR1cmVTaXplLCBjb25zdCBGbG9hdFJlY3QmIHRhcmdldFJlY3QsIGNvbnN0IFRyYW5zZm9ybWF0 aW9uTWF0cml4JiBtb2RlbFZpZXdNYXRyaXgsIGZsb2F0IG9wYWNpdHksIGNvbnN0IEJpdG1hcFRl eHR1cmUqIG1hc2tUZXh0dXJlKQogewogICAgIFJlZlB0cjxUZXh0dXJlTWFwcGVyU2hhZGVyUHJv Z3JhbT4gc2hhZGVySW5mbzsKICAgICBpZiAobWFza1RleHR1cmUpCkBAIC0zMzIsNyArMzMyLDIz IEBAIHZvaWQgVGV4dHVyZU1hcHBlckdMOjpkcmF3VGV4dHVyZSh1aW50MzJfdCB0ZXh0dXJlLCBG bGFncyBmbGFncywgY29uc3QgRmxvYXRSZWN0CiAgICAgY29uc3QgR0xmbG9hdCB1bml0UmVjdFtd ID0gezAsIDAsIDEsIDAsIDEsIDEsIDAsIDF9OwogICAgIEdMX0NNRChnbFZlcnRleEF0dHJpYlBv aW50ZXIoc2hhZGVySW5mby0+dmVydGV4QXR0cmliKCksIDIsIEdMX0ZMT0FULCBHTF9GQUxTRSwg MCwgdW5pdFJlY3QpKQogCi0gICAgVHJhbnNmb3JtYXRpb25NYXRyaXggbWF0cml4ID0gVHJhbnNm b3JtYXRpb25NYXRyaXgoZGF0YSgpLnByb2plY3Rpb25NYXRyaXgpLm11bHRpcGx5KG1vZGVsVmll d01hdHJpeCkubXVsdGlwbHkoVHJhbnNmb3JtYXRpb25NYXRyaXgoCisgICAgVHJhbnNmb3JtYXRp b25NYXRyaXggYWRqdXN0ZWRNb2RlbFZpZXdNYXRyaXgobW9kZWxWaWV3TWF0cml4KTsKKyAgICAv LyBDaGVjayBpZiB0aGUgdHJhbnNmb3JtZWQgdGFyZ2V0IHJlY3QgaGFzIHRoZSBzYW1lIHNoYXBl L2RpbWVuc2lvbnMgYXMgdGhlIGRyYXduIHRleHR1cmUgKGkuZS4gdHJhbnNsYXRlZCBvbmx5KS4K KyAgICBGbG9hdFF1YWQgZmluYWxRdWFkID0gbW9kZWxWaWV3TWF0cml4Lm1hcFF1YWQoRmxvYXRR dWFkKHRhcmdldFJlY3QpKTsKKyAgICBGbG9hdFNpemUgZmluYWxTaXplID0gZmluYWxRdWFkLnAz KCkgLSBmaW5hbFF1YWQucDEoKTsKKyAgICBpZiAoYWJzKHRleHR1cmVTaXplLndpZHRoKCkgLSBm aW5hbFNpemUud2lkdGgoKSkgPCAwLjAwMQorICAgICAgICAmJiBhYnModGV4dHVyZVNpemUuaGVp Z2h0KCkgLSBmaW5hbFNpemUuaGVpZ2h0KCkpIDwgMC4wMDEKKyAgICAgICAgJiYgZmluYWxRdWFk LnAyKCkueSgpID09IGZpbmFsUXVhZC5wMSgpLnkoKQorICAgICAgICAmJiBmaW5hbFF1YWQucDIo KS54KCkgPT0gZmluYWxRdWFkLnAzKCkueCgpCisgICAgICAgICYmIGZpbmFsUXVhZC5wNCgpLngo KSA9PSBmaW5hbFF1YWQucDEoKS54KCkKKyAgICAgICAgJiYgZmluYWxRdWFkLnA0KCkueSgpID09 IGZpbmFsUXVhZC5wMygpLnkoKSkgeworICAgICAgICAvLyBQaXhlbC1hbGlnbiB0aGUgb3JpZ2lu IG9mIG91ciBsYXllcidzIGNvb3JkaW5hdGUgc3lzdGVtIHdpdGhpbiB0aGUgZnJhbWUgYnVmZmVy J3MKKyAgICAgICAgLy8gY29vcmRpbmF0ZSBzeXN0ZW0gdG8gYXZvaWQgc3ViLXBpeGVsIGludGVy cG9sYXRpb24uCisgICAgICAgIGFkanVzdGVkTW9kZWxWaWV3TWF0cml4LnNldE00MShmbG9vcihh ZGp1c3RlZE1vZGVsVmlld01hdHJpeC5tNDEoKSArIDAuNSkpOworICAgICAgICBhZGp1c3RlZE1v ZGVsVmlld01hdHJpeC5zZXRNNDIoZmxvb3IoYWRqdXN0ZWRNb2RlbFZpZXdNYXRyaXgubTQyKCkg KyAwLjUpKTsKKyAgICB9CisKKyAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCBtYXRyaXggPSBUcmFu c2Zvcm1hdGlvbk1hdHJpeChkYXRhKCkucHJvamVjdGlvbk1hdHJpeCkubXVsdGlwbHkoYWRqdXN0 ZWRNb2RlbFZpZXdNYXRyaXgpLm11bHRpcGx5KFRyYW5zZm9ybWF0aW9uTWF0cml4KAogICAgICAg ICAgICAgdGFyZ2V0UmVjdC53aWR0aCgpLCAwLCAwLCAwLAogICAgICAgICAgICAgMCwgdGFyZ2V0 UmVjdC5oZWlnaHQoKSwgMCwgMCwKICAgICAgICAgICAgIDAsIDAsIDEsIDAsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdM LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckdMLmgKaW5kZXggNTU2MTg0MzBjNmYwOTM2Y2QzODIwYWM1YjY5YmMwYWJjYWM2MWRmYi4uZWYy YjI1OGJmYWJiMGEyMTBiNjZmYTIyNjJmMmFkZTg2YjllYzcxYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wu aApAQCAtNDksNyArNDksNyBAQCBwdWJsaWM6CiAKICAgICAvLyByZWltcHMgZnJvbSBUZXh0dXJl TWFwcGVyCiAgICAgdmlydHVhbCB2b2lkIGRyYXdUZXh0dXJlKGNvbnN0IEJpdG1hcFRleHR1cmUm LCBjb25zdCBGbG9hdFJlY3QmLCBjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYsIGZsb2F0IG9w YWNpdHksIGNvbnN0IEJpdG1hcFRleHR1cmUqIG1hc2tUZXh0dXJlKTsKLSAgICB2aXJ0dWFsIHZv aWQgZHJhd1RleHR1cmUodWludDMyX3QgdGV4dHVyZSwgRmxhZ3MsIGNvbnN0IEZsb2F0UmVjdCYs IGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4JiwgZmxvYXQgb3BhY2l0eSwgY29uc3QgQml0bWFw VGV4dHVyZSogbWFza1RleHR1cmUpOworICAgIHZpcnR1YWwgdm9pZCBkcmF3VGV4dHVyZSh1aW50 MzJfdCB0ZXh0dXJlLCBGbGFncywgY29uc3QgSW50U2l6ZSYgdGV4dHVyZVNpemUsIGNvbnN0IEZs b2F0UmVjdCYgdGFyZ2V0UmVjdCwgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIG1vZGVsVmll d01hdHJpeCwgZmxvYXQgb3BhY2l0eSwgY29uc3QgQml0bWFwVGV4dHVyZSogbWFza1RleHR1cmUp OwogICAgIHZpcnR1YWwgdm9pZCBiaW5kU3VyZmFjZShCaXRtYXBUZXh0dXJlKiBzdXJmYWNlKTsK ICAgICB2aXJ0dWFsIHZvaWQgYmVnaW5DbGlwKGNvbnN0IFRyYW5zZm9ybWF0aW9uTWF0cml4Jiwg Y29uc3QgRmxvYXRSZWN0Jik7CiAgICAgdmlydHVhbCB2b2lkIGJlZ2luUGFpbnRpbmcoKTsKQEAg LTgyLDYgKzgyLDcgQEAgcHVibGljOgogICAgIHZvaWQgaW5pdGlhbGl6ZVN0ZW5jaWwoKTsKICAg ICB+Qml0bWFwVGV4dHVyZUdMKCk7CiAgICAgdmlydHVhbCB1aW50MzJfdCBpZCgpIGNvbnN0IHsg cmV0dXJuIG1faWQ7IH0KKyAgICBJbnRTaXplIHRleHR1cmVTaXplKCkgY29uc3QgeyByZXR1cm4g bV90ZXh0dXJlU2l6ZTsgfQogICAgIHZvaWQgc2V0VGV4dHVyZU1hcHBlcihUZXh0dXJlTWFwcGVy R0wqIHRleG1hcCkgeyBtX3RleHR1cmVNYXBwZXIgPSB0ZXhtYXA7IH0KICAgICB2b2lkIHVwZGF0 ZUNvbnRlbnRzKEltYWdlKiwgY29uc3QgSW50UmVjdCYsIGNvbnN0IEludFJlY3QmLCBQaXhlbEZv cm1hdCk7CiAgICAgdm9pZCB1cGRhdGVDb250ZW50cyhjb25zdCB2b2lkKiwgY29uc3QgSW50UmVj dCYpOwo=