80838 2012-03-12 08:09:33 -0700 Final newline (LF or CRLF) in paste buffer is converted to space 2012-10-11 02:23:53 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gconklin webkit-unassigned ap dcheng enrica jeff ksakamoto mifenton rniwa tkent webkit.review.bot oldest_to_newest 576126 0 gconklin 2012-03-12 08:09:33 -0700 Using Chrome 19.0.1061.1 dev-m (and many previous versions) Chrome had a related bug (http://code.google.com/p/chromium/issues/detail?id=106551) dealing with the final newline in the paste buffer that they fixed (https://bugs.webkit.org/show_bug.cgi?id=79305), but they say the second part is a WebKit issue and has always been that way. However, no other browser works this way. On a form where an INPUT TYPE=TEXT field is pasted into, the final newline is converted to a space and other browsers I tested truncate it. Given a paste buffer of "A[newline]B[newline]C[newline]" the results of the paste into the TEXT field in various browsers is: FireFox: "A B C" IE: "A B C" Chrome/WebKit: "A B C " (trailing space after C) This is most noticeable when copying text from a MS Excel field. If the TEXT field is a password field (***) you won't even see the trailing space to know to remove it with a quick backspace. 739697 1 168164 ksakamoto 2012-10-11 01:16:13 -0700 Created attachment 168164 Patch 739702 2 168164 rniwa 2012-10-11 01:21:24 -0700 Comment on attachment 168164 Patch Looks sane to me. 739738 3 168164 webkit.review.bot 2012-10-11 02:23:50 -0700 Comment on attachment 168164 Patch Clearing flags on attachment: 168164 Committed r131032: <http://trac.webkit.org/changeset/131032> 739739 4 webkit.review.bot 2012-10-11 02:23:53 -0700 All reviewed patches have been landed. Closing bug. 168164 2012-10-11 01:16:13 -0700 2012-10-11 02:23:50 -0700 Patch bug-80838-20121011171511.patch text/plain 6891 ksakamoto U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RkY2YzZTY0N2UxY2M4 YjdhNDg3ZTBlZjFjNGQ0ZjNhOGI2YzUxYi4uZGJmNTUwZDFlYTMyZmM5NzFmYmU3MjkwYWFjM2Zh MzkzNmQ0ZWM0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTExICBLdW5p aGlrbyBTYWthbW90byAgPGtzYWthbW90b0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRmluYWwg bmV3bGluZSAoTEYgb3IgQ1JMRikgaW4gcGFzdGUgYnVmZmVyIGlzIGNvbnZlcnRlZCB0byBzcGFj ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4MzgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50 bHkgbmV3bGluZSBjaGFyYWN0ZXJzIGFyZSByZXBsYWNlZCB3aXRoIHNwYWNlcyB3aGVuIHBhc3Rl ZAorICAgICAgICB0byB0ZXh0IGlucHV0LiBUaGlzIGJlaGF2aW9yIHdhcyBpbnRyb2R1Y2VkIGlu IHIzNzUzOSwgd2l0aCB0aGUKKyAgICAgICAgaW50ZW50aW9uIHRvIGZvbGxvdyB0aGUgRmlyZUZv eCdzIGJlaGF2aW9yIChzZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNDYxKS4gSG93ZXZlciwgRmlyZUZveAorICAgICAgICB0cnVuY2F0ZXMgbmV3 bGluZXMgYXQgdGhlIGVuZCBvZiBwYXN0ZWQgdGV4dCwgaW5zdGVhZCBvZiByZXBsYWNpbmcKKyAg ICAgICAgdGhlbSB3aXRoIHNwYWNlcy4gU28gdGhpcyBwYXRjaCBjaGFuZ2VzIFRleHRGaWVsZElu cHV0VHlwZSB0byBjdXQKKyAgICAgICAgdHJhaWxpbmcgbmV3bGluZXMgb2YgaW5zZXJ0ZWQgdGV4 dC4KKworICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3Bhc3RlLW11bHRpbGluZS10ZXh0LWlucHV0 Lmh0bWwKKworICAgICAgICAqIGh0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlRleHRGaWVsZElucHV0VHlwZTo6aGFuZGxlQmVmb3JlVGV4dEluc2VydGVkRXZl bnQpOgorICAgICAgICBUcnVuY2F0ZXMgdHJhaWxpbmcgbmV3bGluZXMuCisKIDIwMTItMTAtMTAg IENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAg ICBTUUxSZXN1bHRTZXQucm93c0FmZmVjdGVkIG5vdCBjbGVhcmVkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAKaW5kZXggNjkyMTIxZTVjYzRhMGMwOTBmYzJlY2Vl NWVmMzVmNTRjMmM2ZWFjZi4uM2U2YzFlZTdjZTI1NGZjZTAwNjg2YTYyZDFmYTk5YTdmMjkyZjgw ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9UZXh0RmllbGRJbnB1dFR5cGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcApAQCAtMzgx LDYgKzM4MSwxMCBAQCB2b2lkIFRleHRGaWVsZElucHV0VHlwZTo6aGFuZGxlQmVmb3JlVGV4dElu c2VydGVkRXZlbnQoQmVmb3JlVGV4dEluc2VydGVkRXZlbnQqCiAKICAgICAvLyBUcnVuY2F0ZSB0 aGUgaW5zZXJ0ZWQgdGV4dCB0byBhdm9pZCB2aW9sYXRpbmcgdGhlIG1heExlbmd0aCBhbmQgb3Ro ZXIgY29uc3RyYWludHMuCiAgICAgU3RyaW5nIGV2ZW50VGV4dCA9IGV2ZW50LT50ZXh0KCk7Cisg ICAgdW5zaWduZWQgdGV4dExlbmd0aCA9IGV2ZW50VGV4dC5sZW5ndGgoKTsKKyAgICB3aGlsZSAo dGV4dExlbmd0aCA+IDAgJiYgaXNBU0NJSUxpbmVCcmVhayhldmVudFRleHRbdGV4dExlbmd0aCAt IDFdKSkKKyAgICAgICAgdGV4dExlbmd0aC0tOworICAgIGV2ZW50VGV4dC50cnVuY2F0ZSh0ZXh0 TGVuZ3RoKTsKICAgICBldmVudFRleHQucmVwbGFjZSgiXHJcbiIsICIgIik7CiAgICAgZXZlbnRU ZXh0LnJlcGxhY2UoJ1xyJywgJyAnKTsKICAgICBldmVudFRleHQucmVwbGFjZSgnXG4nLCAnICcp OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCmluZGV4IDZjZmUxOWRiNTQyZTZkY2ZlMGU3ODYwZjZmOTI1MzZlMjRhODViZjMuLjdlNWJj ZWRjNjZhMDBkY2FhMWY3YzY2MWRhNDM2OTY5MTEyZjQyZGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBA QAorMjAxMi0xMC0xMSAgS3VuaWhpa28gU2FrYW1vdG8gIDxrc2FrYW1vdG9AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIEZpbmFsIG5ld2xpbmUgKExGIG9yIENSTEYpIGluIHBhc3RlIGJ1ZmZlciBp cyBjb252ZXJ0ZWQgdG8gc3BhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgwODM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVmVyaWZ5IHRoYXQgdHJhaWxpbmcgbmV3bGluZXMgYXJlIHN0cmlwcGVkIHdo ZW4gcGFzdGVkIGludG8gdGV4dCBpbnB1dHMuCisKKyAgICAgICAgKiBlZGl0aW5nL2lucHV0L3Bh c3RlLXRleHQtZW5kaW5nLXdpdGgtaW50ZXJjaGFuZ2UtbmV3bGluZS1leHBlY3RlZC50eHQ6Cisg ICAgICAgIFVwZGF0ZWQgdGhlIGV4cGVjdGF0aW9uLgorICAgICAgICAqIGZhc3QvZm9ybXMvcGFz dGUtbXVsdGlsaW5lLXRleHQtaW5wdXQuaHRtbDoKKyAgICAgICAgQ2hhbmdlZCB0byB1c2UgZG9j dW1lbnQuZXhlY0NvbW1hbmQgdG8gbWltaWMgcGFzdGluZywgYmVjYXVzZSBzZXR0aW5nCisgICAg ICAgIGlucHV0LnZhbHVlIGF0dHJpYnV0ZSBkb2VzIG5vdCB0cmlnZ2VyIGJlZm9yZVRleHRJbnNl cnRlZCBldmVudC4KKyAgICAgICAgQWRkZWQgYSB0ZXN0IGNhc2UgdG8gdGVzdCB0cmFpbGluZyBu ZXdsaW5lcy4KKwogMjAxMi0xMC0xMCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVt ZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFNRTFJlc3VsdFNldC5yb3dzQWZmZWN0ZWQgbm90IGNs ZWFyZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvcGFzdGUtdGV4dC1l bmRpbmctd2l0aC1pbnRlcmNoYW5nZS1uZXdsaW5lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2VkaXRpbmcvaW5wdXQvcGFzdGUtdGV4dC1lbmRpbmctd2l0aC1pbnRlcmNoYW5nZS1uZXdsaW5l LWV4cGVjdGVkLnR4dAppbmRleCA2MDYyYWM5MDIyZDVhODBiM2U0NDJkN2MyOTAyMmJjYzVlYjk5 ZDUzLi5lNzg5OGY3OGY3NjMyZTFlN2ExY2MzMGQ5MTllOWFhZTEzYzliNDc4IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L3Bhc3RlLXRleHQtZW5kaW5nLXdpdGgtaW50ZXJj aGFuZ2UtbmV3bGluZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1 dC9wYXN0ZS10ZXh0LWVuZGluZy13aXRoLWludGVyY2hhbmdlLW5ld2xpbmUtZXhwZWN0ZWQudHh0 CkBAIC0xLDQgKzEsNCBAQAogVGhpcyB0ZXN0cyBwYXN0aW5nIGEgdGV4dCB3aXRoIGFuIGludGVy Y2hhbmdlIG5ldyBsaW5lIGF0IHRoZSBlbmQuIFdlYktpdCBzaG91bGRuJ3QgaW5zZXJ0IGEgbmV3 IGxpbmUuCiB8ICAgPHNoYWRvdzpyb290PgogfCAgICAgPGRpdj4KLXwgICAgICAgImFiYyBkZWYg IgorfCAgICAgICAiYWJjIGRlZiIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv cGFzdGUtbXVsdGlsaW5lLXRleHQtaW5wdXQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9wYXN0ZS1tdWx0aWxpbmUtdGV4dC1pbnB1dC1leHBlY3RlZC50eHQKaW5kZXggNWQ1 MjBiNDRiMzQwZmE0NjM0N2MzZGUxNzAwYzMxNTQwM2UzNWZhZC4uYzI1ZGU5MGZhN2VmY2RjZGE1 M2Y0MjA2OTgwMTA0ODI3ZWFjMDQ2NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9wYXN0ZS1tdWx0aWxpbmUtdGV4dC1pbnB1dC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9wYXN0ZS1tdWx0aWxpbmUtdGV4dC1pbnB1dC1leHBlY3RlZC50eHQKQEAg LTEsOCArMSwxMCBAQAotVGVzdDogVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgdGV4dCBpbnB1dHMg d2lsbCBhY2NlcHQgbXVsdGlwbGUgbGluZXMgb2YgcGFzdGVkIHRleHQuIFlvdSBzaG91bGQgc2Vl IHR3byB0ZXN0cyAiUEFTUyIgYmVsb3cuCitUZXN0OiBUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCB0 ZXh0IGlucHV0cyB3aWxsIGFjY2VwdCBtdWx0aXBsZSBsaW5lcyBvZiBwYXN0ZWQgdGV4dC4gWW91 IHNob3VsZCBzZWUgdGhyZWUgdGVzdHMgIlBBU1MiIGJlbG93LgogCiAKIE11bHRpLWxpbmUgdGVz dDoKIFBBU1MKIE51bGwgY2hhciB0ZXN0OgogUEFTUworVHJhaWxpbmcgbmV3bGluZSB0ZXN0Ogor UEFTUwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Bhc3RlLW11bHRpbGlu ZS10ZXh0LWlucHV0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Bhc3RlLW11bHRpbGlu ZS10ZXh0LWlucHV0Lmh0bWwKaW5kZXggYzhlMzQ3ZWVlNjQyOWJmN2IxYzAzYjNmOWVkYzQzYWE0 ODAxNjYxOS4uZjVmNjQzYzI5Y2RkMGQxZmU2ZTcwOGRkMjA4YzJkODBkZmRkZDhiZiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9wYXN0ZS1tdWx0aWxpbmUtdGV4dC1pbnB1dC5o dG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcGFzdGUtbXVsdGlsaW5lLXRleHQtaW5w dXQuaHRtbApAQCAtMTAsMTUgKzEwLDE5IEBACiAgICAgICAgIH0KIAogICAgICAgICB2YXIgREVG QVVMVF9MSU5FXzEgPSAibGluZVx0KDEgb2YgMilcclxubGluZVx0KDIgb2YgMikiOwotICAgICAg ICB2YXIgRVhQRUNURURfTElORV8xID0gImxpbmVcdCgxIG9mIDIpbGluZVx0KDIgb2YgMikiOwor ICAgICAgICB2YXIgRVhQRUNURURfTElORV8xID0gImxpbmVcdCgxIG9mIDIpIGxpbmVcdCgyIG9m IDIpIjsKIAogICAgICAgICAvLyBGSVhNRTogSXMgdGhpcyByZWFsbHkgZXhwZWN0ZWQgYmVoYXZp b3IgdG8gdHJ1bmNhdGUgdGhlIHN0cmluZyBhdCBhIG51bGwgYnl0ZT8KICAgICAgICAgLy8gSXQg ZG9lc24ndCBtYXRjaCBGaXJlZm94IDQgYW5kIGNvbW1vbiBzZW5zZS4KICAgICAgICAgdmFyIERF RkFVTFRfTElORV8yID0gIm51bGxcMGNoYXIiOwogICAgICAgICB2YXIgRVhQRUNURURfTElORV8y ID0gIm51bGwiOwogCisgICAgICAgIHZhciBERUZBVUxUX0xJTkVfMyA9ICJsaW5lIHdpdGggdHJh aWxpbmcgbmV3bGluZXNcclxuXHJcbiI7CisgICAgICAgIHZhciBFWFBFQ1RFRF9MSU5FXzMgPSAi bGluZSB3aXRoIHRyYWlsaW5nIG5ld2xpbmVzIjsKKwogICAgICAgICB2YXIgVEVTVF9OQU1FXzEg PSAiTXVsdGktbGluZSB0ZXN0IjsKICAgICAgICAgdmFyIFRFU1RfTkFNRV8yID0gIk51bGwgY2hh ciB0ZXN0IjsKKyAgICAgICAgdmFyIFRFU1RfTkFNRV8zID0gIlRyYWlsaW5nIG5ld2xpbmUgdGVz dCI7CiAKICAgICAgICAgZnVuY3Rpb24gdGVzdE11bHRpbGluZSgpCiAgICAgICAgIHsKQEAgLTI3 LDEyICszMSwxOCBAQAogCiAgICAgICAgICAgbG9nKFRFU1RfTkFNRV8yICsgIjoiKTsKICAgICAg ICAgICB0ZXN0SW5wdXRGaWVsZChERUZBVUxUX0xJTkVfMiwgRVhQRUNURURfTElORV8yKTsKKwor ICAgICAgICAgIGxvZyhURVNUX05BTUVfMyArICI6Iik7CisgICAgICAgICAgdGVzdElucHV0Rmll bGQoREVGQVVMVF9MSU5FXzMsIEVYUEVDVEVEX0xJTkVfMyk7CiAgICAgICAgIH0KICAKICAgICAg ICAgZnVuY3Rpb24gdGVzdElucHV0RmllbGQoaW5wdXRfdmFsdWUsIGV4cGVjdGVkKQogICAgICAg ICB7Ci0gICAgICAgICAgICBnZXRJbnB1dCgpLnZhbHVlID0gaW5wdXRfdmFsdWU7Ci0gICAgICAg ICAgICB2YXIgc3RyID0ganNFc2NhcGUoZ2V0SW5wdXQoKS52YWx1ZSk7CisgICAgICAgICAgICB2 YXIgaW5wdXQgPSBnZXRJbnB1dCgpOworICAgICAgICAgICAgaW5wdXQuZm9jdXMoKTsKKyAgICAg ICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiLCBmYWxzZSwgbnVsbCk7Cisg ICAgICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0VGV4dCIsIGZhbHNlLCBpbnB1 dF92YWx1ZSk7CisgICAgICAgICAgICB2YXIgc3RyID0ganNFc2NhcGUoaW5wdXQudmFsdWUpOwog ICAgICAgICAgICAgaWYgKHN0ciA9PSBqc0VzY2FwZShleHBlY3RlZCkpCiAgICAgICAgICAgICAg ICAgbG9nKCJQQVNTIik7CiAgICAgICAgICAgICBlbHNlCkBAIC03MSw4ICs4MSw4IEBACiAgICAg PC9zdHlsZT4gCiAgIDwvaGVhZD4gCiAgIDxib2R5IG9ubG9hZD0idGVzdE11bHRpbGluZSgpIj4g Ci0gICAgPGgyPlRlc3Q6IFRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IHRleHQgaW5wdXRzIHdpbGwg YWNjZXB0IG11bHRpcGxlIGxpbmVzIG9mIHBhc3RlZCB0ZXh0LiAgWW91IHNob3VsZCBzZWUgdHdv IHRlc3RzICJQQVNTIiBiZWxvdy48L2gyPiAKLSAgICA8aW5wdXQgaWQ9aW5wdXRJZCBzdHlsZT0i dmlzaWJpbGl0eTogaGlkZGVuOyIgc2l6ZT02MCAvPjxicj4KKyAgICA8aDI+VGVzdDogVGhpcyB0 ZXN0IHZlcmlmaWVzIHRoYXQgdGV4dCBpbnB1dHMgd2lsbCBhY2NlcHQgbXVsdGlwbGUgbGluZXMg b2YgcGFzdGVkIHRleHQuICBZb3Ugc2hvdWxkIHNlZSB0aHJlZSB0ZXN0cyAiUEFTUyIgYmVsb3cu PC9oMj4gCisgICAgPGlucHV0IGlkPWlucHV0SWQgc2l6ZT02MCAvPjxicj4KICAgICA8c3BhbiBj bGFzcz1jb2RlIGlkPWNvbnNvbGU+PC9zcGFuPgogICA8L2JvZHk+IAogPC9odG1sPiAK