80825 2012-03-12 01:55:16 -0700 REGRESSION (r110371): broke platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html 2012-03-15 15:14:05 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand rjkroege gustavo jamesr rjkroege webkit.review.bot oldest_to_newest 576007 0 pnormand 2012-03-12 01:55:16 -0700 http://trac.webkit.org/changeset/110371 broke that test. Diff: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll-actual.txt @@ -1,4 +1,46 @@ +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello world this is a long string and will not wrap. Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello +Hello Test for bug 29348: This tests that using the mouse wheel while having the pointer in a horizontal scrollbar makes it scroll horizontally, also with styled scrollbars. On success, the vertical offset for both divs should be 80, and the horizonta 40. -Scroll offset for 'overflow' is 80 and 40 -Scroll offset for 'styled' is 80 and 40 +FAILED Not sure what's going on. CCing Gustavo who wrote the test and Roger who wrote the "problematic" patch :) For now I'll skip this test in GTK. 576095 1 rjkroege 2012-03-12 06:31:47 -0700 I'll look into it. My patch would definitely be suspicious here. 576520 2 131410 rjkroege 2012-03-12 14:25:42 -0700 Created attachment 131410 Patch 576524 3 rjkroege 2012-03-12 14:27:10 -0700 gns@: pnormand@: could one of you review? The attached patch ought to fix this. 576537 4 pnormand 2012-03-12 14:33:48 -0700 CCing James Robinson who reviewed the original patch. Also Robert, would you mind unskipping the test please? Thanks a lot for taking care of this issue! 576560 5 131417 rjkroege 2012-03-12 14:49:06 -0700 Created attachment 131417 Patch 576565 6 rjkroege 2012-03-12 14:50:54 -0700 New patch: updates the Gtk skipped file (hopefully correctly.) 577667 7 131417 jamesr 2012-03-13 12:31:02 -0700 Comment on attachment 131417 Patch OK. I hope you get a chance to clean this up soon. 577702 8 131417 webkit.review.bot 2012-03-13 12:56:19 -0700 Comment on attachment 131417 Patch Rejecting attachment 131417 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: -commit-queue/ Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/page/EventHandler.cpp patching file LayoutTests/platform/gtk/Skipped Hunk #1 FAILED at 1595. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'James Robi..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11948655 578555 9 131881 rjkroege 2012-03-14 10:51:27 -0700 Created attachment 131881 Patch 579799 10 131881 webkit.review.bot 2012-03-15 15:14:01 -0700 Comment on attachment 131881 Patch Clearing flags on attachment: 131881 Committed r110893: <http://trac.webkit.org/changeset/110893> 579800 11 webkit.review.bot 2012-03-15 15:14:05 -0700 All reviewed patches have been landed. Closing bug. 131410 2012-03-12 14:25:42 -0700 2012-03-12 14:49:01 -0700 Patch bug-80825-20120312172541.patch text/plain 1514 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI0ZDlmM2MxZjY1MGE2 MTgyMzczM2NiNDU0ZjAxNDkzZWYwMGE4NS4uZDgwNjgwMGRjY2M0M2JiNjZkZGE0MmZmNjlmNGNj MzRjODgyNWE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTEyICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9O IChyMTEwMzcxKTogYnJva2UgcGxhdGZvcm0vZ3RrL3Njcm9sbGJhcnMvb3ZlcmZsb3ctc2Nyb2xs YmFyLWhvcml6b250YWwtd2hlZWwtc2Nyb2xsLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwODI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZVdoZWVsRXZlbnQpOiBDb3JyZWN0ZWQgYSB0 eXBvLgorCiAyMDEyLTAzLTEyICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZS1hcHBseSB0aGUgcGF0Y2ggYWZ0ZXIgdjggcm9sbCB0byByMTEwMDAu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggMTczOGRiODk2M2E4NjM2MTQ1 MzExZGJkMTZiMmY2ZDhhYmM0MjdiOS4uNGZhYzBlMjQ4NzExMmYyYTU3ZGI3NjI4NTVlMTYwMWM4 ZjJhOTE0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMjMxNyw3ICsy MzE3LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZv cm1XaGVlbEV2ZW50JiBlKQogICAgIC8vIEluc3RlYWQsIHRoZSBoYW5kbGVycyBzaG91bGQga25v dyBjb252ZXJ0IHZlcnRpY2FsIHNjcm9sbHMKICAgICAvLyBhcHByb3ByaWF0ZWx5LgogICAgIFBs YXRmb3JtV2hlZWxFdmVudCBldmVudCA9IGU7Ci0gICAgaWYgKG1fYmFzZUV2ZW50VHlwZSAhPSBQ bGF0Zm9ybUV2ZW50OjpOb1R5cGUgJiYgc2hvdWxkVHVyblZlcnRpY2FsVGlja3NJbnRvSG9yaXpv bnRhbChyZXN1bHQpKQorICAgIGlmIChtX2Jhc2VFdmVudFR5cGUgPT0gUGxhdGZvcm1FdmVudDo6 Tm9UeXBlICYmIHNob3VsZFR1cm5WZXJ0aWNhbFRpY2tzSW50b0hvcml6b250YWwocmVzdWx0KSkK ICAgICAgICAgZXZlbnQgPSBldmVudC5jb3B5VHVybmluZ1ZlcnRpY2FsVGlja3NJbnRvSG9yaXpv bnRhbFRpY2tzKCk7CiAKICAgICBpZiAobm9kZSkgewo= 131417 2012-03-12 14:49:06 -0700 2012-03-14 10:50:42 -0700 Patch bug-80825-20120312174905.patch text/plain 2054 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI0ZDlmM2MxZjY1MGE2 MTgyMzczM2NiNDU0ZjAxNDkzZWYwMGE4NS4uZDgwNjgwMGRjY2M0M2JiNjZkZGE0MmZmNjlmNGNj MzRjODgyNWE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTEyICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9O IChyMTEwMzcxKTogYnJva2UgcGxhdGZvcm0vZ3RrL3Njcm9sbGJhcnMvb3ZlcmZsb3ctc2Nyb2xs YmFyLWhvcml6b250YWwtd2hlZWwtc2Nyb2xsLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwODI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZVdoZWVsRXZlbnQpOiBDb3JyZWN0ZWQgYSB0 eXBvLgorCiAyMDEyLTAzLTEyICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZS1hcHBseSB0aGUgcGF0Y2ggYWZ0ZXIgdjggcm9sbCB0byByMTEwMDAu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggMTczOGRiODk2M2E4NjM2MTQ1 MzExZGJkMTZiMmY2ZDhhYmM0MjdiOS4uNGZhYzBlMjQ4NzExMmYyYTU3ZGI3NjI4NTVlMTYwMWM4 ZjJhOTE0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMjMxNyw3ICsy MzE3LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZv cm1XaGVlbEV2ZW50JiBlKQogICAgIC8vIEluc3RlYWQsIHRoZSBoYW5kbGVycyBzaG91bGQga25v dyBjb252ZXJ0IHZlcnRpY2FsIHNjcm9sbHMKICAgICAvLyBhcHByb3ByaWF0ZWx5LgogICAgIFBs YXRmb3JtV2hlZWxFdmVudCBldmVudCA9IGU7Ci0gICAgaWYgKG1fYmFzZUV2ZW50VHlwZSAhPSBQ bGF0Zm9ybUV2ZW50OjpOb1R5cGUgJiYgc2hvdWxkVHVyblZlcnRpY2FsVGlja3NJbnRvSG9yaXpv bnRhbChyZXN1bHQpKQorICAgIGlmIChtX2Jhc2VFdmVudFR5cGUgPT0gUGxhdGZvcm1FdmVudDo6 Tm9UeXBlICYmIHNob3VsZFR1cm5WZXJ0aWNhbFRpY2tzSW50b0hvcml6b250YWwocmVzdWx0KSkK ICAgICAgICAgZXZlbnQgPSBldmVudC5jb3B5VHVybmluZ1ZlcnRpY2FsVGlja3NJbnRvSG9yaXpv bnRhbFRpY2tzKCk7CiAKICAgICBpZiAobm9kZSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApp bmRleCAzNmJhZGIxYjY1ZGY3OWM2MmU4NDY4ZDIxOTVhODA4Nzg3NDUyZTM5Li5iOWE0MmY2ZTZm NGNjZmFlMWJjZWRmNTlkN2ExM2EyZTMzN2QzZjRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBl ZApAQCAtMTU5NSw2ICsxNTk1LDMgQEAgcGx1Z2lucy9uZXRzY2FwZS1wbHVnaW4tcGFnZS1jYWNo ZS13b3Jrcy5odG1sCiAKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTgwNTM0CiBmYXN0L2V2ZW50cy9hdXRvc2Nyb2xsLWluLXRleHRmaWVsZC5odG1sCi0KLSMgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwODI1Ci1wbGF0Zm9ybS9ndGsv c2Nyb2xsYmFycy9vdmVyZmxvdy1zY3JvbGxiYXItaG9yaXpvbnRhbC13aGVlbC1zY3JvbGwuaHRt bAo= 131881 2012-03-14 10:51:27 -0700 2012-03-15 15:14:00 -0700 Patch bug-80825-20120314135125.patch text/plain 2163 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM1MmY3ZmM5YzU2YWMw YjU5NjYyMWQyMzhjNDVlNzlkMzIyMWE0ZC4uNTBjNDYxOTQzMGVlOWI0ODc1Mzc5ODZlOTJmMmMy OTljOTA5ZWQ2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTE0ICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSRUdSRVNTSU9O IChyMTEwMzcxKTogYnJva2UgcGxhdGZvcm0vZ3RrL3Njcm9sbGJhcnMvb3ZlcmZsb3ctc2Nyb2xs YmFyLWhvcml6b250YWwtd2hlZWwtc2Nyb2xsLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwODI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmFt ZXMgUm9iaW5zb24uCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZVdoZWVsRXZlbnQpOiBDb3JyZWN0ZWQgYSB0 eXBvLgorCiAyMDEyLTAzLTE0ICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJlZ2lvbiBjYW4gYWNxdWlyZSBhbiBlbXB0eSBzcGFuIGJ5IHN1YnRyYWN0aW5n IGFuIGVtcHR5IFJlZ2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhh bmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDE3 MzhkYjg5NjNhODYzNjE0NTMxMWRiZDE2YjJmNmQ4YWJjNDI3YjkuLjRmYWMwZTI0ODcxMTJmMmE1 N2RiNzYyODU1ZTE2MDFjOGYyYTkxNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAKQEAgLTIzMTcsNyArMjMxNyw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVXaGVlbEV2 ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgZSkKICAgICAvLyBJbnN0ZWFkLCB0aGUgaGFu ZGxlcnMgc2hvdWxkIGtub3cgY29udmVydCB2ZXJ0aWNhbCBzY3JvbGxzCiAgICAgLy8gYXBwcm9w cmlhdGVseS4KICAgICBQbGF0Zm9ybVdoZWVsRXZlbnQgZXZlbnQgPSBlOwotICAgIGlmIChtX2Jh c2VFdmVudFR5cGUgIT0gUGxhdGZvcm1FdmVudDo6Tm9UeXBlICYmIHNob3VsZFR1cm5WZXJ0aWNh bFRpY2tzSW50b0hvcml6b250YWwocmVzdWx0KSkKKyAgICBpZiAobV9iYXNlRXZlbnRUeXBlID09 IFBsYXRmb3JtRXZlbnQ6Ok5vVHlwZSAmJiBzaG91bGRUdXJuVmVydGljYWxUaWNrc0ludG9Ib3Jp em9udGFsKHJlc3VsdCkpCiAgICAgICAgIGV2ZW50ID0gZXZlbnQuY29weVR1cm5pbmdWZXJ0aWNh bFRpY2tzSW50b0hvcml6b250YWxUaWNrcygpOwogCiAgICAgaWYgKG5vZGUpIHsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1NraXBwZWQKaW5kZXggN2NmYmRlN2YzZGUzYTVlZmM4ZGE4OTVjOTBhMWQyOGNhZWFk NzU3YS4uZDY0ZWNhZWEwYTZlYmYwMmVlNmRiNTFmYWYyMjgxNTIwMDIzNzczMyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQKQEAgLTE2MDMsOSArMTYwMyw2IEBAIHBsdWdpbnMvbmV0c2NhcGUt cGx1Z2luLXBhZ2UtY2FjaGUtd29ya3MuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODA1MzQKIGZhc3QvZXZlbnRzL2F1dG9zY3JvbGwtaW4tdGV4dGZpZWxk Lmh0bWwKIAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4MjUK LXBsYXRmb3JtL2d0ay9zY3JvbGxiYXJzL292ZXJmbG93LXNjcm9sbGJhci1ob3Jpem9udGFsLXdo ZWVsLXNjcm9sbC5odG1sCi0KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgwNDY2CiBmYXN0L2Zvcm1zL2xhYmVsL2xhYmVsYWJsZS1lbGVtZW50cy5odG1sCiAK