80812 2012-03-11 22:28:18 -0700 [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port 2012-03-12 07:52:42 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 0 mxie webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 575941 0 mxie 2012-03-11 22:28:18 -0700 For the BlackBerry port, "--cmakearg" from build-webkit options doesn't get passed to buildCMakeProjectOrExit() Also, "PUBLIC_BUILD=0" should not be hard-coded in blackberryCMakeArguments() 575943 1 131282 mxie 2012-03-11 22:44:03 -0700 Created attachment 131282 Patch for the fix 576096 2 131282 rwlbuis 2012-03-12 06:37:25 -0700 Comment on attachment 131282 Patch for the fix LGTM. 576117 3 131282 webkit.review.bot 2012-03-12 07:52:33 -0700 Comment on attachment 131282 Patch for the fix Clearing flags on attachment: 131282 Committed r110427: <http://trac.webkit.org/changeset/110427> 576118 4 webkit.review.bot 2012-03-12 07:52:42 -0700 All reviewed patches have been landed. Closing bug. 131282 2012-03-11 22:44:03 -0700 2012-03-12 07:52:32 -0700 Patch for the fix 0001-2012-03-11-Ming-Xie-mxie-rim.com.patch text/plain 2451 mxie RnJvbSA1M2VkODhiYjhjNWZhNjAyMjE2Y2JlYWZkMTc0OTdmZTE3ZGQ4YjZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaW5nIFhpZSA8bXhpZUByaW0uY29tPgpEYXRlOiBNb24sIDEy IE1hciAyMDEyIDAxOjM2OjE0IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0wMy0xMSAgTWlu ZyBYaWUgIDxteGllQHJpbS5jb20+CgogICAgICAgIFtCbGFja0JlcnJ5XSBidWlsZC13ZWJraXQg ZG9lc24ndCByZWNvZ25pemUgIi0tY21ha2VhcmciCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgoKICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OiBBZGQgJGNtYWtlQXJn cyB0byBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgpCiAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRp cnMucG06CiAgICAgICAgKGJsYWNrYmVycnlDTWFrZUFyZ3VtZW50cyk6IFJlbW92ZSAiUFVCTElD X0JVSUxEPTAiIGRlZmluZQotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICB8ICAgMTIg KysrKysrKysrKysrCiBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCAgfCAgICAyICstCiBUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gfCAgICAxIC0KIDMgZmlsZXMgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWZlZTE0MS4uM2YxZjUzMSAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTAzLTExICBNaW5nIFhpZSAgPG14aWVAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0g YnVpbGQtd2Via2l0IGRvZXNuJ3QgcmVjb2duaXplICItLWNtYWtlYXJnIiBmb3IgdGhlIEJsYWNr QmVycnkgcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODA4MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0OiBBZGQgJGNtYWtlQXJncyB0byBidWlsZENNYWtlUHJv amVjdE9yRXhpdCgpCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAo YmxhY2tiZXJyeUNNYWtlQXJndW1lbnRzKTogUmVtb3ZlICJQVUJMSUNfQlVJTEQ9MCIgZGVmaW5l CisKKwogMjAxMi0wMy0xMSAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCAtLWluc3RydW1lbnRzIG9wdGlvbiB0byBzdW5zcGlkZXIgdG8gcHJvZmlsZSB3 aXRoIEluc3RydW1lbnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBi L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDdjOGNhYzguLjlkMTRmM2MgMTAwNzU1 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0CkBAIC02NzgsNyArNjc4LDcgQEAgaWYgKGlzQmxhY2tCZXJyeSgpKSB7CiAgICAg fQogICAgICRtYWtlQXJncyAuPSAoJG1ha2VBcmdzID8gIiAiIDogIiIpIC4gIi1qIiAuICRudW1i ZXJPZkpvYnMgaWYgJG1ha2VBcmdzICF+IC8talxzKlxkKy87CiAgICAgJHByZWZpeFBhdGggPSAk RU5WeyJTVEFHRV9ESVIifSB1bmxlc3MgJHByZWZpeFBhdGg7Ci0gICAgYnVpbGRDTWFrZVByb2pl Y3RPckV4aXQoJGNsZWFuLCAiQmxhY2tCZXJyeSIsICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsIChj bWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpLCBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKSkpOworICAg IGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwgIkJsYWNrQmVycnkiLCAkcHJlZml4UGF0 aCwgJG1ha2VBcmdzLCAoY21ha2VCYXNlZFBvcnRBcmd1bWVudHMoKSwgY01ha2VBcmdzRnJvbUZl YXR1cmVzKCkpLCAkY21ha2VBcmdzKTsKIH0KIAogaWYgKGlzUXQoKSkgewpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CmluZGV4IDg1ZTJmODYuLjUxYTFiOWMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTk3OSw3ICs5Nzks NiBAQCBzdWIgYmxhY2tiZXJyeUNNYWtlQXJndW1lbnRzKCkKICAgICB9CiAKICAgICBteSBAY21h a2VBcmdzOwotICAgIHB1c2ggQGNtYWtlQXJncywgIi1EUFVCTElDX0JVSUxEPTAiOwogICAgIHB1 c2ggQGNtYWtlQXJncywgJy1EQ01BS0VfU1lTVEVNX05BTUU9IlFOWCInOwogICAgIHB1c2ggQGNt YWtlQXJncywgIi1EQ01BS0VfU1lTVEVNX1BST0NFU1NPUj1cIiRjcHVEaXJcIiI7CiAgICAgcHVz aCBAY21ha2VBcmdzLCAnLURDTUFLRV9TWVNURU1fVkVSU0lPTj0iMSInOwotLSAKMS43LjUuNAoK