80809 2012-03-11 21:59:40 -0700 [GTK] r110296 included an extra $ in @$(AM_V_GEN) 2012-03-12 10:51:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Major --- 0 anthony webkit-unassigned ibiru mrobinson pnormand webkit.review.bot oldest_to_newest 575930 0 anthony 2012-03-11 21:59:40 -0700 see: http://trac.webkit.org/changeset/110296/trunk/Tools/GNUmakefile.am that should have been (note the additional `$` !!!): @$(AM_V_GEN)$(PYTHON) ... NOT ... @(AM_V_GEN)$(PYTHON) ... which causes a syntax error in /bin/sh (the @ tells make to run the following command silently). 575932 1 131280 anthony 2012-03-11 22:03:38 -0700 Created attachment 131280 simple fix self-explanatory :-) 575934 2 webkit.review.bot 2012-03-11 22:05:02 -0700 Attachment 131280 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 576177 3 pnormand 2012-03-12 09:24:24 -0700 Can you please provide a ChangeLog entry? 576203 4 131341 anthony 2012-03-12 09:53:09 -0700 Created attachment 131341 Patch 576204 5 anthony 2012-03-12 09:54:51 -0700 ok, i used `Tools/Scripts/webkit-patch upload` this time :-) 576223 6 pnormand 2012-03-12 10:09:56 -0700 *** Bug 80695 has been marked as a duplicate of this bug. *** 576269 7 131341 webkit.review.bot 2012-03-12 10:51:04 -0700 Comment on attachment 131341 Patch Clearing flags on attachment: 131341 Committed r110446: <http://trac.webkit.org/changeset/110446> 576270 8 webkit.review.bot 2012-03-12 10:51:11 -0700 All reviewed patches have been landed. Closing bug. 131280 2012-03-11 22:03:38 -0700 2012-03-12 09:53:04 -0700 simple fix automake-typo.patch text/plain 447 anthony LS0tIGEvVG9vbHMvR05VbWFrZWZpbGUuYW0JMjAxMi0wMy0wOSAxMzoyMDowNi4wMDAwMDAwMDAg LTA2MDAKKysrIGIvVG9vbHMvR05VbWFrZWZpbGUuYW0JMjAxMi0wMy0xMSAyMzozNTowMC41MTIx MzA2MTggLTA1MDAKQEAgLTMyNCw3ICszMjQsNyBAQAogCSAgZmk7IFwKIAlmaQogZW5kaWYKLQlA KEFNX1ZfR0VOKSQoUFlUSE9OKSAkKHNyY2RpcikvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyAt LXJlYmFzZSAtLXZpcnR1YWwtcm9vdD0kJHtERVNURElSfQorCUAkKEFNX1ZfR0VOKSQoUFlUSE9O KSAkKHNyY2RpcikvVG9vbHMvZ3RrL2dlbmVyYXRlLWd0a2RvYyAtLXJlYmFzZSAtLXZpcnR1YWwt cm9vdD0kJHtERVNURElSfQogCiB1bmluc3RhbGwtbG9jYWw6CiAJQERPQ19NT0RVTEVfVkVSU0lP Tj1gY2F0IC4vRG9jdW1lbnRhdGlvbi93ZWJraXRndGsvdmVyc2lvbi54bWxgOyBc 131341 2012-03-12 09:53:09 -0700 2012-03-12 10:51:04 -0700 Patch bug-80809-20120312115307.patch text/plain 1196 anthony U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2YyZWRmZjBhNTNiYzdlZWYwOTA5YzU5ZTYyZWQ0OWY5 NWQ3ZGEzYS4uYTJlM2QwYzE5ODJjYTIyZDY3YTU5MGI3ODQzZDNlNDNlNTkyZDUxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEyLTAzLTEyICBDIEFudGhvbnkgUmlzaW5nZXIgIDxhbnRob255QHh0ZngubWU+CisK KyAgICAgICAgW0dUS10gcjExMDI5NiBpbmNsdWRlZCBhbiBleHRyYSAkIGluIEAkKEFNX1ZfR0VO KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4MDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEdOVW1h a2VmaWxlLmFtOiBBZGQgYCRgIHRvIEAoQU1fVl9HRU4pLCBlbHNlIC9iaW4vc2ggc3ludGF4IGVy cm9yCisKIDIwMTItMDMtMTIgIE1pbmcgWGllICA8bXhpZUByaW0uY29tPgogCiAgICAgICAgIFtC bGFja0JlcnJ5XSBidWlsZC13ZWJraXQgZG9lc24ndCByZWNvZ25pemUgIi0tY21ha2VhcmciIGZv ciB0aGUgQmxhY2tCZXJyeSBwb3J0CmRpZmYgLS1naXQgYS9Ub29scy9HTlVtYWtlZmlsZS5hbSBi L1Rvb2xzL0dOVW1ha2VmaWxlLmFtCmluZGV4IGE3MGE5MWJmMWUxNjVkZTBjYjk3M2JiM2E1NTNm NTVlYTU4MjQ1ZWEuLjAxYjljM2YzN2NmZDlmNmZhNTE1NTM3NDNiYmEzODA0YTU1NDg3ZDIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0dOVW1ha2VmaWxlLmFtCisrKyBiL1Rvb2xzL0dOVW1ha2VmaWxlLmFt CkBAIC0zMjQsNyArMzI0LDcgQEAgaWYgRU5BQkxFX1dFQktJVDIKIAkgIGZpOyBcCiAJZmkKIGVu ZGlmCi0JQChBTV9WX0dFTikkKFBZVEhPTikgJChzcmNkaXIpL1Rvb2xzL2d0ay9nZW5lcmF0ZS1n dGtkb2MgLS1yZWJhc2UgLS12aXJ0dWFsLXJvb3Q9JCR7REVTVERJUn0KKwlAJChBTV9WX0dFTikk KFBZVEhPTikgJChzcmNkaXIpL1Rvb2xzL2d0ay9nZW5lcmF0ZS1ndGtkb2MgLS1yZWJhc2UgLS12 aXJ0dWFsLXJvb3Q9JCR7REVTVERJUn0KIAogdW5pbnN0YWxsLWxvY2FsOgogCUBET0NfTU9EVUxF X1ZFUlNJT049YGNhdCAuL0RvY3VtZW50YXRpb24vd2Via2l0Z3RrL3ZlcnNpb24ueG1sYDsgXAo=