80808 2012-03-11 20:52:29 -0700 absolutely-positioned element does not update width when container width changes 2022-11-04 02:31:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED http://jsfiddle.net/UgDQy/2/ InRadar P2 Normal --- 1 laughinghan ssandela ahmad.saleem792 ap bfulgham dglazkov eric hyatt mrahaman pravind.2k4 rniwa robert ssandela webkit-bug-importer webkit.review.bot oldest_to_newest 575915 0 laughinghan 2012-03-11 20:52:29 -0700 An element that is absolutely positioned with all of top, left, and right so that it stretches all the way across a position:relative;display:inline container element doesn't change width even if the container width changes, e.g. due to appending elements, see http://jsfiddle.net/UgDQy/2/ . Interestingly, if positioned with left and right but without top, it will update its width correctly, see http://jsfiddle.net/UgDQy/3/ . 625195 1 ssandela 2012-05-16 02:44:49 -0700 Hi Han, I would like to work on this bug, but i am finding it tough to create a .html out of it, as i am not much in to jquery :). can u please upload a test case(.html). 625887 2 laughinghan 2012-05-16 14:57:00 -0700 Gladly, http://jsfiddle.net/UgDQy/4/ doesn't use jQuery, or if you prefer a single HTML page, http://fiddle.jshell.net/UgDQy/4/show/ . 627302 3 ssandela 2012-05-17 21:10:47 -0700 I debugged this, and i found that layout for span element(with absolute positioning and top attribute) does'not happen because of following statements in void RenderBlock::layoutPositionedObjects(bool relayoutChildren) if (relayoutChildren || (r->style()->hasStaticBlockPosition(isHorizontalWritingMode()) && r->parent() != this)) r->setChildNeedsLayout(true, MarkOnlyThis); 1. In case of css "top: 0;" attribute being mentioned, the hasStaticBlockPosition function returns false as top(and/or bottom) is not Auto type, but rather fixed. 2. When "top: 0;"(and/or bottom) is not mentioned, it becomes auto and hence setChildNeedsLayout gets called, hence there is no issue. Need to figure out why hasStaticBlockPosition is imposing topandBottom to be auto. 628407 4 robert 2012-05-19 06:54:07 -0700 (In reply to comment #3) > Need to figure out why hasStaticBlockPosition is imposing topandBottom to be auto. It does this because it's only worried about cases where the block position of the positioned object is relative to a container - that's not the case here (because top: has been specified) so it's not the correct clause to expand. The fact that it fixes the test case is a happy accident. Instead, the issue is that the position and width of the positioned object may need to update if either of left: (in the RTL case) or right: (in the LTR case) are not auto *and* are set to zero and it has a relative positioned parent whose width has changed. So something like: if (r->style()->right()->isFixed() && !r->style()->right().value()) && r->parent() != this) r->setChildNeedsLayout(true, MarkOnlyThis); should fix it in the simple horizontal mode LTR case. I'm not sure if it's worth checking whether the width of the object has changed before setting layout - this may be an unusual enough scenario to just layout whenever it's encountered. I'm not saying this is definitely the right approach - but I think it's something along these lines. You will definitely need dhyatt to approve any changes in this function. 628782 5 ssandela 2012-05-20 22:28:21 -0700 (In reply to comment #4) > (In reply to comment #3) > > Need to figure out why hasStaticBlockPosition is imposing topandBottom to be auto. > > It does this because it's only worried about cases where the block position of the positioned object is relative to a container - that's not the case here (because top: has been specified) so it's not the correct clause to expand. The fact that it fixes the test case is a happy accident. > Yes, i figured it out later on, and thanks a lot for confirmation and response. > Instead, the issue is that the position and width of the positioned object may need to update if either of left: (in the RTL case) or right: (in the LTR case) are not auto *and* are set to zero and it has a relative positioned parent whose width has changed. So something like: > Yes, as u have mentioned above, it is on such particular conditions that layout should happen. But as of now when "top:0;" is not mentioned the layout still happens for positioned elements in the first if condition as it does not really bother about left/right being fixed. I will try and fix this too. > if (r->style()->right()->isFixed() && !r->style()->right().value()) && r->parent() != this) > r->setChildNeedsLayout(true, MarkOnlyThis); > > should fix it in the simple horizontal mode LTR case. I'm not sure if it's worth checking whether the width of the object has changed before setting layout - this may be an unusual enough scenario to just layout whenever it's encountered. > > I'm not saying this is definitely the right approach - but I think it's something along these lines. You will definitely need dhyatt to approve any changes in this function. Thanks for the response and the pointers. 628965 6 142995 ssandela 2012-05-21 04:45:06 -0700 Created attachment 142995 Patch 628977 7 142995 webkit.review.bot 2012-05-21 05:01:31 -0700 Comment on attachment 142995 Patch Attachment 142995 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12734586 628984 8 142995 webkit-ews 2012-05-21 05:10:43 -0700 Comment on attachment 142995 Patch Attachment 142995 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12730604 628986 9 142995 webkit-ews 2012-05-21 05:16:24 -0700 Comment on attachment 142995 Patch Attachment 142995 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12728917 629033 10 143018 ssandela 2012-05-21 06:30:26 -0700 Created attachment 143018 Patch Patch after fixing compiler specific error. 629205 11 143018 pravind.2k4 2012-05-21 09:43:55 -0700 Comment on attachment 143018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143018&action=review > Source/WebCore/rendering/RenderBlock.cpp:2475 > + if ((leftCheck || rightCheck) && r->parent() != this) What happens vertical write mode ? Maybe instead of using leftCheck and rightCheck, these checks can be combined in a static function taking style as a parameter. I hope its not rude of me jump out of nowhere n review this code. Just tot it might help. 629240 12 robert 2012-05-21 10:28:50 -0700 (In reply to comment #11) > (From update of attachment 143018 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143018&action=review > > > Source/WebCore/rendering/RenderBlock.cpp:2475 > > + if ((leftCheck || rightCheck) && r->parent() != this) > > What happens vertical write mode ? Maybe instead of using leftCheck and rightCheck, these checks can be combined in a static function taking style as a parameter. Yup. I do suggest getting dhyatt's nod on the high-level approach before getting too far into the implementation. This is a performance-sensitive function so better to agree the approach first. 629920 13 ssandela 2012-05-21 21:13:02 -0700 (In reply to comment #12) > (In reply to comment #11) > > (From update of attachment 143018 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=143018&action=review > > > > > Source/WebCore/rendering/RenderBlock.cpp:2475 > > > + if ((leftCheck || rightCheck) && r->parent() != this) > > > > What happens vertical write mode ? Maybe instead of using leftCheck and rightCheck, these checks can be combined in a static function taking style as a parameter. > > Yup. I do suggest getting dhyatt's nod on the high-level approach before getting too far into the implementation. This is a performance-sensitive function so better to agree the approach first. Sure, i will take care of Vertical writing mode too. But as robert suggest, its better if we know hyatt's view on the fix. Hyatt, Please provide with your valuable feedback on the approach. 634470 14 143018 jchaffraix 2012-05-25 17:28:20 -0700 Comment on attachment 143018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143018&action=review > Source/WebCore/rendering/RenderBlock.cpp:2476 > + r->setChildNeedsLayout(true, MarkOnlyThis); I have strong doubts that this is the right fix. Could you explain why you believe we need this? Looking at the issue, it's definitely not a repainting bug as selecting doesn't repaint the outline as it should be. Also the text is properly laid out, only the outline that is wrong. I would look into the bounding box / visual overflow from ".abs" and try to understand why it is wrongly computed in this case (we are likely not including the overflow from the new child but I don't know why). You can also track the paintOutline function and backtrack the values from there. > LayoutTests/ChangeLog:12 > + * compositing/absolute-position-change-width-with-inline-container-expected.html: Added. > + * compositing/absolute-position-change-width-with-inline-container.html: Added. Why is the test in compositing/ when it involves 0 composition? > LayoutTests/compositing/absolute-position-change-width-with-inline-container.html:26 > + <p>When you click <button id="more">moooore</button>, the span.abs should expand with the container</p> > + <p><span id="container"><span class="abs">&nbsp;</span>Words, words, words</span> This test passes for me locally on Chromium (haven't tested under DRT). Also can we have a test that doesn't involve a button that doesn't work? We also need some mention of the bug id, title and condition for passing. 634531 15 laughinghan 2012-05-25 19:16:25 -0700 > the text is properly laid out, only the outline that is wrong. To clarify, it's not just the outline, everything related to the width of the ".abs" is wrong, like .offsetWidth, and anything inside with text-align:center won't be re-centered (which is how I actually discovered the bug): http://fiddle.jshell.net/UgDQy/6/show/ or http://jsfiddle.net/UgDQy/6/ It might be worth noting that the text that's properly laid out is a sibling, not a descendant, of the ".abs", and is hence outside it. 634638 16 143018 robert 2012-05-26 03:28:29 -0700 Comment on attachment 143018 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143018&action=review >> Source/WebCore/rendering/RenderBlock.cpp:2476 >> + r->setChildNeedsLayout(true, MarkOnlyThis); > > I have strong doubts that this is the right fix. Could you explain why you believe we need this? > > Looking at the issue, it's definitely not a repainting bug as selecting doesn't repaint the outline as it should be. Also the text is properly laid out, only the outline that is wrong. I would look into the bounding box / visual overflow from ".abs" and try to understand why it is wrongly computed in this case (we are likely not including the overflow from the new child but I don't know why). You can also track the paintOutline function and backtrack the values from there. See my comment on the problem above: ".. the issue is that the position and width of the positioned object may need to update if either of left: (in the RTL case) or right: (in the LTR case) are not auto *and* are set to zero and it has a relative positioned parent whose width has changed." layoutPositionedObjects() needs to detect cases where abs-positioned objects need a layout due to movement of their parents - as you can see from many of the comments in the function it's often a question of finding a good balance between 'definitely' and 'probably' needs layout. In LTR horizontal mode with a right of 0, the abs-positioned object needs layout if its relative positioned parent changes width, likewise in the RTL left:0 case. There isn't a good way at present of knowing if the parent has expanded - only layout will tell. I think the test can be tightened to include only elements with relpos parents too. Note that the extra text doesn't belong to the abspositioned object - the outline doesn't expand because it's not getting a layout at all. 1168752 17 laughinghan 2016-02-26 17:01:30 -0800 I can still repro (with http://fiddle.jshell.net/UgDQy/4/show/ ) in Safari 8.0.8, but it appears to have been fixed in Chrome 48. 1886749 18 ahmad.saleem792 2022-07-26 04:51:49 -0700 I am able to reproduce this bug in Safari 15.6 on macOS 12.5 using attached test case in URL field and outline does not expand when clicking on "mooore.." button and only way to fix is to click "fix" button while other browsers expand outline as soon as you add text via "mooore" button. Just wanted to share updated testing results. Thanks! 1886971 19 webkit-bug-importer 2022-07-26 19:47:32 -0700 <rdar://problem/97641970> 1910309 20 ews-feeder 2022-11-04 02:31:55 -0700 Committed 256315@main (c1324d73bd3c): <https://commits.webkit.org/256315@main> Reviewed commits have been landed. Closing PR #6019 and removing active labels. 142995 2012-05-21 04:45:06 -0700 2012-05-21 06:30:26 -0700 Patch patch_80808 text/plain 5400 ssandela SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzc2NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTIxICBTcmF2YW5L dW1hciBTYW5kZWxhICA8c3NhbmRlbGFAaW5ub21pbmRzLmNvbT4KKworICAgICAgICBhYnNvbHV0 ZWx5LXBvc2l0aW9uZWQgZWxlbWVudCBkb2VzIG5vdCB1cGRhdGUgd2lkdGggd2hlbiBjb250YWlu ZXIgd2lkdGggY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODA4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBsYXlvdXRQb3NpdGlvbmVkT2JqZWN0cyBuZWVkcyB0byBoYXZlIGEgY29uZGl0aW9u IHRvIGNoZWNrIGZvciB1cGRhdGUgaW4gbGF5b3V0IG9mIHBvc2l0aW9uZWQKKyAgICAgICAgZWxl bWVudHMgd2l0aCByZXNwZWN0IHRvIGl0cyByZWxhdGl2ZWx5IHBvc2l0aW9uZWQgcGFyZW50IGVs ZW1lbnQuCisKKyAgICAgICAgVGVzdDogY29tcG9zaXRpbmcvYWJzb2x1dGUtcG9zaXRpb24tY2hh bmdlLXdpZHRoLXdpdGgtaW5saW5lLWNvbnRhaW5lci5odG1sCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91 dFBvc2l0aW9uZWRPYmplY3RzKToKKwogMjAxMi0wNS0yMCAgS2ludWtvIFlhc3VkYSAgPGtpbnVr b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2xlYW51cDogUmVtb3ZlIFdlYkNvcmU6OnJldmVh bEZvbGRlckluT1MoKSB3aGljaCBpcyBubyBsb25nZXIgdXNlZCBhbnl3aGVyZQpJbmRleDogU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAxMTc3NTQpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNDY4LDYgKzI0NjgsMTEgQEAgdm9pZCBSZW5kZXJCbG9jazo6bGF5b3V0UG9zaXRpb25l ZE9iamVjdAogICAgICAgICBpZiAocmVsYXlvdXRDaGlsZHJlbiB8fCAoci0+c3R5bGUoKS0+aGFz U3RhdGljQmxvY2tQb3NpdGlvbihpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKSAmJiByLT5wYXJl bnQoKSAhPSB0aGlzKSkKICAgICAgICAgICAgIHItPnNldENoaWxkTmVlZHNMYXlvdXQodHJ1ZSwg TWFya09ubHlUaGlzKTsKICAgICAgICAgICAgIAorICAgICAgICAvLyBXZSBzZXQgbGF5b3V0IGlm IGVpdGhlciBvZiBsZWZ0OiAoaW4gdGhlIFJUTCBjYXNlKSBvciByaWdodDogKGluIHRoZSBMVFIg Y2FzZSkgYXJlIG5vdCBhdXRvIGFuZCBhcmUgc2V0IHRvIHplcm8sCisgICAgICAgIC8vIGFuZCBp dCBoYXMgYSByZWxhdGl2ZSBwb3NpdGlvbmVkIHBhcmVudCB3aG9zZSB3aWR0aCBoYXMgY2hhbmdl ZAorICAgICAgICBpZiAoKHItPnN0eWxlKCktPmxlZnQoKS5pc0ZpeGVkKCkgJiYgIXItPnN0eWxl KCktPmxlZnQoKS52YWx1ZSgpKSB8fCAoci0+c3R5bGUoKS0+cmlnaHQoKS5pc0ZpeGVkKCkgJiYg IXItPnN0eWxlKCktPnJpZ2h0KCkudmFsdWUoKSkgJiYgci0+cGFyZW50KCkgIT0gdGhpcykKKyAg ICAgICAgICAgIHItPnNldENoaWxkTmVlZHNMYXlvdXQodHJ1ZSwgTWFya09ubHlUaGlzKTsKKwog ICAgICAgICAvLyBJZiByZWxheW91dENoaWxkcmVuIGlzIHNldCBhbmQgdGhlIGNoaWxkIGhhcyBw ZXJjZW50YWdlIHBhZGRpbmcgb3IgYW4gZW1iZWRkZWQgY29udGVudCBib3gsIHdlIGFsc28gbmVl ZCB0byBpbnZhbGlkYXRlIHRoZSBjaGlsZHMgcHJlZiB3aWR0aHMuCiAgICAgICAgIGlmIChyZWxh eW91dENoaWxkcmVuICYmIHItPm5lZWRzUHJlZmVycmVkV2lkdGhzUmVjYWxjdWxhdGlvbigpKQog ICAgICAgICAgICAgci0+c2V0UHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KHRydWUsIE1hcmtP bmx5VGhpcyk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTc3NjYpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0yMSAgU3JhdmFu S3VtYXIgU2FuZGVsYSAgPHNzYW5kZWxhQGlubm9taW5kcy5jb20+CisKKyAgICAgICAgYWJzb2x1 dGVseS1wb3NpdGlvbmVkIGVsZW1lbnQgZG9lcyBub3QgdXBkYXRlIHdpZHRoIHdoZW4gY29udGFp bmVyIHdpZHRoIGNoYW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgwODA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgUmVmIHRlc3RzIHRvIGNoZWNrIGZvciB1cGRhdGUgaW4gcG9zaXRpb25l ZCBlbGVtZW50cyB3aWR0aCB3aXRoIHJlc3BlY3QgdG8KKyAgICAgICAgaXRzIGNvbnRhaW5lciBl bGVtZW50J3MgbGF5b3V0IGNoYW5nZS4KKworICAgICAgICAqIGNvbXBvc2l0aW5nL2Fic29sdXRl LXBvc2l0aW9uLWNoYW5nZS13aWR0aC13aXRoLWlubGluZS1jb250YWluZXItZXhwZWN0ZWQuaHRt bDogQWRkZWQuCisgICAgICAgICogY29tcG9zaXRpbmcvYWJzb2x1dGUtcG9zaXRpb24tY2hhbmdl LXdpZHRoLXdpdGgtaW5saW5lLWNvbnRhaW5lci5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0yMSAg Q3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5y ZXZpZXdlZCBnYXJkZW5pbmcsIHVuc2tpcCBhIG5vdyBwYXNzaW5nIHRlc3QuCkluZGV4OiBMYXlv dXRUZXN0cy9jb21wb3NpdGluZy9hYnNvbHV0ZS1wb3NpdGlvbi1jaGFuZ2Utd2lkdGgtd2l0aC1p bmxpbmUtY29udGFpbmVyLWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Y29tcG9zaXRpbmcvYWJzb2x1dGUtcG9zaXRpb24tY2hhbmdlLXdpZHRoLXdpdGgtaW5saW5lLWNv bnRhaW5lci1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvYWJzb2x1dGUtcG9zaXRpb24tY2hhbmdlLXdpZHRoLXdpdGgtaW5saW5lLWNvbnRhaW5l ci1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIxIEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c3R5bGUgdHlwZT0ndGV4dC9jc3Mn PgorICAgICAgICAgICAgI2NvbnRhaW5lciB7CisgICAgICAgICAgICBwb3NpdGlvbjogcmVsYXRp dmU7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAuYWJzIHsKKyAgICAgICAgICAgICAgICBv dXRsaW5lOiBzb2xpZCAxcHggc2t5Ymx1ZTsKKyAgICAgICAgICAgICAgICBwb3NpdGlvbjogYWJz b2x1dGU7CisgICAgICAgICAgICAgICAgbGVmdDogMDsKKyAgICAgICAgICAgICAgICB0b3A6IDA7 CisgICAgICAgICAgICAgICAgcmlnaHQ6IDA7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc3R5 bGU+CisgICAgPC9oZWFkPgorICAgIDxib2R5PgorICAgICAgICA8cD5XaGVuIHlvdSBjbGljayA8 YnV0dG9uIGlkPSJtb3JlIj5tb29vb3JlPC9idXR0b24+LCB0aGUgc3Bhbi5hYnMgc2hvdWxkIGV4 cGFuZCB3aXRoIHRoZSBjb250YWluZXI8L3A+CisgICAgICAgIDxwPjxzcGFuIGlkPSJjb250YWlu ZXIiPjxzcGFuIGNsYXNzPSJhYnMiPiZuYnNwOzwvc3Bhbj5Xb3Jkcywgd29yZHMsIHdvcmRzIG1v b29vcmU8L3NwYW4+CisgICAgPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKSW5kZXg6IExheW91dFRlc3RzL2NvbXBvc2l0aW5nL2Fic29sdXRlLXBvc2l0aW9uLWNo YW5nZS13aWR0aC13aXRoLWlubGluZS1jb250YWluZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9jb21wb3NpdGluZy9hYnNvbHV0ZS1wb3NpdGlvbi1jaGFuZ2Utd2lkdGgtd2l0aC1p bmxpbmUtY29udGFpbmVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9jb21wb3Np dGluZy9hYnNvbHV0ZS1wb3NpdGlvbi1jaGFuZ2Utd2lkdGgtd2l0aC1pbmxpbmUtY29udGFpbmVy Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjggQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0 bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzdHlsZSB0eXBlPSd0ZXh0L2Nzcyc+CisgICAgICAg ICAgICAjY29udGFpbmVyIHsKKyAgICAgICAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKKyAgICAg ICAgICAgIH0KKyAgICAgICAgICAgIC5hYnMgeworICAgICAgICAgICAgICAgIG91dGxpbmU6IHNv bGlkIDFweCBza3libHVlOworICAgICAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAg ICAgICAgICAgICAgICBsZWZ0OiAwOworICAgICAgICAgICAgICAgIHRvcDogMDsKKyAgICAgICAg ICAgICAgICByaWdodDogMDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgPC9zdHlsZT4KKyAgICAg ICAgPHNjcmlwdCB0eXBlPSd0ZXh0L2phdmFzY3JpcHQnPgorICAgICAgICAgICAgd2luZG93Lm9u bG9hZD1mdW5jdGlvbigpeworICAgICAgICAgICAgdmFyIHNwYW4gPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCdzcGFuJyk7CisgICAgICAgICAgICBzcGFuLmlubmVySFRNTCA9ICcgbW9vb29yZSc7 CisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29udGFpbmVyJykuYXBwZW5k Q2hpbGQoc3Bhbik7CisgICAgICAgICAgICB9OworICAgICAgICA8L3NjcmlwdD4KKyAgICA8L2hl YWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxwPldoZW4geW91IGNsaWNrIDxidXR0b24gaWQ9Im1v cmUiPm1vb29vcmU8L2J1dHRvbj4sIHRoZSBzcGFuLmFicyBzaG91bGQgZXhwYW5kIHdpdGggdGhl IGNvbnRhaW5lcjwvcD4KKyAgICAgICAgPHA+PHNwYW4gaWQ9ImNvbnRhaW5lciI+PHNwYW4gY2xh c3M9ImFicyI+Jm5ic3A7PC9zcGFuPldvcmRzLCB3b3Jkcywgd29yZHM8L3NwYW4+CisgICAgPC9i b2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 143018 2012-05-21 06:30:26 -0700 2012-05-26 03:28:29 -0700 Patch patch_80808 text/plain 5474 ssandela SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzc2NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTIxICBTcmF2YW5L dW1hciBTYW5kZWxhICA8c3NhbmRlbGFAaW5ub21pbmRzLmNvbT4KKworICAgICAgICBhYnNvbHV0 ZWx5LXBvc2l0aW9uZWQgZWxlbWVudCBkb2VzIG5vdCB1cGRhdGUgd2lkdGggd2hlbiBjb250YWlu ZXIgd2lkdGggY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODA4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBsYXlvdXRQb3NpdGlvbmVkT2JqZWN0cyBuZWVkcyB0byBoYXZlIGEgY29uZGl0aW9u IHRvIGNoZWNrIGZvciB1cGRhdGUgaW4gbGF5b3V0IG9mIHBvc2l0aW9uZWQKKyAgICAgICAgZWxl bWVudHMgd2l0aCByZXNwZWN0IHRvIGl0cyByZWxhdGl2ZWx5IHBvc2l0aW9uZWQgcGFyZW50IGVs ZW1lbnQuCisKKyAgICAgICAgVGVzdDogY29tcG9zaXRpbmcvYWJzb2x1dGUtcG9zaXRpb24tY2hh bmdlLXdpZHRoLXdpdGgtaW5saW5lLWNvbnRhaW5lci5odG1sCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91 dFBvc2l0aW9uZWRPYmplY3RzKToKKwogMjAxMi0wNS0yMCAgS2ludWtvIFlhc3VkYSAgPGtpbnVr b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2xlYW51cDogUmVtb3ZlIFdlYkNvcmU6OnJldmVh bEZvbGRlckluT1MoKSB3aGljaCBpcyBubyBsb25nZXIgdXNlZCBhbnl3aGVyZQpJbmRleDogU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAxMTc3NTQpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNDY4LDYgKzI0NjgsMTEgQEAgdm9pZCBSZW5kZXJCbG9jazo6bGF5b3V0UG9zaXRpb25l ZE9iamVjdAogICAgICAgICBpZiAocmVsYXlvdXRDaGlsZHJlbiB8fCAoci0+c3R5bGUoKS0+aGFz U3RhdGljQmxvY2tQb3NpdGlvbihpc0hvcml6b250YWxXcml0aW5nTW9kZSgpKSAmJiByLT5wYXJl bnQoKSAhPSB0aGlzKSkKICAgICAgICAgICAgIHItPnNldENoaWxkTmVlZHNMYXlvdXQodHJ1ZSwg TWFya09ubHlUaGlzKTsKICAgICAgICAgICAgIAorICAgICAgICAvLyBXZSBzZXQgbGF5b3V0IGlm IGVpdGhlciBvZiBsZWZ0OiAoaW4gdGhlIFJUTCBjYXNlKSBvciByaWdodDogKGluIHRoZSBMVFIg Y2FzZSkgYXJlIG5vdCBhdXRvIGFuZCBhcmUgc2V0IHRvIHplcm8sCisgICAgICAgIC8vIGFuZCBp dCBoYXMgYSByZWxhdGl2ZSBwb3NpdGlvbmVkIHBhcmVudCB3aG9zZSB3aWR0aCBoYXMgY2hhbmdl ZAorICAgICAgICBib29sIGxlZnRDaGVjayA9IHItPnN0eWxlKCktPmxlZnQoKS5pc0ZpeGVkKCkg JiYgIXItPnN0eWxlKCktPmxlZnQoKS52YWx1ZSgpOworICAgICAgICBib29sIHJpZ2h0Q2hlY2sg PSByLT5zdHlsZSgpLT5yaWdodCgpLmlzRml4ZWQoKSAmJiAhci0+c3R5bGUoKS0+cmlnaHQoKS52 YWx1ZSgpOworICAgICAgICBpZiAoKGxlZnRDaGVjayB8fCByaWdodENoZWNrKSAmJiByLT5wYXJl bnQoKSAhPSB0aGlzKQorICAgICAgICAgICAgci0+c2V0Q2hpbGROZWVkc0xheW91dCh0cnVlLCBN YXJrT25seVRoaXMpOworCiAgICAgICAgIC8vIElmIHJlbGF5b3V0Q2hpbGRyZW4gaXMgc2V0IGFu ZCB0aGUgY2hpbGQgaGFzIHBlcmNlbnRhZ2UgcGFkZGluZyBvciBhbiBlbWJlZGRlZCBjb250ZW50 IGJveCwgd2UgYWxzbyBuZWVkIHRvIGludmFsaWRhdGUgdGhlIGNoaWxkcyBwcmVmIHdpZHRocy4K ICAgICAgICAgaWYgKHJlbGF5b3V0Q2hpbGRyZW4gJiYgci0+bmVlZHNQcmVmZXJyZWRXaWR0aHNS ZWNhbGN1bGF0aW9uKCkpCiAgICAgICAgICAgICByLT5zZXRQcmVmZXJyZWRMb2dpY2FsV2lkdGhz RGlydHkodHJ1ZSwgTWFya09ubHlUaGlzKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzc2NikKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisy MDEyLTA1LTIxICBTcmF2YW5LdW1hciBTYW5kZWxhICA8c3NhbmRlbGFAaW5ub21pbmRzLmNvbT4K KworICAgICAgICBhYnNvbHV0ZWx5LXBvc2l0aW9uZWQgZWxlbWVudCBkb2VzIG5vdCB1cGRhdGUg d2lkdGggd2hlbiBjb250YWluZXIgd2lkdGggY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBSZWYgdGVzdHMgdG8gY2hlY2sgZm9yIHVw ZGF0ZSBpbiBwb3NpdGlvbmVkIGVsZW1lbnRzIHdpZHRoIHdpdGggcmVzcGVjdCB0bworICAgICAg ICBpdHMgY29udGFpbmVyIGVsZW1lbnQncyBsYXlvdXQgY2hhbmdlLgorCisgICAgICAgICogY29t cG9zaXRpbmcvYWJzb2x1dGUtcG9zaXRpb24tY2hhbmdlLXdpZHRoLXdpdGgtaW5saW5lLWNvbnRh aW5lci1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBjb21wb3NpdGluZy9hYnNvbHV0 ZS1wb3NpdGlvbi1jaGFuZ2Utd2lkdGgtd2l0aC1pbmxpbmUtY29udGFpbmVyLmh0bWw6IEFkZGVk LgorCiAyMDEyLTA1LTIxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK ICAgICAgICAgW1F0XSBVbnJldmlld2VkIGdhcmRlbmluZywgdW5za2lwIGEgbm93IHBhc3Npbmcg dGVzdC4KSW5kZXg6IExheW91dFRlc3RzL2NvbXBvc2l0aW5nL2Fic29sdXRlLXBvc2l0aW9uLWNo YW5nZS13aWR0aC13aXRoLWlubGluZS1jb250YWluZXItZXhwZWN0ZWQuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy9hYnNvbHV0ZS1wb3NpdGlvbi1jaGFuZ2Utd2lk dGgtd2l0aC1pbmxpbmUtY29udGFpbmVyLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9jb21wb3NpdGluZy9hYnNvbHV0ZS1wb3NpdGlvbi1jaGFuZ2Utd2lkdGgtd2l0 aC1pbmxpbmUtY29udGFpbmVyLWV4cGVjdGVkLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MjEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+CisgICAgPGhlYWQ+CisgICAgICAgIDxzdHls ZSB0eXBlPSd0ZXh0L2Nzcyc+CisgICAgICAgICAgICAjY29udGFpbmVyIHsKKyAgICAgICAgICAg IHBvc2l0aW9uOiByZWxhdGl2ZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIC5hYnMgewor ICAgICAgICAgICAgICAgIG91dGxpbmU6IHNvbGlkIDFweCBza3libHVlOworICAgICAgICAgICAg ICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICAgICAgICBsZWZ0OiAwOworICAgICAg ICAgICAgICAgIHRvcDogMDsKKyAgICAgICAgICAgICAgICByaWdodDogMDsKKyAgICAgICAgICAg IH0KKyAgICAgICAgPC9zdHlsZT4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxw PldoZW4geW91IGNsaWNrIDxidXR0b24gaWQ9Im1vcmUiPm1vb29vcmU8L2J1dHRvbj4sIHRoZSBz cGFuLmFicyBzaG91bGQgZXhwYW5kIHdpdGggdGhlIGNvbnRhaW5lcjwvcD4KKyAgICAgICAgPHA+ PHNwYW4gaWQ9ImNvbnRhaW5lciI+PHNwYW4gY2xhc3M9ImFicyI+Jm5ic3A7PC9zcGFuPldvcmRz LCB3b3Jkcywgd29yZHMgbW9vb29yZTwvc3Bhbj4KKyAgICA8L2JvZHk+Cis8L2h0bWw+ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvYWJz b2x1dGUtcG9zaXRpb24tY2hhbmdlLXdpZHRoLXdpdGgtaW5saW5lLWNvbnRhaW5lci5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2NvbXBvc2l0aW5nL2Fic29sdXRlLXBvc2l0aW9uLWNo YW5nZS13aWR0aC13aXRoLWlubGluZS1jb250YWluZXIuaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2NvbXBvc2l0aW5nL2Fic29sdXRlLXBvc2l0aW9uLWNoYW5nZS13aWR0aC13aXRo LWlubGluZS1jb250YWluZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyOCBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHN0eWxlIHR5cGU9J3Rl eHQvY3NzJz4KKyAgICAgICAgICAgICNjb250YWluZXIgeworICAgICAgICAgICAgcG9zaXRpb246 IHJlbGF0aXZlOworICAgICAgICAgICAgfQorICAgICAgICAgICAgLmFicyB7CisgICAgICAgICAg ICAgICAgb3V0bGluZTogc29saWQgMXB4IHNreWJsdWU7CisgICAgICAgICAgICAgICAgcG9zaXRp b246IGFic29sdXRlOworICAgICAgICAgICAgICAgIGxlZnQ6IDA7CisgICAgICAgICAgICAgICAg dG9wOiAwOworICAgICAgICAgICAgICAgIHJpZ2h0OiAwOworICAgICAgICAgICAgfQorICAgICAg ICA8L3N0eWxlPgorICAgICAgICA8c2NyaXB0IHR5cGU9J3RleHQvamF2YXNjcmlwdCc+CisgICAg ICAgICAgICB3aW5kb3cub25sb2FkPWZ1bmN0aW9uKCl7CisgICAgICAgICAgICB2YXIgc3BhbiA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3NwYW4nKTsKKyAgICAgICAgICAgIHNwYW4uaW5uZXJI VE1MID0gJyBtb29vb3JlJzsKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdj b250YWluZXInKS5hcHBlbmRDaGlsZChzcGFuKTsKKyAgICAgICAgICAgIH07CisgICAgICAgIDwv c2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keT4KKyAgICAgICAgPHA+V2hlbiB5b3UgY2xp Y2sgPGJ1dHRvbiBpZD0ibW9yZSI+bW9vb29yZTwvYnV0dG9uPiwgdGhlIHNwYW4uYWJzIHNob3Vs ZCBleHBhbmQgd2l0aCB0aGUgY29udGFpbmVyPC9wPgorICAgICAgICA8cD48c3BhbiBpZD0iY29u dGFpbmVyIj48c3BhbiBjbGFzcz0iYWJzIj4mbmJzcDs8L3NwYW4+V29yZHMsIHdvcmRzLCB3b3Jk czwvc3Bhbj4KKyAgICA8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmls ZQo=