80792 2012-03-11 10:01:35 -0700 [BlackBerry] Fix JPEG encoding support 2012-03-11 13:13:16 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos rakuco tonikitoo webkit.review.bot oldest_to_newest 575759 0 staikos 2012-03-11 10:01:35 -0700 Inadvertently broken during some rebasing work. This re-enables it. 575764 1 131240 staikos 2012-03-11 10:12:08 -0700 Created attachment 131240 Part 1 - Build system 575765 2 131241 staikos 2012-03-11 10:13:02 -0700 Created attachment 131241 Part 2 - Enabled commented-out code Already r+ by Rob 575781 3 131240 tonikitoo 2012-03-11 10:37:25 -0700 Comment on attachment 131240 Part 1 - Build system View in context: https://bugs.webkit.org/attachment.cgi?id=131240&action=review > Source/WebCore/PlatformBlackBerry.cmake:84 > platform/image-encoders/JPEGImageEncoder.cpp > + platform/image-encoders/skia/JPEGImageEncoder.cpp so we build both now? 575782 4 tonikitoo 2012-03-11 10:37:49 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=131240&action=review oh forgor the changelog :( > Source/WebCore/PlatformBlackBerry.cmake:84 > platform/image-encoders/JPEGImageEncoder.cpp > + platform/image-encoders/skia/JPEGImageEncoder.cpp so we build both now? 575783 5 131240 tonikitoo 2012-03-11 10:38:22 -0700 Comment on attachment 131240 Part 1 - Build system no changelog :( 575785 6 staikos 2012-03-11 10:39:36 -0700 (In reply to comment #4) > View in context: https://bugs.webkit.org/attachment.cgi?id=131240&action=review > > oh forgor the changelog :( > > > Source/WebCore/PlatformBlackBerry.cmake:84 > > platform/image-encoders/JPEGImageEncoder.cpp > > + platform/image-encoders/skia/JPEGImageEncoder.cpp > > so we build both now? That's the confusing part. They're different things. (In reply to comment #5) > (From update of attachment 131240 [details]) > no changelog :( Woops! I just uploaded the completely wrong set of patches it seems! 575801 7 131249 staikos 2012-03-11 11:12:23 -0700 Created attachment 131249 Single patch Turns out the other patch wasn't needed anyway. Fixed, with changelog 575824 8 131249 webkit.review.bot 2012-03-11 13:13:12 -0700 Comment on attachment 131249 Single patch Clearing flags on attachment: 131249 Committed r110399: <http://trac.webkit.org/changeset/110399> 575825 9 webkit.review.bot 2012-03-11 13:13:16 -0700 All reviewed patches have been landed. Closing bug. 131240 2012-03-11 10:12:08 -0700 2012-03-11 10:40:09 -0700 Part 1 - Build system 80792-1.patch text/plain 1057 staikos RnJvbSA0MWEyMmRhYjk5NWYwYmI2YWQ3YjE1MjdkOGNkNWUzNDY3NjJjMDBkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW9yZ2UgU3RhaWtvcyA8c3RhaWtvc0B3ZWJraXQub3JnPgpE YXRlOiBUaHUsIDE2IEZlYiAyMDEyIDE0OjQ3OjA2ICswODAwClN1YmplY3Q6IFtQQVRDSCAxMS8x MV0gMjAxMi0wMi0xNSAgR2VvcmdlIFN0YWlrb3MgIDxzdGFpa29zQHdlYmtpdC5vcmc+CgogICAg ICAgIEFkZCBtaXNzaW5nIEpQRUcgZW5jb2RlciBmaWxlLgoKICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBQbGF0Zm9ybUJsYWNrQmVycnkuY21ha2U6Ci0tLQog U291cmNlL1dlYkNvcmUvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlIHwgICAgMSArCiAxIGZpbGVz IGNoYW5nZWQsIDEgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9Q bGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKaW5kZXggYzNhMWVkMi4uYzZhMWQxYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZQpAQCAtODEsNiArODEsNyBAQCBMSVNUKEFQ UEVORCBXZWJDb3JlX1NPVVJDRVMKICAgICBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcvUE5H SW1hZ2VEZWNvZGVyLmNwcAogICAgIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUElt YWdlRGVjb2Rlci5jcHAKICAgICBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNv ZGVyLmNwcAorICAgIHBsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvSlBFR0ltYWdlRW5jb2Rl ci5jcHAKICAgICBwbGF0Zm9ybS9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCiAgICAgcGxhdGZv cm0vcG9zaXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwCiAgICAgcGxhdGZvcm0vdGV4dC9UZXh0QnJl YWtJdGVyYXRvcklDVS5jcHAKLS0gCjEuNy4wLjIKCg== 131241 2012-03-11 10:13:02 -0700 2012-03-11 10:40:18 -0700 Part 2 - Enabled commented-out code 80792-2.patch text/plain 1494 staikos RnJvbSA0YWE3MTQ0NjNjYjJlMjFkZTM2ODZjZjAxYTRhYmNjZDgxNDE3Zjk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW9yZ2UgU3RhaWtvcyA8c3RhaWtvc0B3ZWJraXQub3JnPgpE YXRlOiBUaHUsIDE2IEZlYiAyMDEyIDEwOjM5OjQzICswODAwClN1YmplY3Q6IFtQQVRDSCAwNy8x MV0gMjAxMi0wMi0xNSAgR2VvcmdlIFN0YWlrb3MgIDxzdGFpa29zQHdlYmtpdC5vcmc+CgogICAg ICAgIFJlLWVuYWJsZSBjb21tZW50ZWQgb3V0IGNvZGUgdGhhdCBzaG91bGQgbm90IGhhdmUgYmVl biBjb21tZW50ZWQgb3V0LgoKICAgICAgICBSZXZpZXdlZCBieSBSb2IgQnVpcy4KCiAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6CiAgICAgICAgKFdl YkNvcmU6OkltYWdlVG9EYXRhVVJMKToKLS0tCiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9J bWFnZUJ1ZmZlclNraWEuY3BwICAgICB8ICAgIDQgKystLQogMSBmaWxlcyBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCmluZGV4IGFmOGJj MDcuLmIyNDEwZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKQEAgLTM3MCw4ICszNzAsOCBAQCBzdGF0 aWMgU3RyaW5nIEltYWdlVG9EYXRhVVJMKFQmIHNvdXJjZSwgY29uc3QgU3RyaW5nJiBtaW1lVHlw ZSwgY29uc3QgZG91YmxlKiBxdQogICAgICAgICBpbnQgY29tcHJlc3Npb25RdWFsaXR5ID0gSlBF R0ltYWdlRW5jb2Rlcjo6RGVmYXVsdENvbXByZXNzaW9uUXVhbGl0eTsKICAgICAgICAgaWYgKHF1 YWxpdHkgJiYgKnF1YWxpdHkgPj0gMC4wICYmICpxdWFsaXR5IDw9IDEuMCkKICAgICAgICAgICAg IGNvbXByZXNzaW9uUXVhbGl0eSA9IHN0YXRpY19jYXN0PGludD4oKnF1YWxpdHkgKiAxMDAgKyAw LjUpOwotICAgICAgICAvL2lmICghSlBFR0ltYWdlRW5jb2Rlcjo6ZW5jb2RlKHNvdXJjZSwgY29t cHJlc3Npb25RdWFsaXR5LCAmZW5jb2RlZEltYWdlKSkKLSAgICAgICAgLy8gICAgcmV0dXJuICJk YXRhOiwiOworICAgICAgICBpZiAoIUpQRUdJbWFnZUVuY29kZXI6OmVuY29kZShzb3VyY2UsIGNv bXByZXNzaW9uUXVhbGl0eSwgJmVuY29kZWRJbWFnZSkpCisgICAgICAgICAgICByZXR1cm4gImRh dGE6LCI7CiAgICAgfSBlbHNlIHsKICAgICAgICAgaWYgKCFQTkdJbWFnZUVuY29kZXI6OmVuY29k ZShzb3VyY2UsICZlbmNvZGVkSW1hZ2UpKQogICAgICAgICAgICAgcmV0dXJuICJkYXRhOiwiOwot LSAKMS43LjAuMgoK 131249 2012-03-11 11:12:23 -0700 2012-03-11 13:13:12 -0700 Single patch 80792.patch text/plain 1209 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDM5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAzLTExICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBFbmFibGUgSlBFRyBlbmNv ZGluZyBmb3IgQmxhY2tCZXJyeS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgwNzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBQbGF0Zm9ybUJsYWNrQmVycnkuY21ha2U6CisKIDIwMTItMDMtMTEgIFBh dmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogY29uc29sZS5sb2cgYXR0ZW1wdHMgdG8gc3Vic3RpdHV0ZSBhbnkgIiUiIGNoYXJhY3Rl ciBpbiB0aGUgbWVzc2FnZS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQmxhY2tCZXJy eS5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUJsYWNrQmVycnku Y21ha2UJKHJldmlzaW9uIDExMDM5MykKKysrIFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtQmxhY2tC ZXJyeS5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtNzcsNiArNzcsNyBAQCBMSVNUKEFQUEVORCBX ZWJDb3JlX1NPVVJDRVMKICAgICBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9wbmcvUE5HSW1hZ2VE ZWNvZGVyLmNwcAogICAgIHBsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVj b2Rlci5jcHAKICAgICBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmNw cAorICAgIHBsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvSlBFR0ltYWdlRW5jb2Rlci5jcHAK ICAgICBwbGF0Zm9ybS9wb3NpeC9GaWxlU3lzdGVtUE9TSVguY3BwCiAgICAgcGxhdGZvcm0vcG9z aXgvU2hhcmVkQnVmZmVyUE9TSVguY3BwCiAgICAgcGxhdGZvcm0vdGV4dC9UZXh0QnJlYWtJdGVy YXRvcklDVS5jcHAK