8072 2006-03-29 23:50:41 -0800 REGRESSION: text fields at connect.apple.com spill out of the containing box 2006-04-04 15:20:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED http://connect.apple.com/ Regression P1 Normal --- 1 henk.kampman adele adele darin henk.kampman hyatt oldest_to_newest 37951 0 henk.kampman 2006-03-29 23:50:41 -0800 The widths of the textfields "Apple ID" and "Password" are incorrect. The regression was intruduced starting with nightly r13567 38141 1 darin 2006-03-31 23:05:59 -0800 Actually, the widths of the text fields look fine to me (same as before). The problem seems to be the position of the text fields, not the widths. 38323 2 7475 darin 2006-04-02 21:02:19 -0700 Created attachment 7475 reduction, showing this is some sort of min/max width issue 38324 3 darin 2006-04-02 21:23:30 -0700 I think the bug is caused by the fact that RenderTextField::calcMinMaxWidth sets the min/max width to a width based on the input element's size attribute even when the style has a width specified. 38325 4 darin 2006-04-02 21:35:43 -0700 RenderTextField::calcMinMaxWidth is clearly wrong in at least a few ways. For example, it doesn't consider border or padding. It doesn't consider the values of any CSS properties (width, min-width, max-width). What's annoying is that we probably want most of the logic from RenderBlock::calcMinMaxWidth, but we can't use it because it calls non-virtual calcInlineMinMaxWidth or calcBlockMinMaxWidth. We can look at RenderReplaced::calcMinMaxWidth for inspiration, I guess. Or maybe Hyatt already has a good technique in mind for this. 38348 5 mjs 2006-04-02 23:25:39 -0700 These are all text field regressions so they should all be P1. 38435 6 adele 2006-04-03 16:02:00 -0700 working on this now. 38466 7 darin 2006-04-03 21:12:53 -0700 Assigning to Adele since she says she is working on this. 38525 8 7503 adele 2006-04-04 10:09:01 -0700 Created attachment 7503 initial patch Dave, can you take a look at this first cut of fixing RenderTextField::calcMinMaxWidth? 38538 9 7503 hyatt 2006-04-04 13:40:06 -0700 Comment on attachment 7503 initial patch You shouldn't need these lines at all: + calcBlockMinMaxWidth(); + + if(m_maxWidth < m_minWidth) m_maxWidth = m_minWidth; Other than that, I think this is right, although we probably need more tests of non-fixed widths on text fields (i.e., width:100%). 7475 2006-04-02 21:02:19 -0700 2006-04-02 21:02:19 -0700 reduction, showing this is some sort of min/max width issue 8072-reduction.html text/html 1556 darin PHA+VGVzdCBjYXNlIDE6ICZsdDtpbnB1dCB0eXBlPXRleHQmZ3Q7PC9wPgo8dGFibGUgc3R5bGU9 ImJvcmRlcjogM3B4IHNvbGlkIGJsdWU7Ij4KICAgIDx0cj48dGQgc3R5bGU9ImJvcmRlcjogM3B4 IHNvbGlkIHJlZCI+PGlucHV0IHN0eWxlPSJ3aWR0aDogMTAwcHg7IiB0eXBlPXRleHQ+PC90ZD48 L3RyPgo8L3RhYmxlPgo8cD5UZXN0IGNhc2UgMjogJmx0O2lucHV0IHR5cGU9cGFzc3dvcmQmZ3Q7 PC9wPgo8dGFibGUgc3R5bGU9ImJvcmRlcjogM3B4IHNvbGlkIGJsdWU7Ij4KICAgIDx0cj48dGQg c3R5bGU9ImJvcmRlcjogM3B4IHNvbGlkIHJlZCI+PGlucHV0IHN0eWxlPSJ3aWR0aDogMTAwcHg7 IiB0eXBlPXBhc3N3b3JkPjwvdGQ+PC90cj4KPC90YWJsZT4KPHA+VGVzdCBjYXNlIDM6ICZsdDtk aXYmZ3Q7PC9wPgo8dGFibGUgc3R5bGU9ImJvcmRlcjogM3B4IHNvbGlkIGJsdWU7Ij4KICAgIDx0 cj48dGQgc3R5bGU9ImJvcmRlcjogM3B4IHNvbGlkIHJlZCI+PGRpdiBzdHlsZT0id2lkdGg6IDEw MHB4OyI+PC9kaXY+PC90ZD48L3RyPgo8L3RhYmxlPgo8cD5UZXN0IGNhc2UgNDogJmx0O2lucHV0 IHR5cGU9dGV4dCZndDsgaW4gMngyIHRhYmxlPC9wPgo8dGFibGUgc3R5bGU9ImJvcmRlcjogM3B4 IHNvbGlkIGJsdWU7Ij4KICAgIDx0cj48dGQ+Zmlyc3Q8L3RkPjx0ZCBzdHlsZT0iYm9yZGVyOiAz cHggc29saWQgcmVkIj48aW5wdXQgc3R5bGU9IndpZHRoOiAxMDBweDsiIHR5cGU9dGV4dD48L3Rk PjwvdHI+CiAgICA8dHI+PHRkPnNlY29uZDwvdGQ+PHRkIHN0eWxlPSJib3JkZXI6IDNweCBzb2xp ZCByZWQiIGFsaWduPSJyaWdodCI+PGlucHV0IHN0eWxlPSJ3aWR0aDogMTAwcHg7IiB0eXBlPXRl eHQ+PC90ZD48L3RyPgo8L3RhYmxlPgo8cD5UZXN0IGNhc2UgNTogdHdvIHJvd3Mgb2YgJmx0O2lu cHV0IHR5cGU9cGFzc3dvcmQmZ3Q7IGluIDJ4MiB0YWJsZTwvcD4KPHRhYmxlIHN0eWxlPSJib3Jk ZXI6IDNweCBzb2xpZCBibHVlOyI+CiAgICA8dHI+PHRkPmZpcnN0PC90ZD48dGQgc3R5bGU9ImJv cmRlcjogM3B4IHNvbGlkIHJlZCI+PGlucHV0IHN0eWxlPSJ3aWR0aDogMTAwcHg7IiB0eXBlPXBh c3N3b3JkPjwvdGQ+PC90cj4KICAgIDx0cj48dGQ+c2Vjb25kPC90ZD48dGQgc3R5bGU9ImJvcmRl cjogM3B4IHNvbGlkIHJlZCIgYWxpZ249InJpZ2h0Ij48aW5wdXQgc3R5bGU9IndpZHRoOiAxMDBw eDsiIHR5cGU9cGFzc3dvcmQ+PC90ZD48L3RyPgo8L3RhYmxlPgo8cD5UZXN0IGNhc2UgNjogdHdv IHJvd3Mgb2YgJmx0O2RpdiZndDsgaW4gMngyIHRhYmxlPC9wPgo8dGFibGUgc3R5bGU9ImJvcmRl cjogM3B4IHNvbGlkIGJsdWU7Ij4KICAgIDx0cj48dGQ+Zmlyc3Q8L3RkPjx0ZCBzdHlsZT0iYm9y ZGVyOiAzcHggc29saWQgcmVkIj48ZGl2IHN0eWxlPSJ3aWR0aDogMTAwcHg7Ij48L2Rpdj48L3Rk PjwvdHI+CiAgICA8dHI+PHRkPnNlY29uZDwvdGQ+PHRkIHN0eWxlPSJib3JkZXI6IDNweCBzb2xp ZCByZWQiIGFsaWduPSJyaWdodCI+PGRpdiBzdHlsZT0id2lkdGg6IDEwMHB4OyI+PC9kaXY+PC90 ZD48L3RyPgo8L3RhYmxlPgo= 7503 2006-04-04 10:09:01 -0700 2006-04-04 13:40:06 -0700 initial patch calc.txt text/plain 2430 adele SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUZXh0RmllbGQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRl cmluZy9SZW5kZXJUZXh0RmllbGQuY3BwCShyZXZpc2lvbiAxMzY3MSkKKysrIHJlbmRlcmluZy9S ZW5kZXJUZXh0RmllbGQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTUsMTcgKzIxNSw0NCBAQAog CiB2b2lkIFJlbmRlclRleHRGaWVsZDo6Y2FsY01pbk1heFdpZHRoKCkKIHsKLSAgICAvLyBGaWd1 cmUgb3V0IGhvdyBiaWcgYSB0ZXh0IGZpZWxkIG5lZWRzIHRvIGJlIGZvciBhIGdpdmVuIG51bWJl ciBvZiBjaGFyYWN0ZXJzCi0gICAgLy8gKHVzaW5nICIwIiBhcyB0aGUgbm9taW5hbCBjaGFyYWN0 ZXIpLgotICAgIGludCBzaXplID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KGVsZW1l bnQoKSktPnNpemUoKTsKLSAgICBpZiAoc2l6ZSA8PSAwKQotICAgICAgICBzaXplID0gMjA7Cisg ICAgbV9taW5XaWR0aCA9IDA7CisgICAgbV9tYXhXaWR0aCA9IDA7CisKKyAgICBjYWxjQmxvY2tN aW5NYXhXaWR0aCgpOworCisgICAgaWYobV9tYXhXaWR0aCA8IG1fbWluV2lkdGgpIG1fbWF4V2lk dGggPSBtX21pbldpZHRoOworCisgICAgaWYgKHN0eWxlKCktPndpZHRoKCkuaXNGaXhlZCgpICYm IHN0eWxlKCktPndpZHRoKCkudmFsdWUoKSA+IDApCisgICAgICAgIG1fbWluV2lkdGggPSBtX21h eFdpZHRoID0gY2FsY0NvbnRlbnRCb3hXaWR0aChzdHlsZSgpLT53aWR0aCgpLnZhbHVlKCkpOwor ICAgIGVsc2UgeworICAgICAgICAvLyBGaWd1cmUgb3V0IGhvdyBiaWcgYSB0ZXh0IGZpZWxkIG5l ZWRzIHRvIGJlIGZvciBhIGdpdmVuIG51bWJlciBvZiBjaGFyYWN0ZXJzCisgICAgICAgIC8vICh1 c2luZyAiMCIgYXMgdGhlIG5vbWluYWwgY2hhcmFjdGVyKS4KKyAgICAgICAgaW50IHNpemUgPSBz dGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4oZWxlbWVudCgpKS0+c2l6ZSgpOworICAgICAg ICBpZiAoc2l6ZSA8PSAwKQorICAgICAgICAgICAgc2l6ZSA9IDIwOworCisgICAgICAgIFFDaGFy IGNoWzFdOworICAgICAgICBjaFswXSA9ICcwJzsKKyAgICAgICAgaW50IHNpemVXaWR0aCA9IChp bnQpY2VpbGYoc3R5bGUoKS0+Zm9udCgpLmZsb2F0V2lkdGgoY2gsIDEsIDAsIDEsIDAsIDApICog c2l6ZSk7CisgICAgICAgIG1fbWF4V2lkdGggPSBzaXplV2lkdGg7CisgICAgfQogICAgIAotICAg IFFDaGFyIGNoWzFdOwotICAgIGNoWzBdID0gJzAnOwotICAgIG1fbWluV2lkdGggPSBtX21heFdp ZHRoID0gKGludCljZWlsZihzdHlsZSgpLT5mb250KCkuZmxvYXRXaWR0aChjaCwgMSwgMCwgMSwg MCwgMCkgKiBzaXplKSArIHBhZGRpbmdMZWZ0KCkgKyBwYWRkaW5nUmlnaHQoKSArIAotICAgICAg ICAgICAgICAgIGJvcmRlckxlZnQoKSArIGJvcmRlclJpZ2h0KCkgKyBtX2Rpdi0+cmVuZGVyZXIo KS0+cGFkZGluZ0xlZnQoKSArIG1fZGl2LT5yZW5kZXJlcigpLT5wYWRkaW5nUmlnaHQoKTsKLSAg ICBzZXRNaW5NYXhLbm93bigpOworICAgIGlmIChzdHlsZSgpLT5taW5XaWR0aCgpLmlzRml4ZWQo KSAmJiBzdHlsZSgpLT5taW5XaWR0aCgpLnZhbHVlKCkgPiAwKSB7CisgICAgICAgIG1fbWF4V2lk dGggPSBtYXgobV9tYXhXaWR0aCwgY2FsY0NvbnRlbnRCb3hXaWR0aChzdHlsZSgpLT5taW5XaWR0 aCgpLnZhbHVlKCkpKTsKKyAgICAgICAgbV9taW5XaWR0aCA9IG1heChtX21pbldpZHRoLCBjYWxj Q29udGVudEJveFdpZHRoKHN0eWxlKCktPm1pbldpZHRoKCkudmFsdWUoKSkpOworICAgIH0gZWxz ZQorICAgICAgICBtX21pbldpZHRoID0gbV9tYXhXaWR0aDsKKyAgICAKKyAgICBpZiAoc3R5bGUo KS0+bWF4V2lkdGgoKS5pc0ZpeGVkKCkgJiYgc3R5bGUoKS0+bWF4V2lkdGgoKS52YWx1ZSgpICE9 IHVuZGVmaW5lZExlbmd0aCkgeworICAgICAgICBtX21heFdpZHRoID0gbWluKG1fbWF4V2lkdGgs IGNhbGNDb250ZW50Qm94V2lkdGgoc3R5bGUoKS0+bWF4V2lkdGgoKS52YWx1ZSgpKSk7CisgICAg ICAgIG1fbWluV2lkdGggPSBtaW4obV9taW5XaWR0aCwgY2FsY0NvbnRlbnRCb3hXaWR0aChzdHls ZSgpLT5tYXhXaWR0aCgpLnZhbHVlKCkpKTsKKyAgICB9CisKKyAgICBpbnQgdG9BZGQgPSBwYWRk aW5nTGVmdCgpICsgcGFkZGluZ1JpZ2h0KCkgKyBib3JkZXJMZWZ0KCkgKyBib3JkZXJSaWdodCgp ICsgbV9kaXYtPnJlbmRlcmVyKCktPnBhZGRpbmdMZWZ0KCkgKyBtX2Rpdi0+cmVuZGVyZXIoKS0+ cGFkZGluZ1JpZ2h0KCk7CisgICAgbV9taW5XaWR0aCArPSB0b0FkZDsKKyAgICBtX21heFdpZHRo ICs9IHRvQWRkOworCisgICAgc2V0TWluTWF4S25vd24oKTsgICAgCiB9CiAKIHZvaWQgUmVuZGVy VGV4dEZpZWxkOjpmb3J3YXJkRXZlbnQoRXZlbnQqIGV2dCkK