80690 2012-03-09 02:40:57 -0800 [BlackBerry] Web Notification not working after rebase 2012-03-09 20:42:44 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 charles.wei webkit-unassigned rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 574761 0 charles.wei 2012-03-09 02:40:57 -0800 Web Notification doesn't work on master_35 after rebase. The upstreaming notification is now connected in different way. We need to adapt the new way of connecting the Notifications to the WebCore. New way: WebCore::provideNotificaiton() , defined in NotificaionController.h/cpp old way: ChromeClient::notificaionPresenter(), which is removed . 574763 1 charles.wei 2012-03-09 02:42:38 -0800 Internal PR: 142886 574779 2 131022 charles.wei 2012-03-09 03:09:35 -0800 Created attachment 131022 Patch With this patch, we did: 1. Namespace of NotificationPresenterImpl moved from WebKit to WebCore. All code in WebCoreSupport should be in the namespace of WebCore. 2. Remove the un-needed ChromeClientBlackBerry::notificationPresenter 3. Connect the NotificationPresenter to WebCore using WebCore::provideNotification(Page*, NotificationPresenter*). 574827 3 131022 webkit.review.bot 2012-03-09 05:11:43 -0800 Comment on attachment 131022 Patch Clearing flags on attachment: 131022 Committed r110290: <http://trac.webkit.org/changeset/110290> 574828 4 webkit.review.bot 2012-03-09 05:11:48 -0800 All reviewed patches have been landed. Closing bug. 574834 5 tonikitoo 2012-03-09 05:21:01 -0800 This should not have landed. We are not landing any m35 only patches until it is deployed. 574836 6 tonikitoo 2012-03-09 05:22:57 -0800 .. 575423 7 charles.wei 2012-03-09 20:30:56 -0800 What should we do reopening it? should we revert the patch ? 575427 8 tonikitoo 2012-03-09 20:42:44 -0800 Well, we can close it. I do not think it can cause backport problems. Rob also landed a few patches in the same situation (m35) , but we've agreed to wait a bit, and some patches are on hold. Lets leave this one in : ) why not? 131022 2012-03-09 03:09:35 -0800 2012-03-09 05:11:43 -0800 Patch 0001-BlackBerry-Web-Notification-not-working-after-rebase.patch text/plain 6294 charles.wei RnJvbSA0ZGM0ZjFkZGRlMzkxMWUwZjdhNDIyYjM0ZTZhNmQ3OGJkNzBmNzM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFybGVzIFdlaSA8Y2hhcmxlcy53ZWlAdG9yY2htb2JpbGUu Y29tLmNuPgpEYXRlOiBGcmksIDkgTWFyIDIwMTIgMTk6MDk6MzEgKzA4MDAKU3ViamVjdDogW1BB VENIXSBbQmxhY2tCZXJyeV0gV2ViIE5vdGlmaWNhdGlvbiBub3Qgd29ya2luZyBhZnRlciByZWJh c2UKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDY5MAoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoxLiBOb3RpZmljYXRpb25QcmVzZW50ZXJJbXBsIHNob3Vs ZCBiZSBpbiBuYW1lc3BhY2UgV2ViQ29yZQoyLiBOZWVkIHRvIGNvbm5lY3QgTm90aWZpY2F0aW9u UHJlc2VudGVySW1wbCB0byB3ZWJjb3JlIHRoZSBuZXcgd2F5OgogICBXZWJDb3JlOjpwcm92aWRl Tm90aWZpY2F0aW9uKFBhZ2UqLCBOb3RpZmljYXRpb25QcmVzZW50ZXIqKQozLiBSZW1vdmUgdGhl IG9sZCB3YXkgb2YgY29ubmVjdGluZyB0aGUgTm90aWZpY2F0aW9uOgogICBDaHJvbWVDbGllbnRC bGFja0JlcnJ5Ojpub3RpZmljYXRpb25QcmVzZW50ZXIoKQoKKiBBcGkvV2ViUGFnZS5jcHA6CihC bGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjppbml0KToKKiBXZWJDb3JlU3VwcG9y dC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcDoKKFdlYkNvcmUpOgoqIFdlYkNvcmVTdXBwb3J0 L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuaDoKKENocm9tZUNsaWVudEJsYWNrQmVycnkpOgoqIFdl YkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuY3BwOgoqIFdlYkNvcmVTdXBw b3J0L05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuaDoKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2UuY3BwICAgICAgICAgICB8ICAgIDcgKysrKysrCiBTb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMjIgKysrKysrKysr KysrKysrKysrKysKIC4uLi9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNw cCAgICAgIHwgICAgOCAtLS0tLS0tCiAuLi4vV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50Qmxh Y2tCZXJyeS5oICAgICAgICB8ICAgIDQgLS0tCiAuLi4vV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0 aW9uUHJlc2VudGVySW1wbC5jcHAgICB8ICAgIDMgKy0KIC4uLi9XZWJDb3JlU3VwcG9ydC9Ob3Rp ZmljYXRpb25QcmVzZW50ZXJJbXBsLmggICAgIHwgICAgMiArLQogNiBmaWxlcyBjaGFuZ2VkLCAz MSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcAppbmRleCAwNDlhZjMyLi5hZDQzMzYwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTcyLDYgKzcyLDkgQEAKICNpbmNsdWRlICJM YXllcldlYktpdFRocmVhZC5oIgogI2luY2x1ZGUgIk5ldHdvcmtNYW5hZ2VyLmgiCiAjaW5jbHVk ZSAiTm9kZVJlbmRlclN0eWxlLmgiCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCisjaW5jbHVk ZSAiTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbC5oIgorI2VuZGlmCiAjaW5jbHVkZSAiUGFnZS5o IgogI2luY2x1ZGUgIlBhZ2VDYWNoZS5oIgogI2luY2x1ZGUgIlBhZ2VHcm91cC5oIgpAQCAtNDI4 LDYgKzQzMSwxMCBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjppbml0KGNvbnN0IFdlYlN0cmluZyYg cGFnZUdyb3VwTmFtZSkKICAgICBwYWdlQ2xpZW50cy5kZXZpY2VPcmllbnRhdGlvbkNsaWVudCA9 IG5ldyBEZXZpY2VPcmllbnRhdGlvbkNsaWVudEJsYWNrQmVycnkodGhpcyk7CiAgICAgbV9wYWdl ID0gbmV3IFBhZ2UocGFnZUNsaWVudHMpOwogCisjaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCisg ICAgV2ViQ29yZTo6cHJvdmlkZU5vdGlmaWNhdGlvbihtX3BhZ2UsIE5vdGlmaWNhdGlvblByZXNl bnRlckltcGw6Omluc3RhbmNlKCkpOworI2VuZGlmCisKICNpZiBFTkFCTEUoQ0xJRU5UX0JBU0VE X0dFT0xPQ0FUSU9OKSAmJiBFTkFCTEVfRFJUCiAgICAgLy8gSW4gY2FzZSBydW5uaW5nIGluIER1 bXBSZW5kZXJUcmVlIG1vZGUgc2V0IHRoZSBjb250cm9sbGVyIHRvIG1vY2sgcHJvdmlkZXIuCiAg ICAgaWYgKGdldGVudigiZHJ0UnVuIikpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRl eCBlOTBmNjE0Li4xNWM5NDQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxMi0wMy0wOSAgQ2hhcmxlcyBXZWkgIDxjaGFybGVzLndlaUB0b3JjaG1v YmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFdlYiBOb3RpZmljYXRpb24gbm90 IHdvcmtpbmcgYWZ0ZXIgcmViYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MDY5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIDEuIE5vdGlmaWNhdGlvblByZXNlbnRlckltcGwgc2hvdWxkIGJlIGluIG5h bWVzcGFjZSBXZWJDb3JlCisgICAgICAgIDIuIE5lZWQgdG8gY29ubmVjdCBOb3RpZmljYXRpb25Q cmVzZW50ZXJJbXBsIHRvIHdlYmNvcmUgdGhlIG5ldyB3YXk6CisgICAgICAgICAgIFdlYkNvcmU6 OnByb3ZpZGVOb3RpZmljYXRpb24oUGFnZSosIE5vdGlmaWNhdGlvblByZXNlbnRlciopCisgICAg ICAgIDMuIFJlbW92ZSB0aGUgb2xkIHdheSBvZiBjb25uZWN0aW5nIHRoZSBOb3RpZmljYXRpb246 CisgICAgICAgICAgIENocm9tZUNsaWVudEJsYWNrQmVycnk6Om5vdGlmaWNhdGlvblByZXNlbnRl cigpCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjppbml0KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuaDoKKyAgICAgICAgKENocm9t ZUNsaWVudEJsYWNrQmVycnkpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlv blByZXNlbnRlckltcGwuY3BwOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlv blByZXNlbnRlckltcGwuaDoKKwogMjAxMi0wMy0wOCAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkBy aW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBbHdheXMgdXNlIHRoZSBjdXJyZW50IGZv Y3VzZWQgbm9kZSB3aGVuIHByb2Nlc3NpbmcgZm9jdXMgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVy cnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGVlMWYyOGYuLjNmYzRhZmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0Jl cnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTQzLDcgKzQzLDYgQEAKICNpbmNsdWRlICJLVVJM LmgiCiAjaW5jbHVkZSAiTm9kZS5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCi0jaW5j bHVkZSAiTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbC5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNp bmNsdWRlICJQYWdlR3JvdXAuaCIKICNpbmNsdWRlICJQYWdlR3JvdXBMb2FkRGVmZXJyZXIuaCIK QEAgLTcyNSwxMyArNzI0LDYgQEAgdm9pZCBDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjpkaWRTZXRT Vkdab29tQW5kUGFuKEZyYW1lKiBmcmFtZSwgdW5zaWduZWQgc2hvcnQgem8KIH0KICNlbmRpZgog Ci0jaWYgRU5BQkxFKE5PVElGSUNBVElPTlMpCi1Ob3RpZmljYXRpb25QcmVzZW50ZXIqIENocm9t ZUNsaWVudEJsYWNrQmVycnk6Om5vdGlmaWNhdGlvblByZXNlbnRlcigpIGNvbnN0Ci17Ci0gICAg cmV0dXJuIFdlYktpdDo6Tm90aWZpY2F0aW9uUHJlc2VudGVySW1wbDo6aW5zdGFuY2UoKTsKLX0K LSNlbmRpZgotCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogdm9pZCBDaHJvbWVD bGllbnRCbGFja0JlcnJ5OjphdHRhY2hSb290R3JhcGhpY3NMYXllcihGcmFtZSogZnJhbWUsIEdy YXBoaWNzTGF5ZXIqIGdyYXBoaWNzTGF5ZXIpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5oIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVy cnkuaAppbmRleCAzZTZkYjQ3Li5iMjRkMzljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0Jl cnJ5LmgKQEAgLTEyOCwxMCArMTI4LDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCByZXF1 ZXN0V2ViR0xQZXJtaXNzaW9uKEZyYW1lKik7CiAjZW5kaWYKIAotI2lmIEVOQUJMRShOT1RJRklD QVRJT05TKQotICAgIHZpcnR1YWwgTm90aWZpY2F0aW9uUHJlc2VudGVyKiBub3RpZmljYXRpb25Q cmVzZW50ZXIoKSBjb25zdDsKLSNlbmRpZgotCiAjaWYgRU5BQkxFKFNWRykKICAgICB2aXJ0dWFs IHZvaWQgZGlkU2V0U1ZHWm9vbUFuZFBhbihGcmFtZSosIHVuc2lnbmVkIHNob3J0IHpvb21BbmRQ YW4pOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29y ZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVySW1wbC5jcHAKaW5k ZXggMDc2ZmI1OS4uZDAxYzg3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJJ bXBsLmNwcApAQCAtMjYsOSArMjYsOCBAQAogI2luY2x1ZGUgPFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQuaD4KICNpbmNsdWRlIDxVVUlELmg+CiAKLXVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCi1u YW1lc3BhY2UgV2ViS2l0IHsKK25hbWVzcGFjZSBXZWJDb3JlIHsKIAogTm90aWZpY2F0aW9uUHJl c2VudGVyKiBOb3RpZmljYXRpb25QcmVzZW50ZXJJbXBsOjppbnN0YW5jZSgpCiB7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9u UHJlc2VudGVySW1wbC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L05vdGlmaWNhdGlvblByZXNlbnRlckltcGwuaAppbmRleCBlMjZjMTVmLi5kYTg0YTVlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0 aW9uUHJlc2VudGVySW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3Jl U3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJJbXBsLmgKQEAgLTI5LDcgKzI5LDcgQEAKICNp bmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgog Ci1uYW1lc3BhY2UgV2ViS2l0IHsKK25hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgTm90aWZp Y2F0aW9uUHJlc2VudGVySW1wbCA6IHB1YmxpYyBXZWJDb3JlOjpOb3RpZmljYXRpb25QcmVzZW50 ZXIsIHB1YmxpYyBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Tm90aWZpY2F0aW9uQWNrTGlzdGVuZXIg ewogcHVibGljOgotLSAKMS43LjkuMQoK