<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>80686</bug_id>
          
          <creation_ts>2012-03-09 01:57:28 -0800</creation_ts>
          <short_desc>HTML parser: allow &lt;hr&gt; to be used inside &lt;select&gt; as a separator</short_desc>
          <delta_ts>2023-05-03 01:15:27 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Forms</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://github.com/whatwg/html/issues/3410</see_also>
    
    <see_also>https://github.com/whatwg/html/pull/9124</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>41115</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kent Tamura">tkent</reporter>
          <assigned_to name="Anne van Kesteren">annevk</assigned_to>
          <cc>abarth</cc>
    
    <cc>adele</cc>
    
    <cc>annevk</cc>
    
    <cc>ap</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>hyatt</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>574739</commentid>
    <comment_count>0</comment_count>
      <attachid>131013</attachid>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-03-09 01:57:28 -0800</bug_when>
    <thetext>Created attachment 131013
Reproducible HTML

We have a feature that &lt;hr&gt; children in a &lt;select&gt; represent a menu separator.

http://www.webkit.org/blog/32/webkit-fixes-in-safari-202-mac-os-x-1043/
&gt; Menu separator support: an &lt;hr&gt; inside a &lt;select&gt; with size 1 will now add a horizontal separator in the menu.

This feature doesn&apos;t work for now if such markup is parsed by the parser. It works if we insert &lt;hr&gt; into a &lt;select&gt; by a DOM operation.
Open the attached HTML, and see the difference between two popup menus.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>574913</commentid>
    <comment_count>1</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2012-03-09 08:44:10 -0800</bug_when>
    <thetext>I think we need to change the spec first. It says that hr should be ignored: http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-inselect</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>574915</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-03-09 08:48:44 -0800</bug_when>
    <thetext>Or we should drop the feature if it&apos;s not implemented by other rendering engines.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>575889</commentid>
    <comment_count>3</comment_count>
    <who name="Kent Tamura">tkent</who>
    <bug_when>2012-03-11 19:14:54 -0700</bug_when>
    <thetext>It seems Chromium is using this feature for a popup menu in chrome://settings/fonts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>575907</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-03-11 20:23:56 -0700</bug_when>
    <thetext>&gt; It seems Chromium is using this feature for a popup menu in chrome://settings/fonts.

Chromium shouldn&apos;t constrain us.  We can change Chromium to use a more wildly supported API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>575956</commentid>
    <comment_count>5</comment_count>
    <who name="Adele Peterson">adele</who>
    <bug_when>2012-03-11 23:04:32 -0700</bug_when>
    <thetext>I originally added this support for an Apple Dashboard widget that is no longer using that markup.  Unfortunately, I think there were other clients over the years.  I&apos;ll have to check to see if we have any reports about this not working in the latest Safari/OS X WebKit, but I suspect no one has noticed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1946720</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-04-05 06:41:26 -0700</bug_when>
    <thetext>&lt;rdar://problem/107656886&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1946721</commentid>
    <comment_count>7</comment_count>
    <who name="Anne van Kesteren">annevk</who>
    <bug_when>2023-04-05 06:44:37 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/12407</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1952595</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-05-03 01:15:24 -0700</bug_when>
    <thetext>Committed 263624@main (d9e3a6262dbe): &lt;https://commits.webkit.org/263624@main&gt;

Reviewed commits have been landed. Closing PR #12407 and removing active labels.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>131013</attachid>
            <date>2012-03-09 01:57:28 -0800</date>
            <delta_ts>2012-03-09 01:57:28 -0800</delta_ts>
            <desc>Reproducible HTML</desc>
            <filename>select-separator.html</filename>
            <type>text/html</type>
            <size>506</size>
            <attacher name="Kent Tamura">tkent</attacher>
            
              <data encoding="base64">PGxhYmVsPkhSIGJ5IHBhcnNlcjoKPHNlbGVjdD4KPG9wdGdyb3VwIGxhYmVsPSJmb28iPgo8b3B0
aW9uPmZvbzEKPG9wdGlvbj5mb28yCjwvb3B0Z3JvdXA+CjxvcHRncm91cCBsYWJlbD0iYmFyIj4K
PG9wdGlvbj5iYXIKPC9vcHRncm91cD4KPGhyPgo8b3B0aW9uPmJhego8L3NlbGVjdD4KPC9sYWJl
bD4KCjxsYWJlbD5IUiBieSBET00gb3BlcmF0aW9uCjxzZWxlY3Q+CjxvcHRncm91cCBsYWJlbD0i
Zm9vIj4KPG9wdGlvbj5mb28xCjxvcHRpb24+Zm9vMgo8L29wdGdyb3VwPgo8b3B0Z3JvdXAgbGFi
ZWw9ImJhciI+CjxvcHRpb24+YmFyCjwvb3B0Z3JvdXA+CjxvcHRpb24+YmF6Cjwvc2VsZWN0Pgo8
L2xhYmVsPgoKPHNjcmlwdD4KdmFyIHNlbGVjdDEgPSBkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFn
TmFtZSgnc2VsZWN0JylbMV07CnNlbGVjdDEuaW5zZXJ0QmVmb3JlKGRvY3VtZW50LmNyZWF0ZUVs
ZW1lbnQoJ2hyJyksIHNlbGVjdDEubGFzdEVsZW1lbnRDaGlsZCk7Cjwvc2NyaXB0Pgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>