80670 2012-03-08 19:08:44 -0800 [chromium] Expose the shared graphics context on WebView so callers can allocate resources on the main thread for the compositor to use 2012-03-09 13:33:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth fischman fishd kbr piman senorblanco webkit.review.bot oldest_to_newest 574495 0 jamesr 2012-03-08 19:08:44 -0800 [chromium] Expose the shared graphics context on WebView so callers can allocate resources on the main thread for the compositor to use 574496 1 130951 jamesr 2012-03-08 19:10:15 -0800 Created attachment 130951 Patch 574498 2 webkit.review.bot 2012-03-08 19:12:47 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 574499 3 jamesr 2012-03-08 19:13:50 -0800 Longer term I think that it's possible that this is the only context exposed on WebView, but for now I'm exposing both contexts so that the chromium and WebKit sides can land without #ifdefs to guard and so that we can figure out how to handle H/W accel video separately. Chromium side: https://chromiumcodereview.appspot.com/9657021 574645 4 130951 piman 2012-03-08 22:36:16 -0800 Comment on attachment 130951 Patch lgtm 574995 5 130951 senorblanco 2012-03-09 10:33:10 -0800 Comment on attachment 130951 Patch OK. r=me 575166 6 jamesr 2012-03-09 13:33:02 -0800 Committed r110325: <http://trac.webkit.org/changeset/110325> 130951 2012-03-08 19:10:15 -0800 2012-03-09 10:33:09 -0800 Patch bug-80670-20120308191014.patch text/plain 3979 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBmYWI3NzI1YWExNjNkOWZhY2NkYzI3N2UwNDE4ODUwYzcwZGMzYTUuLjcyNzZiM2EwZTg1ZDMx NmM3NGJmYWZiZTBkZjI3NmFmNjI2ODRmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMjYgQEAKIDIwMTItMDMtMDggIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KIAorICAgICAgICBbY2hyb21pdW1dIEV4cG9zZSB0aGUgc2hhcmVkIGdyYXBoaWNz IGNvbnRleHQgb24gV2ViVmlldyBzbyBjYWxsZXJzIGNhbiBhbGxvY2F0ZSByZXNvdXJjZXMgb24g dGhlIG1haW4gdGhyZWFkIGZvciB0aGUgY29tcG9zaXRvciB0byB1c2UKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwNjcwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBleHBvc2VzIGEgY29udGV4dCBv biBXZWJWaWV3IHRoYXQgaXMgaW4gdGhlIGNvbXBvc2l0b3IncyBzaGFyZSBncm91cCBhbmQgY2Fu IGJlIHVzZWQgZGlyZWN0bHkgZnJvbSB0aGUgbWFpbgorICAgICAgICB0aHJlYWQuIFRoaXMgaXMg dXNlZnVsIGZvciBjb250ZW50IHRoYXQgbmVlZHMgdG8gYWxsb2NhdGUgcmVzb3VyY2VzIGZvciB0 aGUgY29tcG9zaXRvciB0byB1c2UsIGJ1dCBjYW5ub3QKKyAgICAgICAgZGlyZWN0bHkgdXNlIHRo ZSBjb21wb3NpdG9yJ3MgY29udGV4dCBlaXRoZXIgYmVjYXVzZSBpdCBjYW5ub3QgYWNjZXNzIHRo ZSBjb3JyZWN0IHRocmVhZCBvciBiZWNhdXNlIGl0IG5lZWRzIHRvCisgICAgICAgIGluaXRpYWxp emUgaW4gc2l0dWF0aW9ucyB3aGVyZSB3ZSBjYW5ub3QgaW5pdGlhbGl6ZSBhIGNvbXBvc2l0b3Ig KHZpZXcpIGNvbnRleHQgLSBmb3IgaW5zdGFuY2UgYmVmb3JlIHRoZSBuYXRpdmUKKyAgICAgICAg d2luZG93IGlzIGNyZWF0ZWQuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVmlldy5oOgorICAgICAg ICAoV2ViVmlldyk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViVmlld0ltcGw6OnNoYXJlZEdyYXBoaWNzQ29udGV4dDNEKToKKyAgICAgICAgKFdl YktpdCk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6CisgICAgICAgIChXZWJWaWV3SW1w bCk6CisKKzIwMTItMDMtMDggIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4K KwogICAgICAgICBVc2UgYW4gZXhwbGljaXQgYXR0cmlidXRlIHRvIHNpZ25hbCB0aGF0IGEgY29u dGV4dCBwcmVmZXJzIHRvIHVzZSBhIGRpc2NyZXRlIEdQVQogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA2MzkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViVmlldy5oCmluZGV4IDlkNWNhODk0NDIyZmViMDAyMGM0OTk0MDljNjEyM2UxZDFj NTEzZjEuLjUwY2YyZWFhMDkzMmVjODZkNTk0NTJlMTkwYTVhYjI5NTI1YmVjZTAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKQEAgLTQzMCw2ICs0MzAsMTAgQEAgcHVi bGljOgogICAgIC8vIEFQSXMuCiAgICAgdmlydHVhbCBXZWJHcmFwaGljc0NvbnRleHQzRCogZ3Jh cGhpY3NDb250ZXh0M0QoKSA9IDA7CiAKKyAgICAvLyBDb250ZXh0IHRoYXQncyBpbiB0aGUgY29t cG9zaXRvcidzIHNoYXJlIGdyb3VwLCBidXQgaXMgbm90IHRoZSBjb21wb3NpdG9yIGNvbnRleHQg aXRzZWxmLgorICAgIC8vIENhbiBiZSB1c2VkIGZvciBhbGxvY2F0aW5nIHJlc291cmNlcyB0aGF0 IHRoZSBjb21wb3NpdG9yIHdpbGwgbGF0ZXIgYWNjZXNzLgorICAgIHZpcnR1YWwgV2ViR3JhcGhp Y3NDb250ZXh0M0QqIHNoYXJlZEdyYXBoaWNzQ29udGV4dDNEKCkgPSAwOworCiAgICAgLy8gVmlz aWJpbGl0eSAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQogCiAgICAgLy8gU2V0cyB0aGUgdmlzaWJpbGl0eSBvZiB0aGUgV2ViVmlldy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBlYzk0MDNj YmNkNjk5YmY1MTg4N2Y0MzgwNDZkZGU0YTc0MDYwNmFmLi41YTljOTA5MWRjNTE4Zjg2MmU2NDQy YjBhNDQwMTM4YjdjNzZlOTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwCkBAIC0xMDQsNiArMTA0LDcgQEAKICNpbmNsdWRlICJTZWN1cml0eU9yaWdpbi5o IgogI2luY2x1ZGUgIlNlY3VyaXR5UG9saWN5LmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKKyNp bmNsdWRlICJTaGFyZWRHcmFwaGljc0NvbnRleHQzRC5oIgogI2luY2x1ZGUgIlNwZWVjaElucHV0 Q2xpZW50SW1wbC5oIgogI2luY2x1ZGUgIlRleHRJdGVyYXRvci5oIgogI2luY2x1ZGUgIlRpbWVy LmgiCkBAIC0zMzM3LDYgKzMzMzgsMTQgQEAgV2ViR3JhcGhpY3NDb250ZXh0M0QqIFdlYlZpZXdJ bXBsOjpncmFwaGljc0NvbnRleHQzRCgpCiAgICAgcmV0dXJuIDA7CiB9CiAKK1dlYkdyYXBoaWNz Q29udGV4dDNEKiBXZWJWaWV3SW1wbDo6c2hhcmVkR3JhcGhpY3NDb250ZXh0M0QoKQoreworICAg IGlmICghbV9wYWdlLT5zZXR0aW5ncygpLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCgp IHx8ICFhbGxvd3NBY2NlbGVyYXRlZENvbXBvc2l0aW5nKCkpCisgICAgICAgIHJldHVybiAwOwor CisgICAgcmV0dXJuIEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6ZXh0cmFjdFdlYkdyYXBoaWNz Q29udGV4dDNEKFNoYXJlZEdyYXBoaWNzQ29udGV4dDNEOjpnZXQoKSk7Cit9CisKIHZvaWQgV2Vi Vmlld0ltcGw6OnNldFZpc2liaWxpdHlTdGF0ZShXZWJQYWdlVmlzaWJpbGl0eVN0YXRlIHZpc2li aWxpdHlTdGF0ZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIGlz SW5pdGlhbFN0YXRlKSB7CiAgICAgaWYgKCFwYWdlKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuaAppbmRleCA1NTc3NDA3ZGUzYjQxMTI5YjA1ZDM0ZmVjNTFkOThiNjYw NzgyZWNkLi4zODE5ZWNiNjU1NDFlMWQ1M2RhMDg2ODFkMjY2MDhiZGMzNjVlYTViIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKQEAgLTQ1Nyw2ICs0NTcsOCBAQCBw dWJsaWM6CiAgICAgLy8gd2UgY291bGQgbm90IHN1Y2Nlc3NmdWxseSBpbnN0YW50aWF0ZSBhIGNv bnRleHQuCiAgICAgdmlydHVhbCBXZWJHcmFwaGljc0NvbnRleHQzRCogZ3JhcGhpY3NDb250ZXh0 M0QoKTsKIAorICAgIHZpcnR1YWwgV2ViR3JhcGhpY3NDb250ZXh0M0QqIHNoYXJlZEdyYXBoaWNz Q29udGV4dDNEKCk7CisKICAgICBQYXNzT3duUHRyPFdlYkdyYXBoaWNzQ29udGV4dDNEPiBjcmVh dGVDb21wb3NpdG9yR3JhcGhpY3NDb250ZXh0M0QoKTsKIAogICAgIHZpcnR1YWwgdm9pZCBzZXRW aXNpYmlsaXR5U3RhdGUoV2ViUGFnZVZpc2liaWxpdHlTdGF0ZSwgYm9vbCk7Cg==