80668 2012-03-08 18:57:17 -0800 [GTK] Menulist buttons have separators even when the theme turns them off 2012-03-14 15:05:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/enter_bug.cgi?product=WebKit P2 Normal --- 1 mrobinson mrobinson cgarcia gustavo xan.lopez oldest_to_newest 574484 0 mrobinson 2012-03-08 18:57:17 -0800 Adwait disables separators in combo boxes, yet they still appear in menulists rendered in GTK+. 574500 1 130952 mrobinson 2012-03-08 19:16:03 -0800 Created attachment 130952 Patch 575597 2 130952 dbates 2012-03-10 17:53:05 -0800 Comment on attachment 130952 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130952&action=review This patch looks reasonable to me. That being said, feel free to get a more formal review from another GTK expert. > Source/WebCore/ChangeLog:10 > + No new tests. GTK+ theme differences are notoriously difficult > + to test, because consistent results depend on having certain themes > + certain versions of themes installed. The second sentence doesn't read well. I think it may read better if you remove the phrase "certain themes". 576450 3 130952 mrobinson 2012-03-12 13:19:55 -0700 Comment on attachment 130952 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130952&action=review >> Source/WebCore/ChangeLog:10 >> + certain versions of themes installed. > > The second sentence doesn't read well. I think it may read better if you remove the phrase "certain themes". I meant to say "certain themes and certain versions of themes" here. I'll fix that before landing. Thanks for the review! 578822 4 mrobinson 2012-03-14 15:05:06 -0700 Committed r110762: <http://trac.webkit.org/changeset/110762> 130952 2012-03-08 19:16:03 -0800 2012-03-12 13:19:55 -0700 Patch bug-80668-20120308191602.patch text/plain 2664 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdlN2ZiMjZjODk4M2Nk NGQzYzU0YTY0YmYxODhkNDkzNzMwZGJhOC4uZjcwNmRhZWU2MzVmNmQzNDFkOTVlMTcwOTVlNDE3 YjdmOGNhZmM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTA4ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBNZW51 bGlzdCBidXR0b25zIGhhdmUgc2VwYXJhdG9ycyBldmVuIHdoZW4gdGhlIHRoZW1lIHR1cm5zIHRo ZW0gb2ZmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MDY2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gR1RLKyB0aGVtZSBkaWZmZXJlbmNlcyBhcmUgbm90b3Jpb3VzbHkgZGlmZmlj dWx0CisgICAgICAgIHRvIHRlc3QsIGJlY2F1c2UgY29uc2lzdGVudCByZXN1bHRzIGRlcGVuZCBv biBoYXZpbmcgY2VydGFpbiB0aGVtZXMKKyAgICAgICAgY2VydGFpbiB2ZXJzaW9ucyBvZiB0aGVt ZXMgaW5zdGFsbGVkLgorCisgICAgICAgIEluc3RlYWQgb2YgdXNpbmcgdGhlIEdUS19UWVBFX0JV VFRPTiBhbmQgR1RLX1RZUEVfU0VQQVJBVE9SIHRhZ3MgdG8gZ2V0IHRoZQorICAgICAgICBzdHls ZSBjb250ZXh0LCB1c2UgR1RLX1RZUEVfQ09NQk9fQk9YIHdoaWNoIHNob3VsZCBwcm92aWRlIG1v cmUgYWNjdXJhdGUgdGhlbWUgc2V0dGluZ3MuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVu ZGVyVGhlbWVHdGszLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldENvbWJvQm94TWV0cmljcyk6 IEdldCBtZXRyaWNzIGZyb20gYSBHVEtfVFlQRV9DT01CT19CT1ggc3R5bGUgY29udGV4dC4KKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpwYWludE1lbnVMaXN0KTogR2V0IHNlcGFy YXRvciBzZXR0aW5ncyBmcm9tIHRoZSBHVEtfVFlQRV9DT01CT19CT1ggc3R5bGUgY29udGV4dC4K KwogMjAxMi0wMy0wNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAg ICAgICBNZXJnZSBBc3luY0ZpbGVTdHJlYW0gd2l0aCBGaWxlU3RyZWFtUHJveHkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKaW5kZXggMzU2MzAw MjU3OGZjMzAzNzg4ZmRjNTJjOTlmNDJmMTIzNDg0YTI2Yi4uYTY2OWJjOGVmODUyM2Q0ODY2ZjFl YjgwYTI1MTIzMzAyYWQ0YzQ1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Rr L1JlbmRlclRoZW1lR3RrMy5jcHAKQEAgLTM2Niw3ICszNjYsNyBAQCBzdGF0aWMgdm9pZCBnZXRD b21ib0JveE1ldHJpY3MoUmVuZGVyU3R5bGUqIHN0eWxlLCBHdGtCb3JkZXImIGJvcmRlciwgaW50 JiBmb2N1cwogICAgIGlmIChzdHlsZS0+YXBwZWFyYW5jZSgpID09IE5vQ29udHJvbFBhcnQpCiAg ICAgICAgIHJldHVybjsKIAotICAgIEd0a1N0eWxlQ29udGV4dCogY29udGV4dCA9IGdldFN0eWxl Q29udGV4dChHVEtfVFlQRV9CVVRUT04pOworICAgIEd0a1N0eWxlQ29udGV4dCogY29udGV4dCA9 IGdldFN0eWxlQ29udGV4dChHVEtfVFlQRV9DT01CT19CT1gpOwogICAgIGd0a19zdHlsZV9jb250 ZXh0X3NhdmUoY29udGV4dCk7CiAKICAgICBndGtfc3R5bGVfY29udGV4dF9hZGRfY2xhc3MoY29u dGV4dCwgR1RLX1NUWUxFX0NMQVNTX0JVVFRPTik7CkBAIC01MjIsMTIgKzUyMiwxMSBAQCBib29s IFJlbmRlclRoZW1lR3RrOjpwYWludE1lbnVMaXN0KFJlbmRlck9iamVjdCogcmVuZGVyT2JqZWN0 LCBjb25zdCBQYWludEluZm8mCiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfcmVzdG9yZShhcnJvd1N0 eWxlQ29udGV4dCk7CiAKICAgICAvLyBQYWludCB0aGUgc2VwYXJhdG9yIGlmIG5lZWRlZC4KLSAg ICBHdGtTdHlsZUNvbnRleHQqIHNlcGFyYXRvclN0eWxlQ29udGV4dCA9IGdldFN0eWxlQ29udGV4 dChHVEtfVFlQRV9TRVBBUkFUT1IpOworICAgIEd0a1N0eWxlQ29udGV4dCogc2VwYXJhdG9yU3R5 bGVDb250ZXh0ID0gZ2V0U3R5bGVDb250ZXh0KEdUS19UWVBFX0NPTUJPX0JPWCk7CiAgICAgZ3Rr X3N0eWxlX2NvbnRleHRfc2F2ZShzZXBhcmF0b3JTdHlsZUNvbnRleHQpOwogCiAgICAgZ3RrX3N0 eWxlX2NvbnRleHRfc2V0X2RpcmVjdGlvbihzZXBhcmF0b3JTdHlsZUNvbnRleHQsIGRpcmVjdGlv bik7CiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfYWRkX2NsYXNzKHNlcGFyYXRvclN0eWxlQ29udGV4 dCwgInNlcGFyYXRvciIpOwotICAgIGd0a19zdHlsZV9jb250ZXh0X2FkZF9jbGFzcyhzZXBhcmF0 b3JTdHlsZUNvbnRleHQsIEdUS19TVFlMRV9DTEFTU19CVVRUT04pOwogCiAgICAgZ2Jvb2xlYW4g d2lkZVNlcGFyYXRvcnM7CiAgICAgZ2ludCBzZXBhcmF0b3JXaWR0aDsK