80652 2012-03-08 16:07:19 -0800 Fix the build of WebKit with WTFURL following the removal of ForwardingHeaders/wtf 2012-03-08 21:52:52 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 benjamin benjamin abarth eric webkit.review.bot oldest_to_newest 574352 0 benjamin 2012-03-08 16:07:19 -0800 WebKit does not compile with WTFURL. Just fix the headers. 574355 1 130932 benjamin 2012-03-08 16:12:25 -0800 Created attachment 130932 Patch 574561 2 130932 eric 2012-03-08 20:49:10 -0800 Comment on attachment 130932 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130932&action=review > Source/JavaScriptCore/wtf/url/api/ParsedURL.h:32 > +#include <wtf/url/src/URLSegments.h> I guess src/ is public. :) 574609 3 130932 webkit.review.bot 2012-03-08 21:52:34 -0800 Comment on attachment 130932 Patch Clearing flags on attachment: 130932 Committed r110261: <http://trac.webkit.org/changeset/110261> 574610 4 webkit.review.bot 2012-03-08 21:52:39 -0800 All reviewed patches have been landed. Closing bug. 574611 5 benjamin 2012-03-08 21:52:52 -0800 > I guess src/ is public. :) Yep, everything is in there. API is using other parts of WTF. The src part is independent so you have a chance to adopt if for Chromium. Thanks for the review. 130932 2012-03-08 16:12:25 -0800 2012-03-08 21:52:34 -0800 Patch bug-80652-20120308161224.patch text/plain 2404 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MjE5ZTAyMjc2ZDU3ZjEwZTZiZDA0NDQxZDJiMTdiNzQyN2U0MDAxLi42MTA1OWE5Njk5NGZkMTNl NDg3OGM5N2ViNzZmYzcxNDAwNjRmNTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMi0wMy0wOCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBidWlsZCBvZiBXZWJLaXQgd2l0aCBXVEZVUkwgZm9s bG93aW5nIHRoZSByZW1vdmFsIG9mIEZvcndhcmRpbmdIZWFkZXJzL3d0ZgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA2NTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIGhlYWRlciwgVVJMU2Vn bWVudHMuaCBpcyBub3QgcGFydCBvZiB0aGUgQVBJLgorCisgICAgICAgICogd3RmL3VybC9hcGkv UGFyc2VkVVJMLmg6CisKIDIwMTItMDMtMDggIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNv bT4KIAogICAgICAgICBCdWlsZCBmaXguICBUaGF0IGRheSBpcyBub3QgdG9kYXkuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggYWQ1MzVhYjFiZDcxMzFjZjQyMmE4MzUwNDdjMWQxYjllZjI5ODIxNS4uMzBhYmRiZmUy ODM4YzA5OTI0NDQxMjg1YzU1NjUyNWVkYTE0NzlhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTAzLTA4ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4K KworICAgICAgICBGaXggdGhlIGJ1aWxkIG9mIFdlYktpdCB3aXRoIFdURlVSTCBmb2xsb3dpbmcg dGhlIHJlbW92YWwgb2YgRm9yd2FyZGluZ0hlYWRlcnMvd3RmCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDY1MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmb3dhcmRpbmcgaGVhZGVycyBoYXZlIGJl ZW4gcmVtb3ZlZCwgd2UgbXVzdCBub3cgdXNlIHRoZSBmdWxsIHBhdGggdG8gdGhlIGhlYWRlci4K KworICAgICAgICAqIHBsYXRmb3JtL0tVUkxXVEZVUkxJbXBsLmg6CisKIDIwMTItMDMtMDggIFRv bnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBpbXBsZW1lbnQgZmxleGJv eCB3cmFwLXJldmVyc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdXJs L2FwaS9QYXJzZWRVUkwuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdXJsL2FwaS9QYXJz ZWRVUkwuaAppbmRleCAzMThkZGRmZGIzMDI2MTlhYmY3M2FlYWQyMmY0YTkzZmFiNGVmNzNlLi4y YmIzMzMwY2ZjMTEzMjA2ODE0MzkxMzBlMzMxZDM0OGI4ZGIzN2Q4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL3VybC9hcGkvUGFyc2VkVVJMLmgKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi91cmwvYXBpL1BhcnNlZFVSTC5oCkBAIC0yOCw4ICsyOCw4IEBACiAK ICNpZiBVU0UoV1RGVVJMKQogCi0jaW5jbHVkZSA8d3RmL3VybC9hcGkvVVJMU2VnbWVudHMuaD4K ICNpbmNsdWRlIDx3dGYvdXJsL2FwaS9VUkxTdHJpbmcuaD4KKyNpbmNsdWRlIDx3dGYvdXJsL3Ny Yy9VUkxTZWdtZW50cy5oPgogCiBuYW1lc3BhY2UgV1RGIHsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vS1VSTFdURlVSTEltcGwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL0tVUkxXVEZVUkxJbXBsLmgKaW5kZXggNWQzODA2NWZlMmE1ODhiZjVlMDVlNWYzNzljYjI4 NWMyYjI0NjdiYS4uMzc5YzQ5MmFkYjQ2N2IwZWVkMDc1MGY0NzAyNmViNjhkZjkwM2E1MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS1VSTFdURlVSTEltcGwuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMV1RGVVJMSW1wbC5oCkBAIC0zMiw3ICszMiw3IEBA CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAj aW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+Ci0jaW5jbHVkZSA8d3RmL3VybC9QYXJzZWRV UkwuaD4KKyNpbmNsdWRlIDx3dGYvdXJsL2FwaS9QYXJzZWRVUkwuaD4KIAogbmFtZXNwYWNlIFdl YkNvcmUgewogCg==