80633 2012-03-08 13:27:08 -0800 Missing some places where we should be blinding 64bit values (and blinding something we shouldn't) 2012-03-08 14:29:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver webkit.review.bot oldest_to_newest 574126 0 oliver 2012-03-08 13:27:08 -0800 Missing some places where we should be blinding 64bit values (and blinding something we shouldn't) 574132 1 130890 oliver 2012-03-08 13:31:12 -0800 Created attachment 130890 Patch 574135 2 webkit.review.bot 2012-03-08 13:33:35 -0800 Attachment 130890 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/MacroAssembler.h:524: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 574167 3 oliver 2012-03-08 13:59:13 -0800 Committed r110200: <http://trac.webkit.org/changeset/110200> 574197 4 vestbo 2012-03-08 14:20:46 -0800 This broke quite a few things I believe. http://build.webkit.org/builders/Qt%20Linux%20Release/builds/44191/steps/compile-webkit/logs/stdio http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/44369/steps/compile-webkit/logs/stdio http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/41111/steps/compile-webkit/logs/stdio 574210 5 oliver 2012-03-08 14:29:31 -0800 Committed r110206 130890 2012-03-08 13:31:12 -0800 2012-03-08 13:55:26 -0800 Patch bug-80633-20120308133110.patch text/plain 4819 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 YmEyODVkYWY3ZjQyOWYzZDQxZDNlMjA4YTgwZDJiODMzMGE3ZDIxLi43YTRmOGU1MTE1YWEwNTcz Zjc5NWQxMzE0Njg3NGUzODhlZTEyYTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxMi0wMy0wOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIE1pc3Npbmcgc29tZSBwbGFjZXMgd2hlcmUgd2Ugc2hvdWxkIGJlIGJsaW5kaW5n IDY0Yml0IHZhbHVlcyAoYW5kIGJsaW5kaW5nIHNvbWV0aGluZyB3ZSBzaG91bGRuJ3QpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDYzMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCA2NC1iaXQgdHJh cCBmb3Igc2hvdWxkQmxpbmRGb3JTcGVjaWZpY0FyY2gsIHNvIHRoYXQgd2UgYWx3YXlzIGJsaW5k CisgICAgICAgIGlmIHRoZXJlIGlzbid0IGEgbWFjaGluZSBzcGVjaWZpYyBpbXBsZW1lbnRhdGlv biAob3RoZXJ3aXNlIHRoZSA2NGJpdCB2YWx1ZQorICAgICAgICBnb3QgdHJ1bmNhdGVkIGFuZCAz MmJpdCBjaGVja3Mgd2VyZSB1c2VkIC0tIGxlYXZpbmcgMzJiaXRzIHVudGVzdGVkKS4KKyAgICAg ICAgQWxzbyBhZGQgYSBiaXQgb2YgbG9naWMgdG8gZW5zdXJlIHRoYXQgd2UgZG9uJ3QgdHJ5IHRv IGJsaW5kIGEgZmV3IGNvbW1vbgorICAgICAgICBjb25zdGFudHMgdGhhdCBnbyB0aHJvdWdoIHRo ZSBJbW1QdHIgcGF0aHMgLS0gZW5jb2RlZCBudW1lcmljIEpTVmFsdWVzIGFuZAorICAgICAgICB1 bmVuY29kZWQgZG91YmxlcyB3aXRoIGNvbW1vbiAic2FmZSIgdmFsdWVzLgorCisgICAgICAgICog YXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6QWJzdHJh Y3RNYWNyb0Fzc2VtYmxlcjo6c2hvdWxkQmxpbmRGb3JTcGVjaWZpY0FyY2gpOgorICAgICAgICAq IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxl cjo6c2hvdWxkQmxpbmREb3VibGUpOgorICAgICAgICAoTWFjcm9Bc3NlbWJsZXIpOgorICAgICAg ICAoSlNDOjpNYWNyb0Fzc2VtYmxlcjo6c2hvdWxkQmxpbmQpOgorICAgICAgICAqIGFzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxl clg4NkNvbW1vbjo6c2hvdWxkQmxpbmRGb3JTcGVjaWZpY0FyY2gpOgorCiAyMDEyLTAzLTA4ICBT dGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGxpbmUg ZW5kaW5ncyBmb3IgY29weS1maWxlcy5jbWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oCmluZGV4IDgxNjNiYWU2 MzRiYTI4MmM5ODE2YjJlYWZjODAzZTI5ZjAyNTVjMTMuLmYyYTE3ZmJlZjNkMjY1YWRkODkwYTE3 MWUzNTcxNzliYjJmYjA4YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oCkBAIC01OTIsNiArNTkyLDcgQEAg cHJvdGVjdGVkOgogICAgIAogICAgIHN0YXRpYyBib29sIHNjcmF0Y2hSZWdpc3RlckZvckJsaW5k aW5nKCkgeyByZXR1cm4gZmFsc2U7IH0KICAgICBzdGF0aWMgYm9vbCBzaG91bGRCbGluZEZvclNw ZWNpZmljQXJjaCh1aW50MzJfdCkgeyByZXR1cm4gdHJ1ZTsgfQorICAgIHN0YXRpYyBib29sIHNo b3VsZEJsaW5kRm9yU3BlY2lmaWNBcmNoKHVpbnQ2NF90KSB7IHJldHVybiB0cnVlOyB9CiAKICAg ICBmcmllbmQgY2xhc3MgTGlua0J1ZmZlcjsKICAgICBmcmllbmQgY2xhc3MgUmVwYXRjaEJ1ZmZl cjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIu aAppbmRleCA2YTMwNzJlYmEwMjhlOWE0OWZhYmI2NTUwYzUyNDhmZTU2M2M3MDE1Li40ZDAzYjdi YzJkZTVkMzIxODdhYmIzZjIxODUyNmU3ZGVhMTkyNGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCkBAIC01MDQsNiArNTA0LDI5IEBA IHB1YmxpYzoKICAgICB1c2luZyBNYWNyb0Fzc2VtYmxlckJhc2U6OnN1YlB0cjsKICAgICB1c2lu ZyBNYWNyb0Fzc2VtYmxlckJhc2U6OnhvclB0cjsKICAgICAKKyAgICBib29sIHNob3VsZEJsaW5k RG91YmxlKGRvdWJsZSB2YWx1ZSkKKyAgICB7CisgICAgICAgIC8vIERvbid0IHRydXN0IE5hTiBv ciArLy1JbmZpbml0eQorICAgICAgICBpZiAoIWlzZmluaXRlKHZhbHVlKSkKKyAgICAgICAgICAg IHJldHVybiB0cnVlOworCisgICAgICAgIC8vIFRyeSB0byBmb3JjZSBub3JtYWxpc2F0aW9uLCBh bmQgY2hlY2sgdGhhdCB0aGVyZSdzIG5vIGNoYW5nZQorICAgICAgICAvLyBpbiB0aGUgYml0IHBh dHRlcm4KKyAgICAgICAgaWYgKGJpdHdpc2VfY2FzdDx1aW50cHRyX3Q+KHZhbHVlICogMS4wKSAh PSBiaXR3aXNlX2Nhc3Q8dWludHB0cl90Pih2YWx1ZSkpCisgICAgICAgICAgICByZXR1cm4gdHJ1 ZTsKKworICAgICAgICB2YWx1ZSA9IGFicyh2YWx1ZSk7CisgICAgICAgIC8vIE9ubHkgYWxsb3cg YSBsaW1pdGVkIHNldCBvZiBmcmFjdGlvbmFsIGNvbXBvbmVudHMKKyAgICAgICAgZG91YmxlIHNj YWxlZFZhbHVlID0gdmFsdWUgKiA4OworICAgICAgICBpZiAoc2NhbGVkVmFsdWUgLyA4ICE9IHZh bHVlKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIGRvdWJsZSBmcmFjID0gc2Nh bGVkVmFsdWUgLSBmbG9vcihzY2FsZWRWYWx1ZSk7CisgICAgICAgIGlmIChmcmFjICE9IDAuMCkK KyAgICAgICAgICAgIHJldHVybiB0cnVlOworCisgICAgICAgIHJldHVybiB2YWx1ZSA+IDB4ZmY7 CisgICAgfQorICAgIAogICAgIGJvb2wgc2hvdWxkQmxpbmQoSW1tUHRyIGltbSkKICAgICB7IAog ICAgICAgICBBU1NFUlQoIWluVW5pbnRlcnJ1cHRlZFNlcXVlbmNlKCkpOwpAQCAtNTI2LDkgKzU0 OSwyMCBAQCBwdWJsaWM6CiAgICAgICAgIGNhc2UgMHhmZmZmZmZmZmZmZmZmZkw6CiAgICAgICAg IGNhc2UgMHhmZmZmZmZmZmZmZmZmZmZmTDoKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAg ICAgICAgZGVmYXVsdDoKKyAgICAgICAgZGVmYXVsdDogewogICAgICAgICAgICAgaWYgKHZhbHVl IDw9IDB4ZmYpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworI2lmIENQVShYODZfNjQp CisgICAgICAgICAgICBKU1ZhbHVlIGpzVmFsdWUgPSBKU1ZhbHVlOjpkZWNvZGUocmVpbnRlcnBy ZXRfY2FzdDx2b2lkKj4odmFsdWUpKTsKKyAgICAgICAgICAgIGlmIChqc1ZhbHVlLmlzSW50MzIo KSkKKyAgICAgICAgICAgICAgICByZXR1cm4gc2hvdWxkQmxpbmQoSW1tMzIoanNWYWx1ZS5hc0lu dDMyKCkpKTsKKyAgICAgICAgICAgIGlmIChqc1ZhbHVlLmlzRG91YmxlKCkgJiYgIXNob3VsZEJs aW5kRG91YmxlKGpzVmFsdWUuYXNEb3VibGUoKSkpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOworCisgICAgICAgICAgICBpZiAoIXNob3VsZEJsaW5kRG91YmxlKGJpdHdpc2VfY2FzdDxk b3VibGU+KHZhbHVlKSkpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmIAor ICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIHNob3VsZEJsaW5kRm9yU3BlY2lm aWNBcmNoKHZhbHVlKTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCmluZGV4IGQ0ZDQ2NmI5MWYy YmQzZDYyOTYyNTBmNTliZmRjZDgwM2ZiMmVlNTkuLjMyNGU5NmJmNDY2OTc2NGVmZTA0ZjEzMmFl NDYxN2JiNjMwMTZlNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgKQEAgLTkyLDYgKzkyLDcgQEAgcHVi bGljOgogICAgIHN0YXRpYyBjb25zdCBSZWdpc3RlcklEIHN0YWNrUG9pbnRlclJlZ2lzdGVyID0g WDg2UmVnaXN0ZXJzOjplc3A7CiAgICAgCiAgICAgc3RhdGljIGJvb2wgc2hvdWxkQmxpbmRGb3JT cGVjaWZpY0FyY2godWludDMyX3QgdmFsdWUpIHsgcmV0dXJuIHZhbHVlID49IDB4MDBmZmZmZmY7 IH0KKyAgICBzdGF0aWMgYm9vbCBzaG91bGRCbGluZEZvclNwZWNpZmljQXJjaCh1aW50cHRyX3Qg dmFsdWUpIHsgcmV0dXJuIHZhbHVlID49IDB4MDBmZmZmZmY7IH0KIAogICAgIC8vIEludGVnZXIg YXJpdGhtZXRpYyBvcGVyYXRpb25zOgogICAgIC8vCg==