80626 2012-03-08 12:15:42 -0800 [chromium] Only build NEON files if target_arch=="arm" 2012-03-08 19:21:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis raymes tony webkit.review.bot oldest_to_newest 574065 0 thakis 2012-03-08 12:15:42 -0800 [chromium] Only build NEON files fi target_arch=="arm" 574066 1 130874 thakis 2012-03-08 12:18:01 -0800 Created attachment 130874 Patch 574079 2 130874 tony 2012-03-08 12:28:08 -0800 Comment on attachment 130874 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130874&action=review > Source/WebCore/ChangeLog:9 > + Currently, webcore_arm_neon will compile a bunch of files > + whose contents are completely ifdef'd away on non-arm, and > + then bundle all the generated empty .o files into a useless > + libwebcore_arm_neon.a. Don't do this. This change seems fine since we're not using the lib at all. > Source/WebCore/ChangeLog:12 > + Also change the source section from "include everything, then > + throw away everything except 6 files" to "list 6 files". I don't like this because this means we have a file list in two places (confusing for non-chromium people adding new files). The current design is to have all the files listed WebCore.gypi. Another way to do this would be to make a new variable in WebCore.gypi that lists the NEON files. 574082 3 130879 thakis 2012-03-08 12:31:36 -0800 Created attachment 130879 Patch 574085 4 thakis 2012-03-08 12:32:35 -0800 > > Source/WebCore/ChangeLog:12 > > + Also change the source section from "include everything, then > > + throw away everything except 6 files" to "list 6 files". > > I don't like this because this means we have a file list in two places (confusing for non-chromium people adding new files). The current design is to have all the files listed WebCore.gypi. Another way to do this would be to make a new variable in WebCore.gypi that lists the NEON files. Reverted that part. Maybe I'll do your suggestin in a follow-up (for platform/ and rendering/, too) 574503 5 130879 webkit.review.bot 2012-03-08 19:21:19 -0800 Comment on attachment 130879 Patch Clearing flags on attachment: 130879 Committed r110251: <http://trac.webkit.org/changeset/110251> 574504 6 webkit.review.bot 2012-03-08 19:21:23 -0800 All reviewed patches have been landed. Closing bug. 130874 2012-03-08 12:18:01 -0800 2012-03-08 12:31:29 -0800 Patch bug-80626-20120308121800.patch text/plain 4505 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY3MzEzOGRjYTg4ZGY4 MzMzYjhlN2Y5ZmYwZDYyNmUyZTk3NmY3MC4uMDc1OTM1OThiYjBhODAwMThkMmNjMjhkYmNiYzQw ZDViZTExNzlmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTA4ICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIE9ubHkg YnVpbGQgTkVPTiBmaWxlcyBpZiB0YXJnZXRfYXJjaD09ImFybSIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwNjI2CisKKyAgICAgICAgQ3VycmVudGx5 LCB3ZWJjb3JlX2FybV9uZW9uIHdpbGwgY29tcGlsZSBhIGJ1bmNoIG9mIGZpbGVzCisgICAgICAg IHdob3NlIGNvbnRlbnRzIGFyZSBjb21wbGV0ZWx5IGlmZGVmJ2QgYXdheSBvbiBub24tYXJtLCBh bmQKKyAgICAgICAgdGhlbiBidW5kbGUgYWxsIHRoZSBnZW5lcmF0ZWQgZW1wdHkgLm8gZmlsZXMg aW50byBhIHVzZWxlc3MKKyAgICAgICAgbGlid2ViY29yZV9hcm1fbmVvbi5hLiBEb24ndCBkbyB0 aGlzLgorCisgICAgICAgIEFsc28gY2hhbmdlIHRoZSBzb3VyY2Ugc2VjdGlvbiBmcm9tICJpbmNs dWRlIGV2ZXJ5dGhpbmcsIHRoZW4KKyAgICAgICAgdGhyb3cgYXdheSBldmVyeXRoaW5nIGV4Y2Vw dCA2IGZpbGVzIiB0byAibGlzdCA2IGZpbGVzIi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwOgorICAgICAg ICAqIFdlYkNvcmUuZ3lwaToKKwogMjAxMi0wMy0wMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtp dC5vcmc+CiAKICAgICAgICAgQ2hyb21lIDE4IGZhaWxzIGh0bWw1dGVzdC5jb20gWEhSIEJsb2Ig cmVzcG9uc2UgdGVzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2Vi Q29yZS5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCBk OWE3NWY4ZTNhNzM5NThkMWFkODZiZjMyYjQ3OWE0ZGFjMTAyN2ZjLi5kYzcxOTU4NGY1ZTE5M2Zh YjcwMTMzNzJmYzI0MDE0OWFiNjk0YTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJD b3JlLmd5cApAQCAtMTQ2NSw5ICsxNDY1LDYgQEAKICAgICAgICAgWydleGNsdWRlJywgJ3BsYXRm b3JtL01JTUVUeXBlUmVnaXN0cnlcXC5jcHAkJ10sCiAgICAgICAgIFsnZXhjbHVkZScsICdwbGF0 Zm9ybS9UaGVtZVxcLmNwcCQnXSwKICAgICAgICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL2dyYXBo aWNzL0FOR0xFV2ViS2l0QnJpZGdlXFwuKGNwcHxoKSQnXSwKLSAgICAgICAgIyAqTkVPTi5jcHAg ZmlsZXMgbmVlZCBzcGVjaWFsIGNvbXBpbGUgb3B0aW9ucy4KLSAgICAgICAgIyBUaGV5IGFyZSBt b3ZlZCB0byB0aGUgd2ViY29yZV9hcm1fbmVvbiB0YXJnZXQuCi0gICAgICAgIFsnZXhjbHVkZScs ICdwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS8uKk5FT05cXC4oY3BwfGgpJ10sCiAgICAg ICAgIFsnZXhjbHVkZScsICdwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVy XFwuKGNwcHxoKSQnXSwKICAgICAgICAgWydleGNsdWRlJywgJ3BsYXRmb3JtL2ltYWdlLWVuY29k ZXJzL1BOR0ltYWdlRW5jb2RlclxcLihjcHB8aCkkJ10sCiAgICAgICAgIFsnZXhjbHVkZScsICdw bGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlXFwuY3BwJCddLApAQCAtMTcxNiwyNSArMTcx MywyOSBAQAogICAgICMgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MjkxNi4KICAgICB7CiAgICAgICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZV9hcm1fbmVvbics Ci0gICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCi0gICAgICAnZGVwZW5kZW5jaWVzJzog WwotICAgICAgICAnd2ViY29yZV9wcmVyZXF1aXNpdGVzJywKLSAgICAgIF0sCi0gICAgICAnaGFy ZF9kZXBlbmRlbmN5JzogMSwKLSAgICAgICdzb3VyY2VzJzogWwotICAgICAgICAnPEAod2ViY29y ZV9maWxlcyknLAotICAgICAgXSwKLSAgICAgICdzb3VyY2VzLyc6IFsKLSAgICAgICAgWydleGNs dWRlJywgJy4qJ10sCi0gICAgICAgIFsnaW5jbHVkZScsICdwbGF0Zm9ybS9ncmFwaGljcy9maWx0 ZXJzL2FybS8uKk5FT05cXC4oY3BwfGgpJ10sCi0gICAgICBdLAogICAgICAgJ2NvbmRpdGlvbnMn OiBbCi0gICAgICAgIFsnT1M9PSJhbmRyb2lkIicsIHsKLSAgICAgICAgICAnY2ZsYWdzISc6IFsn LW10aHVtYiddLAotICAgICAgICAgICdjZmxhZ3MnOiBbJy1tYXJtJ10sCi0gICAgICAgIH1dLAot ICAgICAgICBbJ09TPT0ibGludXgiIGFuZCB0YXJnZXRfYXJjaD09ImFybSInLCB7CisgICAgICAg IFsndGFyZ2V0X2FyY2g9PSJhcm0iJywgeworICAgICAgICAgICd0eXBlJzogJ3N0YXRpY19saWJy YXJ5JywKKyAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWworICAgICAgICAgICAgJ3dlYmNvcmVf cHJlcmVxdWlzaXRlcycsCisgICAgICAgICAgXSwKKyAgICAgICAgICAnaGFyZF9kZXBlbmRlbmN5 JzogMSwKKyAgICAgICAgICAnc291cmNlcyc6IFsKKyAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmNwcCcsCisgICAgICAg ICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9hcm0vRkVDb21wb3NpdGVBcml0aG1ldGlj TkVPTi5oJywKKyAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUdh dXNzaWFuQmx1ck5FT04uY3BwJywKKyAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9maWx0 ZXJzL2FybS9GRUdhdXNzaWFuQmx1ck5FT04uaCcsCisgICAgICAgICAgICAncGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9hcm0vRkVMaWdodGluZ05FT04uY3BwJywKKyAgICAgICAgICAgICdwbGF0 Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUxpZ2h0aW5nTkVPTi5oJywKKyAgICAgICAgICBd LAogICAgICAgICAgICdjZmxhZ3MnOiBbJy1tYXJtJ10sCisgICAgICAgICAgJ2NvbmRpdGlvbnMn OiBbCisgICAgICAgICAgICBbJ09TPT0iYW5kcm9pZCInLCB7CisgICAgICAgICAgICAgICdjZmxh Z3MhJzogWyctbXRodW1iJ10sCisgICAgICAgICAgICB9XSwKKyAgICAgICAgICBdLAorICAgICAg ICB9LHsgICMgdGFyZ2V0X2FyY2ghPSJhcm0iCisgICAgICAgICAgJ3R5cGUnOiAnbm9uZScsCiAg ICAgICAgIH1dLAogICAgICAgXSwKICAgICB9LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv V2ViQ29yZS5neXBpIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCmluZGV4IDY0ZDA0ZWNm NTU2ZWZmM2I3ZjA1MjJiMDFjM2NlODgyZDNjYTI5MTcuLjg5MDUyMDUxNzBjMzFiZmFlODVlZDk3 M2NmMWFlNGRhYWIyZWQ0NmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lw aQorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKQEAgLTM1MjMsMTIgKzM1MjMsNiBA QAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvU291cmNlR3JhcGhpYy5o JywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL1Nwb3RMaWdodFNvdXJj ZS5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvU3BvdExpZ2h0 U291cmNlLmgnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZF Q29tcG9zaXRlQXJpdGhtZXRpY05FT04uY3BwJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmgnLAotICAgICAgICAg ICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFR2F1c3NpYW5CbHVyTkVPTi5jcHAn LAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFR2F1c3NpYW5C bHVyTkVPTi5oJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9G RUxpZ2h0aW5nTkVPTi5jcHAnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvYXJtL0ZFTGlnaHRpbmdORU9OLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvc2tpYS9GRUNvbG9yTWF0cml4U2tpYS5jcHAnLAogICAgICAgICAgICAgJ3BsYXRm b3JtL2dyYXBoaWNzL2ZpbHRlcnMvc2tpYS9GRUdhdXNzaWFuQmx1clNraWEuY3BwJywKICAgICAg ICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250Q2FjaGVGcmVlVHlwZS5jcHAn LAo= 130879 2012-03-08 12:31:36 -0800 2012-03-08 19:21:19 -0800 Patch bug-80626-20120308123134.patch text/plain 2474 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY3MzEzOGRjYTg4ZGY4 MzMzYjhlN2Y5ZmYwZDYyNmUyZTk3NmY3MC4uNDAzZjZmNzg1YjE0YzM1ZGNhZmU2NDhlOWMwOGY4 OWNkODMxODI2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTA4ICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIE9ubHkg YnVpbGQgTkVPTiBmaWxlcyBpZiB0YXJnZXRfYXJjaD09ImFybSIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwNjI2CisKKyAgICAgICAgQ3VycmVudGx5 LCB3ZWJjb3JlX2FybV9uZW9uIHdpbGwgY29tcGlsZSBhIGJ1bmNoIG9mIGZpbGVzCisgICAgICAg IHdob3NlIGNvbnRlbnRzIGFyZSBjb21wbGV0ZWx5IGlmZGVmJ2QgYXdheSBvbiBub24tYXJtLCBh bmQKKyAgICAgICAgdGhlbiBidW5kbGUgYWxsIHRoZSBnZW5lcmF0ZWQgZW1wdHkgLm8gZmlsZXMg aW50byBhIHVzZWxlc3MKKyAgICAgICAgbGlid2ViY29yZV9hcm1fbmVvbi5hLiBEb24ndCBkbyB0 aGlzLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog V2ViQ29yZS5neXAvV2ViQ29yZS5neXA6CisgICAgICAgICogV2ViQ29yZS5neXBpOgorCiAyMDEy LTAzLTAxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBDaHJvbWUg MTggZmFpbHMgaHRtbDV0ZXN0LmNvbSBYSFIgQmxvYiByZXNwb25zZSB0ZXN0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cCBiL1NvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4IGQ5YTc1ZjhlM2E3Mzk1OGQxYWQ4NmJmMzJi NDc5YTRkYWMxMDI3ZmMuLjQ4MzI1ZDliODk2MTVhOTU0NzUzMDIxNDllNzY4NDVjYTJhOWJkZWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCisrKyBi L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCkBAIC0xNzE2LDI1ICsxNzE2 LDI4IEBACiAgICAgIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYyOTE2LgogICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJjb3JlX2FybV9uZW9uJywK LSAgICAgICd0eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKLSAgICAgICdkZXBlbmRlbmNpZXMnOiBb Ci0gICAgICAgICd3ZWJjb3JlX3ByZXJlcXVpc2l0ZXMnLAotICAgICAgXSwKLSAgICAgICdoYXJk X2RlcGVuZGVuY3knOiAxLAotICAgICAgJ3NvdXJjZXMnOiBbCi0gICAgICAgICc8QCh3ZWJjb3Jl X2ZpbGVzKScsCi0gICAgICBdLAotICAgICAgJ3NvdXJjZXMvJzogWwotICAgICAgICBbJ2V4Y2x1 ZGUnLCAnLionXSwKLSAgICAgICAgWydpbmNsdWRlJywgJ3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvYXJtLy4qTkVPTlxcLihjcHB8aCknXSwKLSAgICAgIF0sCiAgICAgICAnY29uZGl0aW9ucyc6 IFsKLSAgICAgICAgWydPUz09ImFuZHJvaWQiJywgewotICAgICAgICAgICdjZmxhZ3MhJzogWyct bXRodW1iJ10sCi0gICAgICAgICAgJ2NmbGFncyc6IFsnLW1hcm0nXSwKLSAgICAgICAgfV0sCi0g ICAgICAgIFsnT1M9PSJsaW51eCIgYW5kIHRhcmdldF9hcmNoPT0iYXJtIicsIHsKKyAgICAgICAg Wyd0YXJnZXRfYXJjaD09ImFybSInLCB7CisgICAgICAgICAgJ3R5cGUnOiAnc3RhdGljX2xpYnJh cnknLAorICAgICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCisgICAgICAgICAgICAnd2ViY29yZV9w cmVyZXF1aXNpdGVzJywKKyAgICAgICAgICBdLAorICAgICAgICAgICdoYXJkX2RlcGVuZGVuY3kn OiAxLAorICAgICAgICAgICdzb3VyY2VzJzogWworICAgICAgICAgICAgJzxAKHdlYmNvcmVfZmls ZXMpJywKKyAgICAgICAgICBdLAorICAgICAgICAgICdzb3VyY2VzLyc6IFsKKyAgICAgICAgICAg IFsnZXhjbHVkZScsICcuKiddLAorICAgICAgICAgICAgWydpbmNsdWRlJywgJ3BsYXRmb3JtL2dy YXBoaWNzL2ZpbHRlcnMvYXJtLy4qTkVPTlxcLihjcHB8aCknXSwKKyAgICAgICAgICBdLAogICAg ICAgICAgICdjZmxhZ3MnOiBbJy1tYXJtJ10sCisgICAgICAgICAgJ2NvbmRpdGlvbnMnOiBbCisg ICAgICAgICAgICBbJ09TPT0iYW5kcm9pZCInLCB7CisgICAgICAgICAgICAgICdjZmxhZ3MhJzog WyctbXRodW1iJ10sCisgICAgICAgICAgICB9XSwKKyAgICAgICAgICBdLAorICAgICAgICB9LHsg ICMgdGFyZ2V0X2FyY2ghPSJhcm0iCisgICAgICAgICAgJ3R5cGUnOiAnbm9uZScsCiAgICAgICAg IH1dLAogICAgICAgXSwKICAgICB9LAo=