80623 2012-03-08 11:48:55 -0800 Recent changes to chromium.py etc. broke chromium_android.py 2012-03-12 09:42:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80642 1 wangxianzhu wangxianzhu abarth dpranke ojan tony webkit.review.bot oldest_to_newest 574025 0 wangxianzhu 2012-03-08 11:48:55 -0800 Dirk made some changes to chromium.py etc. causing some incompatibilities of chromium_android.py, e.g. _start() and cmd_line(), etc. Should change chromium_android.py accordingly. 574286 1 130916 wangxianzhu 2012-03-08 15:14:52 -0800 Created attachment 130916 patch 574287 2 130916 dpranke 2012-03-08 15:16:11 -0800 Comment on attachment 130916 patch Sorry for missing this ... I should've made these changes as part of my other patch :(. 574544 3 130916 webkit.review.bot 2012-03-08 20:28:47 -0800 Comment on attachment 130916 patch Clearing flags on attachment: 130916 Committed r110258: <http://trac.webkit.org/changeset/110258> 574545 4 webkit.review.bot 2012-03-08 20:28:51 -0800 All reviewed patches have been landed. Closing bug. 576188 5 tony 2012-03-12 09:36:46 -0700 Should we add a unittest for this? 576198 6 wangxianzhu 2012-03-12 09:42:55 -0700 (In reply to comment #5) > Should we add a unittest for this? Agreed. https://bugs.webkit.org/show_bug.cgi?id=80852 130916 2012-03-08 15:14:52 -0800 2012-03-08 20:28:47 -0800 patch 80623 text/plain 2389 wangxianzhu SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMDIxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTAzLTA4ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmVjZW50IGNoYW5nZXMgdG8gY2hyb21pdW0ucHkgZXRjLiBicm9r ZSBjaHJvbWl1bV9hbmRyb2lkLnB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MDYyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bV9hbmRyb2lkLnB5OgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkRHJpdmVyLl9faW5pdF9fKToK KyAgICAgICAgKENocm9taXVtQW5kcm9pZERyaXZlci5fc3RhcnQpOgorCiAyMDEyLTAzLTA4ICBU b3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBb UXRdIFByb3NwZWN0aXZlIFdpbmRvd3MgYnVpbGQgZml4CkluZGV4OiBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRy b2lkLnB5CShyZXZpc2lvbiAxMTAyMDkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkJKHdvcmtpbmcgY29weSkKQEAgLTM5NSwx NCArMzk1LDEzIEBAIGNsYXNzIENocm9taXVtQW5kcm9pZFBvcnQoY2hyb21pdW0uQ2hyb20KIGNs YXNzIENocm9taXVtQW5kcm9pZERyaXZlcihjaHJvbWl1bS5DaHJvbWl1bURyaXZlcik6CiAgICAg ZGVmIF9faW5pdF9fKHNlbGYsIHBvcnQsIHdvcmtlcl9udW1iZXIsIHBpeGVsX3Rlc3RzLCBub190 aW1lb3V0PUZhbHNlKToKICAgICAgICAgY2hyb21pdW0uQ2hyb21pdW1Ecml2ZXIuX19pbml0X18o c2VsZiwgcG9ydCwgd29ya2VyX251bWJlciwgcGl4ZWxfdGVzdHMsIG5vX3RpbWVvdXQpCi0gICAg ICAgIGlmIHNlbGYuX2ltYWdlX3BhdGg6Ci0gICAgICAgICAgICBzZWxmLl9kZXZpY2VfaW1hZ2Vf cGF0aCA9IERFVklDRV9EUlRfRElSICsgcG9ydC5ob3N0LmZpbGVzeXN0ZW0uYmFzZW5hbWUoc2Vs Zi5faW1hZ2VfcGF0aCkKKyAgICAgICAgc2VsZi5fZGV2aWNlX2ltYWdlX3BhdGggPSBOb25lCiAK LSAgICBkZWYgX3N0YXJ0KHNlbGYpOgorICAgIGRlZiBfc3RhcnQoc2VsZiwgcGl4ZWxfdGVzdHMs IHBlcl90ZXN0X2FyZ3MpOgogICAgICAgICAjIENvbnZlcnQgdGhlIG9yaWdpbmFsIGNvbW1hbmQg bGluZSBpbnRvIHRvIHR3byBwYXJ0czoKICAgICAgICAgIyAtIHRoZSAnYWRiIHNoZWxsJyBjb21t YW5kIGxpbmUgdG8gc3RhcnQgYW4gaW50ZXJhY3RpdmUgYWRiIHNoZWxsOwogICAgICAgICAjIC0g dGhlIER1bXBSZW5kZXJUcmVlIGNvbW1hbmQgbGluZSB0byBzZW5kIHRvIHRoZSBhZGIgc2hlbGwu Ci0gICAgICAgIG9yaWdpbmFsX2NtZCA9IHNlbGYuY21kX2xpbmUoKQorICAgICAgICBvcmlnaW5h bF9jbWQgPSBzZWxmLmNtZF9saW5lKHBpeGVsX3Rlc3RzLCBwZXJfdGVzdF9hcmdzKQogICAgICAg ICBzaGVsbF9jbWQgPSBbXQogICAgICAgICBkcnRfYXJncyA9IFtdCiAgICAgICAgIHBhdGhfdG9f ZHJpdmVyID0gc2VsZi5fcG9ydC5fcGF0aF90b19kcml2ZXIoKQpAQCAtNDE1LDYgKzQxNCw4IEBA IGNsYXNzIENocm9taXVtQW5kcm9pZERyaXZlcihjaHJvbWl1bS5DaHIKICAgICAgICAgICAgICAg ICAgICAgc2hlbGxfY21kLmFwcGVuZChwYXJhbSkKICAgICAgICAgICAgIGVsc2U6CiAgICAgICAg ICAgICAgICAgaWYgcGFyYW0uc3RhcnRzd2l0aCgnLS1waXhlbC10ZXN0cz0nKToKKyAgICAgICAg ICAgICAgICAgICAgaWYgbm90IHNlbGYuX2RldmljZV9pbWFnZV9wYXRoOgorICAgICAgICAgICAg ICAgICAgICAgICAgc2VsZi5fZGV2aWNlX2ltYWdlX3BhdGggPSBERVZJQ0VfRFJUX0RJUiArIHNl bGYuX3BvcnQuaG9zdC5maWxlc3lzdGVtLmJhc2VuYW1lKHNlbGYuX2ltYWdlX3BhdGgpCiAgICAg ICAgICAgICAgICAgICAgIHBhcmFtID0gJy0tcGl4ZWwtdGVzdHM9JyArIHNlbGYuX2RldmljZV9p bWFnZV9wYXRoCiAgICAgICAgICAgICAgICAgZHJ0X2FyZ3MuYXBwZW5kKHBhcmFtKQogCg==