80621 2012-03-08 11:45:47 -0800 [BlackBerry] Fix warning in PlatformTouchEventBlackBerry.cpp 2012-03-08 19:05:49 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian tonikitoo webkit.review.bot oldest_to_newest 574022 0 nima.ghanavatian 2012-03-08 11:45:47 -0800 A warning is being triggered because control can reach the end of a non-void function. This should never happen since all the enum's are being accounted for. I am adding an ASSERT_NOT_REACHED() and returning a valid value. 574057 1 130871 nima.ghanavatian 2012-03-08 12:09:51 -0800 Created attachment 130871 Patch 574061 2 130871 rwlbuis 2012-03-08 12:12:14 -0800 Comment on attachment 130871 Patch LGTM. 574490 3 130871 webkit.review.bot 2012-03-08 19:05:45 -0800 Comment on attachment 130871 Patch Clearing flags on attachment: 130871 Committed r110249: <http://trac.webkit.org/changeset/110249> 574491 4 webkit.review.bot 2012-03-08 19:05:49 -0800 All reviewed patches have been landed. Closing bug. 130871 2012-03-08 12:09:51 -0800 2012-03-08 19:05:45 -0800 Patch bug-80621-20120308150704.patch text/plain 1752 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5Nzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBlMDQyMWY1NDY0M2Yz OGVjMDcwZGYwMWRlOTAwOGU1ZTFmYzA4YS4uZmQ5MGRkMmFiYTI1MTNmMzkyMDA2NTJmY2M3ZDc3 ZTBkNTY3MTAyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTA4IE5pbWEg R2hhbmF2YXRpYW4gPG5naGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5 XSBGaXggd2FybmluZyBpbiBQbGF0Zm9ybVRvdWNoRXZlbnRCbGFja0JlcnJ5LmNwcAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA2MjEKKworICAgICAg ICBGaXhlcyBhIHdhcm5pbmcgc2VlbiB3aGVuIGNvbnRyb2wgcmVhY2hlcyB0aGUgZW5kIG9mIGEK KyAgICAgICAgbm9uLXZvaWQgZnVuY3Rpb24uICBSZXR1cm4gVG91Y2hDYW5jZWwgaW4gdGhlICdk ZWZhdWx0JyBjYXNlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9QbGF0Zm9ybVRvdWNoRXZlbnRCbGFja0JlcnJ5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvdWNoRXZlbnRUeXBlKToKKwogMjAxMi0wMy0wNSAg U2FtaSBLeW9zdGlsYSAgPHNreW9zdGlsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBQYXJ0aWFs bHkgbG9hZGVkIEpQRUdzIHNob3VsZCBoYXZlIGFscGhhIGNoYW5uZWwKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZvcm1Ub3VjaEV2ZW50QmxhY2tC ZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BsYXRmb3JtVG91 Y2hFdmVudEJsYWNrQmVycnkuY3BwCmluZGV4IDNlNzlkMTAzMjNlOGY4Zjc1ZTUyOGEyOGE2MDRh NGIyZjU5OThiNDcuLjVmNWRiYmNiMmNjNzQ3M2U3ODMxNDM1YTFhMmFhMGUzZWYzZWI0NzUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUGxhdGZvcm1Ub3Vj aEV2ZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2ti ZXJyeS9QbGF0Zm9ybVRvdWNoRXZlbnRCbGFja0JlcnJ5LmNwcApAQCAtNDAsNiArNDAsMTEgQEAg c3RhdGljIFBsYXRmb3JtRXZlbnQ6OlR5cGUgdG91Y2hFdmVudFR5cGUoQmxhY2tCZXJyeTo6UGxh dGZvcm06OlRvdWNoRXZlbnQqIGV2ZW4KICAgICBjYXNlIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpU b3VjaEV2ZW50OjpUb3VjaENhbmNlbDoKICAgICAgICAgcmV0dXJuIFBsYXRmb3JtRXZlbnQ6OlRv dWNoQ2FuY2VsOwogICAgIH0KKworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIC8vIFJl dHVybmluZyBUb3VjaENhbmNlbCBqdXN0IHRvIHNhdGlzZnkgdGhlIGNvbXBpbGVyJ3Mgd2lzaCB0 byByZXR1cm4gYSB2YWxpZCB0eXBlIGluIGEgbm9uLXZvaWQgZnVuY3Rpb24uCisgICAgLy8gVGhp cyBjb2RlIHNob3VsZCBub3QgYmUgcmVhY2hlZC4KKyAgICByZXR1cm4gUGxhdGZvcm1FdmVudDo6 VG91Y2hDYW5jZWw7CiB9CiAKIFBsYXRmb3JtVG91Y2hFdmVudDo6UGxhdGZvcm1Ub3VjaEV2ZW50 KEJsYWNrQmVycnk6OlBsYXRmb3JtOjpUb3VjaEV2ZW50KiBldmVudCkK