8062 2006-03-29 15:11:43 -0800 Caret color in new text field should take background color and foreground color into consideration 2006-11-27 13:42:11 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 adele adele ian oldest_to_newest 37884 0 adele 2006-03-29 15:11:43 -0800 Caret color in new text field should match text color 38012 1 7399 adele 2006-03-30 13:08:43 -0800 Created attachment 7399 test 38014 2 7401 adele 2006-03-30 13:09:43 -0800 Created attachment 7401 patch 38032 3 7401 adele 2006-03-30 15:48:39 -0800 Comment on attachment 7401 patch Hyatt and I talked about this. We may want to only do this for text fields... or just use the color of the rootEditableElement....or add a new css property -khtml-caret-color with good default values. 38344 4 mjs 2006-04-02 23:25:37 -0700 These are all text field regressions so they should all be P1. 38363 5 mjs 2006-04-02 23:29:14 -0700 It's odd that text fields ever did this - rich text NSTextViews don't seem to. 38372 6 adele 2006-04-03 00:18:17 -0700 The old text fields didn't do this. Hyatt and I discussed adding this feature. Bumping back down to P2 since its not a regression. 53691 7 adele 2006-08-25 13:26:23 -0700 Changing title to reflect new goal. We want to choose a white or black caret based on the background color and foreground colors. 44066 8 11646 adele 2006-11-27 13:23:43 -0800 Created attachment 11646 new patch Hyatt and I discussed this new approach for this bug. This patch just gets the caret color from the root editable element. This will work well for text controls, and also will work for editable WebViews by just getting the color from the body element. 44053 9 11646 hyatt 2006-11-27 13:38:55 -0800 Comment on attachment 11646 new patch r=me 44054 10 adele 2006-11-27 13:42:11 -0800 Committed revision 17885 worldofwarcraft.com users, rejoice! 7399 2006-03-30 13:08:43 -0800 2006-03-30 13:08:43 -0800 test test.html text/html 49 adele PGlucHV0IGlkPSJpbnAiIHZhbHVlPSJ0ZXN0IiBzdHlsZT0iY29sb3I6IHBpbmsiPg== 7401 2006-03-30 13:09:43 -0800 2006-03-30 15:48:39 -0800 patch caret.txt text/plain 707 adele SW5kZXg6IGVkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZWRp dGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcAkocmV2aXNpb24gMTM1NjYpCisrKyBlZGl0aW5n L1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MjcsOCArODI3LDEx IEBACiAgICAgICAgIGxheW91dCgpOwogICAgICAgICAKICAgICBJbnRSZWN0IGNhcmV0ID0gaW50 ZXJzZWN0aW9uKGNhcmV0UmVjdCgpLCByZWN0KTsKKyAgICBCcnVzaCBicnVzaDsKKyAgICBpZiAo bV9zZWwuc3RhcnQoKS5ub2RlKCkgJiYgbV9zZWwuc3RhcnQoKS5ub2RlKCktPnJlbmRlcmVyKCkg JiYgbV9zZWwuc3RhcnQoKS5ub2RlKCktPnJlbmRlcmVyKCktPnN0eWxlKCkpCisgICAgICAgIGJy dXNoLnNldENvbG9yKG1fc2VsLnN0YXJ0KCkubm9kZSgpLT5yZW5kZXJlcigpLT5zdHlsZSgpLT5j b2xvcigpKTsKICAgICBpZiAoIWNhcmV0LmlzRW1wdHkoKSkKLSAgICAgICAgcC0+ZmlsbFJlY3Qo Y2FyZXQsIEJydXNoKCkpOworICAgICAgICBwLT5maWxsUmVjdChjYXJldCwgYnJ1c2gpOwogfQog CiB2b2lkIFNlbGVjdGlvbkNvbnRyb2xsZXI6OmRlYnVnUmVuZGVyZXIoUmVuZGVyT2JqZWN0ICpy LCBib29sIHNlbGVjdGVkKSBjb25zdAo= 11646 2006-11-27 13:23:43 -0800 2006-11-27 13:38:55 -0800 new patch patch_caret.txt text/plain 1656 adele SW5kZXg6IGVkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZWRp dGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcAkocmV2aXNpb24gMTc4ODMpCisrKyBlZGl0aW5n L1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NjYsOCArODY2LDE0 IEBACiAgICAgICAgIGxheW91dCgpOwogICAgICAgICAKICAgICBJbnRSZWN0IGNhcmV0ID0gaW50 ZXJzZWN0aW9uKGNhcmV0UmVjdCgpLCByZWN0KTsKLSAgICBpZiAoIWNhcmV0LmlzRW1wdHkoKSkK LSAgICAgICAgcC0+ZmlsbFJlY3QoY2FyZXQsIENvbG9yOjpibGFjayk7CisgICAgaWYgKCFjYXJl dC5pc0VtcHR5KCkpIHsKKyAgICAgICAgQ29sb3IgY2FyZXRDb2xvciA9IENvbG9yOjpibGFjazsK KyAgICAgICAgRWxlbWVudCogZWxlbWVudCA9IHJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKKyAgICAg ICAgaWYgKGVsZW1lbnQgJiYgZWxlbWVudC0+cmVuZGVyZXIoKSkKKyAgICAgICAgICAgIGNhcmV0 Q29sb3IgPSBlbGVtZW50LT5yZW5kZXJlcigpLT5zdHlsZSgpLT5jb2xvcigpOworCisgICAgICAg IHAtPmZpbGxSZWN0KGNhcmV0LCBjYXJldENvbG9yKTsKKyAgICB9CiB9CiAKIHZvaWQgU2VsZWN0 aW9uQ29udHJvbGxlcjo6ZGVidWdSZW5kZXJlcihSZW5kZXJPYmplY3QgKnIsIGJvb2wgc2VsZWN0 ZWQpIGNvbnN0CkluZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZp c2lvbiAxNzg4NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDA2LTExLTI3ICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIEZpeCBmb3IgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA2MgorICAgICAgICAgIENhcmV0IGNv bG9yIGluIG5ldyB0ZXh0IGZpZWxkIHNob3VsZCB0YWtlIGJhY2tncm91bmQgY29sb3IgYW5kIGZv cmVncm91bmQgY29sb3IgaW50byBjb25zaWRlcmF0aW9uCisKKyAgICAgICAgKiBlZGl0aW5nL1Nl bGVjdGlvbkNvbnRyb2xsZXIuY3BwOiAoV2ViQ29yZTo6U2VsZWN0aW9uQ29udHJvbGxlcjo6cGFp bnRDYXJldCk6CisgICAgICAgICAgVXNlIHRoZSBmb3JlZ3JvdW5kIGNvbG9yIG9mIHRoZSByb290 RWRpdGFibGVFbGVtZW50IHRvIGRldGVybWluZSB0aGUgY2FyZXQgY29sb3IuICBUaGlzIHdpbGwg d29yayB3ZWxsIGZvciB0ZXh0IGNvbnRyb2xzIGluIHdlYiBwYWdlcyAoc2luY2UgdGhlIHJvb3Qg aXMgYWx3YXlzIHRoZSBhY3R1YWwgZm9ybSBjb250cm9sKQorICAgICAgICAgIGFzIHdlbGwgYXMg aW4gZWRpdGFibGUgV2ViVmlld3MsIGxpa2UgaW4gTWFpbCwgd2hpY2ggd2lsbCBqdXN0IHBpY2sg dXAgdGhlIGNvbG9yIGZyb20gdGhlIGJvZHkgZWxlbWVudC4KKwogMjAwNi0xMS0yNiAgU2ltb24g SGF1c21hbm4gIDxoYXVzbWFubkBrZGUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2ll ai4K