80606 2012-03-08 10:16:25 -0800 [chromium] WebPluginContainer::isRectTopmost() gives incorrect result when scrolling. 2012-04-16 10:43:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 viettrungluu raymes abarth fishd raymes viettrungluu webkit.review.bot oldest_to_newest 573906 0 viettrungluu 2012-03-08 10:16:25 -0800 [chromium] Make WebPluginContainer::isRectTopmost() only test for being above visible content. 573916 1 130843 viettrungluu 2012-03-08 10:23:12 -0800 Created attachment 130843 Patch 573921 2 webkit.review.bot 2012-03-08 10:26:10 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 573925 3 130843 fishd 2012-03-08 10:28:20 -0800 Comment on attachment 130843 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130843&action=review > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:463 > + if (it->get() == m_element) what if the plugin is on a layer that is visible but positioned above an invisible layer? 574081 4 viettrungluu 2012-03-08 12:31:06 -0800 (In reply to comment #3) > (From update of attachment 130843 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130843&action=review > > > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:463 > > + if (it->get() == m_element) > > what if the plugin is on a layer that is visible but positioned above an invisible layer? I'm not seeing the problem here. In that case, presumably only the plugin will be in the hit test results, no? (Now, what happens if the plugin is on an invisible layer, etc.? Hmmmm.) 574094 5 fishd 2012-03-08 12:40:10 -0800 (In reply to comment #4) ... > I'm not seeing the problem here. In that case, presumably only the plugin will be in the hit test results, no? > > (Now, what happens if the plugin is on an invisible layer, etc.? Hmmmm.) Yeah, what you mentioned in parens is sort of what I was wondering about. I don't fully know all of the interesting cases. I don't understand what the hit test node set contains or doesn't contain. 590352 6 viettrungluu 2012-03-28 13:31:22 -0700 (In reply to comment #5) > (In reply to comment #4) > ... > > I'm not seeing the problem here. In that case, presumably only the plugin will be in the hit test results, no? > > > > (Now, what happens if the plugin is on an invisible layer, etc.? Hmmmm.) > > Yeah, what you mentioned in parens is sort of what I was wondering about. I don't fully know all of the interesting cases. I don't understand what the hit test node set contains or doesn't contain. The more I think about it, the odder I find that invisible layers show up in the (rect-based) hittest at all. (I'm guessing they don't show up in the non-rect-based hittests? I should check that.) That could be a bug. More investigation needed, at any rate. 600659 7 raymes 2012-04-11 15:55:20 -0700 The problem is that hitTestResultAtPoint() expects the point to be in document coordinates, not window coordinates. 600665 8 136772 raymes 2012-04-11 16:02:25 -0700 Created attachment 136772 Patch 603274 9 136772 webkit.review.bot 2012-04-16 10:43:37 -0700 Comment on attachment 136772 Patch Clearing flags on attachment: 136772 Committed r114275: <http://trac.webkit.org/changeset/114275> 603275 10 webkit.review.bot 2012-04-16 10:43:42 -0700 All reviewed patches have been landed. Closing bug. 130843 2012-03-08 10:23:12 -0800 2012-04-11 16:02:22 -0700 Patch bug-80606-20120308102311.patch text/plain 2863 viettrungluu SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTAxNzQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTAzLTA4ICBWaWV0LVRydW5nIEx1dSAgPHZpZXR0cnVuZ2x1dUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtlIFdlYlBsdWdpbkNvbnRhaW5lcjo6aXNSZWN0 VG9wbW9zdCgpIG9ubHkgdGVzdCBmb3IgYmVpbmcgYWJvdmUgdmlzaWJsZSBjb250ZW50LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA2MDYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYW55IHdlYiBwYWdl cyBoYXZlIGEgaGlkZGVuIGRpdiBvdmVyIGV2ZXJ5dGhpbmcsIHdoaWNoIG1ha2UgdGhlIGNoZWNr CisgICAgICAgIGZhaWwgdW5sZXNzIHdlIG9ubHkgcmVxdWlyZSB0aGF0IHRoZSByZWN0YW5nbGUg YmUgYWJvdmUgdmlzaWJsZSBjb250ZW50LgorCisgICAgICAgICogcHVibGljL1dlYlBsdWdpbkNv bnRhaW5lci5oOgorICAgICAgICAoV2ViUGx1Z2luQ29udGFpbmVyKTogVXBkYXRlIG1ldGhvZCBj b21tZW50LgorICAgICAgICAqIHNyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViUGx1Z2luQ29udGFpbmVySW1wbDo6aXNSZWN0VG9wbW9zdCk6IEl0ZXJh dGUgdGhyb3VnaCBoaXQgdGVzdCByZXN1bHQsIGFsc28gY2hlY2tpbmcgInZpc2liaWxpdHkiLgor CiAyMDEyLTAzLTA4ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZl aXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgTWFrZSBlbGVtZW50cyB3aXRoIGF0dHJpYnV0 ZXMgc21hbGxlciBieSBlbGltaW5hdGluZyB0aGUgbV9lbGVtZW50IGJhY2sgcG9pbnRlciBpbiBO YW1lZE5vZGVNYXAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlBsdWdp bkNvbnRhaW5lci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlBsdWdpbkNvbnRhaW5lci5oCShyZXZpc2lvbiAxMTAxMjMpCisrKyBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJQbHVnaW5Db250YWluZXIuaAkod29ya2luZyBjb3B5KQpAQCAt MTA0LDcgKzEwNCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0T3BhcXVlKGJvb2wp ID0gMDsKIAogICAgIC8vIERldGVybWluZXMgd2hldGhlciB0aGUgZ2l2ZW4gcmVjdGFuZ2xlIGlu IHRoaXMgcGx1Z2luIGlzIGFib3ZlIGFsbCBvdGhlcgotICAgIC8vIGNvbnRlbnQuIFRoZSByZWN0 YW5nbGUgaXMgaW4gdGhlIHBsdWdpbidzIGNvb3JkaW5hdGUgc3lzdGVtLgorICAgIC8vIHZpc2li bGUgY29udGVudC4gVGhlIHJlY3RhbmdsZSBpcyBpbiB0aGUgcGx1Z2luJ3MgY29vcmRpbmF0ZSBz eXN0ZW0uCiAgICAgdmlydHVhbCBib29sIGlzUmVjdFRvcG1vc3QoY29uc3QgV2ViUmVjdCYpID0g MDsKIAogICAgIHZpcnR1YWwgV2ViUGx1Z2luKiBwbHVnaW4oKSA9IDA7CkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNw cAkocmV2aXNpb24gMTEwMTIzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1 Z2luQ29udGFpbmVySW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1OCw5ICs0NTgsMTQgQEAg Ym9vbCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjppc1JlY3RUb3BtbwogICAgIEhpdFRlc3RSZXN1 bHQgcmVzdWx0ID0KICAgICAgICAgcGFnZS0+bWFpbkZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5o aXRUZXN0UmVzdWx0QXRQb2ludChjZW50ZXIsIGZhbHNlLCBmYWxzZSwgRG9udEhpdFRlc3RTY3Jv bGxiYXJzLCBIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVzdDo6QWN0aXZl LCBwYWRkaW5nKTsKICAgICBjb25zdCBIaXRUZXN0UmVzdWx0OjpOb2RlU2V0JiBub2RlcyA9IHJl c3VsdC5yZWN0QmFzZWRUZXN0UmVzdWx0KCk7Ci0gICAgaWYgKG5vZGVzLnNpemUoKSAhPSAxKQot ICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgcmV0dXJuIChub2Rlcy5maXJzdCgpLmdldCgpID09 IG1fZWxlbWVudCk7CisgICAgYm9vbCBmb3VuZFBsdWdpbiA9IGZhbHNlOworICAgIGZvciAoSGl0 VGVzdFJlc3VsdDo6Tm9kZVNldDo6Y29uc3RfaXRlcmF0b3IgaXQgPSBub2Rlcy5iZWdpbigpOyBp dCAhPSBub2Rlcy5lbmQoKTsgKytpdCkgeworICAgICAgICBpZiAoaXQtPmdldCgpID09IG1fZWxl bWVudCkKKyAgICAgICAgICAgIGZvdW5kUGx1Z2luID0gdHJ1ZTsKKyAgICAgICAgZWxzZSBpZiAo aXQtPmdldCgpLT5oYXNOb25FbXB0eUJvdW5kaW5nQm94KCkpCisgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgfQorICAgIHJldHVybiBmb3VuZFBsdWdpbjsKIH0KIAogdm9pZCBXZWJQbHVn aW5Db250YWluZXJJbXBsOjpkaWRSZWNlaXZlUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXNwb25z ZSYgcmVzcG9uc2UpCg== 136772 2012-04-11 16:02:25 -0700 2012-04-16 10:43:37 -0700 Patch bug-80606-20120411160301.patch text/plain 2137 raymes U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDljYTYzZGFkOTJjMWI0NzliMWY4NjdlMzk1ZGE4YTBjMTQ4ZmY5YjkuLjdmMzMzZmFlMDk0YmQy OWEzY2FlN2JkZmFkM2VjYjczYmFkZDI3YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDQtMTEgIFJheW1lcyBLaG91cnkgIDxyYXltZXNAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEZpeCBidWcgaW4gV2ViUGx1Z2luQ29udGFpbmVyOjppc1JlY3RU b3Btb3N0KCkgd2hpY2ggZ2F2ZSB0aGUgaW5jb3JyZWN0IHJlc3VsdCBmb3IgYSBzY3JvbGxlZCB3 aW5kb3cuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 MDYwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog c3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQbHVn aW5Db250YWluZXJJbXBsOjppc1JlY3RUb3Btb3N0KToKKwogMjAxMi0wNC0wNiAgQW1pIEZpc2No bWFuICA8ZmlzY2htYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJvbGwgQ2hyb21pdW0gREVQ UwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1Z2luQ29udGFp bmVySW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWlu ZXJJbXBsLmNwcAppbmRleCBmOWU2NzhkMTdkNTJjMDA5YTMyZWMwN2M5NzgyZjQ0NWJmYTUwYjI2 Li5mNjlhZTVjOTM1ZmI5NTdmMGFhN2UwMjQ4YWIzNjAwMzY0MzVmNzBlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcApA QCAtNDUzLDEwICs0NTMsMTAgQEAgYm9vbCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjppc1JlY3RU b3Btb3N0KGNvbnN0IFdlYlJlY3QmIHJlY3QpCiAKICAgICAvLyBoaXRUZXN0UmVzdWx0QXRQb2lu dCgpIHRha2VzIGEgcGFkZGluZyByZWN0YW5nbGUuCiAgICAgLy8gRklYTUU6IFdlJ2xsIGJlIG9m ZiBieSAxIHdoZW4gdGhlIHdpZHRoIG9yIGhlaWdodCBpcyBldmVuLgotICAgIEludFJlY3Qgd2lu ZG93UmVjdCA9IGNvbnZlcnRUb0NvbnRhaW5pbmdXaW5kb3coc3RhdGljX2Nhc3Q8SW50UmVjdD4o cmVjdCkpOwotICAgIExheW91dFBvaW50IGNlbnRlciA9IHdpbmRvd1JlY3QuY2VudGVyKCk7Cisg ICAgSW50UmVjdCBkb2N1bWVudFJlY3QoeCgpICsgcmVjdC54LCB5KCkgKyByZWN0LnksIHJlY3Qu d2lkdGgsIHJlY3QuaGVpZ2h0KTsKKyAgICBMYXlvdXRQb2ludCBjZW50ZXIgPSBkb2N1bWVudFJl Y3QuY2VudGVyKCk7CiAgICAgLy8gTWFrZSB0aGUgcmVjdCB3ZSdyZSBjaGVja2luZyAodGhlIHBv aW50IHN1cnJvdW5kZWQgYnkgcGFkZGluZyByZWN0cykgY29udGFpbmVkIGluc2lkZSB0aGUgcmVx dWVzdGVkIHJlY3QuIChOb3RlIHRoYXQgLTEvMiBpcyAwLikKLSAgICBMYXlvdXRTaXplIHBhZGRp bmcoKHdpbmRvd1JlY3Qud2lkdGgoKSAtIDEpIC8gMiwgKHdpbmRvd1JlY3QuaGVpZ2h0KCkgLSAx KSAvIDIpOworICAgIExheW91dFNpemUgcGFkZGluZygoZG9jdW1lbnRSZWN0LndpZHRoKCkgLSAx KSAvIDIsIChkb2N1bWVudFJlY3QuaGVpZ2h0KCkgLSAxKSAvIDIpOwogICAgIEhpdFRlc3RSZXN1 bHQgcmVzdWx0ID0KICAgICAgICAgcGFnZS0+bWFpbkZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5o aXRUZXN0UmVzdWx0QXRQb2ludChjZW50ZXIsIGZhbHNlLCBmYWxzZSwgRG9udEhpdFRlc3RTY3Jv bGxiYXJzLCBIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVzdDo6QWN0aXZl LCBwYWRkaW5nKTsKICAgICBjb25zdCBIaXRUZXN0UmVzdWx0OjpOb2RlU2V0JiBub2RlcyA9IHJl c3VsdC5yZWN0QmFzZWRUZXN0UmVzdWx0KCk7Cg==