80582 2012-03-08 02:32:43 -0800 Make check-webkit-style complain about "No new tests (OOPS)" lines in changelogs 2012-03-09 03:14:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca abarth levin ojan webkit.review.bot oldest_to_newest 573732 0 nduca 2012-03-08 02:32:43 -0800 Make check-webkit-style complain about "No new tests (OOPS)" lines in changelogs 573733 1 130798 nduca 2012-03-08 02:33:09 -0800 Created attachment 130798 Patch 573880 2 130798 levin 2012-03-08 09:37:34 -0800 Comment on attachment 130798 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130798&action=review > Tools/Scripts/webkitpy/style/checkers/changelog.py:78 > + "Need whitespace between colon and description") I don't think this is what you want the error to say. 573939 3 130849 nduca 2012-03-08 10:47:49 -0800 Created attachment 130849 Patch for landing 573957 4 levin 2012-03-08 11:00:55 -0800 You can re-add cq+ but I wanted to say this which I should have said before. Many times when I've seen people have this they are new and need guidance. The typical guidance is "You should remove the 'No new tests' and either add tests and list them here or explain why no new tests were possible which may be due to the fact that n'N change in behavior happened so no new tests'." Apologies for not saying this before. You may leave it as is or add something more directed like I did above. 574000 5 nduca 2012-03-08 11:24:24 -0800 Great idea! I'll adjust the text accordingly. (In reply to comment #4) > You can re-add cq+ but I wanted to say this which I should have said before. > > Many times when I've seen people have this they are new and need guidance. > > The typical guidance is "You should remove the 'No new tests' and either add tests and list them here or explain why no new tests were possible which may be due to the fact that n'N change in behavior happened so no new tests'." > > Apologies for not saying this before. You may leave it as is or add something more directed like I did above. 574006 6 130866 nduca 2012-03-08 11:30:23 -0800 Created attachment 130866 Patch 574007 7 130866 nduca 2012-03-08 11:31:06 -0800 Comment on attachment 130866 Patch Hows this? 574469 8 130866 webkit.review.bot 2012-03-08 18:34:51 -0800 Comment on attachment 130866 Patch Rejecting attachment 130866 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 124103 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 124103. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11898241 574740 9 131014 nduca 2012-03-09 01:58:01 -0800 Created attachment 131014 Patch for landing 574784 10 131014 webkit.review.bot 2012-03-09 03:13:59 -0800 Comment on attachment 131014 Patch for landing Clearing flags on attachment: 131014 Committed r110282: <http://trac.webkit.org/changeset/110282> 574785 11 webkit.review.bot 2012-03-09 03:14:04 -0800 All reviewed patches have been landed. Closing bug. 130798 2012-03-08 02:33:09 -0800 2012-03-08 10:47:45 -0800 Patch bug-80582-20120308023307.patch text/plain 3041 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzA0YWEzYzMyMDgwZGVhYmFmN2I1ODk3NGIxNzAwMjc0 OTdjNWQyNi4uNGY1YTE4N2I0N2ViMDgwMDU0OTliN2Q0NmZjNWVmZTNmMDIxM2E4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAzLTA4ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAg ICBNYWtlIGNoZWNrLXdlYmtpdC1zdHlsZSBjb21wbGFpbiBhYm91dCAiTm8gbmV3IHRlc3RzIChP T1BTKSIgbGluZXMgaW4gY2hhbmdlbG9ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA1ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdl bG9nLnB5OgorICAgICAgICAoQ2hhbmdlTG9nQ2hlY2tlci5jaGVja19lbnRyeSk6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRlc3QucHk6 CisgICAgICAgIChDaGFuZ2VMb2dDaGVja2VyVGVzdC50ZXN0X25vX25ld190ZXN0cyk6CisKIDIw MTItMDMtMDcgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBnYXJk ZW4tby1tYXRpYyByZWJhc2VsaW5lIGlzIGJyb2tlbiBmb3IgcG9ydHMgdGhhdCBkb24ndCBoYXZl IGEgZmFsbGJhY2sgcG9ydApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NoYW5nZWxvZy5weQppbmRleCBkNzQ0YmM4N2RiZjQ1MGEyMjE5MmQyMzRlNTM2ODU2 ZTY4YWRkMWY2Li42NDQ2Nzg3NjllZTg0OTU5MzU4NzkyMTYwMWVjMTNjYzdjOWJkNDQwIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5w eQpAQCAtNjgsNiArNjgsMTQgQEAgY2xhc3MgQ2hhbmdlTG9nQ2hlY2tlcihvYmplY3QpOgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImNoYW5nZWxvZy9maWxlY2hhbmdlZGVz Y3JpcHRpb253aGl0ZXNwYWNlIiwgNSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICJOZWVkIHdoaXRlc3BhY2UgYmV0d2VlbiBjb2xvbiBhbmQgZGVzY3JpcHRpb24iKQogCisg ICAgICAgICMgY2hlY2sgZm9yIGEgbGluZ2VyaW5nICJObyBuZXcgdGVzdHMuIChPT1BTISkiIGxl ZnQgb3ZlciBmcm9tIHByZXBhcmUtY2hhbmdlTG9nLgorICAgICAgICBsaW5lX25vID0gZmlyc3Rf bGluZV9jaGVja2VkIC0gMQorICAgICAgICBmb3IgbGluZSBpbiBlbnRyeV9saW5lczoKKyAgICAg ICAgICAgIGxpbmVfbm8gPSBsaW5lX25vICsgMQorICAgICAgICAgICAgaWYgcmUubWF0Y2goJ1xz Kk5vIG5ldyB0ZXN0cy4gXChPT1BTIVwpJCcsIGxpbmUpOgorICAgICAgICAgICAgICAgIHNlbGYu aGFuZGxlX3N0eWxlX2Vycm9yKGxpbmVfbm8sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgImNoYW5nZWxvZy9ub25ld3Rlc3RzIiwgNSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiTmVlZCB3aGl0ZXNwYWNlIGJldHdlZW4gY29sb24gYW5k IGRlc2NyaXB0aW9uIikKIAogICAgIGRlZiBjaGVjayhzZWxmLCBsaW5lcyk6CiAgICAgICAgIHNl bGYuX3RhYl9jaGVja2VyLmNoZWNrKGxpbmVzKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRlc3QucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weQppbmRleCA4 NDJlYWExNmIwMjI5Y2QyMzRiODljZDIzMmZhZWMxZTFmYWJjNTdlLi45ZmU4YTYwYmMxMWY0NzBj NmE1Y2RhNGUzY2E0ZjlhZGQ2ZjlkZWE3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weQpAQCAtMTIx LDYgKzEyMSwxNCBAQCBjbGFzcyBDaGFuZ2VMb2dDaGVja2VyVGVzdCh1bml0dGVzdC5UZXN0Q2Fz ZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgICogIFNvdXJjZS9Ub29scy9y YW5kb20tc2NyaXB0LnB5OkZpeGVkXG4nCiAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAg ICAgICogIFNvdXJjZS9Ub29scy9vbmUtbW9yZWZpbGU6XG4nKQogCisgICAgZGVmIHRlc3Rfbm9f bmV3X3Rlc3RzKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9lcnJvcig1LCByYW5nZSgxLCAy MCksICdjaGFuZ2Vsb2cvbm9uZXd0ZXN0cycsCisgICAgICAgICAgICAgICAgICAgICAgICAgICcy MDExLTAxLTAxIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xlLmNvbT5cbicKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgJyAgICAgICAgRXhhbXBsZUJ1Z1xuJworICAgICAgICAgICAgICAg ICAgICAgICAgICAnICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjM0NVxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnXG4nCisgICAgICAgICAgICAg ICAgICAgICAgICAgICcgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKVxuJworICAgICAgICAg ICAgICAgICAgICAgICAgICAnICAgICAgICAqICBTb3VyY2UvVG9vbHMvcmFuZG9tLXNjcmlwdC5w eTogRml4ZWQnKQogCiAgICAgZGVmIHRlc3Rfbm9fZXJyb3Ioc2VsZik6CiAgICAgICAgIHNlbGYu YXNzZXJ0X25vX2Vycm9yKFtdLAo= 130849 2012-03-08 10:47:49 -0800 2012-03-08 11:30:19 -0800 Patch for landing bug-80582-20120308104748.patch text/plain 3016 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTJlYWRiMzU5Y2QyOGI3ZDhkNTQzZDJkOTkyYjQxODE3 MDkyMzc0NC4uMjAzNzE2Mzk0MGYzMGU2MjZiMTkzNzAxZDMzM2E3YTU3ZTc3ZTQ5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAzLTA4ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAg ICBNYWtlIGNoZWNrLXdlYmtpdC1zdHlsZSBjb21wbGFpbiBhYm91dCAiTm8gbmV3IHRlc3RzIChP T1BTKSIgbGluZXMgaW4gY2hhbmdlbG9ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA1ODIKKworICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZp bi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9n LnB5OgorICAgICAgICAoQ2hhbmdlTG9nQ2hlY2tlci5jaGVja19lbnRyeSk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRlc3QucHk6Cisg ICAgICAgIChDaGFuZ2VMb2dDaGVja2VyVGVzdC50ZXN0X25vX25ld190ZXN0cyk6CisKIDIwMTIt MDMtMDggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTAxMTUuCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9nLnB5CmluZGV4IGQ3NDRiYzg3ZGJm NDUwYTIyMTkyZDIzNGU1MzY4NTZlNjhhZGQxZjYuLmUzZWFlZDRmZDQ5YTQ2YTYyYWUxYmRkZGM0 NmU1MjhlNmMwMmY3ODIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY2hhbmdlbG9nLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY2hhbmdlbG9nLnB5CkBAIC02OCw2ICs2OCwxNCBAQCBjbGFzcyBDaGFuZ2VMb2dD aGVja2VyKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiY2hh bmdlbG9nL2ZpbGVjaGFuZ2VkZXNjcmlwdGlvbndoaXRlc3BhY2UiLCA1LAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIk5lZWQgd2hpdGVzcGFjZSBiZXR3ZWVuIGNvbG9uIGFu ZCBkZXNjcmlwdGlvbiIpCiAKKyAgICAgICAgIyBjaGVjayBmb3IgYSBsaW5nZXJpbmcgIk5vIG5l dyB0ZXN0cy4gKE9PUFMhKSIgbGVmdCBvdmVyIGZyb20gcHJlcGFyZS1jaGFuZ2VMb2cuCisgICAg ICAgIGxpbmVfbm8gPSBmaXJzdF9saW5lX2NoZWNrZWQgLSAxCisgICAgICAgIGZvciBsaW5lIGlu IGVudHJ5X2xpbmVzOgorICAgICAgICAgICAgbGluZV9ubyA9IGxpbmVfbm8gKyAxCisgICAgICAg ICAgICBpZiByZS5tYXRjaCgnXHMqTm8gbmV3IHRlc3RzLiBcKE9PUFMhXCkkJywgbGluZSk6Cisg ICAgICAgICAgICAgICAgc2VsZi5oYW5kbGVfc3R5bGVfZXJyb3IobGluZV9ubywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiY2hhbmdlbG9nL25vbmV3dGVzdHMiLCA1 LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJUaGUgJ05vIG5ldyB0 ZXN0cy4gKE9PUFMhKScgbm90ZSBzaG91bGQgbm90IGJlIGNvbW1pdHRlZC4iKQogCiAgICAgZGVm IGNoZWNrKHNlbGYsIGxpbmVzKToKICAgICAgICAgc2VsZi5fdGFiX2NoZWNrZXIuY2hlY2sobGlu ZXMpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2No YW5nZWxvZ191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5CmluZGV4IDg0MmVhYTE2YjAyMjljZDIzNGI4OWNkMjMy ZmFlYzFlMWZhYmM1N2UuLjlmZThhNjBiYzExZjQ3MGM2YTVjZGE0ZTNjYTRmOWFkZDZmOWRlYTcg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdl bG9nX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY2hhbmdlbG9nX3VuaXR0ZXN0LnB5CkBAIC0xMjEsNiArMTIxLDE0IEBAIGNsYXNzIENoYW5n ZUxvZ0NoZWNrZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgICAgICAgICAgICAg ICAgICAgJyAgICAgICAgKiAgU291cmNlL1Rvb2xzL3JhbmRvbS1zY3JpcHQucHk6Rml4ZWRcbicK ICAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgKiAgU291cmNlL1Rvb2xzL29uZS1t b3JlZmlsZTpcbicpCiAKKyAgICBkZWYgdGVzdF9ub19uZXdfdGVzdHMoc2VsZik6CisgICAgICAg IHNlbGYuYXNzZXJ0X2Vycm9yKDUsIHJhbmdlKDEsIDIwKSwgJ2NoYW5nZWxvZy9ub25ld3Rlc3Rz JywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJzIwMTEtMDEtMDEgRG1pdHJ5IExvbW92ICA8 ZHNsb21vdkBnb29nbGUuY29tPlxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAg ICBFeGFtcGxlQnVnXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgIGh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzQ1XG4nCisgICAgICAgICAgICAg ICAgICAgICAgICAgICdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgTm8g bmV3IHRlc3RzLiAoT09QUyEpXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAg ICogIFNvdXJjZS9Ub29scy9yYW5kb20tc2NyaXB0LnB5OiBGaXhlZCcpCiAKICAgICBkZWYgdGVz dF9ub19lcnJvcihzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbm9fZXJyb3IoW10sCg== 130866 2012-03-08 11:30:23 -0800 2012-03-09 01:57:56 -0800 Patch bug-80582-20120308113022.patch text/plain 3069 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTJlYWRiMzU5Y2QyOGI3ZDhkNTQzZDJkOTkyYjQxODE3 MDkyMzc0NC4uMjAzNzE2Mzk0MGYzMGU2MjZiMTkzNzAxZDMzM2E3YTU3ZTc3ZTQ5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAzLTA4ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAg ICBNYWtlIGNoZWNrLXdlYmtpdC1zdHlsZSBjb21wbGFpbiBhYm91dCAiTm8gbmV3IHRlc3RzIChP T1BTKSIgbGluZXMgaW4gY2hhbmdlbG9ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA1ODIKKworICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZp bi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9n LnB5OgorICAgICAgICAoQ2hhbmdlTG9nQ2hlY2tlci5jaGVja19lbnRyeSk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5pdHRlc3QucHk6Cisg ICAgICAgIChDaGFuZ2VMb2dDaGVja2VyVGVzdC50ZXN0X25vX25ld190ZXN0cyk6CisKIDIwMTIt MDMtMDggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTAxMTUuCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9nLnB5CmluZGV4IGQ3NDRiYzg3ZGJm NDUwYTIyMTkyZDIzNGU1MzY4NTZlNjhhZGQxZjYuLmEwOTZkM2Y0NjhhYjY4ZjYxNGNiZTc0Y2U2 NDNkN2VkMWQ3ZDRmMmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY2hhbmdlbG9nLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY2hhbmdlbG9nLnB5CkBAIC02OCw2ICs2OCwxNCBAQCBjbGFzcyBDaGFuZ2VMb2dD aGVja2VyKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiY2hh bmdlbG9nL2ZpbGVjaGFuZ2VkZXNjcmlwdGlvbndoaXRlc3BhY2UiLCA1LAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIk5lZWQgd2hpdGVzcGFjZSBiZXR3ZWVuIGNvbG9uIGFu ZCBkZXNjcmlwdGlvbiIpCiAKKyAgICAgICAgIyBjaGVjayBmb3IgYSBsaW5nZXJpbmcgIk5vIG5l dyB0ZXN0cy4gKE9PUFMhKSIgbGVmdCBvdmVyIGZyb20gcHJlcGFyZS1jaGFuZ2VMb2cuCisgICAg ICAgIGxpbmVfbm8gPSBmaXJzdF9saW5lX2NoZWNrZWQgLSAxCisgICAgICAgIGZvciBsaW5lIGlu IGVudHJ5X2xpbmVzOgorICAgICAgICAgICAgbGluZV9ubyA9IGxpbmVfbm8gKyAxCisgICAgICAg ICAgICBpZiByZS5tYXRjaCgnXHMqTm8gbmV3IHRlc3RzLiBcKE9PUFMhXCkkJywgbGluZSk6Cisg ICAgICAgICAgICAgICAgc2VsZi5oYW5kbGVfc3R5bGVfZXJyb3IobGluZV9ubywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiY2hhbmdlbG9nL25vbmV3dGVzdHMiLCA1 LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJZb3Ugc2hvdWxkIHJl bW92ZSB0aGUgJ05vIG5ldyB0ZXN0cycgYW5kIGVpdGhlciBhZGQgYW5kIGxpc3QgdGVzdHMsIG9y IGV4cGxhaW4gd2h5IG5vIG5ldyB0ZXN0cyB3ZXJlIHBvc3NpYmxlLiIpCiAKICAgICBkZWYgY2hl Y2soc2VsZiwgbGluZXMpOgogICAgICAgICBzZWxmLl90YWJfY2hlY2tlci5jaGVjayhsaW5lcykK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdl bG9nX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j aGFuZ2Vsb2dfdW5pdHRlc3QucHkKaW5kZXggODQyZWFhMTZiMDIyOWNkMjM0Yjg5Y2QyMzJmYWVj MWUxZmFiYzU3ZS4uOWZlOGE2MGJjMTFmNDcwYzZhNWNkYTRlM2NhNGY5YWRkNmY5ZGVhNyAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2df dW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j aGFuZ2Vsb2dfdW5pdHRlc3QucHkKQEAgLTEyMSw2ICsxMjEsMTQgQEAgY2xhc3MgQ2hhbmdlTG9n Q2hlY2tlclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAg ICAnICAgICAgICAqICBTb3VyY2UvVG9vbHMvcmFuZG9tLXNjcmlwdC5weTpGaXhlZFxuJwogICAg ICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICAqICBTb3VyY2UvVG9vbHMvb25lLW1vcmVm aWxlOlxuJykKIAorICAgIGRlZiB0ZXN0X25vX25ld190ZXN0cyhzZWxmKToKKyAgICAgICAgc2Vs Zi5hc3NlcnRfZXJyb3IoNSwgcmFuZ2UoMSwgMjApLCAnY2hhbmdlbG9nL25vbmV3dGVzdHMnLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAnMjAxMS0wMS0wMSBEbWl0cnkgTG9tb3YgIDxkc2xv bW92QGdvb2dsZS5jb20+XG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgIEV4 YW1wbGVCdWdcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgaHR0cDovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzNDVcbicKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgJ1xuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICBObyBuZXcg dGVzdHMuIChPT1BTISlcbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgKiAg U291cmNlL1Rvb2xzL3JhbmRvbS1zY3JpcHQucHk6IEZpeGVkJykKIAogICAgIGRlZiB0ZXN0X25v X2Vycm9yKHNlbGYpOgogICAgICAgICBzZWxmLmFzc2VydF9ub19lcnJvcihbXSwK 131014 2012-03-09 01:58:01 -0800 2012-03-09 03:13:59 -0800 Patch for landing bug-80582-20120309015800.patch text/plain 3062 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMjc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWIyNzdlOTk4N2VjNmJkZmVhOTc4NmJmZjNlMTA4MTNl M2RlYWNlOC4uNjgzNDAzOTg2NzhhMjFkZWYzZWE0NjUzMjk5ZTVlYTkxYWFhN2JmOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTAzLTA4ICBOYXQgRHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAg ICBNYWtlIGNoZWNrLXdlYmtpdC1zdHlsZSBjb21wbGFpbiBhYm91dCAibm8gbmV3IHRlc3RzIiBs aW5lcyBpbiBjaGFuZ2Vsb2dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MDU4MgorCisgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHk6Cisg ICAgICAgIChDaGFuZ2VMb2dDaGVja2VyLmNoZWNrX2VudHJ5KToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVzdC5weToKKyAgICAgICAg KENoYW5nZUxvZ0NoZWNrZXJUZXN0LnRlc3Rfbm9fbmV3X3Rlc3RzKToKKwogMjAxMi0wMy0wOSAg U2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExMDI1MC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY2hhbmdlbG9nLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2cucHkKaW5kZXggZDc0NGJjODdkYmY0NTBhMjIx OTJkMjM0ZTUzNjg1NmU2OGFkZDFmNi4uYTA5NmQzZjQ2OGFiNjhmNjE0Y2JlNzRjZTY0M2Q3ZWQx ZDdkNGYyZiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jaGFuZ2Vsb2cucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jaGFuZ2Vsb2cucHkKQEAgLTY4LDYgKzY4LDE0IEBAIGNsYXNzIENoYW5nZUxvZ0NoZWNrZXIo b2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjaGFuZ2Vsb2cv ZmlsZWNoYW5nZWRlc2NyaXB0aW9ud2hpdGVzcGFjZSIsIDUsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiTmVlZCB3aGl0ZXNwYWNlIGJldHdlZW4gY29sb24gYW5kIGRlc2Ny aXB0aW9uIikKIAorICAgICAgICAjIGNoZWNrIGZvciBhIGxpbmdlcmluZyAiTm8gbmV3IHRlc3Rz LiAoT09QUyEpIiBsZWZ0IG92ZXIgZnJvbSBwcmVwYXJlLWNoYW5nZUxvZy4KKyAgICAgICAgbGlu ZV9ubyA9IGZpcnN0X2xpbmVfY2hlY2tlZCAtIDEKKyAgICAgICAgZm9yIGxpbmUgaW4gZW50cnlf bGluZXM6CisgICAgICAgICAgICBsaW5lX25vID0gbGluZV9ubyArIDEKKyAgICAgICAgICAgIGlm IHJlLm1hdGNoKCdccypObyBuZXcgdGVzdHMuIFwoT09QUyFcKSQnLCBsaW5lKToKKyAgICAgICAg ICAgICAgICBzZWxmLmhhbmRsZV9zdHlsZV9lcnJvcihsaW5lX25vLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJjaGFuZ2Vsb2cvbm9uZXd0ZXN0cyIsIDUsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIllvdSBzaG91bGQgcmVtb3ZlIHRo ZSAnTm8gbmV3IHRlc3RzJyBhbmQgZWl0aGVyIGFkZCBhbmQgbGlzdCB0ZXN0cywgb3IgZXhwbGFp biB3aHkgbm8gbmV3IHRlc3RzIHdlcmUgcG9zc2libGUuIikKIAogICAgIGRlZiBjaGVjayhzZWxm LCBsaW5lcyk6CiAgICAgICAgIHNlbGYuX3RhYl9jaGVja2VyLmNoZWNrKGxpbmVzKQpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jaGFuZ2Vsb2dfdW5p dHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxv Z191bml0dGVzdC5weQppbmRleCA4NDJlYWExNmIwMjI5Y2QyMzRiODljZDIzMmZhZWMxZTFmYWJj NTdlLi45ZmU4YTYwYmMxMWY0NzBjNmE1Y2RhNGUzY2E0ZjlhZGQ2ZjlkZWE3IDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxvZ191bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NoYW5nZWxv Z191bml0dGVzdC5weQpAQCAtMTIxLDYgKzEyMSwxNCBAQCBjbGFzcyBDaGFuZ2VMb2dDaGVja2Vy VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAg ICAgICogIFNvdXJjZS9Ub29scy9yYW5kb20tc2NyaXB0LnB5OkZpeGVkXG4nCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICcgICAgICAgICogIFNvdXJjZS9Ub29scy9vbmUtbW9yZWZpbGU6XG4n KQogCisgICAgZGVmIHRlc3Rfbm9fbmV3X3Rlc3RzKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2Vy dF9lcnJvcig1LCByYW5nZSgxLCAyMCksICdjaGFuZ2Vsb2cvbm9uZXd0ZXN0cycsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICcyMDExLTAxLTAxIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29v Z2xlLmNvbT5cbicKKyAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgICAgICAgRXhhbXBsZUJ1 Z1xuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICBodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjM0NVxuJworICAgICAgICAgICAgICAgICAgICAgICAg ICAnXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICcgICAgICAgIE5vIG5ldyB0ZXN0cy4g KE9PUFMhKVxuJworICAgICAgICAgICAgICAgICAgICAgICAgICAnICAgICAgICAqICBTb3VyY2Uv VG9vbHMvcmFuZG9tLXNjcmlwdC5weTogRml4ZWQnKQogCiAgICAgZGVmIHRlc3Rfbm9fZXJyb3Io c2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X25vX2Vycm9yKFtdLAo=