80568 2012-03-07 21:21:19 -0800 DFG CFA incorrectly handles ValueToInt32 2018-03-08 12:33:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 573565 0 fpizlo 2012-03-07 21:21:19 -0800 The code completely fails to match up with what DFG::SpeculativeJIT is doing. Not to mention that it makes no sense at all. 573580 1 130764 fpizlo 2012-03-07 21:36:59 -0800 Created attachment 130764 the patch 573721 2 130764 fpizlo 2012-03-08 01:55:42 -0800 Comment on attachment 130764 the patch Reviewed in person by Gavin. 573726 3 fpizlo 2012-03-08 02:02:40 -0800 Landed in http://trac.webkit.org/changeset/110159 130764 2012-03-07 21:36:59 -0800 2012-03-08 01:56:04 -0800 the patch fixcfa_patch_1.diff text/plain 1621 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEwMTQ1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTAzLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIENGQSBpbmNvcnJlY3RseSBoYW5kbGVzIFZhbHVlVG9JbnQzMgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA1NjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIENoYW5nZWQgaXQgbWF0Y2gg ZXhhY3RseSB0aGUgZGVjaXNpb24gcGF0dGVybiB1c2VkIGluCisgICAgICAgIERGRzo6U3BlY3Vs YXRpdmVKSVQ6OmNvbXBpbGVWYWx1ZVRvSW50MzIKKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFj dFN0YXRlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdFN0YXRlOjpleGVjdXRlKToK KwogMjAxMi0wMy0wNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExMDEyNy4KSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcAkocmV2aXNpb24g MTEwMTQ0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjkxLDEzICsyOTEsMTEgQEAgYm9vbCBBYnN0cmFjdFN0YXRl OjpleGVjdXRlKHVuc2lnbmVkIGluZAogICAgICAgICBicmVhazsKICAgICAgICAgICAgIAogICAg IGNhc2UgVmFsdWVUb0ludDMyOgotICAgICAgICBpZiAoIW1fZ3JhcGhbbm9kZS5jaGlsZDEoKV0u c2hvdWxkTm90U3BlY3VsYXRlSW50ZWdlcigpKSB7CisgICAgICAgIGlmIChtX2dyYXBoW25vZGUu Y2hpbGQxKCldLnNob3VsZE5vdFNwZWN1bGF0ZUludGVnZXIoKSkgewogICAgICAgICAgICAgaWYg KG1fZ3JhcGhbbm9kZS5jaGlsZDEoKV0uc2hvdWxkU3BlY3VsYXRlRG91YmxlKCkpCiAgICAgICAg ICAgICAgICAgZm9yTm9kZShub2RlLmNoaWxkMSgpKS5maWx0ZXIoUHJlZGljdE51bWJlcik7Ci0g ICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgZm9yTm9kZShub2RlLmNoaWxkMSgpKS5m aWx0ZXIoUHJlZGljdEludDMyKTsKLSAgICAgICAgfQotICAgICAgICBmb3JOb2RlKG5vZGVJbmRl eCkuc2V0KFByZWRpY3RJbnQzMik7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgZm9yTm9k ZShub2RlSW5kZXgpLnNldChQcmVkaWN0SW50MzIpOwogICAgICAgICBicmVhazsKICAgICAgICAg ICAgIAogICAgIGNhc2UgVmFsdWVBZGQ6Cg==