80567 2012-03-07 21:20:59 -0800 LayoutTestHelper could get torn down earlier (mostly to reset color profile) 2012-03-23 14:10:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton dpranke abarth ap dpranke mitz ojan simon.fraser webkit.review.bot oldest_to_newest 573563 0 thorton 2012-03-07 21:20:59 -0800 LayoutTestHelper currently gets torn down when run-webkit-tests finally quits. However, if you have run-webkit-tests launch a browser to the results and wait on that instance, it could be a while before it's torn down. Since LayoutTestHelper is designed mostly to deal with setting up things required for generating consistent results, etc. (i.e. changing the display color space), it seems like it only needs to be alive while the tests are running. It would be nice if it were killed as soon as the last test was finished, before the browser with results is launched, so that the user's display can go back to its normal color space as soon as possible. 583736 1 thorton 2012-03-20 20:23:43 -0700 *** Bug 81731 has been marked as a duplicate of this bug. *** 584539 2 dpranke 2012-03-21 13:07:40 -0700 makes sense. 584540 3 dpranke 2012-03-21 13:08:20 -0700 On a mildly related note, I'm not actually sure why we wait for the browser to exit on the mac port. The chromium port doesn't; is this desired behavior? 584551 4 thorton 2012-03-21 13:18:10 -0700 (In reply to comment #3) > On a mildly related note, I'm not actually sure why we wait for the browser to exit on the mac port. The chromium port doesn't; is this desired behavior? Not at all; I assumed it happened on Chromium too! 584606 5 133109 dpranke 2012-03-21 13:58:26 -0700 Created attachment 133109 Patch 584795 6 dpranke 2012-03-21 17:20:13 -0700 Filed bug 81845 and uploaded a patch to not block on safari at the end ... 586719 7 dpranke 2012-03-23 14:10:06 -0700 Committed r111902: <http://trac.webkit.org/changeset/111902> 133109 2012-03-21 13:58:26 -0700 2012-03-23 11:38:11 -0700 Patch bug-80567-20120321135825.patch text/plain 5528 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTExNTk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWI1ZTJkNjkyMjJhMDI5ZjI0NmM2NGZmNDdkZjJjZGMw ODk2YjlkYi4uYzFhZDBkMzg3NjU1ZDIzMWFlNmUzNmYwNWM0MTVhY2IyNDcyYWEzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTAzLTIxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIExheW91dFRlc3RIZWxwZXIgY291bGQgZ2V0IHRvcm4gZG93biBlYXJsaWVyIChtb3N0 bHkgdG8gcmVzZXQgY29sb3IgcHJvZmlsZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTgwNTY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTW92ZSBjbGVhbl91cF9ydW4gdG8gb2NjdXIgcmlnaHQgYWZ0ZXIg d2UgZmluaXNoIHRlc3RpbmcgYW5kCisgICAgICAgIGJlZm9yZSB3ZSBzdGFydCBwcm9jZXNzaW5n IHRoZSByZXN1bHRzLiBBbHNvIG1ha2VzIHNldF91cF9ydW4oKQorICAgICAgICBhbmQgY2xlYW5f dXBfcnVuKCkgcHJpdmF0ZSBzaW5jZSB0aGVyZSdzIG5vIHJlYWwgbmVlZCBmb3IKKyAgICAgICAg Y2FsbGVycyB0byBiZSBhd2FyZSBvZiB0aGVtLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weToKKyAgICAgICAgKE1hbmFnZXIu X3NldF91cF9ydW4pOgorICAgICAgICAoTWFuYWdlci5ydW4pOgorICAgICAgICAoTWFuYWdlci5f Y2xlYW5fdXBfcnVuKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9j b250cm9sbGVycy9tYW5hZ2VyX3VuaXR0ZXN0LnB5OgorICAgICAgICAoTWFuYWdlclRlc3QudGVz dF9odHRwX2xvY2tpbmcpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHk6CisgICAgICAgIChydW4pOgorCiAyMDEyLTAzLTIxICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BsaW51eC5pbnRlbC5jb20+CiAKICAg ICAgICAgW0VGTF0gVXNlIGpoYnVpbGQgZG93bmxvYWRlZCBmb250cyBpbnN0ZWFkIG9mIGhhcmRj b2RlZCBzeXN0ZW0gZm9udCBwYXRocwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKaW5kZXggZWNmMDcyZmU4 YWJlMjAyYTdjZTFiNTk3ZjUxN2UwZDA4YzViYzdjZi4uNzcxMmNkNTZkYmM0Mzg0ZGMwZmQ2YjI4 YmFjMjZhZjEzZDAxNGIwNiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CkBAIC04NDIsNyArODQyLDcg QEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgogICAgIGRlZiBuZWVkc19zZXJ2ZXJzKHNlbGYpOgog ICAgICAgICByZXR1cm4gYW55KHNlbGYuX3Rlc3RfcmVxdWlyZXNfbG9jayh0ZXN0X25hbWUpIGZv ciB0ZXN0X25hbWUgaW4gc2VsZi5fdGVzdF9maWxlcykgYW5kIHNlbGYuX29wdGlvbnMuaHR0cAog Ci0gICAgZGVmIHNldF91cF9ydW4oc2VsZik6CisgICAgZGVmIF9zZXRfdXBfcnVuKHNlbGYpOgog ICAgICAgICAiIiJDb25maWd1cmVzIHRoZSBzeXN0ZW0gdG8gYmUgcmVhZHkgdG8gcnVuIHRlc3Rz LgogCiAgICAgICAgIFJldHVybnMgYSBSZXN1bHRTdW1tYXJ5IG9iamVjdCBpZiB3ZSBzaG91bGQg Y29udGludWUgdG8gcnVuIHRlc3RzLApAQCAtODc2LDcgKzg3Niw3IEBAIGNsYXNzIE1hbmFnZXIo b2JqZWN0KToKIAogICAgICAgICByZXR1cm4gcmVzdWx0X3N1bW1hcnkKIAotICAgIGRlZiBydW4o c2VsZiwgcmVzdWx0X3N1bW1hcnkpOgorICAgIGRlZiBydW4oc2VsZik6CiAgICAgICAgICIiIlJ1 biBhbGwgb3VyIHRlc3RzIG9uIGFsbCBvdXIgdGVzdCBmaWxlcy4KIAogICAgICAgICBGb3IgZWFj aCB0ZXN0IGZpbGUsIHdlIHJ1biBlYWNoIHRlc3QgdHlwZS4gSWYgdGhlcmUgYXJlIGFueSBmYWls dXJlcywKQEAgLTg5MSw2ICs4OTEsMTEgQEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgogICAgICAg ICAjIGNvbGxlY3RfdGVzdHMoKSBtdXN0IGhhdmUgYmVlbiBjYWxsZWQgZmlyc3QgdG8gaW5pdGlh bGl6ZSB1cy4KICAgICAgICAgIyBJZiB3ZSBkaWRuJ3QgZmluZCBhbnkgZmlsZXMgdG8gdGVzdCwg d2UndmUgZXJyb3JlZCBvdXQgYWxyZWFkeSBpbgogICAgICAgICAjIHByZXBhcmVfbGlzdHNfYW5k X3ByaW50X291dHB1dCgpLgorCisgICAgICAgIHJlc3VsdF9zdW1tYXJ5ID0gc2VsZi5fc2V0X3Vw X3J1bigpCisgICAgICAgIGlmIG5vdCByZXN1bHRfc3VtbWFyeToKKyAgICAgICAgICAgIHJldHVy biAtMQorCiAgICAgICAgIGFzc2VydChsZW4oc2VsZi5fdGVzdF9maWxlcykpCiAKICAgICAgICAg c3RhcnRfdGltZSA9IHRpbWUudGltZSgpCkBAIC05MTMsMTIgKzkxOCwxMSBAQCBjbGFzcyBNYW5h Z2VyKG9iamVjdCk6CiAKICAgICAgICAgZW5kX3RpbWUgPSB0aW1lLnRpbWUoKQogCisgICAgICAg IHNlbGYuX2NsZWFuX3VwX3J1bigpCisKICAgICAgICAgc2VsZi5fcHJpbnRfdGltaW5nX3N0YXRp c3RpY3MoZW5kX3RpbWUgLSBzdGFydF90aW1lLCB0aHJlYWRfdGltaW5ncywgdGVzdF90aW1pbmdz LCBpbmRpdmlkdWFsX3Rlc3RfdGltaW5ncywgcmVzdWx0X3N1bW1hcnkpCiAgICAgICAgIHNlbGYu X3ByaW50X3Jlc3VsdF9zdW1tYXJ5KHJlc3VsdF9zdW1tYXJ5KQogCi0gICAgICAgIHN5cy5zdGRv dXQuZmx1c2goKQotICAgICAgICBzeXMuc3RkZXJyLmZsdXNoKCkKLQogICAgICAgICBzZWxmLl9w cmludGVyLnByaW50X29uZV9saW5lX3N1bW1hcnkocmVzdWx0X3N1bW1hcnkudG90YWwsIHJlc3Vs dF9zdW1tYXJ5LmV4cGVjdGVkLCByZXN1bHRfc3VtbWFyeS51bmV4cGVjdGVkKQogCiAgICAgICAg IHVuZXhwZWN0ZWRfcmVzdWx0cyA9IHN1bW1hcml6ZV9yZXN1bHRzKHNlbGYuX3BvcnQsIHNlbGYu X2V4cGVjdGF0aW9ucywgcmVzdWx0X3N1bW1hcnksIHJldHJ5X3N1bW1hcnksIGluZGl2aWR1YWxf dGVzdF90aW1pbmdzLCBvbmx5X3VuZXhwZWN0ZWQ9VHJ1ZSwgaW50ZXJydXB0ZWQ9aW50ZXJydXB0 ZWQpCkBAIC05NjQsOSArOTY4LDggQEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgogICAgICAgICAg ICAgc2VsZi5fcG9ydC5yZWxlYXNlX2h0dHBfbG9jaygpCiAgICAgICAgICAgICBzZWxmLl9oYXNf aHR0cF9sb2NrID0gRmFsc2UKIAotICAgIGRlZiBjbGVhbl91cF9ydW4oc2VsZik6CisgICAgZGVm IF9jbGVhbl91cF9ydW4oc2VsZik6CiAgICAgICAgICIiIlJlc3RvcmVzIHRoZSBzeXN0ZW0gYWZ0 ZXIgd2UncmUgZG9uZSBydW5uaW5nIHRlc3RzLiIiIgotCiAgICAgICAgIF9sb2cuZGVidWcoImZs dXNoaW5nIHN0ZG91dCIpCiAgICAgICAgIHN5cy5zdGRvdXQuZmx1c2goKQogICAgICAgICBfbG9n LmRlYnVnKCJmbHVzaGluZyBzdGRlcnIiKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJfdW5pdHRl c3QucHkKaW5kZXggYTVmYzg5ODkwODg2NWE2NDFkMjRkZmI0MjU2Yjk1MWZmNzZkYTVlYy4uOGJj NmFmZmZlMTM4NmVhNTE1M2VkMzk2OTE3YmU2MjE0ODk5YzYwZiAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl91bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9tYW5hZ2VyX3VuaXR0ZXN0LnB5CkBAIC0yMTgsOSArMjE4LDcgQEAgY2xhc3MgTWFuYWdlclRl c3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBtYW5hZ2VyID0gTG9ja0NoZWNraW5nTWFu YWdlcihwb3J0LCBvcHRpb25zLCBwcmludGVyKQogICAgICAgICBtYW5hZ2VyLmNvbGxlY3RfdGVz dHMoYXJncykKICAgICAgICAgbWFuYWdlci5wYXJzZV9leHBlY3RhdGlvbnMoKQotICAgICAgICBy ZXN1bHRfc3VtbWFyeSA9IG1hbmFnZXIuc2V0X3VwX3J1bigpCi0gICAgICAgIG51bV91bmV4cGVj dGVkX3Jlc3VsdHMgPSBtYW5hZ2VyLnJ1bihyZXN1bHRfc3VtbWFyeSkKLSAgICAgICAgbWFuYWdl ci5jbGVhbl91cF9ydW4oKQorICAgICAgICBudW1fdW5leHBlY3RlZF9yZXN1bHRzID0gbWFuYWdl ci5ydW4oKQogICAgICAgICBwcmludGVyLmNsZWFudXAoKQogICAgICAgICB0ZXN0ZXIuYXNzZXJ0 RXF1YWxzKG51bV91bmV4cGVjdGVkX3Jlc3VsdHMsIDApCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDA2 NmI4YTg5Y2RlMTY0Yzg5ZTlkMzcwZjQ1YzgyN2ExMWU3ZTI1MGYuLjQ5MWMyYjIzNmIyOTliZGJl YjNjODcxMmU1ZjY2MmVjMjFmY2YwODcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMTIxLDExICsxMjEs OCBAQCBkZWYgcnVuKHBvcnQsIG9wdGlvbnMsIGFyZ3MsIHJlZ3VsYXJfb3V0cHV0PXN5cy5zdGRl cnIsIGJ1aWxkYm90X291dHB1dD1zeXMuc3RkbwogICAgICAgICBwcmludGVyLnByaW50X3VwZGF0 ZSgiUGFyc2luZyBleHBlY3RhdGlvbnMgLi4uIikKICAgICAgICAgbWFuYWdlci5wYXJzZV9leHBl Y3RhdGlvbnMoKQogCi0gICAgICAgIHJlc3VsdF9zdW1tYXJ5ID0gbWFuYWdlci5zZXRfdXBfcnVu KCkKLSAgICAgICAgaWYgcmVzdWx0X3N1bW1hcnk6Ci0gICAgICAgICAgICB1bmV4cGVjdGVkX3Jl c3VsdF9jb3VudCA9IG1hbmFnZXIucnVuKHJlc3VsdF9zdW1tYXJ5KQotICAgICAgICAgICAgbWFu YWdlci5jbGVhbl91cF9ydW4oKQotICAgICAgICAgICAgX2xvZy5kZWJ1ZygiVGVzdGluZyBjb21w bGV0ZWQsIEV4aXQgc3RhdHVzOiAlZCIgJSB1bmV4cGVjdGVkX3Jlc3VsdF9jb3VudCkKKyAgICAg ICAgdW5leHBlY3RlZF9yZXN1bHRfY291bnQgPSBtYW5hZ2VyLnJ1bigpCisgICAgICAgIF9sb2cu ZGVidWcoIlRlc3RpbmcgY29tcGxldGVkLCBFeGl0IHN0YXR1czogJWQiICUgdW5leHBlY3RlZF9y ZXN1bHRfY291bnQpCiAgICAgZmluYWxseToKICAgICAgICAgcHJpbnRlci5jbGVhbnVwKCkKIAo=