80565 2012-03-07 21:09:12 -0800 [Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled. 2012-03-07 22:55:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fischman fischman abarth cc-bugs fischman fishd jamesr webkit.review.bot oldest_to_newest 573554 0 fischman 2012-03-07 21:09:12 -0800 Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled. 573555 1 130758 fischman 2012-03-07 21:11:05 -0800 Created attachment 130758 Patch 573560 2 130758 jamesr 2012-03-07 21:13:33 -0800 Comment on attachment 130758 Patch I should you should also update the various comments around this function (and the functions that call into this) to clearly document the expectations of this return value - i.e. you can't make any GL calls or make the context current unless you know you're on the thread the compositor is running on. 573569 3 130762 fischman 2012-03-07 21:24:36 -0800 Created attachment 130762 Patch 573572 4 webkit.review.bot 2012-03-07 21:25:54 -0800 Please wait for approval from fishd@chromium.org, abarth@webkit.org or jamesr@chromium.org before submitting because this patch contains changes to the Chromium platform API. 573573 5 130762 jamesr 2012-03-07 21:25:57 -0800 Comment on attachment 130762 Patch Cool, I think that's sufficiently scary. 573641 6 130762 webkit.review.bot 2012-03-07 22:55:52 -0800 Comment on attachment 130762 Patch Clearing flags on attachment: 130762 Committed r110149: <http://trac.webkit.org/changeset/110149> 573642 7 webkit.review.bot 2012-03-07 22:55:57 -0800 All reviewed patches have been landed. Closing bug. 130758 2012-03-07 21:11:05 -0800 2012-03-07 21:24:33 -0800 Patch bug-80565-20120307211104.patch text/plain 1569 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA4MWQ0ZmNkYjYzZWJh YTA3MDgxMTcwZjRlZTBjNGFmOWUzYTNiOC4uM2I2MWFlMjMzMzZjMjQ2M2Q0NDFhMGMyZWVhNTlm MDhmNjljYjI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTA3ICBBbWkg RmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBB bGxvdyBDQ0xheWVyVHJlZUhvc3Q6OmNvbnRleHQoKSB0byBiZSBjYWxsZWQgZXZlbiB3aXRoIHRo ZSB0aHJlYWRlZCBjb21wb3NpdG9yIGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDU2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZ2V0cyB0cmlnZ2VyZWQgYnkgdGhlIHZpZGVvIEhX IGRlY29kZStyZW5kZXIgcGF0aCB3aGVuIHRocmVhZGVkIGNvbXBvc2l0b3IgaXMgZW5hYmxlZAor ICAgICAgICAoaHR0cHM6Ly9jaHJvbWl1bWNvZGVyZXZpZXcuYXBwc3BvdC5jb20vOTYzOTAwNS8p CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5 ZXJUcmVlSG9zdDo6Y29udGV4dCk6CisKIDIwMTItMDMtMDUgIFN0ZXBoZW4gQ2hlbm5leSAgPHNj aGVubmV5QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFNWRyBDb21wb3NpdGUg b2YgT2Zmc2V0IGNyYXNoZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCmluZGV4IDdj Y2I1ZmQ3MThjMjM3NzAwMzg4ZWFjMTk5OWRmZWY5YmM2OGNiMDQuLmIyMGVmMzY1MTQyY2E2Mjcz ODI5MWU0YzI5ZTMxMTQ0ZWQ3ZmJkMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNw cApAQCAtMjQzLDcgKzI0Myw2IEBAIHZvaWQgQ0NMYXllclRyZWVIb3N0OjpkaWRMb3NlQ29udGV4 dCgpCiAvLyBUZW1wb3JhcnkgaGFjayB1bnRpbCBXZWJWaWV3SW1wbCBjb250ZXh0IGNyZWF0aW9u IGdldHMgc2ltcGxpZmllZAogR3JhcGhpY3NDb250ZXh0M0QqIENDTGF5ZXJUcmVlSG9zdDo6Y29u dGV4dCgpCiB7Ci0gICAgQVNTRVJUKCFDQ1Byb3h5OjpoYXNJbXBsVGhyZWFkKCkpOwogICAgIHJl dHVybiBtX3Byb3h5LT5jb250ZXh0KCk7CiB9CiAK 130762 2012-03-07 21:24:36 -0800 2012-03-07 22:55:52 -0800 Patch bug-80565-20120307212435.patch text/plain 3516 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA4MWQ0ZmNkYjYzZWJh YTA3MDgxMTcwZjRlZTBjNGFmOWUzYTNiOC4uM2I2MWFlMjMzMzZjMjQ2M2Q0NDFhMGMyZWVhNTlm MDhmNjljYjI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTA3ICBBbWkg RmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBB bGxvdyBDQ0xheWVyVHJlZUhvc3Q6OmNvbnRleHQoKSB0byBiZSBjYWxsZWQgZXZlbiB3aXRoIHRo ZSB0aHJlYWRlZCBjb21wb3NpdG9yIGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDU2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZ2V0cyB0cmlnZ2VyZWQgYnkgdGhlIHZpZGVvIEhX IGRlY29kZStyZW5kZXIgcGF0aCB3aGVuIHRocmVhZGVkIGNvbXBvc2l0b3IgaXMgZW5hYmxlZAor ICAgICAgICAoaHR0cHM6Ly9jaHJvbWl1bWNvZGVyZXZpZXcuYXBwc3BvdC5jb20vOTYzOTAwNS8p CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNDTGF5 ZXJUcmVlSG9zdDo6Y29udGV4dCk6CisKIDIwMTItMDMtMDUgIFN0ZXBoZW4gQ2hlbm5leSAgPHNj aGVubmV5QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFNWRyBDb21wb3NpdGUg b2YgT2Zmc2V0IGNyYXNoZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9w dWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1Ymxp Yy9XZWJMYXllclRyZWVWaWV3LmgKaW5kZXggNjgzN2IxOWVjYmRkMjE3NmRiNmQzZDM3ZWI5OTYy MDI4NGIwMDc2Mi4uM2VmMjk1ZDk0NTU5ODMxOTczY2NhYjVlYzI1MGMyNzAxODhkNDA0ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3 LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3 LmgKQEAgLTE1NSwxNCArMTU1LDEzIEBAIHB1YmxpYzoKICAgICAvLyBUaGlzIGNhbiBoYXZlIGEg c2lnbmlmaWNhbnQgcGVyZm9ybWFuY2UgaW1wYWN0IGFuZCBzaG91bGQgYmUgdXNlZCB3aXRoIGNh cmUuCiAgICAgV0VCS0lUX0VYUE9SVCB2b2lkIGZpbmlzaEFsbFJlbmRlcmluZygpOwogCi0KLSAg ICAvLyBEZWJ1Z2dpbmcgLyBkYW5nZXJvdXMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCi0KICAgICAvLyBSZXR1cm5zIHRoZSBjb250ZXh0IGJlaW5nIHVzZWQg Zm9yIHJlbmRlcmluZyB0aGlzIHZpZXcuIEluIHRocmVhZGVkIGNvbXBvc2l0aW5nIG1vZGUsIGl0 IGlzCi0gICAgLy8gbm90IHNhZmUgdG8gdXNlIHRoaXMgY29udGV4dCBhdCBhbGwgb24gdGhlIG1h aW4gdGhyZWFkLgotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBBUEkgYXMgc29vbiBhcyBwb3Nz aWJsZSwgaXQncyB2ZXJ5IGJ1Zy1wcm9uZSBpbiB0aHJlYWRlZCBtb2RlLgorICAgIC8vIG5vdCBz YWZlIHRvIHVzZSB0aGlzIGNvbnRleHQgZm9yIGFueXRoaW5nIG9uIHRoZSBtYWluIHRocmVhZCwg b3RoZXIgdGhhbiBwYXNzaW5nIHRoZSBwb2ludGVyIHRvCisgICAgLy8gdGhlIGNvbXBvc2l0b3Ig dGhyZWFkLgogICAgIFdFQktJVF9FWFBPUlQgV2ViR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQo KTsKIAorICAgIC8vIERlYnVnZ2luZyAvIGRhbmdlcm91cyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKwogICAgIC8vIFNpbXVsYXRlcyBhIGxvc3QgY29udGV4 dC4gRm9yIHRlc3Rpbmcgb25seS4KICAgICBXRUJLSVRfRVhQT1JUIHZvaWQgbG9zZUNvbXBvc2l0 b3JDb250ZXh0KGludCBudW1UaW1lcyk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3Bw CmluZGV4IDdjY2I1ZmQ3MThjMjM3NzAwMzg4ZWFjMTk5OWRmZWY5YmM2OGNiMDQuLmIyMGVmMzY1 MTQyY2E2MjczODI5MWU0YzI5ZTMxMTQ0ZWQ3ZmJkMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRy ZWVIb3N0LmNwcApAQCAtMjQzLDcgKzI0Myw2IEBAIHZvaWQgQ0NMYXllclRyZWVIb3N0OjpkaWRM b3NlQ29udGV4dCgpCiAvLyBUZW1wb3JhcnkgaGFjayB1bnRpbCBXZWJWaWV3SW1wbCBjb250ZXh0 IGNyZWF0aW9uIGdldHMgc2ltcGxpZmllZAogR3JhcGhpY3NDb250ZXh0M0QqIENDTGF5ZXJUcmVl SG9zdDo6Y29udGV4dCgpCiB7Ci0gICAgQVNTRVJUKCFDQ1Byb3h5OjpoYXNJbXBsVGhyZWFkKCkp OwogICAgIHJldHVybiBtX3Byb3h5LT5jb250ZXh0KCk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdC5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRy ZWVIb3N0LmgKaW5kZXggMmExYmRkMWY0Y2I4YWNhYWZmNjhkNTY4MDM5ZjEwOTYzMDRlMjUzYS4u MGM3ZWJlYTVhYjEzN2I2ODg1NThkM2E2ZDg1OTU3MTE4ZTE2MThiMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NM YXllclRyZWVIb3N0LmgKQEAgLTE0Nyw2ICsxNDcsOCBAQCBwdWJsaWM6CiAgICAgLy8gT25seSB1 c2VkIHdoZW4gY29tcG9zaXRpbmcgb24gdGhlIG1haW4gdGhyZWFkLgogICAgIHZvaWQgY29tcG9z aXRlKCk7CiAKKyAgICAvLyBOT1RFOiBUaGUgcmV0dXJuZWQgdmFsdWUgY2FuIG9ubHkgYmUgdXNl ZCB0byBtYWtlIEdMIGNhbGxzIG9yIG1ha2UgdGhlCisgICAgLy8gY29udGV4dCBjdXJyZW50IG9u IHRoZSB0aHJlYWQgdGhlIGNvbXBvc2l0b3IgaXMgcnVubmluZyBvbiEKICAgICBHcmFwaGljc0Nv bnRleHQzRCogY29udGV4dCgpOwogCiAgICAgLy8gQ29tcG9zaXRlcyBhbmQgYXR0ZW1wdHMgdG8g cmVhZCBiYWNrIHRoZSByZXN1bHQgaW50byB0aGUgcHJvdmlkZWQK