80551 2012-03-07 16:52:33 -0800 REGRESSION (r107672): Cached empty XMLHttpRequest responses are not delivered 2012-03-09 09:50:29 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Critical --- 1 ap japhet abarth beidson japhet oldest_to_newest 573366 0 ap 2012-03-07 16:52:33 -0800 If a response is cached with ETag, it cannot be fetched from cache with XMLHttpRequest. To reproduce, 1. unpack attached files into LayoutTests/http/tests, 2. run-webkit-httpd, 3. Open http://127.0.0.1:8000/304.html, 4. Follow instructions in test. 573367 1 130726 ap 2012-03-07 16:52:58 -0800 Created attachment 130726 test case 573368 2 ap 2012-03-07 16:53:14 -0800 <rdar://problem/10979550> 573392 3 japhet 2012-03-07 17:18:35 -0800 (In reply to comment #2) > <rdar://problem/10979550> (In reply to comment #0) > If a response is cached with ETag, it cannot be fetched from cache with XMLHttpRequest. > > To reproduce, > 1. unpack attached files into LayoutTests/http/tests, > 2. run-webkit-httpd, > 3. Open http://127.0.0.1:8000/304.html, > 4. Follow instructions in test. I'm wondering if we should perhaps switch to requiring identical headers except a whitelist, rather than presuming reuse is ok with a blacklist, as proposed in https://bugs.webkit.org/show_bug.cgi?id=80334 What do you think? 573397 4 ap 2012-03-07 17:24:54 -0800 This sounds reasonable to me, but I don't see the connection to this bug. Here, no response is delivered at all, not even a stale one. 573881 5 japhet 2012-03-08 09:38:49 -0800 (In reply to comment #4) > This sounds reasonable to me, but I don't see the connection to this bug. Here, no response is delivered at all, not even a stale one. Sorry, I misread the report. That's bad, will look at this today. 574107 6 japhet 2012-03-08 12:56:56 -0800 (In reply to comment #5) > (In reply to comment #4) > > This sounds reasonable to me, but I don't see the connection to this bug. Here, no response is delivered at all, not even a stale one. > > Sorry, I misread the report. That's bad, will look at this today. This appears to be more general than just etags. When the content of a cached xhr is valid but empty, we exit too early in CachedRawResource::didAddClient() and leave the load hanging. 574114 7 ap 2012-03-08 13:05:57 -0800 Re-titling accordingly. 574203 8 130905 japhet 2012-03-08 14:24:53 -0800 Created attachment 130905 patch 574954 9 japhet 2012-03-09 09:37:00 -0800 Landed: http://trac.webkit.org/changeset/110301 130726 2012-03-07 16:52:58 -0800 2012-03-08 14:24:53 -0800 test case 304.zip application/zip 1554 ap UEsDBBQACAAIAAOGZ0AAAAAAAAAAAAAAAAAIABAAMzA0Lmh0bWxVWAwA2QFYT8UBWE/1ARQAlZLP S8MwFMfv/SseObVMWkFvawsqwwnbRXbw4CVr37pomsTkdXPI/ndf16EiE9mp6ffHJ49HclfeaVW9 Aq1VgGVH1kDADXqpgVSLIYUbAywYgq3SGqzRO1giaNs0WPMvNxFWKhBIImwdpXnmyihnVg+zpur5 hSAMFCeiXPA3zwaXY84jqLpgXMk9jyyFyitHQDuHfe2dshe5kYMqyghg1ZmKFMO5FbehSeCDVYDa Vl3Lk6YN0kRjf7zdPdSx4JxIUmUM+uliPoNRAVyDEYhnI8bc3Uc/scOoR+hGevD41rEGBRjcwtN8 NiVyj4MYJ+ND7phJZV1P+nXNeCXIF8bCedt4DEFcfF3R0w/Tf5sJ7NmXOuC/QG1lfRJ2MM4AoffW nyQNzhkoubSeTqIG50+UdWhicT9ZcFlcXV6nbu34SL77nQxo6mHb+yjPhvdQRp9QSwcIXHUpxU8B AADCAgAAUEsDBAoAAAAAAH2GZ0AAAAAAAAAAAAAAAAAJABAAX19NQUNPU1gvVVgMAK0CWE+tAlhP 9QEUAFBLAwQUAAgACAADhmdAAAAAAAAAAAAAAAAAEwAQAF9fTUFDT1NYLy5fMzA0Lmh0bWxVWAwA 2QFYT8UBWE/1ARQAY2AVY2dgYmDwTUxW8A9WiFCAApAYAycQGwFxJRCD+KuBmCHENSJEMSg5gwEn cAwJCYIyQTrmADE/mhJGhLh4cn6uXmJBQU6qXkhqRYlrXnJ+SmZeOlAyNMRN18La0NjEyNDc0sIE AFBLBwhvz4AVZwAAAKsAAABQSwMEFAAIAAgAkIVnQAAAAAAAAAAAAAAAAAcAEAAzMDQucGhwVVgM AMgBWE/wAFhP9QEUAIVQ20rDQBB9z1cMJdBEmzY3q6bWUmJKhTZKDL6ILGszTRZyI10hRfx315hI CoL7cFg4l5k5N4syKSW2B0UmT17w7AUvg3UYPpL7FfEffI9sl6G7Hryq8CGBeAnSCCul0UyMsQ6W boNfcNgWEdszjAbqrBFizbgi/p+SXORIjkgrmINhwhlYhgDTFjDVG5hJckoPnGRthhDGWUQ5KnfL 0CPByjUM0xoBZxkqKmjwGykGyFiXrMLDP6bzE5PU3jF06S5BzS1yXhWpA+X7W8p2I8hordEY50MY n/g6m/cz04FG0G7Q478DMedaeCzRAY41n5QpZfnwD80G85gnDuh90uM0dkRdln0xvby67lMbUZXW 1d1ucFKf0HbtL26lL1BLBwiF+2S7HQEAAOIBAABQSwMEFAAIAAgAkIVnQAAAAAAAAAAAAAAAABIA EABfX01BQ09TWC8uXzMwNC5waHBVWAwAyAFYT/AAWE/1ARQAY2AVY2dgYmDwTUxW8A9WiFCAApAY AycQGwFxJRCD+KuBmCHENSJEMSg5gwEncAwJCYIyQTrmADE/mhJGhLh4cn6uXmJBQU6qXkhqRYlr XnJ+SmZeOlAyNMRN18La0NjEyNDc0sIEAFBLBwhvz4AVZwAAAKsAAABQSwECFQMUAAgACAADhmdA XHUpxU8BAADCAgAACAAMAAAAAAAAAABApIEAAAAAMzA0Lmh0bWxVWAgA2QFYT8UBWE9QSwECFQMK AAAAAAB9hmdAAAAAAAAAAAAAAAAACQAMAAAAAAAAAABA/UGVAQAAX19NQUNPU1gvVVgIAK0CWE+t AlhPUEsBAhUDFAAIAAgAA4ZnQG/PgBVnAAAAqwAAABMADAAAAAAAAAAAQKSBzAEAAF9fTUFDT1NY Ly5fMzA0Lmh0bWxVWAgA2QFYT8UBWE9QSwECFQMUAAgACACQhWdAhftkux0BAADiAQAABwAMAAAA AAAAAABApIGEAgAAMzA0LnBocFVYCADIAVhP8ABYT1BLAQIVAxQACAAIAJCFZ0Bvz4AVZwAAAKsA AAASAAwAAAAAAAAAAECkgeYDAABfX01BQ09TWC8uXzMwNC5waHBVWAgAyAFYT/AAWE9QSwUGAAAA AAUABQBfAQAAnQQAAAAA 130905 2012-03-08 14:24:53 -0800 2012-03-09 09:50:29 -0800 patch emptyresponse.txt text/plain 4433 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDIwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTA4ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2FjaGVkUmF3UmVzb3VyY2Ug YnJlYWtzIHdoZW4gdHJ5aW5nIHRvIGxvYWQKKyAgICAgICAgYSByZXNvdXJjZSB3aXRoIGFuIGVt cHR5IHJlc3BvbnNlIGJvZHkgZnJvbSBjYWNoZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL2NhY2hlL3plcm8tbGVuZ3Ro LXhoci5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmF3UmVzb3VyY2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmF3UmVzb3VyY2U6OmRpZEFkZENsaWVudCk6IERv bid0IGV4aXQgZWFybHkKKyAgICAgICAgICAgIGlmIG1fZGF0YSBpcyBlbXB0eSwgd2UgbWF5IHN0 aWxsIG5lZWQgdG8gbm90aWZ5RmluaXNoZWQoKS4KKwogMjAxMi0wMy0wOCAgVG9yIEFybmUgVmVz dGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBUcnkgdG8g Zml4IHRoZSBTbm93IExlb3BhcmQgYnVpbGQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRSYXdSZXNvdXJjZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmNwcAkocmV2aXNpb24gMTEwMTc1KQorKysg U291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJhd1Jlc291cmNlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNzQsOSArNzQsMTAgQEAKICAgICAgICAgcmV0dXJuOwogICAgIENhY2hlZFJh d1Jlc291cmNlQ2xpZW50KiBjbGllbnQgPSBzdGF0aWNfY2FzdDxDYWNoZWRSYXdSZXNvdXJjZUNs aWVudCo+KGMpOwogICAgIGNsaWVudC0+cmVzcG9uc2VSZWNlaXZlZCh0aGlzLCBtX3Jlc3BvbnNl KTsKLSAgICBpZiAoIWhhc0NsaWVudChjKSB8fCAhbV9kYXRhKQorICAgIGlmICghaGFzQ2xpZW50 KGMpKQogICAgICAgICByZXR1cm47Ci0gICAgY2xpZW50LT5kYXRhUmVjZWl2ZWQodGhpcywgbV9k YXRhLT5kYXRhKCksIG1fZGF0YS0+c2l6ZSgpKTsKKyAgICBpZiAobV9kYXRhKQorICAgICAgICBj bGllbnQtPmRhdGFSZWNlaXZlZCh0aGlzLCBtX2RhdGEtPmRhdGEoKSwgbV9kYXRhLT5zaXplKCkp OwogICAgIGlmICghaGFzQ2xpZW50KGMpKQogICAgICAgIHJldHVybjsKICAgICBDYWNoZWRSZXNv dXJjZTo6ZGlkQWRkQ2xpZW50KGNsaWVudCk7CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2NhY2hlL3plcm8tbGVuZ3RoLXhoci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvY2FjaGUvemVyby1sZW5ndGgteGhyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL3plcm8tbGVuZ3RoLXhoci5odG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDQxIEBACis8Ym9keSBvbmxvYWQ9InRlc3QoKTsiPgorPHA+VGVzdCB0aGF0 IHdlIGRvbid0IGhhbmcgeGhyIGxvYWRzIGZyb20gY2FjaGUgd2hlbiB0aGUgcmVzcG9zbmUgYm9k eSB3YXMgZW1wdHkuPHA+Cis8cHJlIGlkPWxvZz48L3ByZT4KKzxzY3JpcHQgdHlwZT0idGV4dC9q YXZhc2NyaXB0Ij4KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci53YWl0VW50aWxEb25lKCk7Cit9CisKK2Z1bmN0aW9uIGxvZyhtc2cpIHsKKyAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgibG9nIikuaW5uZXJIVE1MICs9IG1zZyArICJcbiI7Cit9CisKK2Z1 bmN0aW9uIHRlc3QoKSB7CisgICAgdmFyIHJlcXVlc3QgPSBuZXcgWE1MSHR0cFJlcXVlc3QoKTsK KyAgICByZXF1ZXN0LmFkZEV2ZW50TGlzdGVuZXIoInByb2dyZXNzIiwgZnVuY3Rpb24oKSB7IGxv ZygicHJvZ3Jlc3MiKSB9LCBmYWxzZSk7CisgICAgcmVxdWVzdC5hZGRFdmVudExpc3RlbmVyKCJs b2FkIiwgZnVuY3Rpb24oKSB7IGxvZygibG9hZCIpOyByZXBlYXQoKTsgfSwgZmFsc2UpOworICAg IHJlcXVlc3QuYWRkRXZlbnRMaXN0ZW5lcigiZXJyb3IiLCBmdW5jdGlvbigpIHsgbG9nKCJlcnJv ciIpOyByZXBlYXQoKTsgfSwgZmFsc2UpOworICAgIHJlcXVlc3QuYWRkRXZlbnRMaXN0ZW5lcigi YWJvcnQiLCBmdW5jdGlvbigpIHsgbG9nKCJhYm9ydCIpOyByZXBlYXQoKTsgfSwgZmFsc2UpOwor ICAgIHJlcXVlc3Qub3BlbigiR0VUIiwgInJlc291cmNlcy9lbXB0eS50eHQiLCB0cnVlKTsKKyAg ICByZXF1ZXN0LnNlbmQoKTsKK30KKworZnVuY3Rpb24gcmVwZWF0KCkgeworICAgIHZhciByZXF1 ZXN0ID0gbmV3IFhNTEh0dHBSZXF1ZXN0KCk7CisgICAgcmVxdWVzdC5hZGRFdmVudExpc3RlbmVy KCJwcm9ncmVzcyIsIGZ1bmN0aW9uKCkgeyBsb2coInByb2dyZXNzIikgfSwgZmFsc2UpOworICAg IHJlcXVlc3QuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIGZ1bmN0aW9uKCkgeyBsb2coImxvYWQi KTsgZW5kKCk7IH0sIGZhbHNlKTsKKyAgICByZXF1ZXN0LmFkZEV2ZW50TGlzdGVuZXIoImVycm9y IiwgZnVuY3Rpb24oKSB7IGxvZygiZXJyb3IiKTsgZW5kKCk7IH0sIGZhbHNlKTsKKyAgICByZXF1 ZXN0LmFkZEV2ZW50TGlzdGVuZXIoImFib3J0IiwgZnVuY3Rpb24oKSB7IGxvZygiYWJvcnQiKTsg ZW5kKCk7IH0sIGZhbHNlKTsKKyAgICByZXF1ZXN0Lm9wZW4oIkdFVCIsICJyZXNvdXJjZXMvZW1w dHkudHh0IiwgdHJ1ZSk7CisgICAgcmVxdWVzdC5zZW5kKCk7Cit9CisKK2Z1bmN0aW9uIGVuZCgp IHsKKyAgICBsb2coIkRPTkUiKTsKKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Cit9Cis8L3Njcmlw dD4KKzwvYm9keT4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvcmVzb3VyY2Vz L2VtcHR5LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hl L3plcm8tbGVuZ3RoLXhoci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9jYWNoZS96ZXJvLWxlbmd0aC14aHItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS96ZXJvLWxlbmd0aC14aHItZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYgQEAKK1Rlc3QgdGhhdCB3ZSBkb24ndCBo YW5nIHhociBsb2FkcyBmcm9tIGNhY2hlIHdoZW4gdGhlIHJlc3Bvc25lIGJvZHkgd2FzIGVtcHR5 LgorCitsb2FkCitsb2FkCitET05FCisKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDIwNSkKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEy LTAzLTA4ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgVGVz dCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwNTUxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3Rz L2NhY2hlL3Jlc291cmNlcy9lbXB0eS50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMv Y2FjaGUvemVyby1sZW5ndGgteGhyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0 cC90ZXN0cy9jYWNoZS96ZXJvLWxlbmd0aC14aHIuaHRtbDogQWRkZWQuCisKIDIwMTItMDMtMDcg IE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBNb3JlIENocm9taXVt IExpb24gcmViYXNlbGluZXMgYXMgd2VsbCBhcyBzb21lIGZpeGVzIGZvcgo=