80536 2012-03-07 13:33:37 -0800 REGRESSION: When Safari is not frontmost, pages should not get mouse moves or hover 2012-04-19 14:47:14 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified OS X 10.7 RESOLVED FIXED InRadar, Regression P2 Normal --- 1 bdakin bdakin adele bdakin jeremya jeremya rniwa simon.fraser oldest_to_newest 573182 0 bdakin 2012-03-07 13:33:37 -0800 On Lion with legacy-style scrollbars enabled in System Preferences, load http://www.webkit.org/ in a window in Safari, then bring another app to the front, but leave the Safari window visible. Now hover over the Safari window; you'll see that the links show hover feedback. This should not happen; pages in the background should not be able to spy on my mouse movement. This regressed with http://trac.webkit.org/changeset/101619/trunk which removed code from EventHandler to perform a read only hit test when onlyUpdateScrollbars is true <rdar://problem/10940970> 573226 1 jeremya 2012-03-07 14:09:14 -0800 Is it possible to add a failing test for this? 573232 2 bdakin 2012-03-07 14:17:17 -0800 (In reply to comment #1) > Is it possible to add a failing test for this? Off the top of my head I am not sure how to test this, but there may very well be a way. 573239 3 rniwa 2012-03-07 14:24:36 -0800 (In reply to comment #2) > (In reply to comment #1) > > Is it possible to add a failing test for this? > > Off the top of my head I am not sure how to test this, but there may very well be a way. Can we add layoutTestController or internals method to emulate this situation? 573289 4 bdakin 2012-03-07 15:15:20 -0800 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Is it possible to add a failing test for this? > > > > Off the top of my head I am not sure how to test this, but there may very well be a way. > > Can we add layoutTestController or internals method to emulate this situation? (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Is it possible to add a failing test for this? > > > > Off the top of my head I am not sure how to test this, but there may very well be a way. > > Can we add layoutTestController or internals method to emulate this situation? Well the situation should be emulated if you can make a test have legacy style scrollbars (which I think they all do by default still anyway), and if you can make the window the test is in not key. From there, you would want to hover the mouse over something that would normally change if the window were key and test whether or not it changed. I do not know which of these things currently is or is not possible in the tests. 597216 5 adele 2012-04-05 23:06:59 -0700 Jeremy, any progress on resolving this regression? 604142 6 jeremya 2012-04-17 10:54:00 -0700 Does this also happen on Snow Leopard? 604148 7 bdakin 2012-04-17 10:58:59 -0700 (In reply to comment #6) > Does this also happen on Snow Leopard? No. It affects Lion and post-Lion only. 605716 8 137929 bdakin 2012-04-19 11:15:32 -0700 Created attachment 137929 Patch Unfortunately this is tricky to test in the test harness, but this is the fix. 605741 9 137929 adele 2012-04-19 11:33:36 -0700 Comment on attachment 137929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137929&action=review > Source/WebCore/ChangeLog:10 > + extra line here? 605743 10 simon.fraser 2012-04-19 11:34:46 -0700 Is this testable? 605759 11 bdakin 2012-04-19 11:52:42 -0700 http://trac.webkit.org/changeset/114661 In answer to Simon's question, so far I have been unsuccessful at creating a test, but it really should be possible. We need a test that has legacy scrollbars with a window that is not key. Then we need hover-able elements, and we need to hover them, and then we need to detect if they changed hover appearance or not. So, lots of moving parts, but it is theoretically possible. 605908 12 bdakin 2012-04-19 14:29:00 -0700 Ooo, I think I made a test! 605937 13 137979 bdakin 2012-04-19 14:43:27 -0700 Created attachment 137979 Test Test! 605943 14 137979 bdakin 2012-04-19 14:47:14 -0700 Comment on attachment 137979 Test nm, this fails in WK2 137929 2012-04-19 11:15:32 -0700 2012-04-19 11:33:36 -0700 Patch for-review.txt text/plain 1898 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDY1MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTE5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA1MzYKKyAgICAgICAgUkVHUkVTU0lPTjogV2hlbiBTYWZhcmkg aXMgbm90IGZyb250bW9zdCwgcGFnZXMgc2hvdWxkIG5vdCBnZXQgbW91c2UgbW92ZXMgb3IgCisg ICAgICAgIGhvdmVyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBwYXRjaCBqdXN0IGFkZHMgc29tZSBjb2RlIGJhY2sgdGhhdCB3YXMgcmVtb3Zl ZCBieSAKKworICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMDI2MzIg VGhpcyBwYXJ0aWN1bGFyIGNvZGUgd2FzIHVucmVsYXRlZCB0byB0aGF0IAorICAgICAgICBidWcg YW5kIHNob3VsZCBub3QgaGF2ZSBiZWVuIHJlbW92ZWQuCisgICAgICAgICogcGFnZS9FdmVudEhh bmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZU1v dmVFdmVudCk6CisKIDIwMTItMDQtMTkgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogbm9kZXMgYXJlIG5vdCByZW1vdmVkIGZy b20gdGhlIHN1bW1hcnkgdmlldyB3aGVuIHN3aXRjaGluZyBiZXR3ZWVuIGFsbG9jYXRpb24gcmFu Z2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lvbiAxMTQ2 MDQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE3NDYsNiArMTc0NiwxMyBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VN b3ZlRXZlbnQoCiAgICAgSGl0VGVzdFJlcXVlc3Q6OkhpdFRlc3RSZXF1ZXN0VHlwZSBoaXRUeXBl ID0gSGl0VGVzdFJlcXVlc3Q6Ok1vdmU7CiAgICAgaWYgKG1fbW91c2VQcmVzc2VkKQogICAgICAg ICBoaXRUeXBlIHw9IEhpdFRlc3RSZXF1ZXN0OjpBY3RpdmU7CisgICAgZWxzZSBpZiAob25seVVw ZGF0ZVNjcm9sbGJhcnMpIHsKKyAgICAgICAgLy8gTW91c2UgZXZlbnRzIHNob3VsZCBiZSB0cmVh dGVkIGFzICJyZWFkLW9ubHkiIGlmIHdlJ3JlIHVwZGF0aW5nIG9ubHkgc2Nyb2xsYmFycy4gVGhp cyAgCisgICAgICAgIC8vIG1lYW5zIHRoYXQgOmhvdmVyIGFuZCA6YWN0aXZlIGZyZWV6ZSBpbiB0 aGUgc3RhdGUgdGhleSB3ZXJlIGluLCByYXRoZXIgdGhhbiB1cGRhdGluZyAgCisgICAgICAgIC8v IGZvciBub2RlcyB0aGUgbW91c2UgbW92ZXMgd2hpbGUgdGhlIHdpbmRvdyBpcyBub3Qga2V5ICh3 aGljaCB3aWxsIGJlIHRoZSBjYXNlIGlmIAorICAgICAgICAvLyBvbmx5VXBkYXRlU2Nyb2xsYmFy cyBpcyB0cnVlKS4gCisgICAgICAgIGhpdFR5cGUgfD0gSGl0VGVzdFJlcXVlc3Q6OlJlYWRPbmx5 OworICAgIH0KIAogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAgICAgLy8gVHJlYXQgYW55IG1v dXNlIG1vdmUgZXZlbnRzIGFzIHJlYWRvbmx5IGlmIHRoZSB1c2VyIGlzIGN1cnJlbnRseSB0b3Vj aGluZyB0aGUgc2NyZWVuLgo= 137979 2012-04-19 14:43:27 -0700 2012-04-19 14:47:14 -0700 Test for-review-2.txt text/plain 3216 bdakin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExNDY3NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA0LTE5ICBCZXRoIERha2luICA8YmRh a2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODA1MzYKKyAgICAgICAgUkVHUkVTU0lPTjogV2hlbiBTYWZhcmkgaXMgbm90IGZy b250bW9zdCwgcGFnZXMgc2hvdWxkIG5vdCBnZXQgbW91c2UgbW92ZXMgb3IgCisgICAgICAgIGhv dmVyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L2Nzcy9ob3Zlci11cGRhdGUtaW4tYmFja2dyb3VuZC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvY3NzL2hvdmVyLXVwZGF0ZS1pbi1iYWNrZ3JvdW5kLmh0bWw6IEFkZGVk LgorCiAyMDEyLTA0LTE5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04gKHIxMTQ2NjYpOiBmYXN0L3J1YnkvZmxvYXRpbmctcnVieS10ZXh0Lmh0 bWwsIGZhc3QvcnVieS9wb3NpdGlvbmVkLXJ1YnktdGV4dC5odG1sIGZhaWxpbmcgb24gTGlvbiBS ZWxlYXNlIChUZXN0cykKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY3NzL2hvdmVyLXVwZGF0ZS1p bi1iYWNrZ3JvdW5kLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0 L2Nzcy9ob3Zlci11cGRhdGUtaW4tYmFja2dyb3VuZC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9ob3Zlci11cGRhdGUtaW4tYmFja2dyb3VuZC1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNyBAQAorSG92ZXIgY29sb3IgYmVmb3Jl IHRlc3Q6IHJnYigwLCAwLCAyNTUpCitQQVNTIHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCd0YXJnZXQnKSwgbnVsbCkuYmFja2dyb3VuZENvbG9yIGlzICJy Z2IoMCwgMCwgMjU1KSIKK0JVRyBJRDogQnVnIDgwNTM2IFJFR1JFU1NJT046IFdoZW4gd2luZG93 IGlzIG5vdCBmcm9udG1vc3QsIHBhZ2VzIHNob3VsZCBub3QgZ2V0IG1vdXNlIG1vdmVzIG9yIGhv dmVyLgorCitUbyBydW4gbWFudWFsbHksIGNsaWNrIG9uIHRoZSBkZXNrdG9wIHNvIHRoYXQgdGhl IGJyb3dzZXIgd2luZG93IGlzIG5vdCBrZXkuIFRoZW4gaG92ZXIgb3ZlciB0aGUgYmx1ZSBib3gs IGFuZCBlbnN1cmUgdGhhdCBpdCBkb2VzIG5vdCB0dXJuIGdyZWVuLgorCitIb3ZlciBoZXJlLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvaG92ZXItdXBkYXRlLWluLWJhY2tncm91bmQuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9ob3Zlci11cGRhdGUtaW4tYmFj a2dyb3VuZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jc3MvaG92ZXIt dXBkYXRlLWluLWJhY2tncm91bmQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0OSBAQAor PGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKyAgICAjdGFyZ2V0IHsKKyAgICAgICAgd2lkdGg6IDIw MHB4OworICAgICAgICBoZWlnaHQ6IDIwMHB4OworICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBi bHVlOworICAgIH0KKyAgICAjdGFyZ2V0OmhvdmVyIHsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xv cjogZ3JlZW47CisgICAgfQorICAgIGJvZHkgeworICAgICAgICBoZWlnaHQ6IDE1MDBweDsKKyAg ICB9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CitmdW5jdGlvbiBy dW50ZXN0KCkKK3sKKyAgICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAg ICAgcmV0dXJuOworCisgICAgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLnNldFdpbmRvd0lz S2V5KGZhbHNlKTsKKworICAgIGRlYnVnKCdIb3ZlciBjb2xvciBiZWZvcmUgdGVzdDogJyArIHdp bmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKSwg bnVsbCkuYmFja2dyb3VuZENvbG9yKTsKKworICAgIHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgndGFyZ2V0Jyk7CisgICAgdmFyIHggPSB0YXJnZXQub2Zmc2V0UGFyZW50Lm9m ZnNldExlZnQgKyB0YXJnZXQub2Zmc2V0TGVmdCArIHRhcmdldC5vZmZzZXRXaWR0aCAvIDI7Cisg ICAgdmFyIHkgPSB0YXJnZXQub2Zmc2V0UGFyZW50Lm9mZnNldFRvcCArIHRhcmdldC5vZmZzZXRU b3AgKyB0YXJnZXQub2Zmc2V0SGVpZ2h0IC8gMjsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVU byh4LCB5KTsKKworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygid2luZG93LmdldENvbXB1dGVk U3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RhcmdldCcpLCBudWxsKS5iYWNrZ3JvdW5k Q29sb3IiLCAicmdiKDAsIDAsIDI1NSkiKTsKK30KKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eSBvbmxvYWQ9InJ1bnRlc3QoKSI+Cis8cD48Yj5CVUcgSUQ6PC9iPiA8YSBocmVmPSJodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA1MzYiPkJ1ZyA4MDUzNjwvYT4gUkVH UkVTU0lPTjogV2hlbiB3aW5kb3cgaXMgbm90IGZyb250bW9zdCwgcGFnZXMgc2hvdWxkIG5vdCBn ZXQgbW91c2UgbW92ZXMgb3IgaG92ZXIuCis8L3A+CisKKzxwPlRvIHJ1biBtYW51YWxseSwgY2xp Y2sgb24gdGhlIGRlc2t0b3Agc28gdGhhdCB0aGUgYnJvd3NlciB3aW5kb3cgaXMgbm90IGtleS4g VGhlbiBob3ZlciBvdmVyIHRoZSBibHVlIGJveCwgYW5kIGVuc3VyZSB0aGF0IGl0IGRvZXMgbm90 IHR1cm4gZ3JlZW4uCis8L3A+CisKKzxkaXYgaWQ9InRhcmdldCI+CitIb3ZlciBoZXJlLgorPC9k aXY+CisKKzwvYm9keT4KKzwvaHRtbD4K