80529 2012-03-07 12:21:47 -0800 Web Inspector: Creating a selector for class names with trailing spaces results with two dots instead of one 2012-04-14 16:39:53 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED HasReduction P2 Normal --- 1 me vivekgalatage apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy vivekgalatage webkit.review.bot yurys oldest_to_newest 573108 0 me 2012-03-07 12:21:47 -0800 Screencast http://www.screenr.com/Ug78 Expected selector: ".dummy" Actual: "..dummy" 573740 1 vivekgalatage 2012-03-08 02:46:26 -0800 The problem is with Source/WebCore/inspector/front-end/DOMAgent.js file's method appropriateSelectorFor. This is the method which chooses the appropriate selector for the currently selected node in the Element view. So now as the existing class has a trailing spaces i.e. " dummy" the function misses to remove this space at the beginning and goes on prefixing the . before the className variable. Also the regular expression removes the white spaces with "." so it appears twice when added. So this has to be trimmed before using. The change is on the line no 348 and change it as below - var selector = "." + className.trim().replace(/\s+/, "."); Will upload the patch for this fix soon. Thank you, Vivek 573891 2 130834 vivekgalatage 2012-03-08 09:53:29 -0800 Created attachment 130834 Patch 573945 3 130834 webkit.review.bot 2012-03-08 10:50:29 -0800 Comment on attachment 130834 Patch Rejecting attachment 130834 from review queue. vivekgalatage@gmail.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 573946 4 130834 webkit.review.bot 2012-03-08 10:51:23 -0800 Comment on attachment 130834 Patch Rejecting attachment 130834 from commit-queue. vivekgalatage@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 573949 5 130851 vivekgalatage 2012-03-08 10:53:35 -0800 Created attachment 130851 Patch 574034 6 130851 aroben 2012-03-08 11:53:37 -0800 Comment on attachment 130851 Patch Is there a way to create an automated test for this? 574036 7 130851 pfeldman 2012-03-08 11:54:45 -0800 Comment on attachment 130851 Patch Nit: this could have a test. 574042 8 pfeldman 2012-03-08 11:57:30 -0800 @aroben: either Alexander or myself will follow up with the test. 574145 9 130851 webkit.review.bot 2012-03-08 13:40:48 -0800 Comment on attachment 130851 Patch Clearing flags on attachment: 130851 Committed r110198: <http://trac.webkit.org/changeset/110198> 574146 10 webkit.review.bot 2012-03-08 13:40:53 -0800 All reviewed patches have been landed. Closing bug. 130834 2012-03-08 09:53:29 -0800 2012-03-08 11:35:19 -0800 Patch bug-80529-20120308232326.patch text/plain 1442 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDE3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA4ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENyZWF0aW5nIGEgc2VsZWN0b3IgZm9yIGNsYXNzIG5hbWVzIHdpdGggdHJhaWxpbmcgc3Bh Y2VzIHJlc3VsdHMgd2l0aCB0d28gZG90cyBpbnN0ZWFkIG9mIG9uZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA1MjkKKworICAgICAgICBUcmltIHRo ZSBjbGFzc05hbWUgYmVmb3JlIHJlcGxhY2luZyB0aGUgd2hpdGVzcGFjZXMgd2l0aCBkb3QgIi4i CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5ET01Ob2RlLnByb3RvdHlwZS5hcHByb3ByaWF0ZVNlbGVjdG9y Rm9yKToKKwogMjAxMi0wMy0wOCAgUm9iaW4gQ2FvICA8cm9iaW4uY2FvQHRvcmNobW9iaWxlLmNv bS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0gV2ViR0wgcmVsYXRlZCBmaWxl cyBmcm9tIHBsYXRmb3JtL2dyYXBoaWNzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RPTUFnZW50LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMJKHJldmlzaW9uIDExMDE3MCkKKysrIFNvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMJKHdvcmtpbmcgY29weSkKQEAg LTM2NSw3ICszNjUsNyBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZS5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgdmFyIGNsYXNzTmFtZSA9IHRoaXMuZ2V0QXR0cmlidXRlKCJjbGFzcyIpOwogICAgICAg ICBpZiAoY2xhc3NOYW1lKSB7Ci0gICAgICAgICAgICB2YXIgc2VsZWN0b3IgPSAiLiIgKyBjbGFz c05hbWUucmVwbGFjZSgvXHMrL2csICIuIik7CisgICAgICAgICAgICB2YXIgc2VsZWN0b3IgPSAi LiIgKyBjbGFzc05hbWUudHJpbSgpLnJlcGxhY2UoL1xzKy9nLCAiLiIpOwogICAgICAgICAgICAg cmV0dXJuIChqdXN0U2VsZWN0b3IgPyBzZWxlY3RvciA6IGxvd2VyQ2FzZU5hbWUgKyBzZWxlY3Rv cik7CiAgICAgICAgIH0KIAo= 130851 2012-03-08 10:53:35 -0800 2012-03-08 13:40:48 -0800 Patch bug-80529-20120309002332.patch text/plain 1442 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDE3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA4ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENyZWF0aW5nIGEgc2VsZWN0b3IgZm9yIGNsYXNzIG5hbWVzIHdpdGggdHJhaWxpbmcgc3Bh Y2VzIHJlc3VsdHMgd2l0aCB0d28gZG90cyBpbnN0ZWFkIG9mIG9uZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA1MjkKKworICAgICAgICBUcmltIHRo ZSBjbGFzc05hbWUgYmVmb3JlIHJlcGxhY2luZyB0aGUgd2hpdGVzcGFjZXMgd2l0aCBkb3QgIi4i CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9ET01BZ2VudC5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5ET01Ob2RlLnByb3RvdHlwZS5hcHByb3ByaWF0ZVNlbGVjdG9y Rm9yKToKKwogMjAxMi0wMy0wOCAgUm9iaW4gQ2FvICA8cm9iaW4uY2FvQHRvcmNobW9iaWxlLmNv bS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0gV2ViR0wgcmVsYXRlZCBmaWxl cyBmcm9tIHBsYXRmb3JtL2dyYXBoaWNzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL0RPTUFnZW50LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMJKHJldmlzaW9uIDExMDE3MCkKKysrIFNvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9NQWdlbnQuanMJKHdvcmtpbmcgY29weSkKQEAg LTM2NSw3ICszNjUsNyBAQCBXZWJJbnNwZWN0b3IuRE9NTm9kZS5wcm90b3R5cGUgPSB7CiAKICAg ICAgICAgdmFyIGNsYXNzTmFtZSA9IHRoaXMuZ2V0QXR0cmlidXRlKCJjbGFzcyIpOwogICAgICAg ICBpZiAoY2xhc3NOYW1lKSB7Ci0gICAgICAgICAgICB2YXIgc2VsZWN0b3IgPSAiLiIgKyBjbGFz c05hbWUucmVwbGFjZSgvXHMrL2csICIuIik7CisgICAgICAgICAgICB2YXIgc2VsZWN0b3IgPSAi LiIgKyBjbGFzc05hbWUudHJpbSgpLnJlcGxhY2UoL1xzKy9nLCAiLiIpOwogICAgICAgICAgICAg cmV0dXJuIChqdXN0U2VsZWN0b3IgPyBzZWxlY3RvciA6IGxvd2VyQ2FzZU5hbWUgKyBzZWxlY3Rv cik7CiAgICAgICAgIH0KIAo=