80524 2012-03-07 11:20:57 -0800 [Qt] [WK2] Webkit fails to link when compiled with force_static_libs_as_shared 2012-03-08 02:44:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 ostap73 webkit-unassigned abarth dglazkov eric ggaren hausmann webkit.review.bot oldest_to_newest 573036 0 ostap73 2012-03-07 11:20:57 -0800 /home/sl/work/webkit2/WebKitBuild/Debug/lib/libWTF.so: undefined reference to `JSC::IdentifierTable::~IdentifierTable()' collect2: ld returned 1 exit status make[4]: *** [MIMESniffing] Error 1 make[4]: Leaving directory `/home/sl/work/webkit2/WebKitBuild/Debug/Source/WebKit/qt/tests/MIMESniffing' make[3]: *** [sub--home-sl-work-webkit2-Source-WebKit-qt-tests-MIMESniffing-make_default-ordered] Error 2 make[3]: Leaving directory `/home/sl/work/webkit2/WebKitBuild/Debug/Source' make[2]: *** [sub-tests-pri-make_default-ordered] Error 2 make[2]: Leaving directory `/home/sl/work/webkit2/WebKitBuild/Debug/Source' make[1]: *** [sub-Source-QtWebKit-pro-make_default-ordered] Error 2 make[1]: Leaving directory `/home/sl/work/webkit2/WebKitBuild/Debug' make: *** [incremental] Error 2 573089 1 130665 ostap73 2012-03-07 11:56:17 -0800 Created attachment 130665 Patch 573104 2 hausmann 2012-03-07 12:12:22 -0800 I see this problem only when the toolchain includes -Wl,z,defs, which isn't a default. I'll check with Tor Arne tomorrow, but I'd prefer to remove the offending flags from CFLAGS instead of doing the move. This kind of build configuration isn't supported by the project yet I think. 573139 3 130665 webkit.review.bot 2012-03-07 12:49:19 -0800 Comment on attachment 130665 Patch Attachment 130665 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11851264 573189 4 130665 hausmann 2012-03-07 13:38:13 -0800 Comment on attachment 130665 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130665&action=review One second thought, this seems to make sense. The class is declared in WTFThreadData.h, why not define it in the .cpp. But there's the Chromium build issue :) > Source/JavaScriptCore/wtf/WTFThreadData.cpp:70 > +namespace JSC { > + > +IdentifierTable::~IdentifierTable() > +{ > + HashSet<StringImpl*>::iterator end = m_table.end(); > + for (HashSet<StringImpl*>::iterator iter = m_table.begin(); iter != end; ++iter) > + (*iter)->setIsIdentifier(false); > +} > + > +std::pair<HashSet<StringImpl*>::iterator, bool> IdentifierTable::add(StringImpl* value) > +{ > + std::pair<HashSet<StringImpl*>::iterator, bool> result = m_table.add(value); > + (*result.first)->setIsIdentifier(true); > + return result; > } This should be surrounded by #if USE(JSC) to fix the Chromium build. 573283 5 130707 ostap73 2012-03-07 15:12:15 -0800 Created attachment 130707 Updated patch. 573722 6 130707 webkit.review.bot 2012-03-08 01:57:40 -0800 Comment on attachment 130707 Updated patch. Clearing flags on attachment: 130707 Committed r110158: <http://trac.webkit.org/changeset/110158> 573723 7 webkit.review.bot 2012-03-08 01:57:45 -0800 All reviewed patches have been landed. Closing bug. 573728 8 eric 2012-03-08 02:10:43 -0800 Huh? This seems like a layering violation. WTF shouldn't need to know about JSC... 573739 9 hausmann 2012-03-08 02:44:52 -0800 (In reply to comment #8) > Huh? This seems like a layering violation. WTF shouldn't need to know about JSC... It was a bit the other way around, I think. WTF used stuff from JSC, i.e. WTFThreadData.h declared IdentifierTable but it was _implemented_ in JSC. But yeah, with or without this patch the identifier stuff is the reason for the remaining #if USE(JSC) in WTF I think. 130665 2012-03-07 11:56:17 -0800 2012-03-07 15:12:15 -0800 Patch IdentifierTable_fix_01.diff text/plain 2518 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUzMTRlMjMuLjQxODNhNjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTA3ICBWaWF0Y2hlc2xhdiBP c3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgorCisgICAgICAgIFtR dF0gW1dLMl0gV2Via2l0IGZhaWxzIHRvIGxpbmsgd2hlbiBjb21waWxlZCB3aXRoIGZvcmNlX3N0 YXRpY19saWJzX2FzX3NoYXJlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODA1MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBNb3ZlIElkZW50aWZpZXJUYWJsZSBtZXRob2RzIGRlZmludGlvbiB0byBXVEZU aHJlYWREYXRhLmNwcCB0byBmaXggbGlua2luZyAKKyAgICAgICAgb2YgV1RGIGxpYnJhcnkuCisK KyAgICAgICAgKiBydW50aW1lL0lkZW50aWZpZXIuY3BwOgorICAgICAgICAqIHd0Zi9XVEZUaHJl YWREYXRhLmNwcDoKKyAgICAgICAgKEpTQyk6CisgICAgICAgIChKU0M6OklkZW50aWZpZXJUYWJs ZTo6fklkZW50aWZpZXJUYWJsZSk6CisgICAgICAgIChKU0M6OklkZW50aWZpZXJUYWJsZTo6YWRk KToKKwogMjAxMi0wMy0wNyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5j b20+CiAKICAgICAgICAgQVJNIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSWRlbnRpZmllci5jcHAKaW5kZXggMGQyMzNlMy4uZmJjNTc4NyAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5jcHAKQEAgLTM2LDIwICszNiw2IEBA IHVzaW5nIFdURjo6VGhyZWFkU3BlY2lmaWM7CiAKIG5hbWVzcGFjZSBKU0MgewogCi1JZGVudGlm aWVyVGFibGU6On5JZGVudGlmaWVyVGFibGUoKQotewotICAgIEhhc2hTZXQ8U3RyaW5nSW1wbCo+ OjppdGVyYXRvciBlbmQgPSBtX3RhYmxlLmVuZCgpOwotICAgIGZvciAoSGFzaFNldDxTdHJpbmdJ bXBsKj46Oml0ZXJhdG9yIGl0ZXIgPSBtX3RhYmxlLmJlZ2luKCk7IGl0ZXIgIT0gZW5kOyArK2l0 ZXIpCi0gICAgICAgICgqaXRlciktPnNldElzSWRlbnRpZmllcihmYWxzZSk7Ci19Ci0KLXN0ZDo6 cGFpcjxIYXNoU2V0PFN0cmluZ0ltcGwqPjo6aXRlcmF0b3IsIGJvb2w+IElkZW50aWZpZXJUYWJs ZTo6YWRkKFN0cmluZ0ltcGwqIHZhbHVlKQotewotICAgIHN0ZDo6cGFpcjxIYXNoU2V0PFN0cmlu Z0ltcGwqPjo6aXRlcmF0b3IsIGJvb2w+IHJlc3VsdCA9IG1fdGFibGUuYWRkKHZhbHVlKTsKLSAg ICAoKnJlc3VsdC5maXJzdCktPnNldElzSWRlbnRpZmllcih0cnVlKTsKLSAgICByZXR1cm4gcmVz dWx0OwotfQotCiBJZGVudGlmaWVyVGFibGUqIGNyZWF0ZUlkZW50aWZpZXJUYWJsZSgpCiB7CiAg ICAgcmV0dXJuIG5ldyBJZGVudGlmaWVyVGFibGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9XVEZUaHJlYWREYXRhLmNwcAppbmRleCAyNDFmYmU0Li4yMWZjYWI0IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvV1RGVGhyZWFkRGF0YS5jcHAKQEAgLTUxLDQgKzUxLDIzIEBAIFdU RlRocmVhZERhdGE6On5XVEZUaHJlYWREYXRhKCkKICNlbmRpZgogfQogCit9IC8vIG5hbWVzcGFj ZSBXVEYKKworbmFtZXNwYWNlIEpTQyB7CisKK0lkZW50aWZpZXJUYWJsZTo6fklkZW50aWZpZXJU YWJsZSgpCit7CisgICAgSGFzaFNldDxTdHJpbmdJbXBsKj46Oml0ZXJhdG9yIGVuZCA9IG1fdGFi bGUuZW5kKCk7CisgICAgZm9yIChIYXNoU2V0PFN0cmluZ0ltcGwqPjo6aXRlcmF0b3IgaXRlciA9 IG1fdGFibGUuYmVnaW4oKTsgaXRlciAhPSBlbmQ7ICsraXRlcikKKyAgICAgICAgKCppdGVyKS0+ c2V0SXNJZGVudGlmaWVyKGZhbHNlKTsKK30KKworc3RkOjpwYWlyPEhhc2hTZXQ8U3RyaW5nSW1w bCo+OjppdGVyYXRvciwgYm9vbD4gSWRlbnRpZmllclRhYmxlOjphZGQoU3RyaW5nSW1wbCogdmFs dWUpCit7CisgICAgc3RkOjpwYWlyPEhhc2hTZXQ8U3RyaW5nSW1wbCo+OjppdGVyYXRvciwgYm9v bD4gcmVzdWx0ID0gbV90YWJsZS5hZGQodmFsdWUpOworICAgICgqcmVzdWx0LmZpcnN0KS0+c2V0 SXNJZGVudGlmaWVyKHRydWUpOworICAgIHJldHVybiByZXN1bHQ7CiB9CisKK30gLy8gbmFtZXNw YWNlIEpTQworCg== 130707 2012-03-07 15:12:15 -0800 2012-03-08 01:57:40 -0800 Updated patch. IdentifierTable_fix_02.diff text/plain 2540 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDUzMTRlMjMuLjQxODNhNjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTA3ICBWaWF0Y2hlc2xhdiBP c3RhcGVua28gIDxvc3RhcGVua28udmlhdGNoZXNsYXZAbm9raWEuY29tPgorCisgICAgICAgIFtR dF0gW1dLMl0gV2Via2l0IGZhaWxzIHRvIGxpbmsgd2hlbiBjb21waWxlZCB3aXRoIGZvcmNlX3N0 YXRpY19saWJzX2FzX3NoYXJlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODA1MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBNb3ZlIElkZW50aWZpZXJUYWJsZSBtZXRob2RzIGRlZmludGlvbiB0byBXVEZU aHJlYWREYXRhLmNwcCB0byBmaXggbGlua2luZyAKKyAgICAgICAgb2YgV1RGIGxpYnJhcnkuCisK KyAgICAgICAgKiBydW50aW1lL0lkZW50aWZpZXIuY3BwOgorICAgICAgICAqIHd0Zi9XVEZUaHJl YWREYXRhLmNwcDoKKyAgICAgICAgKEpTQyk6CisgICAgICAgIChKU0M6OklkZW50aWZpZXJUYWJs ZTo6fklkZW50aWZpZXJUYWJsZSk6CisgICAgICAgIChKU0M6OklkZW50aWZpZXJUYWJsZTo6YWRk KToKKwogMjAxMi0wMy0wNyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5j b20+CiAKICAgICAgICAgQVJNIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0lkZW50aWZpZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSWRlbnRpZmllci5jcHAKaW5kZXggMGQyMzNlMy4uZmJjNTc4NyAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSWRlbnRpZmllci5jcHAKQEAgLTM2LDIwICszNiw2IEBA IHVzaW5nIFdURjo6VGhyZWFkU3BlY2lmaWM7CiAKIG5hbWVzcGFjZSBKU0MgewogCi1JZGVudGlm aWVyVGFibGU6On5JZGVudGlmaWVyVGFibGUoKQotewotICAgIEhhc2hTZXQ8U3RyaW5nSW1wbCo+ OjppdGVyYXRvciBlbmQgPSBtX3RhYmxlLmVuZCgpOwotICAgIGZvciAoSGFzaFNldDxTdHJpbmdJ bXBsKj46Oml0ZXJhdG9yIGl0ZXIgPSBtX3RhYmxlLmJlZ2luKCk7IGl0ZXIgIT0gZW5kOyArK2l0 ZXIpCi0gICAgICAgICgqaXRlciktPnNldElzSWRlbnRpZmllcihmYWxzZSk7Ci19Ci0KLXN0ZDo6 cGFpcjxIYXNoU2V0PFN0cmluZ0ltcGwqPjo6aXRlcmF0b3IsIGJvb2w+IElkZW50aWZpZXJUYWJs ZTo6YWRkKFN0cmluZ0ltcGwqIHZhbHVlKQotewotICAgIHN0ZDo6cGFpcjxIYXNoU2V0PFN0cmlu Z0ltcGwqPjo6aXRlcmF0b3IsIGJvb2w+IHJlc3VsdCA9IG1fdGFibGUuYWRkKHZhbHVlKTsKLSAg ICAoKnJlc3VsdC5maXJzdCktPnNldElzSWRlbnRpZmllcih0cnVlKTsKLSAgICByZXR1cm4gcmVz dWx0OwotfQotCiBJZGVudGlmaWVyVGFibGUqIGNyZWF0ZUlkZW50aWZpZXJUYWJsZSgpCiB7CiAg ICAgcmV0dXJuIG5ldyBJZGVudGlmaWVyVGFibGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0 Zi9XVEZUaHJlYWREYXRhLmNwcAppbmRleCAyNDFmYmU0Li5lYzVkZTcyIDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvV1RGVGhyZWFkRGF0YS5jcHAKQEAgLTUxLDQgKzUxLDI1IEBAIFdU RlRocmVhZERhdGE6On5XVEZUaHJlYWREYXRhKCkKICNlbmRpZgogfQogCit9IC8vIG5hbWVzcGFj ZSBXVEYKKworI2lmIFVTRShKU0MpCituYW1lc3BhY2UgSlNDIHsKKworSWRlbnRpZmllclRhYmxl Ojp+SWRlbnRpZmllclRhYmxlKCkKK3sKKyAgICBIYXNoU2V0PFN0cmluZ0ltcGwqPjo6aXRlcmF0 b3IgZW5kID0gbV90YWJsZS5lbmQoKTsKKyAgICBmb3IgKEhhc2hTZXQ8U3RyaW5nSW1wbCo+Ojpp dGVyYXRvciBpdGVyID0gbV90YWJsZS5iZWdpbigpOyBpdGVyICE9IGVuZDsgKytpdGVyKQorICAg ICAgICAoKml0ZXIpLT5zZXRJc0lkZW50aWZpZXIoZmFsc2UpOworfQorCitzdGQ6OnBhaXI8SGFz aFNldDxTdHJpbmdJbXBsKj46Oml0ZXJhdG9yLCBib29sPiBJZGVudGlmaWVyVGFibGU6OmFkZChT dHJpbmdJbXBsKiB2YWx1ZSkKK3sKKyAgICBzdGQ6OnBhaXI8SGFzaFNldDxTdHJpbmdJbXBsKj46 Oml0ZXJhdG9yLCBib29sPiByZXN1bHQgPSBtX3RhYmxlLmFkZCh2YWx1ZSk7CisgICAgKCpyZXN1 bHQuZmlyc3QpLT5zZXRJc0lkZW50aWZpZXIodHJ1ZSk7CisgICAgcmV0dXJuIHJlc3VsdDsKIH0K KworfSAvLyBuYW1lc3BhY2UgSlNDCisjZW5kaWYKKwo=