80507 2012-03-07 04:52:10 -0800 Web Inspector: [Styles] Click in the first line of rule while editing property starts a new property 2012-03-09 01:52:13 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 572797 0 apavlov 2012-03-07 04:52:10 -0800 Patch to follow. 572806 1 130601 apavlov 2012-03-07 05:05:40 -0800 Created attachment 130601 Patch 572846 2 130601 vsevik 2012-03-07 06:36:37 -0800 Comment on attachment 130601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130601&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:980 > + selectorContainer.addEventListener("mousedown", this._handleEmptySpaceMouseDown.bind(this), false); We have the same problem for each rule element also. > Source/WebCore/inspector/front-end/StylesSidebarPane.js:1181 > + var willCauseCancelEditing = this._willCauseCancelEditing; Could you please extract this method? 572869 3 130621 apavlov 2012-03-07 07:13:20 -0800 Created attachment 130621 Patch 572878 4 130621 vsevik 2012-03-07 07:37:37 -0800 Comment on attachment 130621 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130621&action=review > Source/WebCore/inspector/front-end/StylesSidebarPane.js:2031 > + if (this.section._checkWillCancelEditing()) Consider renaming _startEditing to _mouseClicked. 574736 5 apavlov 2012-03-09 01:52:13 -0800 Committed r110278: <http://trac.webkit.org/changeset/110278> 130601 2012-03-07 05:05:40 -0800 2012-03-07 07:13:13 -0800 Patch bug-80507-20120307170538.patch text/plain 2137 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI5ZjEwZTUzMTMwNjQ1 NDdkMmUwNTY5YTg3MmI4NjU0OGI5YjRkMS4uMzMzZTEzMjQ0Yzg2Zjg1N2UwMTg4YmE5ODM3MWVj MTdiMmM1YjU0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTAzLTA3ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogW1N0eWxlc10gQ2xpY2sgaW4gdGhlIGZpcnN0IGxpbmUgb2YgcnVsZSB3aGlsZSBlZGl0 aW5nIHByb3BlcnR5IHN0YXJ0cyBhIG5ldyBwcm9wZXJ0eQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA1MDcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lk ZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlv bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbi5wcm90b3R5 cGUuX2hhbmRsZVNlbGVjdG9yQ29udGFpbmVyQ2xpY2spOgorCiAyMDEyLTAzLTA3ICBLZW5pY2hp IElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbV2ViU29ja2V0XSBT aG91bGQgcmFpc2UgU1lOVEFYX0VSUiB3aGVuIG1lc3NhZ2UgY29udGFpbnMgdW5wYWlyZWQgc3Vy cm9nYXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9T dHlsZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv U3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggZWU3MTU3Y2QxOTljYzI5NDYyMDI5Y2MzMTY4NTEx YzFlOWYzYTQxNi4uZWY4ZDRiYzM4MGM2ZDczMjJiYTgxZmZlMDM5ZTdlNmJjYmEyNTY0MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFy UGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxlc1Np ZGViYXJQYW5lLmpzCkBAIC05NzcsNiArOTc3LDcgQEAgV2ViSW5zcGVjdG9yLlN0eWxlUHJvcGVy dGllc1NlY3Rpb24gPSBmdW5jdGlvbihwYXJlbnRQYW5lLCBzdHlsZVJ1bGUsIGVkaXRhYmxlLAog ICAgIHZhciBvcGVuQnJhY2UgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7CiAgICAg b3BlbkJyYWNlLnRleHRDb250ZW50ID0gIiB7IjsKICAgICBzZWxlY3RvckNvbnRhaW5lci5hcHBl bmRDaGlsZChvcGVuQnJhY2UpOworICAgIHNlbGVjdG9yQ29udGFpbmVyLmFkZEV2ZW50TGlzdGVu ZXIoIm1vdXNlZG93biIsIHRoaXMuX2hhbmRsZUVtcHR5U3BhY2VNb3VzZURvd24uYmluZCh0aGlz KSwgZmFsc2UpOwogICAgIHNlbGVjdG9yQ29udGFpbmVyLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNr IiwgdGhpcy5faGFuZGxlU2VsZWN0b3JDb250YWluZXJDbGljay5iaW5kKHRoaXMpLCBmYWxzZSk7 CiAKICAgICB2YXIgY2xvc2VCcmFjZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwpA QCAtMTE3Nyw2ICsxMTc4LDExIEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnRpZXNTZWN0aW9u LnByb3RvdHlwZSA9IHsKIAogICAgIF9oYW5kbGVTZWxlY3RvckNvbnRhaW5lckNsaWNrOiBmdW5j dGlvbihldmVudCkKICAgICB7CisgICAgICAgIHZhciB3aWxsQ2F1c2VDYW5jZWxFZGl0aW5nID0g dGhpcy5fd2lsbENhdXNlQ2FuY2VsRWRpdGluZzsKKyAgICAgICAgZGVsZXRlIHRoaXMuX3dpbGxD YXVzZUNhbmNlbEVkaXRpbmc7CisgICAgICAgIGlmICh3aWxsQ2F1c2VDYW5jZWxFZGl0aW5nKQor ICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIGlmIChldmVudC50YXJnZXQgPT09IHRoaXMu X3NlbGVjdG9yQ29udGFpbmVyKQogICAgICAgICAgICAgdGhpcy5hZGROZXdCbGFua1Byb3BlcnR5 KDApLnN0YXJ0RWRpdGluZygpOwogICAgIH0sCg== 130621 2012-03-07 07:13:20 -0800 2012-03-07 07:37:37 -0800 Patch bug-80507-20120307191318.patch text/plain 3353 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI5ZjEwZTUzMTMwNjQ1 NDdkMmUwNTY5YTg3MmI4NjU0OGI5YjRkMS4uMDFhODIyMjRiNWI5NzlkOTJlOWNiMWI3N2M2ZTVk MzcwMWY4ZjRhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTA3ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogW1N0eWxlc10gQ2xpY2sgaW4gdGhlIGZpcnN0IGxpbmUgb2YgcnVsZSB3aGlsZSBlZGl0 aW5nIHByb3BlcnR5IHN0YXJ0cyBhIG5ldyBwcm9wZXJ0eQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA1MDcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lk ZWJhclBhbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlv bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbi5wcm90b3R5 cGUuX2NoZWNrV2lsbENhbmNlbEVkaXRpbmcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0eWxl UHJvcGVydGllc1NlY3Rpb24ucHJvdG90eXBlLl9oYW5kbGVTZWxlY3RvckNvbnRhaW5lckNsaWNr KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnRpZXNTZWN0aW9uLnByb3RvdHlw ZS5faGFuZGxlRW1wdHlTcGFjZUNsaWNrKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZVBy b3BlcnR5VHJlZUVsZW1lbnQucHJvdG90eXBlKToKKwogMjAxMi0wMy0wNyAgS2VuaWNoaSBJc2hp YmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1dlYlNvY2tldF0gU2hvdWxk IHJhaXNlIFNZTlRBWF9FUlIgd2hlbiBtZXNzYWdlIGNvbnRhaW5zIHVucGFpcmVkIHN1cnJvZ2F0 ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVz U2lkZWJhclBhbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0eWxl c1NpZGViYXJQYW5lLmpzCmluZGV4IGVlNzE1N2NkMTk5Y2MyOTQ2MjAyOWNjMzE2ODUxMWMxZTlm M2E0MTYuLjEyYWNhODdjNTk1MzBjODhlMWM3ODk0YWJiMjc2ZDVlMDU3Y2UyNzkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUu anMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFy UGFuZS5qcwpAQCAtOTc3LDYgKzk3Nyw3IEBAIFdlYkluc3BlY3Rvci5TdHlsZVByb3BlcnRpZXNT ZWN0aW9uID0gZnVuY3Rpb24ocGFyZW50UGFuZSwgc3R5bGVSdWxlLCBlZGl0YWJsZSwKICAgICB2 YXIgb3BlbkJyYWNlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIpOwogICAgIG9wZW5C cmFjZS50ZXh0Q29udGVudCA9ICIgeyI7CiAgICAgc2VsZWN0b3JDb250YWluZXIuYXBwZW5kQ2hp bGQob3BlbkJyYWNlKTsKKyAgICBzZWxlY3RvckNvbnRhaW5lci5hZGRFdmVudExpc3RlbmVyKCJt b3VzZWRvd24iLCB0aGlzLl9oYW5kbGVFbXB0eVNwYWNlTW91c2VEb3duLmJpbmQodGhpcyksIGZh bHNlKTsKICAgICBzZWxlY3RvckNvbnRhaW5lci5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIHRo aXMuX2hhbmRsZVNlbGVjdG9yQ29udGFpbmVyQ2xpY2suYmluZCh0aGlzKSwgZmFsc2UpOwogCiAg ICAgdmFyIGNsb3NlQnJhY2UgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKQEAgLTEx NzUsOCArMTE3NiwxNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbi5wcm90 b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiBudWxsOwogICAgIH0sCiAKKyAgICBfY2hlY2tXaWxs Q2FuY2VsRWRpdGluZzogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdmFyIHdpbGxDYXVzZUNh bmNlbEVkaXRpbmcgPSB0aGlzLl93aWxsQ2F1c2VDYW5jZWxFZGl0aW5nOworICAgICAgICBkZWxl dGUgdGhpcy5fd2lsbENhdXNlQ2FuY2VsRWRpdGluZzsKKyAgICAgICAgcmV0dXJuIHdpbGxDYXVz ZUNhbmNlbEVkaXRpbmc7CisgICAgfSwKKwogICAgIF9oYW5kbGVTZWxlY3RvckNvbnRhaW5lckNs aWNrOiBmdW5jdGlvbihldmVudCkKICAgICB7CisgICAgICAgIGlmICh0aGlzLl9jaGVja1dpbGxD YW5jZWxFZGl0aW5nKCkpCisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIGlmIChldmVudC50 YXJnZXQgPT09IHRoaXMuX3NlbGVjdG9yQ29udGFpbmVyKQogICAgICAgICAgICAgdGhpcy5hZGRO ZXdCbGFua1Byb3BlcnR5KDApLnN0YXJ0RWRpdGluZygpOwogICAgIH0sCkBAIC0xMjMwLDkgKzEy NDAsNyBAQCBXZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbi5wcm90b3R5cGUgPSB7 CiAKICAgICBfaGFuZGxlRW1wdHlTcGFjZUNsaWNrOiBmdW5jdGlvbihldmVudCkKICAgICB7Ci0g ICAgICAgIHZhciB3aWxsQ2F1c2VDYW5jZWxFZGl0aW5nID0gdGhpcy5fd2lsbENhdXNlQ2FuY2Vs RWRpdGluZzsKLSAgICAgICAgZGVsZXRlIHRoaXMuX3dpbGxDYXVzZUNhbmNlbEVkaXRpbmc7Ci0g ICAgICAgIGlmICh3aWxsQ2F1c2VDYW5jZWxFZGl0aW5nKQorICAgICAgICBpZiAodGhpcy5fY2hl Y2tXaWxsQ2FuY2VsRWRpdGluZygpKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGlm IChldmVudC50YXJnZXQuaGFzU3R5bGVDbGFzcygiaGVhZGVyIikgfHwgdGhpcy5lbGVtZW50Lmhh c1N0eWxlQ2xhc3MoInJlYWQtb25seSIpIHx8IGV2ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JT ZWxmV2l0aENsYXNzKCJtZWRpYSIpKSB7CkBAIC0yMDIwLDYgKzIwMjgsOCBAQCBXZWJJbnNwZWN0 b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgZXZlbnQu cHJldmVudERlZmF1bHQoKTsKIAogICAgICAgICBpZiAoZXZlbnQudGFyZ2V0ID09PSB0aGlzLmxp c3RJdGVtRWxlbWVudCkgeworICAgICAgICAgICAgaWYgKHRoaXMuc2VjdGlvbi5fY2hlY2tXaWxs Q2FuY2VsRWRpdGluZygpKQorICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIHRo aXMuc2VjdGlvbi5hZGROZXdCbGFua1Byb3BlcnR5KHRoaXMucHJvcGVydHkuaW5kZXggKyAxKS5z dGFydEVkaXRpbmcoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQo=