80505 2012-03-07 03:17:13 -0800 Linux has madvise enough to support OSAllocator::commit/decommit 2012-03-15 13:28:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 hojong.han webkit-unassigned barraclough fpizlo ggaren msaboff paroga webkit.review.bot oldest_to_newest 572749 0 hojong.han 2012-03-07 03:17:13 -0800 Linux has madvise enough to support OSAllocator::commit/decommit, but it's not used in commit and decommit. What about using this function with OS(LINUX) option? 572755 1 130587 hojong.han 2012-03-07 03:30:24 -0800 Created attachment 130587 Patch 573119 2 130587 ggaren 2012-03-07 12:32:16 -0800 Comment on attachment 130587 Patch r=me 579109 3 hojong.han 2012-03-14 21:12:52 -0700 Thanks for review. Isn't it necessary to put it in the queue? Is there anything to do more? Please let me know. 579656 4 130587 webkit.review.bot 2012-03-15 12:54:29 -0700 Comment on attachment 130587 Patch Clearing flags on attachment: 130587 Committed r110874: <http://trac.webkit.org/changeset/110874> 579657 5 webkit.review.bot 2012-03-15 12:54:34 -0700 All reviewed patches have been landed. Closing bug. 579677 6 130587 paroga 2012-03-15 13:27:44 -0700 Comment on attachment 130587 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130587&action=review > Source/JavaScriptCore/wtf/OSAllocatorPosix.cpp:145 > + madvise(address, bytes, MADV_DONTNEED); what's the difference between this line and the line guarded with HAVE(MADV_DONTNEED)? can't we merge them or at least follow the "style" of the other lines? 130587 2012-03-07 03:30:24 -0800 2012-03-15 13:27:44 -0700 Patch bug-80505-20120307203020.patch text/plain 2300 hojong.han U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NGRhNjhkZWFhYmYyOWYxYTYxOTE5OGM0OTEzZTA1NjAwNzA2YzVkLi5mMjc3MjkyMDFlNTg0Y2Zi NDlhMjM3YTNiNTMxZmQxMWIxNGYwYjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wMy0wNyAgSG9qb25nIEhhbiAgPGhvam9uZy5oYW5Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgTGludXggaGFzIG1hZHZpc2UgZW5vdWdoIHRvIHN1cHBvcnQgT1NBbGxv Y2F0b3I6OmNvbW1pdC9kZWNvbW1pdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODA1MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHd0Zi9PU0FsbG9jYXRvclBvc2l4LmNwcDoKKyAgICAgICAgKFdURjo6 T1NBbGxvY2F0b3I6OnJlc2VydmVVbmNvbW1pdHRlZCk6CisgICAgICAgIChXVEY6Ok9TQWxsb2Nh dG9yOjpjb21taXQpOgorICAgICAgICAoV1RGOjpPU0FsbG9jYXRvcjo6ZGVjb21taXQpOgorCiAy MDEyLTAzLTA3ICBBbmR5IFdpbmdvICA8d2luZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBQYXJz ZXI6IElubGluZSBTY29wZU5vZGVEYXRhIGludG8gU2NvcGVOb2RlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd3RmL09TQWxsb2NhdG9yUG9zaXguY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9PU0FsbG9jYXRvclBvc2l4LmNwcAppbmRleCA1ZGJkZGM4M2VhODM5MGU2 ZDdlMDZjMTgwNzg0NDg2MDY3YjFjYjgyLi5mMTRlY2I4ZGE4MmY0MjFhZmFlOWQzMTlmMTljNGEy Y2QwMTA4MzMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL09TQWxsb2Nh dG9yUG9zaXguY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvT1NBbGxvY2F0b3JQ b3NpeC5jcHAKQEAgLTM5LDYgKzM5LDggQEAgdm9pZCogT1NBbGxvY2F0b3I6OnJlc2VydmVVbmNv bW1pdHRlZChzaXplX3QgYnl0ZXMsIFVzYWdlIHVzYWdlLCBib29sIHdyaXRhYmxlLAogICAgIHZv aWQqIHJlc3VsdCA9IHJlc2VydmVBbmRDb21taXQoYnl0ZXMsIHVzYWdlLCB3cml0YWJsZSwgZXhl Y3V0YWJsZSwgaW5jbHVkZXNHdWFyZFBhZ2VzKTsKICNpZiBPUyhRTlgpCiAgICAgcG9zaXhfbWFk dmlzZShyZXN1bHQsIGJ5dGVzLCBQT1NJWF9NQURWX0RPTlRORUVEKTsKKyNlbGlmIE9TKExJTlVY KQorICAgIG1hZHZpc2UocmVzdWx0LCBieXRlcywgTUFEVl9ET05UTkVFRCk7CiAjZWxpZiBIQVZF KE1BRFZfRlJFRV9SRVVTRSkKICAgICAvLyBUbyBzdXBwb3J0IHRoZSAicmVzZXJ2ZSB0aGVuIGNv bW1pdCIgbW9kZWwsIHdlIGhhdmUgdG8gaW5pdGlhbGx5IGRlY29tbWl0LgogICAgIHdoaWxlICht YWR2aXNlKHJlc3VsdCwgYnl0ZXMsIE1BRFZfRlJFRV9SRVVTQUJMRSkgPT0gLTEgJiYgZXJybm8g PT0gRUFHQUlOKSB7IH0KQEAgLTEyNCw2ICsxMjYsOCBAQCB2b2lkIE9TQWxsb2NhdG9yOjpjb21t aXQodm9pZCogYWRkcmVzcywgc2l6ZV90IGJ5dGVzLCBib29sLCBib29sKQogewogI2lmIE9TKFFO WCkKICAgICBwb3NpeF9tYWR2aXNlKGFkZHJlc3MsIGJ5dGVzLCBQT1NJWF9NQURWX1dJTExORUVE KTsKKyNlbGlmIE9TKExJTlVYKQorICAgIG1hZHZpc2UoYWRkcmVzcywgYnl0ZXMsIE1BRFZfV0lM TE5FRUQpOwogI2VsaWYgSEFWRShNQURWX0ZSRUVfUkVVU0UpCiAgICAgd2hpbGUgKG1hZHZpc2Uo YWRkcmVzcywgYnl0ZXMsIE1BRFZfRlJFRV9SRVVTRSkgPT0gLTEgJiYgZXJybm8gPT0gRUFHQUlO KSB7IH0KICNlbHNlCkBAIC0xMzcsNiArMTQxLDggQEAgdm9pZCBPU0FsbG9jYXRvcjo6ZGVjb21t aXQodm9pZCogYWRkcmVzcywgc2l6ZV90IGJ5dGVzKQogewogI2lmIE9TKFFOWCkKICAgICBwb3Np eF9tYWR2aXNlKGFkZHJlc3MsIGJ5dGVzLCBQT1NJWF9NQURWX0RPTlRORUVEKTsKKyNlbGlmIE9T KExJTlVYKQorICAgIG1hZHZpc2UoYWRkcmVzcywgYnl0ZXMsIE1BRFZfRE9OVE5FRUQpOwogI2Vs aWYgSEFWRShNQURWX0ZSRUVfUkVVU0UpCiAgICAgd2hpbGUgKG1hZHZpc2UoYWRkcmVzcywgYnl0 ZXMsIE1BRFZfRlJFRV9SRVVTQUJMRSkgPT0gLTEgJiYgZXJybm8gPT0gRUFHQUlOKSB7IH0KICNl bGlmIEhBVkUoTUFEVl9GUkVFKQo=