80500 2012-03-07 00:42:08 -0800 [GTK] remove webkitpy dependency in run-gtk-tests 2012-03-07 09:24:36 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80495 1 pnormand webkit-unassigned mrobinson pnormand oldest_to_newest 572653 0 pnormand 2012-03-07 00:42:08 -0800 So it can be shipped in tarballs and used during distcheck. 572696 1 130570 pnormand 2012-03-07 01:39:14 -0800 Created attachment 130570 Patch 572849 2 130570 mrobinson 2012-03-07 06:42:16 -0800 Comment on attachment 130570 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130570&action=review Great! Thank you! > Tools/Scripts/run-gtk-tests:154 > - out = self._executive.run_command([jhbuild_path ,'gtester', test], env=test_env, > - error_handler=_error_handler) > + process = subprocess.Popen([jhbuild_path ,'gtester', test], env=test_env, stdout=subprocess.PIPE) > + out = process.communicate()[0] > sys.stdout.write(out) If you omit the stdout argument altogether, I believe the default is to route it to stdout anyway. Perhaps you can just omit that and sys.stdout.write(out) sys.stdout.flush() altogether. 572854 3 pnormand 2012-03-07 06:47:07 -0800 Alright I'll try that before landing, thanks :) 572951 4 pnormand 2012-03-07 09:24:36 -0800 Committed r110062: <http://trac.webkit.org/changeset/110062> 130570 2012-03-07 01:39:14 -0800 2012-03-07 06:42:16 -0800 Patch Patch.patch text/plain 4826 pnormand RnJvbSA4NDMyN2U3ZTQ2NzdhYWZkMGQxZTFhYzZkZTY1YzI2NjFhODI5NTgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDcgTWFyIDIwMTIgMTA6MjY6NDYgKzAxMDAKU3ViamVjdDogW1BBVENIXSBQ YXRjaAoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysr KysrKwogVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIHwgICAyMSArKysrKysrKysrKy0tLS0t LS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGIy NzUyMzkuLmZiMjA5MWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMi0wMy0wNyAgUGhpbGlwcGUgTm9ybWFuZCAg PHBub3JtYW5kQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gcmVtb3ZlIHdlYmtpdHB5IGRl cGVuZGVuY3kgaW4gcnVuLWd0ay10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA1MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZXBsYWNlIEV4ZWN1dGl2ZSBjYWxscyB3aXRoIGJhcmUgc3VicHJv Y2VzcyBjYWxscy4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0czoKKyAgICAgICAg KFRlc3RSdW5uZXIpOgorICAgICAgICAoVGVzdFJ1bm5lci5fbG9va3VwX2F0c3BpMl9iaW5hcnkp OgorICAgICAgICAoVGVzdFJ1bm5lci5ydW4pOgorICAgICAgICAoVGVzdFJ1bm5lci5ydW4ucnVu X2Zvcl9yZWFsKToKKworMjAxMi0wMy0wNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CisKICAgICAgICAgW0dUS10gcmFjZSBjb25kaXRpb24gaW4gcnVuLWd0ay10ZXN0 cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA0OTUK IApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0 cy9ydW4tZ3RrLXRlc3RzCmluZGV4IDQ3ZDIwYTAuLjQ3YzlkZDEgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMK QEAgLTE3LDcgKzE3LDYgQEAKICMgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLiwg NTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwKICMgQm9zdG9uLCBNQSAwMjExMC0xMzAx LCBVU0EuCiAKLWZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVjdXRpdmUgaW1wb3J0IEV4 ZWN1dGl2ZQogaW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCBvcywgc3lzLCB0aW1lCiAKQEAgLTM2 LDcgKzM1LDYgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgICAgICAiV2ViS2l0MkFQ SVRlc3RzL1Rlc3REb3dubG9hZHMiIF0KIAogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKLSAgICAg ICAgc2VsZi5fZXhlY3V0aXZlID0gRXhlY3V0aXZlKCkKIAogICAgICAgICAjIEZJWE1FOiB3ZWJr aXQtYnVpbGQtZGlyZWN0b3J5IC0tY29uZmlndXJhdGlvbiBhbHdheXMgcmV0dXJucwogICAgICAg ICAjIFJlbGVhc2UgYmVjYXVzZSB3ZSBuZXZlciBjYWxsIHNldC13ZWJraXQtY29uZmlndXJhdGlv bi4KQEAgLTczLDcgKzcxLDkgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgICAgICAg ICAgc2VsZi5fdGVzdHMuYXBwZW5kKHRlc3RfcGF0aCkKIAogICAgIGRlZiBfbG9va3VwX2F0c3Bp Ml9iaW5hcnkoc2VsZiwgamhidWlsZF9wYXRoLCBmaWxlbmFtZSk6Ci0gICAgICAgIGV4ZWNfcHJl Zml4ID0gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFtqaGJ1aWxkX3BhdGggLCdwa2ctY29u ZmlnJywgJy0tdmFyaWFibGU9ZXhlY19wcmVmaXgnLCAnYXRzcGktMiddKS5yc3RyaXAoJ1xyXG4n KQorICAgICAgICBwcm9jZXNzID0gc3VicHJvY2Vzcy5Qb3BlbihbamhidWlsZF9wYXRoICwncGtn LWNvbmZpZycsICctLXZhcmlhYmxlPWV4ZWNfcHJlZml4JywgJ2F0c3BpLTInXSwgc3Rkb3V0PXN1 YnByb2Nlc3MuUElQRSkKKyAgICAgICAgc3Rkb3V0ID0gcHJvY2Vzcy5jb21tdW5pY2F0ZSgpWzBd CisgICAgICAgIGV4ZWNfcHJlZml4ID0gc3Rkb3V0LnJzdHJpcCgnXHJcbicpCiAgICAgICAgIHBh dGhzX3RvX2NoZWNrID0gWyAnbGliZXhlYycsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAn bGliL2F0LXNwaTItY29yZScsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAnbGliMzIvYXQt c3BpMi1jb3JlJywKQEAgLTEwNyw4ICsxMDcsNiBAQCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAg ICB0ZXN0X2VudlsnR1NFVFRJTkdTX0JBQ0tFTkQnXSA9ICdtZW1vcnknCiAKICAgICAgICAgZmFp bGVkX3Rlc3RzID0gW10KLSAgICAgICAgZGVmIF9lcnJvcl9oYW5kbGVyKGVycm9yKToKLSAgICAg ICAgICAgIGZhaWxlZF90ZXN0cy5hcHBlbmQoZXJyb3Iuc2NyaXB0X2FyZ3NbMl0pCiAKICAgICAg ICAgZ2xvYmFsIHRpbWVkX291dDsKICAgICAgICAgdGltZWRfb3V0ID0gRmFsc2UKQEAgLTExOSw3 ICsxMTcsNyBAQCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICBhMTF5X2J1c19sYXVuY2hlcl9w YXRoID0gc2VsZi5fbG9va3VwX2F0c3BpMl9iaW5hcnkoamhidWlsZF9wYXRoLCAnYXQtc3BpLWJ1 cy1sYXVuY2hlcicpCiAgICAgICAgIGFzc2VydChhMTF5X2J1c19sYXVuY2hlcl9wYXRoKQogICAg ICAgICB0cnk6Ci0gICAgICAgICAgICBhMTF5X2J1c19sYXVuY2hlciA9IEV4ZWN1dGl2ZSgpLnBv cGVuKFthMTF5X2J1c19sYXVuY2hlcl9wYXRoXSwgZW52PXRlc3RfZW52KQorICAgICAgICAgICAg YTExeV9idXNfbGF1bmNoZXIgPSBzdWJwcm9jZXNzLlBvcGVuKFthMTF5X2J1c19sYXVuY2hlcl9w YXRoXSwgZW52PXRlc3RfZW52KQogICAgICAgICBleGNlcHQ6CiAgICAgICAgICAgICBzeXMuc3Rk ZXJyLndyaXRlKCJGYWlsZWQgdG8gbGF1bmNoIHRoZSBhY2Nlc3NpYmlsaXR5IGJ1c1xuIikKICAg ICAgICAgICAgIHN5cy5zdGRlcnIuZmx1c2goKQpAQCAtMTQ0LDE4ICsxNDIsMjEgQEAgY2xhc3Mg VGVzdFJ1bm5lcjoKICAgICAgICAgICAgIGExMXlfcmVnaXN0cnlkX3BhdGggPSBzZWxmLl9sb29r dXBfYXRzcGkyX2JpbmFyeShqaGJ1aWxkX3BhdGgsICdhdC1zcGkyLXJlZ2lzdHJ5ZCcpCiAgICAg ICAgICAgICBpZiBhMTF5X3JlZ2lzdHJ5ZF9wYXRoOgogICAgICAgICAgICAgICAgIHRyeToKLSAg ICAgICAgICAgICAgICAgICAgYTExeV9yZWdpc3RyeWQgPSBFeGVjdXRpdmUoKS5wb3BlbihbYTEx eV9yZWdpc3RyeWRfcGF0aF0sIGVudj10ZXN0X2VudikKKyAgICAgICAgICAgICAgICAgICAgYTEx eV9yZWdpc3RyeWQgPSBzdWJwcm9jZXNzLlBvcGVuKFthMTF5X3JlZ2lzdHJ5ZF9wYXRoXSwgZW52 PXRlc3RfZW52KQogICAgICAgICAgICAgICAgICAgICBhMTF5X3JlZ2lzdHJ5ZF9ydW5uaW5nID0g VHJ1ZQogICAgICAgICAgICAgICAgIGV4Y2VwdDoKICAgICAgICAgICAgICAgICAgICAgc3lzLnN0 ZGVyci53cml0ZSgiRmFpbGVkIHRvIHJ1biB0aGUgYWNjZXNzaWJpbGl0eSByZWdpc3RyeVxuIikK ICAgICAgICAgICAgICAgICAgICAgc3lzLnN0ZGVyci5mbHVzaCgpCiAKICAgICAgICAgICAgIGZv ciB0ZXN0IGluIHNlbGYuX3Rlc3RzOgotICAgICAgICAgICAgICAgIG91dCA9IHNlbGYuX2V4ZWN1 dGl2ZS5ydW5fY29tbWFuZChbamhidWlsZF9wYXRoICwnZ3Rlc3RlcicsIHRlc3RdLCBlbnY9dGVz dF9lbnYsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGVycm9yX2hhbmRsZXI9X2Vycm9yX2hhbmRsZXIpCisgICAgICAgICAgICAgICAgcHJvY2VzcyA9 IHN1YnByb2Nlc3MuUG9wZW4oW2poYnVpbGRfcGF0aCAsJ2d0ZXN0ZXInLCB0ZXN0XSwgZW52PXRl c3RfZW52LCBzdGRvdXQ9c3VicHJvY2Vzcy5QSVBFKQorICAgICAgICAgICAgICAgIG91dCA9IHBy b2Nlc3MuY29tbXVuaWNhdGUoKVswXQogICAgICAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUo b3V0KQogICAgICAgICAgICAgICAgIHN5cy5zdGRvdXQuZmx1c2goKQogCisgICAgICAgICAgICAg ICAgaWYgcHJvY2Vzcy53YWl0KCk6CisgICAgICAgICAgICAgICAgICAgIGZhaWxlZF90ZXN0cy5h cHBlbmQodGVzdCkKKwogICAgICAgICAgICAgICAgIGlmIGNoZWNrX2JhaWxvdXQoKToKICAgICAg ICAgICAgICAgICAgICAgdGltZWRfb3V0ID0gVHJ1ZQogICAgICAgICAgICAgICAgICAgICBicmVh awpAQCAtMTc3LDcgKzE3OCw3IEBAIGNsYXNzIFRlc3RSdW5uZXI6CiAKIGlmIF9fbmFtZV9fID09 ICJfX21haW5fXyI6CiAgICAgdHJ5OgotICAgICAgICB4dmZiID0gRXhlY3V0aXZlKCkucG9wZW4o WyJYdmZiIiwgIjo1NSIsICItc2NyZWVuIiwgIjAiLCAiODAweDYwMHgyNCIsICItbm9saXN0ZW4i LCAidGNwIl0sCisgICAgICAgIHh2ZmIgPSBzdWJwcm9jZXNzLlBvcGVuKFsiWHZmYiIsICI6NTUi LCAiLXNjcmVlbiIsICIwIiwgIjgwMHg2MDB4MjQiLCAiLW5vbGlzdGVuIiwgInRjcCJdLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwgc3Rk ZXJyPXN1YnByb2Nlc3MuUElQRSkKICAgICBleGNlcHQ6CiAgICAgICAgIHN5cy5zdGRlcnIud3Jp dGUoIkZhaWxlZCB0byBydW4gWHZmYlxuIikKLS0gCjEuNy45LjE=