80492 2012-03-06 22:45:01 -0800 [Qt] Fix the SH4 build after r109834 2012-03-09 04:45:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 80354 1 ossy webkit-unassigned abecsi fu hausmann kenneth loki oliver ossy thouraya.andolsi webkit.review.bot zecke zherczeg oldest_to_newest 572549 0 ossy 2012-03-06 22:45:01 -0800 http://trac.webkit.org/changeset/109834 broke the ARM/MIPS/SH4 build because their macroassemblers are incomplete. It is a P1/blocker bug, because now nobody can build trunk WebKit for Qt-ARM (eg. for N9) 572550 1 ossy 2012-03-06 22:50:57 -0800 Missing functions from MacroAssemblerARM: - ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerARM::ResultCondition, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&)' - ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerARM::ResultCondition, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID&)' Missing functions from MacroAssemblerMIPS: - ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerMIPS::ResultCondition, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&)' - ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerMIPS::ResultCondition, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::MIPSAssembler>::RegisterID&)' Missing functions from MacroAssemblerSH4: - ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:624:68: error: no matching function for call to 'JSC::JIT::branchAdd32(JSC::MacroAssemblerSH4::ResultCondition, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&)' - ../../../../Source/JavaScriptCore/jit/JITArithmetic32_64.cpp:738:68: error: no matching function for call to 'JSC::JIT::branchSub32(JSC::MacroAssemblerSH4::ResultCondition, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&, JSC::AbstractMacroAssembler<JSC::SH4Assembler>::Imm32, const JSC::AbstractMacroAssembler<JSC::SH4Assembler>::RegisterID&)' 572555 2 oliver 2012-03-06 22:53:50 -0800 Sigh, I'll hit it with a stick in the morning. 572558 3 ossy 2012-03-06 22:54:50 -0800 fu@mips.com, thouraya.andolsi@st.com 572560 4 ossy 2012-03-06 22:56:00 -0800 (In reply to comment #3) > fu@mips.com, thouraya.andolsi@st.com Oooop, copy/paste error. :) I cc-ed MIPS and SH4 guys too. 572756 5 hausmann 2012-03-07 03:31:00 -0800 ARM fix landed in http://trac.webkit.org/changeset/110044 572865 6 ossy 2012-03-07 07:09:59 -0800 cc Holger too, he might be interested in fixing MIPS and SH4 platforms. 573409 7 130734 fu 2012-03-07 17:39:51 -0800 Created attachment 130734 Add MIPS branch(Add,Sub)32 functions Hi, Here is a MIPS patch. Thanks! Regards, Chao-ying 573608 8 130734 webkit.review.bot 2012-03-07 22:15:17 -0800 Comment on attachment 130734 Add MIPS branch(Add,Sub)32 functions Clearing flags on attachment: 130734 Committed r110147: <http://trac.webkit.org/changeset/110147> 573609 9 webkit.review.bot 2012-03-07 22:15:22 -0800 All reviewed patches have been landed. Closing bug. 573757 10 ossy 2012-03-08 03:45:02 -0800 Reopen to fix SH4 build too. 573835 11 130822 thouraya.andolsi 2012-03-08 07:59:27 -0800 Created attachment 130822 fix for sh4 platform 574794 12 130822 zherczeg 2012-03-09 03:44:39 -0800 Comment on attachment 130822 fix for sh4 platform r=me 574815 13 130822 webkit.review.bot 2012-03-09 04:45:36 -0800 Comment on attachment 130822 fix for sh4 platform Clearing flags on attachment: 130822 Committed r110289: <http://trac.webkit.org/changeset/110289> 574816 14 webkit.review.bot 2012-03-09 04:45:47 -0800 All reviewed patches have been landed. Closing bug. 130734 2012-03-07 17:39:51 -0800 2012-03-07 22:15:17 -0800 Add MIPS branch(Add,Sub)32 functions mips20120307.diff text/plain 3113 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEwMTIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEyLTAzLTA3ICBDaGFvLXluZyBGdSAgPGZ1QG1pcHMuY29tPgorCisgICAgICAgIFtRdF0g Rml4IHRoZSBNSVBTL1NINCBidWlsZCBhZnRlciByMTA5ODM0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDQ5MgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCB0aHJlZS1hcmd1bWVudCBicmFu Y2goQWRkLFN1YikzMi4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMu aDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjphZGQzMik6CisgICAgICAgIChN YWNyb0Fzc2VtYmxlck1JUFMpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6OnN1 YjMyKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpicmFuY2hBZGQzMik6Cisg ICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6YnJhbmNoU3ViMzIpOgorCiAyMDEyLTAz LTA2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgRnVydGhlciBo YXJkZW4gNjQtYml0IEpJVApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlck1JUFMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCShyZXZpc2lvbiAxMTAxMjApCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCSh3b3JraW5n IGNvcHkpCkBAIC0xMzIsNiArMTMyLDExIEBAIHB1YmxpYzoKICAgICAgICAgfQogICAgIH0KIAor ICAgIHZvaWQgYWRkMzIoUmVnaXN0ZXJJRCBzcmMsIFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVy SUQgZGVzdCkKKyAgICB7CisgICAgICAgIGFkZDMyKGltbSwgc3JjLCBkZXN0KTsKKyAgICB9CisK ICAgICB2b2lkIGFkZDMyKFRydXN0ZWRJbW0zMiBpbW0sIEFkZHJlc3MgYWRkcmVzcykKICAgICB7 CiAgICAgICAgIGlmIChhZGRyZXNzLm9mZnNldCA+PSAtMzI3NjggJiYgYWRkcmVzcy5vZmZzZXQg PD0gMzI3NjcKQEAgLTM2OCw2ICszNzMsMjQgQEAgcHVibGljOgogICAgICAgICB9CiAgICAgfQog CisgICAgdm9pZCBzdWIzMihSZWdpc3RlcklEIHNyYywgVHJ1c3RlZEltbTMyIGltbSwgUmVnaXN0 ZXJJRCBkZXN0KQorICAgIHsKKyAgICAgICAgaWYgKCFpbW0ubV9pc1BvaW50ZXIgJiYgaW1tLm1f dmFsdWUgPj0gLTMyNzY3ICYmIGltbS5tX3ZhbHVlIDw9IDMyNzY4CisgICAgICAgICAgICAmJiAh bV9maXhlZFdpZHRoKSB7CisgICAgICAgICAgICAvKgorICAgICAgICAgICAgICBhZGRpdSAgICAg ZGVzdCwgc3JjLCBpbW0KKyAgICAgICAgICAgICovCisgICAgICAgICAgICBtX2Fzc2VtYmxlci5h ZGRpdShkZXN0LCBzcmMsIC1pbW0ubV92YWx1ZSk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICAvKgorICAgICAgICAgICAgICBsaSAgICAgICAgaW1tVGVtcCwgaW1tCisgICAgICAgICAg ICAgIHN1YnUgICAgICBkZXN0LCBzcmMsIGltbVRlbXAKKyAgICAgICAgICAgICovCisgICAgICAg ICAgICBtb3ZlKGltbSwgaW1tVGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgICAgIG1fYXNzZW1ibGVy LnN1YnUoZGVzdCwgc3JjLCBpbW1UZW1wUmVnaXN0ZXIpOworICAgICAgICB9CisgICAgfQorCiAg ICAgdm9pZCBzdWIzMihUcnVzdGVkSW1tMzIgaW1tLCBBZGRyZXNzIGFkZHJlc3MpCiAgICAgewog ICAgICAgICBpZiAoYWRkcmVzcy5vZmZzZXQgPj0gLTMyNzY4ICYmIGFkZHJlc3Mub2Zmc2V0IDw9 IDMyNzY3CkBAIC0xMjAzLDYgKzEyMjYsMTMgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYnJh bmNoQWRkMzIoY29uZCwgaW1tVGVtcFJlZ2lzdGVyLCBkZXN0KTsKICAgICB9CiAKKyAgICBKdW1w IGJyYW5jaEFkZDMyKFJlc3VsdENvbmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIHNyYywgVHJ1c3Rl ZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBkZXN0KQorICAgIHsKKyAgICAgICAgbW92ZShpbW0sIGlt bVRlbXBSZWdpc3Rlcik7CisgICAgICAgIG1vdmUoc3JjLCBkZXN0KTsKKyAgICAgICAgcmV0dXJu IGJyYW5jaEFkZDMyKGNvbmQsIGltbVRlbXBSZWdpc3RlciwgZGVzdCk7CisgICAgfQorCiAgICAg SnVtcCBicmFuY2hNdWwzMihSZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJRCBzcmMsIFJl Z2lzdGVySUQgZGVzdCkKICAgICB7CiAgICAgICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxvdykg fHwgKGNvbmQgPT0gU2lnbmVkKSB8fCAoY29uZCA9PSBaZXJvKSB8fCAoY29uZCA9PSBOb25aZXJv KSk7CkBAIC0xMzA4LDYgKzEzMzgsMTMgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYnJhbmNo U3ViMzIoY29uZCwgaW1tVGVtcFJlZ2lzdGVyLCBkZXN0KTsKICAgICB9CiAKKyAgICBKdW1wIGJy YW5jaFN1YjMyKFJlc3VsdENvbmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIHNyYywgVHJ1c3RlZElt bTMyIGltbSwgUmVnaXN0ZXJJRCBkZXN0KQorICAgIHsKKyAgICAgICAgbW92ZShpbW0sIGltbVRl bXBSZWdpc3Rlcik7CisgICAgICAgIG1vdmUoc3JjLCBkZXN0KTsKKyAgICAgICAgcmV0dXJuIGJy YW5jaFN1YjMyKGNvbmQsIGltbVRlbXBSZWdpc3RlciwgZGVzdCk7CisgICAgfQorCiAgICAgSnVt cCBicmFuY2hPcjMyKFJlc3VsdENvbmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIHNyYywgUmVnaXN0 ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgQVNTRVJUKChjb25kID09IFNpZ25lZCkgfHwgKGNv bmQgPT0gWmVybykgfHwgKGNvbmQgPT0gTm9uWmVybykpOwo= 130822 2012-03-08 07:59:27 -0800 2012-03-09 04:45:36 -0800 fix for sh4 platform 0001-SH4-fix.patch text/plain 2799 thouraya.andolsi RnJvbSA2NzVkZjBhOGM2ZjAwZDkxZWEzMjVlODJiY2QzZWMzM2EyZDFlNzU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaG91cmF5YSBBTkRPTFNJIDx0aG91cmF5YS5hbmRvbHNpQHN0 LmNvbT4KRGF0ZTogVGh1LCA4IE1hciAyMDEyIDE1OjQyOjA5ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gU0g0IGZpeAoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICAgICB8ICAgMTEgKysrKysrCiAuLi4vSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01h Y3JvQXNzZW1ibGVyU0g0LmggICB8ICAgMzUgKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMg Y2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjNjNlOTYyLi41MjhiY2E0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxMi0wMy0wOCAgVGhvdXJheWEgQU5ET0xTSSAgPHRob3VyYXlh LmFuZG9sc2lAc3QuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gRml4IHRoZSBTSDQgYnVpbGQgYWZ0ZXIgcjEwOTgzNAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA0OTIKKworICAgICAgICAq IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2Vt YmxlclNINDo6YnJhbmNoQWRkMzIpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlclNINDo6 YnJhbmNoU3ViMzIpOgorCiAyMDEyLTAzLTA3ICBDaGFvLXluZyBGdSAgPGZ1QG1pcHMuY29tPgog CiAgICAgICAgIFtRdF0gRml4IHRoZSBNSVBTL1NINCBidWlsZCBhZnRlciByMTA5ODM0CmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0 LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgK aW5kZXggOWExZmZjMy4uMmI1YzBjYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaApAQCAtMTU2NSw2ICsxNTY1LDMzIEBAIHB1 YmxpYzoKICAgICAgICAgcmV0dXJuIGJyYW5jaEFkZDMyKGNvbmQsIHNjcmF0Y2hSZWczLCBkZXN0 KTsKICAgICB9CiAKKyAgICBKdW1wIGJyYW5jaEFkZDMyKFJlc3VsdENvbmRpdGlvbiBjb25kLCBS ZWdpc3RlcklEIHNyYywgVHJ1c3RlZEltbTMyIGltbSwgUmVnaXN0ZXJJRCBkZXN0KQorICAgIHsK KyAgICAgICAgQVNTRVJUKChjb25kID09IE92ZXJmbG93KSB8fCAoY29uZCA9PSBTaWduZWQpIHx8 IChjb25kID09IFplcm8pIHx8IChjb25kID09IE5vblplcm8pKTsKKworICAgICAgICBpZiAoc3Jj ICE9IGRlc3QpCisgICAgICAgICAgICBtb3ZlKHNyYywgZGVzdCk7CisKKyAgICAgICAgaWYgKGNv bmQgPT0gT3ZlcmZsb3cpIHsKKyAgICAgICAgICAgIG1vdmUoaW1tLCBzY3JhdGNoUmVnMyk7Cisg ICAgICAgICAgICBtX2Fzc2VtYmxlci5hZGR2bFJlZ1JlZyhzY3JhdGNoUmVnMywgZGVzdCk7Cisg ICAgICAgICAgICByZXR1cm4gYnJhbmNoVHJ1ZSgpOworICAgICAgICB9CisKKyAgICAgICAgYWRk MzIoaW1tLCBkZXN0KTsKKworICAgICAgICBpZiAoY29uZCA9PSBTaWduZWQpIHsKKyAgICAgICAg ICAgIG1fYXNzZW1ibGVyLmNtcHB6KGRlc3QpOworICAgICAgICAgICAgcmV0dXJuIGJyYW5jaEZh bHNlKCk7CisgICAgICAgIH0KKworICAgICAgICBjb21wYXJlMzIoMCwgZGVzdCwgRXF1YWwpOwor CisgICAgICAgIGlmIChjb25kID09IE5vdEVxdWFsKQorICAgICAgICAgICAgcmV0dXJuIGJyYW5j aEZhbHNlKCk7CisgICAgICAgIHJldHVybiBicmFuY2hUcnVlKCk7CisgICAgfQorCiAgICAgSnVt cCBicmFuY2hNdWwzMihSZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJRCBzcmMsIFJlZ2lz dGVySUQgZGVzdCkKICAgICB7CiAgICAgICAgIEFTU0VSVCgoY29uZCA9PSBPdmVyZmxvdykgfHwg KGNvbmQgPT0gU2lnbmVkKSB8fCAoY29uZCA9PSBaZXJvKSB8fCAoY29uZCA9PSBOb25aZXJvKSk7 CkBAIC0xNjQyLDYgKzE2NjksMTQgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYnJhbmNoU3Vi MzIoY29uZCwgc2NyYXRjaFJlZzMsIGRlc3QpOwogICAgIH0KIAorICAgIEp1bXAgYnJhbmNoU3Vi MzIoUmVzdWx0Q29uZGl0aW9uIGNvbmQsIFJlZ2lzdGVySUQgc3JjLCBUcnVzdGVkSW1tMzIgaW1t LCBSZWdpc3RlcklEIGRlc3QpCisgICAgeworICAgICAgICBtb3ZlKGltbSwgc2NyYXRjaFJlZzMp OworICAgICAgICBpZiAoc3JjICE9IGRlc3QpCisgICAgICAgICAgICBtb3ZlKHNyYywgZGVzdCk7 CisgICAgICAgIHJldHVybiBicmFuY2hTdWIzMihjb25kLCBzY3JhdGNoUmVnMywgZGVzdCk7Cisg ICAgfQorCiAgICAgSnVtcCBicmFuY2hPcjMyKFJlc3VsdENvbmRpdGlvbiBjb25kLCBSZWdpc3Rl cklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgQVNTRVJUKChjb25kID09 IFNpZ25lZCkgfHwgKGNvbmQgPT0gWmVybykgfHwgKGNvbmQgPT0gTm9uWmVybykpOwotLSAKMS43 LjIuMwoK