80474 2012-03-06 19:34:21 -0800 Web Inspector: Cannot insert right curly bracket on some keyboards 2012-03-08 12:34:46 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 cem.kocagil+webkit webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 572455 0 cem.kocagil+webkit 2012-03-06 19:34:21 -0800 Right curly brackets cannot be typed on keyboards where the right curly bracket is inserted by using AltGr+0. Instead, this combination has the same effect as ctrl+0 (reset zoom). The changeset that causes the bug: http://trac.webkit.org/changeset/108794/ Patch is on the way 572457 1 130523 cem.kocagil+webkit 2012-03-06 19:42:19 -0800 Created attachment 130523 Patch 572679 2 130523 apavlov 2012-03-07 01:11:08 -0800 Comment on attachment 130523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130523&action=review > Source/WebCore/inspector/front-end/inspector.js:720 > + var hasCtrlOrMeta = WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) && !event.shiftKey && !event.altKey; I would rename the variable into something like "hasOnlyCtrlOrMeta" in order to differentiate it from the "normal" hasCtrlOrMeta checks around the code. Otherwise looks good; thanks for diagnosing and fixing this. 572700 3 130523 pfeldman 2012-03-07 01:47:23 -0800 Comment on attachment 130523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130523&action=review >> Source/WebCore/inspector/front-end/inspector.js:720 >> + var hasCtrlOrMeta = WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) && !event.shiftKey && !event.altKey; > > I would rename the variable into something like "hasOnlyCtrlOrMeta" in order to differentiate it from the "normal" hasCtrlOrMeta checks around the code. Otherwise looks good; thanks for diagnosing and fixing this. Thanks for looking into it. As Alexander suggests, I'd move hasCtrlOrMeta closer to its usage (below the first switch), combined it with the !InspectorFrontendHost.isStub and renamed to something like isValidZoomShortcut. 572913 4 130631 cem.kocagil+webkit 2012-03-07 08:40:39 -0800 Created attachment 130631 Patch 573775 5 cem.kocagil+webkit 2012-03-08 05:09:17 -0800 Updated, waiting for review 574089 6 130631 webkit.review.bot 2012-03-08 12:34:41 -0800 Comment on attachment 130631 Patch Clearing flags on attachment: 130631 Committed r110192: <http://trac.webkit.org/changeset/110192> 574090 7 webkit.review.bot 2012-03-08 12:34:46 -0800 All reviewed patches have been landed. Closing bug. 130523 2012-03-06 19:42:19 -0800 2012-03-07 08:40:39 -0800 Patch bracket.diff text/plain 1400 cem.kocagil+webkit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDAwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTA2ICBDZW0gS29j YWdpbCAgPGNlbS5rb2NhZ2lsQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBD YW5ub3QgaW5zZXJ0IHJpZ2h0IGN1cmx5IGJyYWNrZXQgb24gc29tZSBrZXlib2FyZHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwNDc0CisKKyAgICAg ICAgTWFrZSBzdXJlIG90aGVyIG1vZGlmaWVycyBhcmUgbm90IHByZXNzZWQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duKToK KwogMjAxMi0wMy0wNiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgZml4IGNyYXNoZXMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwkocmV2aXNpb24gMTEwMDAxKQorKysg U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMJKHdvcmtpbmcg Y29weSkKQEAgLTcxNyw3ICs3MTcsNyBAQCBXZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3duID0g ZnVuY3Rpb24oCiAgICAgfQogCiAgICAgdmFyIGlzTWFjID0gV2ViSW5zcGVjdG9yLmlzTWFjKCk7 Ci0gICAgdmFyIGhhc0N0cmxPck1ldGEgPSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5l dmVudEhhc0N0cmxPck1ldGEoZXZlbnQpOworICAgIHZhciBoYXNDdHJsT3JNZXRhID0gV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQuZXZlbnRIYXNDdHJsT3JNZXRhKGV2ZW50KSAmJiAhZXZl bnQuc2hpZnRLZXkgJiYgIWV2ZW50LmFsdEtleTsKICAgICBzd2l0Y2ggKGV2ZW50LmtleUlkZW50 aWZpZXIpIHsKICAgICAgICAgY2FzZSAiVSswMDFCIjogLy8gRXNjYXBlIGtleQogICAgICAgICAg ICAgaWYgKGV2ZW50LnRhcmdldC5oYXNTdHlsZUNsYXNzKCJ0ZXh0LXByb21wdCIpIHx8ICFXZWJJ bnNwZWN0b3IuaXNJbkVkaXRNb2RlKGV2ZW50KSkgewo= 130631 2012-03-07 08:40:39 -0800 2012-03-08 12:34:41 -0800 Patch bracket.diff text/plain 2382 cem.kocagil+webkit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEwMDU2KQorKysgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDMtMDcgIENlbSBL b2NhZ2lsICA8Y2VtLmtvY2FnaWxAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IENhbm5vdCBpbnNlcnQgcmlnaHQgY3VybHkgYnJhY2tldCBvbiBzb21lIGtleWJvYXJkcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA0NzQKKworICAg ICAgICBNYWtlIHN1cmUgb3RoZXIgbW9kaWZpZXJzIGFyZSBub3QgcHJlc3NlZAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL2luc3BlY3Rvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5kb2N1bWVudEtleURvd24p OgorCiAyMDEyLTAzLTA3ICBFbGxpb3QgUG9nZXIgIDxlcG9nZXJAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBbQ2hyb21pdW1dIFJlbW92ZSB1c2Vfc2tpYSBvcHRpb24gZnJvbSBHWVAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzDQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMJKHJl dmlzaW9uIDExMDA1NikKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC03MTcsNyArNzE3LDYgQEAgV2ViSW5zcGVjdG9y LmRvY3VtZW50S2V5RG93biA9IGZ1bmN0aW9uKAogICAgIH0KIAogICAgIHZhciBpc01hYyA9IFdl Ykluc3BlY3Rvci5pc01hYygpOwotICAgIHZhciBoYXNDdHJsT3JNZXRhID0gV2ViSW5zcGVjdG9y LktleWJvYXJkU2hvcnRjdXQuZXZlbnRIYXNDdHJsT3JNZXRhKGV2ZW50KTsKICAgICBzd2l0Y2gg KGV2ZW50LmtleUlkZW50aWZpZXIpIHsKICAgICAgICAgY2FzZSAiVSswMDFCIjogLy8gRXNjYXBl IGtleQogICAgICAgICAgICAgaWYgKGV2ZW50LnRhcmdldC5oYXNTdHlsZUNsYXNzKCJ0ZXh0LXBy b21wdCIpIHx8ICFXZWJJbnNwZWN0b3IuaXNJbkVkaXRNb2RlKGV2ZW50KSkgewpAQCAtNzM5LDIz ICs3MzgsMjcgQEAgV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5RG93biA9IGZ1bmN0aW9uKAogICAg ICAgICAgICAgYnJlYWs7CiAgICAgfQogCisgICAgdmFyIGlzVmFsaWRab29tU2hvcnRjdXQgPSBX ZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5ldmVudEhhc0N0cmxPck1ldGEoZXZlbnQpICYm CisgICAgICAgICFldmVudC5zaGlmdEtleSAmJgorICAgICAgICAhZXZlbnQuYWx0S2V5ICYmCisg ICAgICAgICFJbnNwZWN0b3JGcm9udGVuZEhvc3QuaXNTdHViOwogICAgIHN3aXRjaCAoZXZlbnQu a2V5Q29kZSkgewogICAgICAgICBjYXNlIDEwNzogLy8gKwogICAgICAgICBjYXNlIDE4NzogLy8g KwotICAgICAgICAgICAgaWYgKGhhc0N0cmxPck1ldGEgJiYgIUluc3BlY3RvckZyb250ZW5kSG9z dC5pc1N0dWIpIHsKKyAgICAgICAgICAgIGlmIChpc1ZhbGlkWm9vbVNob3J0Y3V0KSB7CiAgICAg ICAgICAgICAgICAgV2ViSW5zcGVjdG9yLl96b29tSW4oKTsKICAgICAgICAgICAgICAgICBldmVu dC5wcmV2ZW50RGVmYXVsdCgpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIGNhc2UgMTA5OiAvLyAtCiAgICAgICAgIGNhc2UgMTg5OiAvLyAtCi0gICAgICAgICAg ICBpZiAoaGFzQ3RybE9yTWV0YSAmJiAhSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlzU3R1Yikgewor ICAgICAgICAgICAgaWYgKGlzVmFsaWRab29tU2hvcnRjdXQpIHsKICAgICAgICAgICAgICAgICBX ZWJJbnNwZWN0b3IuX3pvb21PdXQoKTsKICAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVm YXVsdCgpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug NDg6IC8vIDAKLSAgICAgICAgICAgIGlmIChoYXNDdHJsT3JNZXRhICYmICFJbnNwZWN0b3JGcm9u dGVuZEhvc3QuaXNTdHViKSB7CisgICAgICAgICAgICBpZiAoaXNWYWxpZFpvb21TaG9ydGN1dCkg ewogICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5fcmVzZXRab29tKCk7CiAgICAgICAgICAg ICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICAgICAgICAgIH0K