80459 2012-03-06 17:25:56 -0800 [chromium] Fix threaded compositing issues in WebGLLayerChromium (except for printing) 2012-04-10 12:19:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80464 82275 1 jamesr jamesr cc-bugs jbauman kbr nduca vangelis webkit.review.bot oldest_to_newest 572321 0 jamesr 2012-03-06 17:25:56 -0800 [chromium] Fix threaded compositing issues in WebGLLayerChromium (except for printing) 572336 1 130490 jamesr 2012-03-06 17:35:39 -0800 Created attachment 130490 Patch 572354 2 jamesr 2012-03-06 17:43:50 -0800 Printing in threaded mode taken care of here: https://bugs.webkit.org/show_bug.cgi?id=80464 Lost context recovery doesn't generally work in threaded mode yet, but it will once https://bugs.webkit.org/show_bug.cgi?id=80100 lands (currently in the commit queue) 572372 3 130490 kbr 2012-03-06 17:58:32 -0800 Comment on attachment 130490 Patch Thanks, this is excellent. Do you want to close https://bugs.webkit.org/show_bug.cgi?id=78129 as a dup of this one? 572375 4 jamesr 2012-03-06 18:00:22 -0800 Yup, I had forgotten about that other bug. Thanks for the quick review! 572377 5 jamesr 2012-03-06 18:00:35 -0800 *** Bug 78129 has been marked as a duplicate of this bug. *** 572393 6 jamesr 2012-03-06 18:13:14 -0800 Committed r109993: <http://trac.webkit.org/changeset/109993> 599485 7 kbr 2012-04-10 12:19:16 -0700 *** Bug 72739 has been marked as a duplicate of this bug. *** 130490 2012-03-06 17:35:39 -0800 2012-03-06 17:58:32 -0800 Patch bug-80459-20120306173538.patch text/plain 6342 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTkwNmY3NjE0ZTYwZWY4 YmI0OGFhYTYyMWFkNTFjMGI0YWUzNTcyNy4uMTBkNjgzMzAwNDRlZTFlNjBkOTVkMzc0MjY0MDFl NGFlZjQ2ZjQwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM2IEBACiAyMDEyLTAzLTA2ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW2Nocm9taXVtXSBG aXggdGhyZWFkZWQgY29tcG9zaXRpbmcgaXNzdWVzIGluIFdlYkdMTGF5ZXJDaHJvbWl1bSAoZXhj ZXB0IGZvciBwcmludGluZykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgwNDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBmaXhlcyBhIGZldyB3cm9uZy10aHJlYWQgaXNzdWVzIGluIFdlYkdMTGF5 ZXJDaHJvbWl1bSBmb3IgdGhyZWFkZWQgY29tcG9zaXRpbmcuICBUaGUga2V5IHJlcXVpcmVtZW50 cyB0aGF0CisgICAgICAgIHRocmVhZGVkIGNvbXBvc2l0aW5nIGltcG9zZXMgb24gTGF5ZXJDaHJv bWl1bSBzdWJjbGFzc2VzIGFyZSB0aGF0IHRoZSBjb21wb3NpdG9yJ3MgY29udGV4dCBjYW4gb25s eSBiZSB1c2VkIGZyb20KKyAgICAgICAgdGhlIGNvbXBvc2l0b3IgdGhyZWFkLCBtZWFuaW5nIGlu c2lkZSBvZiB1cGRhdGVDb21wb3NpdG9yUmVzb3VyY2VzKCkgYW5kIHB1c2hQcm9wZXJ0aWVzVG8o KSwgYW5kIHRoYXQKKyAgICAgICAgbm9uLWNvbXBvc2l0b3IgY29udGV4dHMgY2FuIG9ubHkgYmUg dXNlZCBmcm9tIHRoZSBtYWluIHRocmVhZC4gVGhpcyBtZWFucyBzcGVjaWZpY2FsbHkgdGhhdCB3 ZSBjYW4ndCB1c2UgdGhlCisgICAgICAgIERyYXdpbmdCdWZmZXIncyBjb250ZXh0IGluIGVpdGhl ciBvZiB0aGVzZSB0d28gZnVuY3Rpb25zLgorCisgICAgICAgIFN1bW1hcnkgb2YgY2hhbmdlczoK KyAgICAgICAgKikgTW92ZSB0aGUgcHVibGlzaFRvUGxhdGZvcm1MYXllcigpIGNhbGwgYW5kIHJl bGF0ZWQgbG9naWMgaW5zaWRlIG9mIHBhaW50Q29udGVudHNJZkRpcnR5KCksIHdoaWNoIGlzIGNh bGxlZAorICAgICAgICBvbiB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgICopIE1vdmUgbG9zdCBj b250ZXh0IHRyYWNraW5nIG91dHNpZGUgb2YgZHJhd3NDb250ZW50KCksIHNpbmNlIHRoYXQgZnVu Y3Rpb24gaXMgY2FsbGVkIGZyb20gYm90aCB0aHJlYWRzLCB0byBhCisgICAgICAgIHNlcGFyYXRl IGJvb2wgdGhhdCBpcyB1cGRhdGVkIGFmdGVyIGVhY2ggV2ViR0wgY29tcG9zaXRlIGFuZCBzZXRE cmF3aW5nQnVmZmVyIGNhbGwuCisKKyAgICAgICAgUHJpbnRpbmcgc3RpbGwgZG9lc24ndCB3b3Jr IGluIHRocmVhZGVkIG1vZGUgd2l0aCB0aGlzIHBhdGNoLCBJJ2xsIGFkZHJlc3MgdGhhdCBzZXBh cmF0ZWx5LiBQcmludGluZyBhbmQgbG9zdAorICAgICAgICBjb250ZXh0IHJlY292ZXJ5IHN0aWxs IHdvcmsgYXMgdGhleSBkaWQgaW4gdGhlIHNpbmdsZS10aHJlYWRlZCBwYXRoLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vV2ViR0xMYXllckNocm9taXVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYkdMTGF5ZXJDaHJvbWl1bTo6V2ViR0xMYXllckNocm9taXVtKToK KyAgICAgICAgKFdlYkNvcmU6OldlYkdMTGF5ZXJDaHJvbWl1bTo6ZHJhd3NDb250ZW50KToKKyAg ICAgICAgKFdlYkNvcmU6OldlYkdMTGF5ZXJDaHJvbWl1bTo6cGFpbnRDb250ZW50c0lmRGlydHkp OgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xMYXllckNocm9taXVtOjp1cGRhdGVDb21wb3NpdG9y UmVzb3VyY2VzKToKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMTGF5ZXJDaHJvbWl1bTo6c2V0RHJh d2luZ0J1ZmZlcik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vV2ViR0xM YXllckNocm9taXVtLmg6CisgICAgICAgIChXZWJHTExheWVyQ2hyb21pdW0pOgorCisyMDEyLTAz LTA2ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW2No cm9taXVtXSBOdWxsLWNoZWNrIG1fbGF5ZXJSZW5kZXJlciBpbiBDQ0xheWVyVHJlZUhvc3RJbXBs OjpmaW5pc2hBbGxSZW5kZXJpbmcoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODA0NDUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vV2ViR0xMYXllckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1dlYkdMTGF5ZXJDaHJvbWl1bS5jcHAKaW5k ZXggMmI1ZGZkM2NhY2RkMThkOGI5YTEyZDM3Y2YyZTk3NWE5MGRiY2E1MC4uMzEzY2EwMTg1NWVj MzQ2MDk1YWU5MWVhZTIxNDRlZmRiZDY4MzQ5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vV2ViR0xMYXllckNocm9taXVtLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9XZWJHTExheWVyQ2hyb21p dW0uY3BwCkBAIC01NCw2ICs1NCw3IEBAIFdlYkdMTGF5ZXJDaHJvbWl1bTo6V2ViR0xMYXllckNo cm9taXVtKCkKICAgICAsIG1fdGV4dHVyZUlkKDApCiAgICAgLCBtX3RleHR1cmVDaGFuZ2VkKHRy dWUpCiAgICAgLCBtX3RleHR1cmVVcGRhdGVkKGZhbHNlKQorICAgICwgbV9jb250ZXh0TG9zdChm YWxzZSkKICAgICAsIG1fZHJhd2luZ0J1ZmZlcigwKQogewogfQpAQCAtNjYsMTcgKzY3LDIzIEBA IFdlYkdMTGF5ZXJDaHJvbWl1bTo6fldlYkdMTGF5ZXJDaHJvbWl1bSgpCiAKIGJvb2wgV2ViR0xM YXllckNocm9taXVtOjpkcmF3c0NvbnRlbnQoKSBjb25zdAogewotICAgIHJldHVybiBMYXllckNo cm9taXVtOjpkcmF3c0NvbnRlbnQoKSAmJiBjb250ZXh0KCkgJiYgKGNvbnRleHQoKS0+Z2V0RXh0 ZW5zaW9ucygpLT5nZXRHcmFwaGljc1Jlc2V0U3RhdHVzQVJCKCkgPT0gR3JhcGhpY3NDb250ZXh0 M0Q6Ok5PX0VSUk9SKTsKKyAgICByZXR1cm4gTGF5ZXJDaHJvbWl1bTo6ZHJhd3NDb250ZW50KCkg JiYgIW1fY29udGV4dExvc3Q7CiB9CiAKLXZvaWQgV2ViR0xMYXllckNocm9taXVtOjp1cGRhdGVD b21wb3NpdG9yUmVzb3VyY2VzKEdyYXBoaWNzQ29udGV4dDNEKiByZW5kZXJlckNvbnRleHQsIEND VGV4dHVyZVVwZGF0ZXImKQordm9pZCBXZWJHTExheWVyQ2hyb21pdW06OnBhaW50Q29udGVudHNJ ZkRpcnR5KGNvbnN0IFJlZ2lvbiYpCiB7Ci0gICAgaWYgKCFkcmF3c0NvbnRlbnQoKSkKKyAgICBp ZiAoIWRyYXdzQ29udGVudCgpIHx8ICFtX25lZWRzRGlzcGxheSB8fCAhbV90ZXh0dXJlVXBkYXRl ZCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFtX25lZWRzRGlzcGxheSkKLSAgICAgICAg cmV0dXJuOworICAgIGRyYXdpbmdCdWZmZXIoKS0+cHVibGlzaFRvUGxhdGZvcm1MYXllcigpOwor ICAgIGNvbnRleHQoKS0+bWFya0xheWVyQ29tcG9zaXRlZCgpOworICAgIG1fbmVlZHNEaXNwbGF5 ID0gZmFsc2U7CisgICAgbV90ZXh0dXJlVXBkYXRlZCA9IGZhbHNlOworICAgIG1fY29udGV4dExv c3QgPSBjb250ZXh0KCktPmdldEV4dGVuc2lvbnMoKS0+Z2V0R3JhcGhpY3NSZXNldFN0YXR1c0FS QigpICE9IEdyYXBoaWNzQ29udGV4dDNEOjpOT19FUlJPUjsKK30KIAordm9pZCBXZWJHTExheWVy Q2hyb21pdW06OnVwZGF0ZUNvbXBvc2l0b3JSZXNvdXJjZXMoR3JhcGhpY3NDb250ZXh0M0QqIHJl bmRlcmVyQ29udGV4dCwgQ0NUZXh0dXJlVXBkYXRlciYpCit7CiAgICAgaWYgKG1fdGV4dHVyZUNo YW5nZWQpIHsKICAgICAgICAgcmVuZGVyZXJDb250ZXh0LT5iaW5kVGV4dHVyZShHcmFwaGljc0Nv bnRleHQzRDo6VEVYVFVSRV8yRCwgbV90ZXh0dXJlSWQpOwogICAgICAgICAvLyBTZXQgdGhlIG1p bi1tYWcgZmlsdGVycyB0byBsaW5lYXIgYW5kIHdyYXAgbW9kZXMgdG8gR0xfQ0xBTVBfVE9fRURH RQpAQCAtODcsMTQgKzk0LDYgQEAgdm9pZCBXZWJHTExheWVyQ2hyb21pdW06OnVwZGF0ZUNvbXBv c2l0b3JSZXNvdXJjZXMoR3JhcGhpY3NDb250ZXh0M0QqIHJlbmRlcmVyQ28KICAgICAgICAgcmVu ZGVyZXJDb250ZXh0LT50ZXhQYXJhbWV0ZXJpKEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJE LCBHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV9XUkFQX1QsIEdyYXBoaWNzQ29udGV4dDNEOjpD TEFNUF9UT19FREdFKTsKICAgICAgICAgbV90ZXh0dXJlQ2hhbmdlZCA9IGZhbHNlOwogICAgIH0K LSAgICAvLyBVcGRhdGUgdGhlIGNvbnRlbnRzIG9mIHRoZSB0ZXh0dXJlIHVzZWQgYnkgdGhlIGNv bXBvc2l0b3IuCi0gICAgaWYgKG1fbmVlZHNEaXNwbGF5ICYmIG1fdGV4dHVyZVVwZGF0ZWQpIHsK LSAgICAgICAgLy8gcHVibGlzaFRvUGxhdGZvcm1MYXllciBwcmVwYXJlcyB0aGUgY29udGVudHMg b2YgdGhlIG9mZi1zY3JlZW4gcmVuZGVyIHRhcmdldCBmb3IgdXNlIGJ5IHRoZSBjb21wb3NpdG9y LgotICAgICAgICBkcmF3aW5nQnVmZmVyKCktPnB1Ymxpc2hUb1BsYXRmb3JtTGF5ZXIoKTsKLSAg ICAgICAgY29udGV4dCgpLT5tYXJrTGF5ZXJDb21wb3NpdGVkKCk7Ci0gICAgICAgIG1fbmVlZHNE aXNwbGF5ID0gZmFsc2U7Ci0gICAgICAgIG1fdGV4dHVyZVVwZGF0ZWQgPSBmYWxzZTsKLSAgICB9 CiB9CiAKIHZvaWQgV2ViR0xMYXllckNocm9taXVtOjpwdXNoUHJvcGVydGllc1RvKENDTGF5ZXJJ bXBsKiBsYXllcikKQEAgLTE2Myw2ICsxNjIsNyBAQCB2b2lkIFdlYkdMTGF5ZXJDaHJvbWl1bTo6 c2V0RHJhd2luZ0J1ZmZlcihEcmF3aW5nQnVmZmVyKiBkcmF3aW5nQnVmZmVyKQogICAgIEdyYXBo aWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVzIGF0dHJpYnV0ZXMgPSBjb250ZXh0KCktPmdldENvbnRl eHRBdHRyaWJ1dGVzKCk7CiAgICAgbV9oYXNBbHBoYSA9IGF0dHJpYnV0ZXMuYWxwaGE7CiAgICAg bV9wcmVtdWx0aXBsaWVkQWxwaGEgPSBhdHRyaWJ1dGVzLnByZW11bHRpcGxpZWRBbHBoYTsKKyAg ICBtX2NvbnRleHRMb3N0ID0gY29udGV4dCgpLT5nZXRFeHRlbnNpb25zKCktPmdldEdyYXBoaWNz UmVzZXRTdGF0dXNBUkIoKSAhPSBHcmFwaGljc0NvbnRleHQzRDo6Tk9fRVJST1I7CiB9CiAKIEdy YXBoaWNzQ29udGV4dDNEKiBXZWJHTExheWVyQ2hyb21pdW06OmNvbnRleHQoKSBjb25zdApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vV2ViR0xM YXllckNocm9taXVtLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9XZWJHTExheWVyQ2hyb21pdW0uaAppbmRleCBmNGJiODM5ODE4NTQ2NmU5ZjdjOGI3MzEwOGIz NGVjMDQ4ZDUwMzljLi43NzY4Y2ViYzVhNzg0MDhlZDkzOThhNmI3MjgyN2UxNGJkYmZlZjcxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9XZWJH TExheWVyQ2hyb21pdW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9XZWJHTExheWVyQ2hyb21pdW0uaApAQCAtNTMsNiArNTMsNyBAQCBwdWJsaWM6CiAg ICAgdm9pZCBzZXRUZXh0dXJlSWQodW5zaWduZWQgdGV4dHVyZUlkKSB7IG1fdGV4dHVyZUlkID0g dGV4dHVyZUlkOyB9CiAKICAgICB2aXJ0dWFsIGJvb2wgZHJhd3NDb250ZW50KCkgY29uc3Q7Cisg ICAgdmlydHVhbCB2b2lkIHBhaW50Q29udGVudHNJZkRpcnR5KGNvbnN0IFJlZ2lvbiYpOwogICAg IHZpcnR1YWwgdm9pZCB1cGRhdGVDb21wb3NpdG9yUmVzb3VyY2VzKEdyYXBoaWNzQ29udGV4dDNE KiwgQ0NUZXh0dXJlVXBkYXRlciYpOwogICAgIHZpcnR1YWwgdm9pZCBwdXNoUHJvcGVydGllc1Rv KENDTGF5ZXJJbXBsKik7CiAgICAgdmlydHVhbCB2b2lkIHNldE5lZWRzRGlzcGxheVJlY3QoY29u c3QgRmxvYXRSZWN0Jik7CkBAIC03Myw2ICs3NCw3IEBAIHByaXZhdGU6CiAgICAgdW5zaWduZWQg bV90ZXh0dXJlSWQ7CiAgICAgYm9vbCBtX3RleHR1cmVDaGFuZ2VkOwogICAgIGJvb2wgbV90ZXh0 dXJlVXBkYXRlZDsKKyAgICBib29sIG1fY29udGV4dExvc3Q7CiAKICAgICAvLyBUaGUgRHJhd2lu Z0J1ZmZlciBob2xkaW5nIHRoZSBXZWJHTCBjb250ZW50cyBmb3IgdGhpcyBsYXllci4KICAgICAv LyBBIHJlZmVyZW5jZSBpcyBub3QgaGVsZCBoZXJlLCBiZWNhdXNlIHRoZSBEcmF3aW5nQnVmZmVy IGFscmVhZHkgaG9sZHMK