80450 2012-03-06 16:04:41 -0800 [chromium] REGRESSION(109469): WebGL printing busted 2012-03-06 17:08:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cc-bugs jbauman kbr oldest_to_newest 572241 0 jamesr 2012-03-06 16:04:41 -0800 Post r109469 printing WebGL fails, nothing shows up. 572276 1 jamesr 2012-03-06 16:48:44 -0800 The issue here appears to be switching from using contentChanged() to setNeedsDisplay...() to set the m_textureUpdated bit on WebGLLayerChromium. That bit is used to implement preservesDrawingBuffer semantics, so it's important that it is only set due to a WebGL draw. Unfortunately when printing we synchronously rebuild the compositing tree which triggers a call to GraphicsLayerChromium::setContentsToCanvas() which calls setNeedsDisplay() on the m_contentsLayer. I have no idea why it does this, but that's what breaks printing. I'm pretty confident the fix is to not call setNeedsDisplay() in GLC::setContentsToCanvas(), at least if the new layer == the old one. 572284 2 130476 jamesr 2012-03-06 16:55:52 -0800 Created attachment 130476 Patch 572289 3 130476 kbr 2012-03-06 17:02:07 -0800 Comment on attachment 130476 Patch LGTM as long as it's been tested. 572291 4 jamesr 2012-03-06 17:04:54 -0800 I've manually tested WebGL printing and run the layout / unit tests and things seem to work. Fingers crossed! 572298 5 jamesr 2012-03-06 17:08:27 -0800 Committed r109982: <http://trac.webkit.org/changeset/109982> 130476 2012-03-06 16:55:52 -0800 2012-03-06 17:02:07 -0800 Patch bug-80450-20120306165551.patch text/plain 2059 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ4NjY5OWI3NDY4Y2Q3 ODE1OWRmNzkzNzY3ZmE3OGM1YzBlODVlMS4uMDc5YjNmNjZmZTE3OGYzYmQ1ODU3MDNhODFmN2Ew ODFiMzhjYmY5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTA2ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBS RUdSRVNTSU9OKDEwOTQ2OSk6IFdlYkdMIHByaW50aW5nIGJ1c3RlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA0NTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCBtYXJraW5nIGxheWVycyBhcyBu ZWVkaW5nIGRpc3BsYXkgaW4gc2V0Q29udGVudHNUby4uLigpIHNpbmNlIHRoaXMgYnJlYWtzIFdl YkdMJ3MgZGFtYWdlIHRyYWNraW5nIGFuZCBpcworICAgICAgICB1bm5lY2Vzc2FyeS4KKworICAg ICAgICBUZXN0ZWQgV2ViR0wgcHJpbnRpbmcgbWFudWFsbHkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NMYXllckNocm9taXVtOjpzZXRDb250ZW50c1RvQ2FudmFzKToKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6c2V0Q29udGVudHNUb01lZGlh KToKKwogMjAxMi0wMy0wNiAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIE1ha2UgQ1NTU3R5bGVTZWxlY3Rvcjo6Y29udmVydFRvTGVuZ3RoKCkg YmVoYXZlIG1vcmUgbGlrZSBDU1NQcmltaXRpdmVWYWx1ZTo6Y29udmVydFRvTGVuZ3RoKCkuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9HcmFw aGljc0xheWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vR3JhcGhpY3NMYXllckNocm9taXVtLmNwcAppbmRleCA4NTcxOWRiNzVhYTgyZGRm MGFhYjg2NThkMzdiYzM1ZTg3NzA2YjA0Li5lODc1NDcxMmJmYjU3MmVkNjRhOTE3NjZmNjM2Mzkz Zjg3ODg1NDZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9HcmFwaGljc0xheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0dyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTM4 NCw3ICszODQsNiBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6c2V0Q29udGVudHNUb0Nh bnZhcyhQbGF0Zm9ybUxheWVyKiBwbGF0Zm9ybUxheWVyKQogICAgICAgICAgICAgbV9jb250ZW50 c0xheWVyUHVycG9zZSA9IENvbnRlbnRzTGF5ZXJGb3JDYW52YXM7CiAgICAgICAgICAgICBjaGls ZHJlbkNoYW5nZWQgPSB0cnVlOwogICAgICAgICB9Ci0gICAgICAgIG1fY29udGVudHNMYXllci0+ c2V0TmVlZHNEaXNwbGF5KCk7CiAgICAgICAgIHVwZGF0ZUNvbnRlbnRzUmVjdCgpOwogICAgIH0g ZWxzZSB7CiAgICAgICAgIGlmIChtX2NvbnRlbnRzTGF5ZXIpIHsKQEAgLTQzNCw3ICs0MzMsNiBA QCB2b2lkIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bTo6c2V0Q29udGVudHNUb01lZGlhKFBsYXRmb3Jt TGF5ZXIqIGxheWVyKQogICAgICAgICAgICAgbV9jb250ZW50c0xheWVyUHVycG9zZSA9IENvbnRl bnRzTGF5ZXJGb3JWaWRlbzsKICAgICAgICAgICAgIGNoaWxkcmVuQ2hhbmdlZCA9IHRydWU7CiAg ICAgICAgIH0KLSAgICAgICAgbGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOwogICAgICAgICB1cGRh dGVDb250ZW50c1JlY3QoKTsKICAgICB9IGVsc2UgewogICAgICAgICBpZiAobV9jb250ZW50c0xh eWVyKSB7Cg==