80448 2012-03-06 15:39:57 -0800 [BlackBerry] WebKit rendering problem when show/hide VKB 2012-03-07 11:24:03 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 jkjiang jkjiang manyoso rwlbuis tonikitoo webkit.review.bot oldest_to_newest 572214 0 jkjiang 2012-03-06 15:39:57 -0800 Absolute positioned element with percentage top was rendered as invalid content when show/hide virtual keyboard. PR #141727. 572912 1 130630 jkjiang 2012-03-07 08:39:47 -0800 Created attachment 130630 Patch 572919 2 130630 tonikitoo 2012-03-07 08:48:20 -0800 Comment on attachment 130630 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130630&action=review > Source/WebKit/blackberry/ChangeLog:14 > + > + When setting viewport size, layout happens inside > + WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is > + outside of the code path of "needsLayout" so that the contents are > + not rendered into the backing store. This is a regression of r108718, > + switch back to do the layout inside the public API > + WebPage::setDefaultLayoutSize(). it worries me very my that WebPage::xxx does more than WebPagePrivate:xxx methods :/ please lets fix this in a follow up. 572925 3 jkjiang 2012-03-07 08:53:04 -0800 (In reply to comment #2) > (From update of attachment 130630 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130630&action=review > > > Source/WebKit/blackberry/ChangeLog:14 > > + > > + When setting viewport size, layout happens inside > > + WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is > > + outside of the code path of "needsLayout" so that the contents are > > + not rendered into the backing store. This is a regression of r108718, > > + switch back to do the layout inside the public API > > + WebPage::setDefaultLayoutSize(). > > it worries me very my that WebPage::xxx does more than WebPagePrivate:xxx methods :/ > > please lets fix this in a follow up. OK, I will try it. 573040 4 130630 webkit.review.bot 2012-03-07 11:23:59 -0800 Comment on attachment 130630 Patch Clearing flags on attachment: 130630 Committed r110076: <http://trac.webkit.org/changeset/110076> 573041 5 webkit.review.bot 2012-03-07 11:24:03 -0800 All reviewed patches have been landed. Closing bug. 130630 2012-03-07 08:39:47 -0800 2012-03-07 11:23:59 -0800 Patch bug-80448-20120307113946.patch text/plain 2768 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3Yjk5MzI5YzYyZTU0MTA3ZWEzN2FhMmEwMjFhMzM3YmMzYzAzM2ZjLi45ODc2MmQ5ZjQ3 YWE4YWRjMTEwYzU0ZjA1OTdlY2Y2OGQyOTAxMjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMi0wMy0wNyAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBXZWJLaXQgcmVuZGVyaW5nIHByb2Js ZW0gd2hlbiBzaG93L2hpZGUgVktCCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MDQ0OAorICAgICAgICBSSU0gUFI6IDE0MTcyNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gc2V0dGluZyB2aWV3cG9y dCBzaXplLCBsYXlvdXQgaGFwcGVucyBpbnNpZGUKKyAgICAgICAgV2ViUGFnZVByaXZhdGU6OnNl dERlZmF1bHRMYXlvdXRTaXplKCksIGluIHRoaXMgd2F5LCB0aGUgbGF5b3V0IGlzCisgICAgICAg IG91dHNpZGUgb2YgdGhlIGNvZGUgcGF0aCBvZiAibmVlZHNMYXlvdXQiIHNvIHRoYXQgdGhlIGNv bnRlbnRzIGFyZQorICAgICAgICBub3QgcmVuZGVyZWQgaW50byB0aGUgYmFja2luZyBzdG9yZS4g VGhpcyBpcyBhIHJlZ3Jlc3Npb24gb2YgcjEwODcxOCwKKyAgICAgICAgc3dpdGNoIGJhY2sgdG8g ZG8gdGhlIGxheW91dCBpbnNpZGUgdGhlIHB1YmxpYyBBUEkKKyAgICAgICAgV2ViUGFnZTo6c2V0 RGVmYXVsdExheW91dFNpemUoKS4KKworICAgICAgICBXZSBoYXZlbid0IHVwc3RyZWFtZWQgdGhl IG1hbnVhbCB0ZXN0cyBkaXJlY3RvcnkgeWV0LCB0aGVyZWZvcmUsCisgICAgICAgIHRoZSBuZXcg bWFudWFsIHRlc3QgY2FzZSB3aWxsIGJlIHVwc3RyZWFtZWQgbGF0ZXIuCisKKyAgICAgICAgKiBB cGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2 YXRlOjpzZXREZWZhdWx0TGF5b3V0U2l6ZSk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OldlYlBhZ2U6OnNldERlZmF1bHRMYXlvdXRTaXplKToKKwogMjAxMi0wMy0wNiAgTGlhbmdodWkg Q2hlbiAgPGxpYWNoZW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gU2V0IGNvcnJl Y3QgUmVzb3VyY2VSZXF1ZXN0IHRhcmdldCB0eXBlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvV2ViUGFnZS5jcHAKaW5kZXggZDRiMWE2ZWFiMWVlNzg3MDgxZmU4NmMyZjU3NTBjZjBkNzhk ODg2ZC4uODlmODUwMTIxYzc2YjNlZWNjNTU2ODFlNzc2NGI3ODVmMTgwZGE3NCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0zMzc4LDI1ICszMzc4LDI0IEBA IHZvaWQgV2ViUGFnZTo6c2V0Vmlld3BvcnRTaXplKGNvbnN0IFBsYXRmb3JtOjpJbnRTaXplJiB2 aWV3cG9ydFNpemUsIGJvb2wgZW5zdXJlCiAKIHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldERlZmF1 bHRMYXlvdXRTaXplKGNvbnN0IEludFNpemUmIHNpemUpCiB7Ci0gICAgaWYgKHNpemUgPT0gbV9k ZWZhdWx0TGF5b3V0U2l6ZSkKLSAgICAgICAgcmV0dXJuOwotCiAgICAgSW50U2l6ZSBzY3JlZW5T aXplID0gUGxhdGZvcm06OkdyYXBoaWNzOjpTY3JlZW46OnByaW1hcnlTY3JlZW4oKS0+c2l6ZSgp OwogICAgIEFTU0VSVChzaXplLndpZHRoKCkgPD0gc2NyZWVuU2l6ZS53aWR0aCgpICYmIHNpemUu aGVpZ2h0KCkgPD0gc2NyZWVuU2l6ZS5oZWlnaHQoKSk7CiAgICAgbV9kZWZhdWx0TGF5b3V0U2l6 ZSA9IHNpemUuZXhwYW5kZWRUbyhtaW5pbXVtTGF5b3V0U2l6ZSkuc2hydW5rVG8oc2NyZWVuU2l6 ZSk7Ci0KLSAgICBib29sIG5lZWRzTGF5b3V0ID0gc2V0Vmlld01vZGUodmlld01vZGUoKSk7Ci0g ICAgaWYgKG5lZWRzTGF5b3V0KSB7Ci0gICAgICAgIHNldE5lZWRzTGF5b3V0KCk7Ci0gICAgICAg IGlmICghaXNMb2FkaW5nKCkpCi0gICAgICAgICAgICByZXF1ZXN0TGF5b3V0SWZOZWVkZWQoKTsK LSAgICB9CiB9CiAKIHZvaWQgV2ViUGFnZTo6c2V0RGVmYXVsdExheW91dFNpemUoaW50IHdpZHRo LCBpbnQgaGVpZ2h0KQogewogICAgIEludFNpemUgc2l6ZSh3aWR0aCwgaGVpZ2h0KTsKKyAgICBp ZiAoc2l6ZSA9PSBkLT5tX2RlZmF1bHRMYXlvdXRTaXplKQorICAgICAgICByZXR1cm47CisKICAg ICBkLT5zZXREZWZhdWx0TGF5b3V0U2l6ZShzaXplKTsKKyAgICBib29sIG5lZWRzTGF5b3V0ID0g ZC0+c2V0Vmlld01vZGUoZC0+dmlld01vZGUoKSk7CisgICAgaWYgKG5lZWRzTGF5b3V0KSB7Cisg ICAgICAgIGQtPnNldE5lZWRzTGF5b3V0KCk7CisgICAgICAgIGlmICghZC0+aXNMb2FkaW5nKCkp CisgICAgICAgICAgICBkLT5yZXF1ZXN0TGF5b3V0SWZOZWVkZWQoKTsKKyAgICB9CiB9CiAKIGJv b2wgV2ViUGFnZTo6bW91c2VFdmVudChjb25zdCBQbGF0Zm9ybTo6TW91c2VFdmVudCYgbW91c2VF dmVudCwgYm9vbCogd2hlZWxEZWx0YUFjY2VwdGVkKQo=