80445 2012-03-06 14:56:52 -0800 [chromium] Null-check m_layerRenderer in CCLayerTreeHostImpl::finishAllRendering() 2012-03-06 17:16:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cc-bugs enne nduca vangelis webkit.review.bot oldest_to_newest 572181 0 jamesr 2012-03-06 14:56:52 -0800 [chromium] Null-check m_layerRenderer in CCLayerTreeHostImpl::finishAllRendering() 572182 1 130448 jamesr 2012-03-06 14:57:35 -0800 Created attachment 130448 Patch 572183 2 jamesr 2012-03-06 14:58:13 -0800 This should fix the crash in https://bugs.webkit.org/show_bug.cgi?id=80445. I'm still not quite sure how to construct a good test for it. 572191 3 130448 nduca 2012-03-06 15:08:38 -0800 Comment on attachment 130448 Patch That works. You might do a CCLayerTreeHostTest that does a draw inside CCLayerTreeHostTestHooks::layout()... /me forgets, has the renderer been initialized by then? 572197 4 130448 enne 2012-03-06 15:15:12 -0800 Comment on attachment 130448 Patch I see a clear path where this could happen. If initializing the layer renderer fails, WebViewImpl will call finishAllRendering in response to didRebindGraphicsContext(false). What about a test with a fake proxy that fails to initialize a layer renderer and calls finishAllRendering in response? Are you seeing another case where it could happen? 572201 5 jamesr 2012-03-06 15:20:21 -0800 Yeah, that should do the trick. Will try it... 572221 6 130456 jamesr 2012-03-06 15:45:22 -0800 Created attachment 130456 Patch 572222 7 jamesr 2012-03-06 15:45:47 -0800 I was able to write a more direct unit test - without the CCLayerTreeHostImpl changes, the new unit tests just crashes. 572229 8 130456 enne 2012-03-06 15:51:36 -0800 Comment on attachment 130456 Patch Thanks for the test. :) 572305 9 jamesr 2012-03-06 17:16:17 -0800 Committed r109985: <http://trac.webkit.org/changeset/109985> 130448 2012-03-06 14:57:35 -0800 2012-03-06 15:45:19 -0800 Patch bug-80445-20120306145734.patch text/plain 1407 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5Nzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDVlYzRhYTA5MDI1Yjg2 YzdhZTM0YmVhNDUzYTMzNTJjZTdjYjEzZi4uOTM1NDcxNmMwNDVhY2VhZTgxYmY1NGY4ZGZmNTQz YzQxZTNlOTJhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTA2ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBO dWxsLWNoZWNrIG1fbGF5ZXJSZW5kZXJlciBpbiBDQ0xheWVyVHJlZUhvc3RJbXBsOjpmaW5pc2hB bGxSZW5kZXJpbmcoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODA0NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6ZmluaXNoQWxsUmVu ZGVyaW5nKToKKwogMjAxMi0wMy0wNSAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gSW5pdGlhbGl6ZSBDQ092ZXJkcmF3Q291bnRzIHN0 cnVjdCB0byB6ZXJvCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCmluZGV4 IDFiOTZlNDk1ZGQwOGQ2OTRkYmVmODE5NWUzY2FmNjg4MjVlZTdiZmIuLmU4OWU1YzNjY2MyMGYw YTcwNWNkODcwNTAwNDJkMmZmMmQ5MjU2NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdEltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwCkBAIC0zMTksNyArMzE5LDggQEAgdm9pZCBDQ0xheWVyVHJlZUhvc3RJbXBs OjpkcmF3TGF5ZXJzKCkKIAogdm9pZCBDQ0xheWVyVHJlZUhvc3RJbXBsOjpmaW5pc2hBbGxSZW5k ZXJpbmcoKQogewotICAgIG1fbGF5ZXJSZW5kZXJlci0+ZmluaXNoKCk7CisgICAgaWYgKG1fbGF5 ZXJSZW5kZXJlcikKKyAgICAgICAgbV9sYXllclJlbmRlcmVyLT5maW5pc2goKTsKIH0KIAogYm9v bCBDQ0xheWVyVHJlZUhvc3RJbXBsOjppc0NvbnRleHRMb3N0KCkK 130456 2012-03-06 15:45:22 -0800 2012-03-06 15:51:35 -0800 Patch bug-80445-20120306154521.patch text/plain 3660 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ4NjY5OWI3NDY4Y2Q3 ODE1OWRmNzkzNzY3ZmE3OGM1YzBlODVlMS4uNTk0MjM5MzA1ZWNiMGI1ODQ2MWU3NmM4NmQ4Y2Y3 ZWQ5N2E3OTRkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTA2ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBO dWxsLWNoZWNrIG1fbGF5ZXJSZW5kZXJlciBpbiBDQ0xheWVyVHJlZUhvc3RJbXBsOjpmaW5pc2hB bGxSZW5kZXJpbmcoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODA0NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOdWxsLWNoZWNrIENDTGF5ZXJUcmVlSG9zdEltcGw6Om1fbGF5ZXJSZW5kZXJlciBzaW5j ZSBpdCB3b24ndCBiZSBzZXQgaWYgY29udGV4dCBpbml0aWFsaWF0aW9uIGZhaWxlZCBmb3IgYW55 CisgICAgICAgIHJlYXNvbi4KKworICAgICAgICBDb3ZlcmVkIGJ5IG5ldyB1bml0IHRlc3QgaW4g Q0NMYXllclRyZWVIb3N0SW1wbFRlc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkND TGF5ZXJUcmVlSG9zdEltcGw6OmZpbmlzaEFsbFJlbmRlcmluZyk6CisKIDIwMTItMDMtMDYgIEx1 a2UgTWFjcGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBNYWtl IENTU1N0eWxlU2VsZWN0b3I6OmNvbnZlcnRUb0xlbmd0aCgpIGJlaGF2ZSBtb3JlIGxpa2UgQ1NT UHJpbWl0aXZlVmFsdWU6OmNvbnZlcnRUb0xlbmd0aCgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZwppbmRleCAzZjkyMTk0ZTM0ZDI5MGIyNjI0MzhhODI2Nzg4MjhjM2VlZDQwYmVhLi4yNWRmYjVm YzMyMDU2MDRhMWQ2MmQ2ZWRkMzUwYjAyODY2NjAxYmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTA2ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVz ckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBOdWxsLWNoZWNrIG1fbGF5ZXJS ZW5kZXJlciBpbiBDQ0xheWVyVHJlZUhvc3RJbXBsOjpmaW5pc2hBbGxSZW5kZXJpbmcoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA0NDUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RzL0NDTGF5 ZXJUcmVlSG9zdEltcGxUZXN0LmNwcDoKKyAgICAgICAgKEZha2VXZWJHcmFwaGljc0NvbnRleHQz RE1ha2VDdXJyZW50RmFpbHMpOgorICAgICAgICAoV2ViS2l0OjpGYWtlV2ViR3JhcGhpY3NDb250 ZXh0M0RNYWtlQ3VycmVudEZhaWxzOjptYWtlQ29udGV4dEN1cnJlbnQpOgorICAgICAgICAoV2Vi S2l0KToKKyAgICAgICAgKFdlYktpdDo6VEVTVF9GKToKKwogMjAxMi0wMy0wNiAgRGF2aWQgR3Jv Z2FuICA8ZGdyb2dhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBBZGQgT1ZF UlJJREVzIHRvIFdlYldvcmtlckNsaWVudEltcGwuaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJl ZUhvc3RJbXBsLmNwcAppbmRleCBmNzE1YWUzNWQxN2Y5MGI3NGRiMjJkYzBmM2M5NGU2NjcwNTE5 OTlhLi4xYzVmMjNhOTEwMjU5MDlmNWM4MTY3OTM4YTYyYWE3MmExNjEyMThhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJl ZUhvc3RJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcApAQCAtMzE5LDcgKzMxOSw4IEBAIHZvaWQg Q0NMYXllclRyZWVIb3N0SW1wbDo6ZHJhd0xheWVycygpCiAKIHZvaWQgQ0NMYXllclRyZWVIb3N0 SW1wbDo6ZmluaXNoQWxsUmVuZGVyaW5nKCkKIHsKLSAgICBtX2xheWVyUmVuZGVyZXItPmZpbmlz aCgpOworICAgIGlmIChtX2xheWVyUmVuZGVyZXIpCisgICAgICAgIG1fbGF5ZXJSZW5kZXJlci0+ ZmluaXNoKCk7CiB9CiAKIGJvb2wgQ0NMYXllclRyZWVIb3N0SW1wbDo6aXNDb250ZXh0TG9zdCgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9z dEltcGxUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVI b3N0SW1wbFRlc3QuY3BwCmluZGV4IGVkMDUyYTljM2Q4NjljN2FlOTI3MWY2MTFhMzljNDVhYmE4 YmIyOTcuLjI5MjM4ZDhkNjg5M2E5YTgxYjY0NTk5YTJlNzE3ZmM4M2JiNjc2OTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1w bFRlc3QuY3BwCkBAIC05MTIsNCArOTEyLDE2IEBAIFRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBs VGVzdCwgY29udGV4dExvc3RBbmRSZXN0b3JlZE5vdGlmaWNhdGlvblNlbnRUb0FsbExheWVyCiAg ICAgRVhQRUNUX1RSVUUobGF5ZXIyLT5kaWRMb3NlQW5kUmVjcmVhdGVHcmFwaGljc0NvbnRleHRD YWxsZWQoKSk7CiB9CiAKK2NsYXNzIEZha2VXZWJHcmFwaGljc0NvbnRleHQzRE1ha2VDdXJyZW50 RmFpbHMgOiBwdWJsaWMgRmFrZVdlYkdyYXBoaWNzQ29udGV4dDNEIHsKK3B1YmxpYzoKKyAgICB2 aXJ0dWFsIGJvb2wgbWFrZUNvbnRleHRDdXJyZW50KCkgeyByZXR1cm4gZmFsc2U7IH0KK307CisK K1RFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgZmluaXNoQWxsUmVuZGVyaW5nQWZ0ZXJD b250ZXh0TG9zdCkKK3sKKyAgICAvLyBUaGUgY29udGV4dCBpbml0aWFsaXphdGlvbiB3aWxsIGZh aWwsIGJ1dCB3ZSBzaG91bGQgc3RpbGwgYmUgYWJsZSB0byBjYWxsIGZpbmlzaEFsbFJlbmRlcmlu ZygpIHdpdGhvdXQgYW55IGlsbCBlZmZlY3RzLgorICAgIG1faG9zdEltcGwtPmluaXRpYWxpemVM YXllclJlbmRlcmVyKEdyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZTo6Y3JlYXRlR3JhcGhpY3NDb250 ZXh0RnJvbVdlYkNvbnRleHQoYWRvcHRQdHIobmV3IEZha2VXZWJHcmFwaGljc0NvbnRleHQzRE1h a2VDdXJyZW50RmFpbHMpLCBHcmFwaGljc0NvbnRleHQzRDo6UmVuZGVyRGlyZWN0bHlUb0hvc3RX aW5kb3cpKTsKKyAgICBtX2hvc3RJbXBsLT5maW5pc2hBbGxSZW5kZXJpbmcoKTsKK30KKwogfSAv LyBuYW1lc3BhY2UK