80443 2012-03-06 14:39:07 -0800 Copying old baselines throws an error if the new directory doesn't exist 2012-03-06 18:16:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dpranke webkit.review.bot oldest_to_newest 572159 0 ojan 2012-03-06 14:39:07 -0800 Copying old baselines throws an error if the new directory doesn't exist 572161 1 130445 ojan 2012-03-06 14:40:50 -0800 Created attachment 130445 Patch 572165 2 130445 abarth 2012-03-06 14:43:12 -0800 Comment on attachment 130445 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130445&action=review > Tools/Scripts/webkitpy/common/system/filesystem.py:73 > + self.maybe_make_directory(self.dirname(destination)) copyfile is supposed to just be a wrapper around shutil.copyfile with the same semantics. We should change the callers of copyfile to call maybe_make_directory or provide a new function that does both. 572167 3 ojan 2012-03-06 14:44:44 -0800 (In reply to comment #2) > (From update of attachment 130445 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130445&action=review > > > Tools/Scripts/webkitpy/common/system/filesystem.py:73 > > + self.maybe_make_directory(self.dirname(destination)) > > copyfile is supposed to just be a wrapper around shutil.copyfile with the same semantics. We should change the callers of copyfile to call maybe_make_directory or provide a new function that does both. Why is it important that the semantics match? 572170 4 abarth 2012-03-06 14:47:17 -0800 > Why is it important that the semantics match? The idea behind filesystem is just to be able to mock out access to the real file system. Having the functions match the native python functions means you can read the python docs to see how they work. 572173 5 130447 ojan 2012-03-06 14:50:48 -0800 Created attachment 130447 Patch 572174 6 130447 abarth 2012-03-06 14:51:26 -0800 Comment on attachment 130447 Patch Thanks. 572176 7 ojan 2012-03-06 14:53:43 -0800 Committed r109963: <http://trac.webkit.org/changeset/109963> 572395 8 dpranke 2012-03-06 18:16:12 -0800 I think this change broke test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) on the mac. I'll fix that in a separate change ... 130445 2012-03-06 14:40:50 -0800 2012-03-06 14:50:45 -0800 Patch bug-80443-20120306144049.patch text/plain 2306 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ3ZWQwYjU2MTBiZGY5YThkMTUxODAwYzI5NDZhYTFi YTE0NTRiYS4uYWI5ODAyODEwNWFkMDFkYTQzZWIzOWEwMTRjNTk2MDViZjkzM2M2YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTAzLTA2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgQ29weWluZyBvbGQgYmFzZWxpbmVzIHRocm93cyBhbiBlcnJvciBpZiB0aGUgbmV3IGRpcmVj dG9yeSBkb2Vzbid0IGV4aXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MDQ0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGNvcHlmaWxlIHNob3VsZCBhbHdheSBqdXN0IG1ha2UgdGhlIGRpcmVjdG9yeSBp ZiBpdCBuZWVkcyB0by4KKyAgICAgICAgVGhlcmUgaXMgYXQgbGVhc3Qgb25lIG90aGVyIHNpbWls YXIgYnVnIGluIHdlYmtpdHB5IGluCisgICAgICAgIHJlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0 X3Rlc3RzLiBUaGUgb25seSBkb3duc2lkZSBvZiBkb2luZyB0aGlzCisgICAgICAgIGlzIHRoYXQg d2Ugd2lsbCBjcmVhdGUgZGlyZWN0b3JpZXMgZXZlbiBpbiBlcnJvciBjYXNlcworICAgICAgICAo ZS5nLiB3aGVuIHRoZSBzb3VyY2UgZmlsZSBkb2Vzbid0IGV4aXN0KS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lzdGVtLnB5OgorICAgICAgICAoRmls ZVN5c3RlbS5jb3B5ZmlsZSk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL2ZpbGVzeXN0ZW1fbW9jay5weToKKyAgICAgICAgKE1vY2tGaWxlU3lzdGVtLmNvcHlmaWxl KToKKwogMjAxMi0wMy0wNSAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIEFkZCBhIG1lY2hhbmlzbSB0byByZWJhc2VsaW5lIG5ldyBwb3J0cwpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0ZW0ucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQppbmRleCA2MGI2 ODBjMDY1OTVjZTVlZTYyOTFiOTE0ZTMxZWUwY2I5NDBmM2I4Li45MzFjMTNjMWYzNmUwYTFjZTZj Y2E0OTU2MGViYTM3ZjYyZTQ4NDExIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbS5weQpAQCAtNzAsNiArNzAsNyBAQCBjbGFzcyBGaWxl U3lzdGVtKG9iamVjdCk6CiAgICAgICAgIHJldHVybiBvcy5jaGRpcihwYXRoKQogCiAgICAgZGVm IGNvcHlmaWxlKHNlbGYsIHNvdXJjZSwgZGVzdGluYXRpb24pOgorICAgICAgICBzZWxmLm1heWJl X21ha2VfZGlyZWN0b3J5KHNlbGYuZGlybmFtZShkZXN0aW5hdGlvbikpCiAgICAgICAgIHNodXRp bC5jb3B5ZmlsZShzb3VyY2UsIGRlc3RpbmF0aW9uKQogCiAgICAgZGVmIGRpcm5hbWUoc2VsZiwg cGF0aCk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v ZmlsZXN5c3RlbV9tb2NrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L2ZpbGVzeXN0ZW1fbW9jay5weQppbmRleCA2ZmIxZGNhZWVkNTBlNTA3N2M4NmNhNTM0YTEwZGIy NmNmYzZjNDAyLi5kYzU3MWNlMzRhZmUwMGM1ZmY0MWFlOGIzNDNkMDgwNTFjMmZhY2E5IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmlsZXN5c3RlbV9t b2NrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9maWxlc3lz dGVtX21vY2sucHkKQEAgLTEwNCw2ICsxMDQsOCBAQCBjbGFzcyBNb2NrRmlsZVN5c3RlbShvYmpl Y3QpOgogICAgICAgICBzZWxmLmN3ZCA9IHBhdGgKIAogICAgIGRlZiBjb3B5ZmlsZShzZWxmLCBz b3VyY2UsIGRlc3RpbmF0aW9uKToKKyAgICAgICAgc2VsZi5tYXliZV9tYWtlX2RpcmVjdG9yeShz ZWxmLmRpcm5hbWUoZGVzdGluYXRpb24pKQorCiAgICAgICAgIGlmIG5vdCBzZWxmLmV4aXN0cyhz b3VyY2UpOgogICAgICAgICAgICAgc2VsZi5fcmFpc2Vfbm90X2ZvdW5kKHNvdXJjZSkKICAgICAg ICAgaWYgc2VsZi5pc2Rpcihzb3VyY2UpOgo= 130447 2012-03-06 14:50:48 -0800 2012-03-06 14:51:26 -0800 Patch bug-80443-20120306145047.patch text/plain 3721 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWQ3ZWQwYjU2MTBiZGY5YThkMTUxODAwYzI5NDZhYTFi YTE0NTRiYS4uNGU1Y2NhZGI1NzY1MzhmMzkzNmUyMWNlOGEzMzIwY2M4OTc2MjA4MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTAzLTA2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgQ29weWluZyBvbGQgYmFzZWxpbmVzIHRocm93cyBhbiBlcnJvciBpZiB0aGUgbmV3IGRpcmVj dG9yeSBkb2Vzbid0IGV4aXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MDQ0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEV4aXN0aW5nIHRlc3RzIGNvdmVyIHRoZSBuZXcgY29kZSB3aXRoIHRoZSBmaXgg dG8gZmlsZXN5c3RlbV9tb2NrLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL2ZpbGVzeXN0ZW1fbW9jay5weToKKyAgICAgICAgKE1vY2tGaWxlU3lzdGVtLmNvcHlm aWxlKToKKyAgICAgICAgRml4IHRoZSBtb2NrIHRvIGJldHRlciBtYXRjaCBweXRob24ncyBjb3B5 ZmlsZSBzZW1hbnRpY3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3RvX2JlX21vdmVk L3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5OgorICAgICAgICAoUmViYXNlbGlu ZXIuX2NyZWF0ZV9odG1sX2Jhc2VsaW5lX2ZpbGVzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZS5weToKKyAgICAgICAgKFJlYmFzZWxpbmVUZXN0 Ll9jb3B5X2V4aXN0aW5nX2Jhc2VsaW5lKToKKwogMjAxMi0wMy0wNSAgT2phbiBWYWZhaSAgPG9q YW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhIG1lY2hhbmlzbSB0byByZWJhc2VsaW5l IG5ldyBwb3J0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lz dGVtL2ZpbGVzeXN0ZW1fbW9jay5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9maWxlc3lzdGVtX21vY2sucHkKaW5kZXggNmZiMWRjYWVlZDUwZTUwNzdjODZjYTUzNGEx MGRiMjZjZmM2YzQwMi4uMmZmNjg4YWY3ZWY4NDFkZjg5ZWZmNDc4MDQwNDBhZWNkYWMzMmU1YiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2ZpbGVzeXN0 ZW1fbW9jay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZmls ZXN5c3RlbV9tb2NrLnB5CkBAIC0xMTAsNiArMTEwLDggQEAgY2xhc3MgTW9ja0ZpbGVTeXN0ZW0o b2JqZWN0KToKICAgICAgICAgICAgIHJhaXNlIElPRXJyb3IoZXJybm8uRUlTRElSLCBzb3VyY2Us IG9zLnN0cmVycm9yKGVycm5vLklTRElSKSkKICAgICAgICAgaWYgc2VsZi5pc2RpcihkZXN0aW5h dGlvbik6CiAgICAgICAgICAgICByYWlzZSBJT0Vycm9yKGVycm5vLkVJU0RJUiwgZGVzdGluYXRp b24sIG9zLnN0cmVycm9yKGVycm5vLklTRElSKSkKKyAgICAgICAgaWYgbm90IHNlbGYuZXhpc3Rz KHNlbGYuZGlybmFtZShkZXN0aW5hdGlvbikpOgorICAgICAgICAgICAgcmFpc2UgSU9FcnJvcihl cnJuby5FTk9FTlQsIGRlc3RpbmF0aW9uLCBvcy5zdHJlcnJvcihlcnJuby5FTk9FTlQpKQogCiAg ICAgICAgIHNlbGYuZmlsZXNbZGVzdGluYXRpb25dID0gc2VsZi5maWxlc1tzb3VyY2VdCiAgICAg ICAgIHNlbGYud3JpdHRlbl9maWxlc1tkZXN0aW5hdGlvbl0gPSBzZWxmLmZpbGVzW3NvdXJjZV0K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9fYmVfbW92ZWQvcmViYXNlbGlu ZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3RvX2Jl X21vdmVkL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDI3ZGI3MjAy MjliYjFhZjhkYWQzNjA5ZDBhMzg0NmYyMmI4ZTViMTMuLjk4Mjk5ODc5YWQwNTVmNDE5YTlmYmMy ZWQyZmVjZDMyYTc5MTFlNjIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9f YmVfbW92ZWQvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90b19iZV9tb3ZlZC9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90 ZXN0cy5weQpAQCAtNTUwLDYgKzU1MCw3IEBAIGNsYXNzIFJlYmFzZWxpbmVyKG9iamVjdCk6CiAg ICAgICAgIGJhc2VsaW5lX2ZpbGVuYW1lID0gc2VsZi5fZmlsZXN5c3RlbS5iYXNlbmFtZShiYXNl bGluZV9mdWxscGF0aCkKICAgICAgICAgbmV3X2ZpbGUgPSBnZXRfcmVzdWx0X2ZpbGVfZnVsbHBh dGgoc2VsZi5fZmlsZXN5c3RlbSwgc2VsZi5fb3B0aW9ucy5odG1sX2RpcmVjdG9yeSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmFzZWxpbmVfZmlsZW5hbWUs IHNlbGYuX3BsYXRmb3JtLCAnbmV3JykKKyAgICAgICAgc2VsZi5fZmlsZXN5c3RlbS5tYXliZV9t YWtlX2RpcmVjdG9yeShzZWxmLl9maWxlc3lzdGVtLmRpcm5hbWUobmV3X2ZpbGUpKQogICAgICAg ICBzZWxmLl9maWxlc3lzdGVtLmNvcHlmaWxlKGJhc2VsaW5lX2Z1bGxwYXRoLCBuZXdfZmlsZSkK ICAgICAgICAgX2xvZy5kZWJ1ZygnICBIdG1sOiBjb3BpZWQgbmV3IGJhc2VsaW5lIGZpbGUgZnJv bSAiJXMiIHRvICIlcyIuJywKICAgICAgICAgICAgICAgICAgIGJhc2VsaW5lX2Z1bGxwYXRoLCBu ZXdfZmlsZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9yZWJhc2VsaW5lLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3Jl YmFzZWxpbmUucHkKaW5kZXggZTIyZDlkMDMxOGIxMjI4MzQyMTE0NjExNTA4ZGU4ZThiODlkMzc5 Mi4uZjQ3NDk0YWNkMmZhZTgyNWI4Y2NmZjVkYjI0YTk4NjMzNTU5NDJmMiAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3JlYmFzZWxpbmUucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3JlYmFzZWxpbmUucHkKQEAgLTgw LDYgKzgwLDcgQEAgY2xhc3MgUmViYXNlbGluZVRlc3QoQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1h bmQpOgogICAgICAgICAgICAgcHJpbnQoIkV4aXN0aW5nIGJhc2VsaW5lIGF0ICVzLCBub3QgY29w eWluZyBvdmVyIGl0LiIgJSBuZXdfYmFzZWxpbmUpCiAgICAgICAgIGVsc2U6CiAgICAgICAgICAg ICBwcmludCgiQ29weWluZyBiYXNlbGluZSBmcm9tICVzIHRvICVzLiIgJSAob2xkX2Jhc2VsaW5l LCBuZXdfYmFzZWxpbmUpKQorICAgICAgICAgICAgc2VsZi5fdG9vbC5maWxlc3lzdGVtLm1heWJl X21ha2VfZGlyZWN0b3J5KHNlbGYuX3Rvb2wuZmlsZXN5c3RlbS5kaXJuYW1lKG5ld19iYXNlbGlu ZSkpCiAgICAgICAgICAgICBzZWxmLl90b29sLmZpbGVzeXN0ZW0uY29weWZpbGUob2xkX2Jhc2Vs aW5lLCBuZXdfYmFzZWxpbmUpCiAgICAgICAgICAgICBpZiBub3Qgc2VsZi5fdG9vbC5zY20oKS5l eGlzdHMobmV3X2Jhc2VsaW5lKToKICAgICAgICAgICAgICAgICBzZWxmLl90b29sLnNjbSgpLmFk ZChuZXdfYmFzZWxpbmUpCg==