80440 2012-03-06 13:16:19 -0800 filter-build-webkit needs more filters 2012-03-06 16:33:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino joepeck oldest_to_newest 572094 0 dino 2012-03-06 13:16:19 -0800 A few new build steps are passing through fbwk as errors. 572236 1 130459 dino 2012-03-06 15:59:53 -0800 Created attachment 130459 Patch 572240 2 130459 joepeck 2012-03-06 16:04:34 -0800 Comment on attachment 130459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130459&action=review > Tools/Scripts/filter-build-webkit:154 > + } elsif ($line =~ /^(PhaseScriptExecution|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|ProcessProductPackaging|CodeSign|SymLink|Updating|CompileXIB|StripNIB) ("[^"]+"|\S+)/) { I often see these too. Could you add these? "CopyPlistFile" and "GenerateDSYMFile" 572262 3 dino 2012-03-06 16:33:44 -0800 http://trac.webkit.org/changeset/109975 130459 2012-03-06 15:59:53 -0800 2012-03-06 16:04:33 -0800 Patch fbwk.patch text/plain 3636 dino ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZDdl ZDBiLi5jODdkYzE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMDYgIERlYW4gSmFja3NvbiAgPGRpbm9A YXBwbGUuY29tPgorCisgICAgICAgIGZpbHRlci1idWlsZC13ZWJraXQgbmVlZHMgbW9yZSBmaWx0 ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDQ0 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVk IGFzIG1hbnkgbWlzc2luZyBmaWx0ZXJzIGFzIEkgY291bGQgZmluZCBmb3IgQXBwbGUKKyAgICAg ICAgYnVpbGRzLiBQbHVzIGEgZmV3IG1pbm9yIHN0eWxlIHVwZGF0ZXMuCisKKyAgICAgICAgKiBT Y3JpcHRzL2ZpbHRlci1idWlsZC13ZWJraXQ6CisgICAgICAgIChwcmludExpbmUpOgorCiAyMDEy LTAzLTA1ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIGEg bWVjaGFuaXNtIHRvIHJlYmFzZWxpbmUgbmV3IHBvcnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL2ZpbHRlci1idWlsZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2ZpbHRlci1idWlsZC13ZWJr aXQKaW5kZXggZTM0YjFkNy4uZTcwNWI3NSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9maWx0 ZXItYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdApA QCAtMzQsMTIgKzM0LDEyIEBAIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSBHZXRvcHQ6Okxv bmc7CiB1c2UgVkNTVXRpbHM7CiAKLXVzZSBjb25zdGFudCB7ICAgIAordXNlIGNvbnN0YW50IHsK ICAgICBTVFlMRV9QTEFJTiA9PiAwLAogICAgIFNUWUxFX0hFQURFUiA9PiAxLAogICAgIFNUWUxF X1NVQ0NFU1MgPT4gMiwKICAgICBTVFlMRV9BTEVSVCA9PiAzLAotICAgIAorCiAgICAgSFRNTF9I RUFERVIgPT48PEhUTUxIRUFERVIsCiA8aHRtbD4KICAgICA8aGVhZD4KQEAgLTEyMSw3ICsxMjEs NyBAQCBteSAkYnVpbGRGaW5pc2hlZDsKIG15ICRidWlsZEZhaWxlZCA9IDA7CiB3aGlsZSAobXkg JGxpbmUgPSA8PikgewogICAgIHByaW50IFVORklMVEVSRURfT1VUUFVUX0hBTkRMRSAkbGluZSBp ZiAkbG9nVW5maWx0ZXJlZE91dHB1dDsKLSAgICAKKwogICAgIGNob21wKCRsaW5lKTsKIAogICAg IG5leHQgaWYgJGxpbmUgPX4gL15ccyokLzsKQEAgLTEzOCw2ICsxMzgsOSBAQCB3aGlsZSAobXkg JGxpbmUgPSA8PikgewogICAgIG5leHQgaWYgJGxpbmUgPX4gL14jIExvd2VyIGNhc2UgYWxsIHRo ZSB2YWx1ZXMsIGFzIENTUyB2YWx1ZXMgYXJlIGNhc2UtaW5zZW5zaXRpdmUkLzsKICAgICBuZXh0 IGlmICRsaW5lID1+IC9eaWYgc29ydCAvOwogICAgIG5leHQgaWYgJGxpbmUgPX4gL14gICAgLzsK KyAgICBuZXh0IGlmICRsaW5lID1+IC9ecHJpbnRmIC87CisgICAgbmV4dCBpZiAkbGluZSA9fiAv Xm9mZmxpbmVhc206IE5vdGhpbmcgY2hhbmdlZC87CisgICAgbmV4dCBpZiAkbGluZSA9fiAvXlNo b3dpbmcgZmlyc3QvOwogCiAgICAgaWYgKCRsaW5lID1+IC9ePXsxMH0vKSB7CiAgICAgICAgIHBy aW50TGluZSgkbGluZSwgU1RZTEVfU1VDQ0VTUyk7CkBAIC0xNDgsOSArMTUxLDIwIEBAIHdoaWxl IChteSAkbGluZSA9IDw+KSB7CiAgICAgICAgIHByaW50TGluZSgkbGluZSwgU1RZTEVfUExBSU4p OwogICAgIH0gZWxzaWYgKCRsaW5lID1+IC9cKlwqIEJVSUxEIFNVQ0NFRURFRCBcKlwqLykgewog ICAgICAgICBwcmludExpbmUoIkJ1aWxkIFN1Y2NlZWRlZCIsIFNUWUxFX1NVQ0NFU1MpOwotICAg IH0gZWxzaWYgKCRsaW5lID1+IC9eKFBoYXNlU2NyaXB0RXhlY3V0aW9ufENvbXBpbGVDfERpc3Ry aWJ1dGVkLUNvbXBpbGVDfExkfFBCWENwfENwUmVzb3VyY2V8Q29weVBOR0ZpbGV8Q29weVRpZmZG aWxlfENwSGVhZGVyfFByb2Nlc3Npbmd8UHJvY2Vzc0luZm9QbGlzdEZpbGV8UHJvY2Vzc1BDSHxQ cm9jZXNzUENIXCtcK3xUb3VjaHxMaWJ0b29sfENvcHlTdHJpbmdzRmlsZXxNaWd8Q3JlYXRlVW5p dmVyc2FsQmluYXJ5fEFuYWx5emUpICgiW14iXSsifFxTKykvKSB7CisgICAgfSBlbHNpZiAoJGxp bmUgPX4gL14oUGhhc2VTY3JpcHRFeGVjdXRpb258Q29tcGlsZUN8RGlzdHJpYnV0ZWQtQ29tcGls ZUN8TGR8UEJYQ3B8Q3BSZXNvdXJjZXxDb3B5UE5HRmlsZXxDb3B5VGlmZkZpbGV8Q3BIZWFkZXJ8 UHJvY2Vzc2luZ3xQcm9jZXNzSW5mb1BsaXN0RmlsZXxQcm9jZXNzUENIfFByb2Nlc3NQQ0hcK1wr fFRvdWNofExpYnRvb2x8Q29weVN0cmluZ3NGaWxlfE1pZ3xDcmVhdGVVbml2ZXJzYWxCaW5hcnl8 QW5hbHl6ZXxQcm9jZXNzUHJvZHVjdFBhY2thZ2luZ3xDb2RlU2lnbnxTeW1MaW5rfFVwZGF0aW5n fENvbXBpbGVYSUJ8U3RyaXBOSUIpICgiW14iXSsifFxTKykvKSB7CiAgICAgICAgIG15ICgkY29t bWFuZCwgJHBhdGgpID0gKCQxLCBiYXNlbmFtZSgkMikpOwogICAgICAgICBwcmludExpbmUoIiRj b21tYW5kICRwYXRoIiwgU1RZTEVfUExBSU4pOworICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eXC9c Uys/KHN0cmlwfFdlYkNvcmVFeHBvcnRGaWxlR2VuZXJhdG9yKSAuKj8oXC98XD4gKShcUyspLykg eworICAgICAgICBteSAoJGNvbW1hbmQsICRwYXRoKSA9IChiYXNlbmFtZSgkMSksIGJhc2VuYW1l KCQzKSk7CisgICAgICAgIHByaW50TGluZSgiJGNvbW1hbmQgJHBhdGgiLCBTVFlMRV9QTEFJTik7 CisgICAgfSBlbHNpZiAoJGxpbmUgPX4gL15vZmZsaW5lYXNtXDogLykgeworICAgICAgICBwcmlu dExpbmUoJGxpbmUsIFNUWUxFX1BMQUlOKTsKKyAgICB9IGVsc2lmICgkbGluZSA9fiAvXkdlbmVy YXRpbmcgbWVzc2FnZS4qKGhlYWRlcnxyZWNlaXZlcikgZm9yIChcUyspXC5cLlwuLykgeworICAg ICAgICBteSAoJGNvbW1hbmQsICRwYXRoKSA9ICgkMSwgYmFzZW5hbWUoJDIpKTsKKyAgICAgICAg cHJpbnRMaW5lKCJHZW5lcmF0aW5nIG1lc3NhZ2UgJGNvbW1hbmQgJHBhdGgiLCBTVFlMRV9QTEFJ Tik7CisgICAgfSBlbHNpZiAoJGxpbmUgPX4gL14oXFMrXC9jYykuKj8oXFMrKVwuKG91dHxleHAp LykgeworICAgICAgICBteSAoJGNvbW1hbmQsICRwYXRoKSA9IChiYXNlbmFtZSgkMSksIGJhc2Vu YW1lKCQyKSk7CisgICAgICAgIHByaW50TGluZSgiJGNvbW1hbmQgJHBhdGgiLCBTVFlMRV9QTEFJ Tik7CiAgICAgfSBlbHNlIHsKICAgICAgICAgIyBUaGlzIG9ubHkgZ2V0cyBoaXQgaWYgc3RkZXJy IGlzIHJlZGlyZWN0ZWQgdG8gc3Rkb3V0LgogICAgICAgICBpZiAoJGxpbmUgPX4gL1wqXCogQlVJ TEQgRkFJTEVEIFwqXCovKSB7CkBAIC0xNzAsNyArMTg0LDcgQEAgZXhpdCAkYnVpbGRGYWlsZWQ7 CiBzdWIgcHJpbnRMaW5lKCQkKQogewogICAgIG15ICgkbGluZSwgJHN0eWxlKSA9IEBfOwotICAg IAorCiAgICAgaWYgKCRvdXRwdXRGb3JtYXQgZXEgImh0bWwiKSB7CiAgICAgICAgICRsaW5lID0g ZXNjYXBlSFRNTCgkbGluZSk7CiAgICAgICAgIGlmICAgICgkc3R5bGUgPT0gU1RZTEVfSEVBREVS KSAgeyBwcmludCBPVVRQVVRfSEFORExFICI8aDI+JGxpbmU8L2gyPiI7IH0K