80426 2012-03-06 09:49:06 -0800 [WK2] Make it possible to build without geolocation support 2012-03-07 04:04:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abecsi abecsi hausmann kenneth ossy oldest_to_newest 571923 0 abecsi 2012-03-06 09:49:06 -0800 Add missing guards for GeolocationPermissionRequestManager and co. 571925 1 130397 abecsi 2012-03-06 09:51:01 -0800 Created attachment 130397 proposed patch 572777 2 130397 abecsi 2012-03-07 04:04:12 -0800 Comment on attachment 130397 proposed patch Clearing flags on attachment: 130397 Committed r110046: <http://trac.webkit.org/changeset/110046> 572778 3 abecsi 2012-03-07 04:04:20 -0800 All reviewed patches have been landed. Closing bug. 130397 2012-03-06 09:51:01 -0800 2012-03-07 04:04:12 -0800 proposed patch geolocation_guard_fix.patch text/plain 6670 abecsi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhMjg0YmNkLi4xNDgzNDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTItMDMtMDYgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CisK KyAgICAgICAgW1dLMl0gTWFrZSBpdCBwb3NzaWJsZSB0byBidWlsZCB3aXRob3V0IGdlb2xvY2F0 aW9uIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTgwNDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIG1pc3NpbmcgZ3VhcmRzLgorCisgICAgICAgICogVUlQcm9jZXNzL0dlb2xvY2F0aW9u UGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpHZW9s b2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5OjpkaWRSZWNlaXZlR2VvbG9jYXRp b25QZXJtaXNzaW9uRGVjaXNpb24pOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmNsb3NlKToKKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlkQ3Jhc2gpOgorICAgICAgICAqIFdlYlByb2Nl c3MvR2VvbG9jYXRpb24vR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuY3BwOgor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZTo6V2ViUGFnZSk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmg6CisgICAgICAgIChXZWJQYWdlKToKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbjoKKwogMjAxMi0wMy0wNiAgU2lt b24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBN YWtlIFFRdWlja1dlYlZpZXcncyB1cmwgcHJvcGVydHkgd29yayB3aXRoIGEgZmxpY2thYmxlIHdl YnZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9HZW9sb2NhdGlvblBl cm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9HZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcAppbmRleCAzOGJi ZDZhLi43MWJlYWY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvR2VvbG9j YXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0dlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3Bw CkBAIC02Myw3ICs2MywxMCBAQCB2b2lkIEdlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5h Z2VyUHJveHk6OmRpZFJlY2VpdmVHZW9sb2NhdGlvblBlcm1pc3Npb25EZQogICAgIGlmIChpdCA9 PSBtX3BlbmRpbmdSZXF1ZXN0cy5lbmQoKSkKICAgICAgICAgcmV0dXJuOwogCisjaWYgRU5BQkxF KEdFT0xPQ0FUSU9OKQogICAgIG1fcGFnZS0+cHJvY2VzcygpLT5zZW5kKE1lc3NhZ2VzOjpXZWJQ YWdlOjpEaWRSZWNlaXZlR2VvbG9jYXRpb25QZXJtaXNzaW9uRGVjaXNpb24oZ2VvbG9jYXRpb25J RCwgYWxsb3dlZCksIG1fcGFnZS0+cGFnZUlEKCkpOworI2VuZGlmCisKICAgICBtX3BlbmRpbmdS ZXF1ZXN0cy5yZW1vdmUoaXQpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdl UHJveHkuY3BwCmluZGV4IDI5OWFjMWMuLmE5NWUyOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0zNzQsNyArMzc0LDEwIEBAIHZvaWQgV2ViUGFnZVBy b3h5OjpjbG9zZSgpCiAgICAgICAgIG1fb3BlblBhbmVsUmVzdWx0TGlzdGVuZXIgPSAwOwogICAg IH0KIAorI2lmIEVOQUJMRShHRU9MT0NBVElPTikKICAgICBtX2dlb2xvY2F0aW9uUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyLmludmFsaWRhdGVSZXF1ZXN0cygpOworI2VuZGlmCisKICAgICBtX25v dGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5pbnZhbGlkYXRlUmVxdWVzdHMoKTsK IAogICAgIG1fdG9vbFRpcCA9IFN0cmluZygpOwpAQCAtMzI0OCw3ICszMjUxLDEwIEBAIHZvaWQg V2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlkQ3Jhc2goKQogICAgICAgICBtX29wZW5QYW5lbFJlc3Vs dExpc3RlbmVyID0gbnVsbHB0cjsKICAgICB9CiAKKyNpZiBFTkFCTEUoR0VPTE9DQVRJT04pCiAg ICAgbV9nZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5pbnZhbGlkYXRlUmVxdWVz dHMoKTsKKyNlbmRpZgorCiAgICAgbV9ub3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFn ZXIuaW52YWxpZGF0ZVJlcXVlc3RzKCk7CiAKICAgICBtX3Rvb2xUaXAgPSBTdHJpbmcoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvR2VvbG9jYXRpb24vR2VvbG9jYXRp b25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9HZW9sb2NhdGlvbi9HZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5jcHAKaW5k ZXggMWFjMjNiMS4uZDZiZGI4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9HZW9sb2NhdGlvbi9HZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9HZW9sb2NhdGlvbi9HZW9sb2NhdGlvblBlcm1p c3Npb25SZXF1ZXN0TWFuYWdlci5jcHAKQEAgLTI2LDYgKzI2LDggQEAKICNpbmNsdWRlICJjb25m aWcuaCIKICNpbmNsdWRlICJHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5oIgog CisjaWYgRU5BQkxFKEdFT0xPQ0FUSU9OKQorCiAjaW5jbHVkZSAiV2ViQ29yZUFyZ3VtZW50Q29k ZXJzLmgiCiAjaW5jbHVkZSAiV2ViRnJhbWUuaCIKICNpbmNsdWRlICJXZWJQYWdlLmgiCkBAIC04 OSwzICs5MSw1IEBAIHZvaWQgR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6OmRp ZFJlY2VpdmVHZW9sb2NhdGlvblBlcm1pc3Npb25EZWNpc2lvCiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYktpdAorCisjZW5kaWYgLy8gRU5BQkxFKEdFT0xPQ0FUSU9OKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IGE2OWYwZDcuLjlmOGI0MTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAg LTE5OSw3ICsxOTksOSBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJRCwgY29uc3Qg V2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKICNpZiBQTEFURk9STShRVCkK ICAgICAsIG1fdGFwSGlnaGxpZ2h0Q29udHJvbGxlcih0aGlzKQogI2VuZGlmCisjaWYgRU5BQkxF KEdFT0xPQ0FUSU9OKQogICAgICwgbV9nZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdl cih0aGlzKQorI2VuZGlmCiAgICAgLCBtX3BhZ2VJRChwYWdlSUQpCiAgICAgLCBtX2NhblJ1bkJl Zm9yZVVubG9hZENvbmZpcm1QYW5lbChwYXJhbWV0ZXJzLmNhblJ1bkJlZm9yZVVubG9hZENvbmZp cm1QYW5lbCkKICAgICAsIG1fY2FuUnVuTW9kYWwocGFyYW1ldGVycy5jYW5SdW5Nb2RhbCkKQEAg LTIyNTQsMTAgKzIyNTYsMTIgQEAgdm9pZCBXZWJQYWdlOjpleHRlbmRTYW5kYm94Rm9yRmlsZUZy b21PcGVuUGFuZWwoY29uc3QgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxlJgogfQogI2VuZGlmCiAK KyNpZiBFTkFCTEUoR0VPTE9DQVRJT04pCiB2b2lkIFdlYlBhZ2U6OmRpZFJlY2VpdmVHZW9sb2Nh dGlvblBlcm1pc3Npb25EZWNpc2lvbih1aW50NjRfdCBnZW9sb2NhdGlvbklELCBib29sIGFsbG93 ZWQpCiB7CiAgICAgbV9nZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5kaWRSZWNl aXZlR2VvbG9jYXRpb25QZXJtaXNzaW9uRGVjaXNpb24oZ2VvbG9jYXRpb25JRCwgYWxsb3dlZCk7 CiB9CisjZW5kaWYKIAogdm9pZCBXZWJQYWdlOjpkaWRSZWNlaXZlTm90aWZpY2F0aW9uUGVybWlz c2lvbkRlY2lzaW9uKHVpbnQ2NF90IG5vdGlmaWNhdGlvbklELCBib29sIGFsbG93ZWQpCiB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAppbmRleCBiZDU2MGVj Li5iYzg0ZTM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmgKQEAgLTMyNCw3ICszMjQsMTAgQEAgcHVibGljOgogICAgIFRhcEhpZ2hsaWdodENvbnRyb2xs ZXImIHRhcEhpZ2hsaWdodENvbnRyb2xsZXIoKSB7IHJldHVybiBtX3RhcEhpZ2hsaWdodENvbnRy b2xsZXI7IH0KICNlbmRpZgogCisjaWYgRU5BQkxFKEdFT0xPQ0FUSU9OKQogICAgIEdlb2xvY2F0 aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyJiBnZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlcigpIHsgcmV0dXJuIG1fZ2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI7 IH0KKyNlbmRpZgorCiAgICAgTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyKiBu b3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIoKTsKIAogICAgIHZvaWQgcGFnZURp ZFNjcm9sbCgpOwpAQCAtNjM1LDYgKzYzOCw3IEBAIHByaXZhdGU6CiAjZW5kaWYKIAogICAgIHZv aWQgZGlkUmVjZWl2ZUdlb2xvY2F0aW9uUGVybWlzc2lvbkRlY2lzaW9uKHVpbnQ2NF90IGdlb2xv Y2F0aW9uSUQsIGJvb2wgYWxsb3dlZCk7CisKICAgICB2b2lkIGRpZFJlY2VpdmVOb3RpZmljYXRp b25QZXJtaXNzaW9uRGVjaXNpb24odWludDY0X3Qgbm90aWZpY2F0aW9uSUQsIGJvb2wgYWxsb3dl ZCk7CiAKICAgICB2b2lkIGFkdmFuY2VUb05leHRNaXNzcGVsbGluZyhib29sIHN0YXJ0QmVmb3Jl U2VsZWN0aW9uKTsKQEAgLTc0NSw5ICs3NDksMTIgQEAgcHJpdmF0ZToKICAgICBSZWZQdHI8V2Vi UG9wdXBNZW51PiBtX2FjdGl2ZVBvcHVwTWVudTsKICAgICBSZWZQdHI8V2ViQ29udGV4dE1lbnU+ IG1fY29udGV4dE1lbnU7CiAgICAgUmVmUHRyPFdlYk9wZW5QYW5lbFJlc3VsdExpc3RlbmVyPiBt X2FjdGl2ZU9wZW5QYW5lbFJlc3VsdExpc3RlbmVyOwotICAgIEdlb2xvY2F0aW9uUGVybWlzc2lv blJlcXVlc3RNYW5hZ2VyIG1fZ2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI7CiAg ICAgUmVmUHRyPE5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcj4gbV9ub3RpZmlj YXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI7CiAKKyNpZiBFTkFCTEUoR0VPTE9DQVRJT04p CisgICAgR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIgbV9nZW9sb2NhdGlvblBl cm1pc3Npb25SZXF1ZXN0TWFuYWdlcjsKKyNlbmRpZgorCiAgICAgT3duUHRyPFdlYkNvcmU6OlBy aW50Q29udGV4dD4gbV9wcmludENvbnRleHQ7CiAjaWYgUExBVEZPUk0oR1RLKQogICAgIFJlZlB0 cjxXZWJQcmludE9wZXJhdGlvbkd0az4gbV9wcmludE9wZXJhdGlvbjsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLm1lc3NhZ2VzLmluIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4KaW5kZXgg YzkzYjIwOC4uMmM5NDM2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4KQEAgLTE3OSw5ICsxNzksMTEgQEAgbWVzc2Fn ZXMgLT4gV2ViUGFnZSB7CiAgICAgU2V0U21hcnRJbnNlcnREZWxldGVFbmFibGVkKGJvb2wgaXNT bWFydEluc2VydERlbGV0ZUVuYWJsZWQpOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoR0VPTE9DQVRJ T04pCiAgICAgIyBHZW9sb2NhdGlvbgogICAgIERpZFJlY2VpdmVHZW9sb2NhdGlvblBlcm1pc3Np b25EZWNpc2lvbih1aW50NjRfdCBnZW9sb2NhdGlvbklELCBib29sIGFsbG93ZWQpCi0gICAgCisj ZW5kaWYKKwogICAgICMgTm90aWZpY2F0aW9uCiAgICAgRGlkUmVjZWl2ZU5vdGlmaWNhdGlvblBl cm1pc3Npb25EZWNpc2lvbih1aW50NjRfdCBub3RpZmljYXRpb25JRCwgYm9vbCBhbGxvd2VkKQog Cg==