80425 2012-03-06 08:19:05 -0800 [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture 2012-03-07 08:56:44 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 79119 1 allan.jensen webkit-unassigned abecsi dinu.jacob hausmann webkit.review.bot oldest_to_newest 571875 0 allan.jensen 2012-03-06 08:19:05 -0800 Tapping on any page such as google.com would previously cause the view to zoom in. This no longer happens after the patch in r109575. 572381 1 dinu.jacob 2012-03-06 18:04:00 -0800 Need to set the startScreenPos for the mock touch point. 572386 2 130504 dinu.jacob 2012-03-06 18:05:30 -0800 Created attachment 130504 Patch 572551 3 130504 hausmann 2012-03-06 22:51:54 -0800 Comment on attachment 130504 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130504&action=review > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:196 > + touchPoint.setStartScenePos(m_startScreenPos); You're right, the double tap recognizer uses the start screen pos, but there's a typo in this line where the start_screen_ pos is set on the start_Scene_ pos property. Please fix before landing :) 572815 4 dinu.jacob 2012-03-07 05:22:16 -0800 (In reply to comment #3) > (From update of attachment 130504 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=130504&action=review > > > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:196 > > + touchPoint.setStartScenePos(m_startScreenPos); > > You're right, the double tap recognizer uses the start screen pos, but there's a typo in this line where the start_screen_ pos is set on the start_Scene_ pos property. Please fix before landing :) That was intentional. As canvas translates the touch events we need to set the screen position as the scene position. I can add a comment there. 572821 5 130605 dinu.jacob 2012-03-07 05:28:59 -0800 Created attachment 130605 Updated Patch 572928 6 130605 webkit.review.bot 2012-03-07 08:56:39 -0800 Comment on attachment 130605 Updated Patch Clearing flags on attachment: 130605 Committed r110058: <http://trac.webkit.org/changeset/110058> 572929 7 webkit.review.bot 2012-03-07 08:56:44 -0800 All reviewed patches have been landed. Closing bug. 130504 2012-03-06 18:05:30 -0800 2012-03-07 05:28:59 -0800 Patch 80425.patch text/plain 2095 dinu.jacob ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NTZl NDgzLi5mNTZkNjk1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMtMDYgIERpbnUgSmFjb2IgIDxkaW51Lmph Y29iQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjEwOTU3NSkgQnJva2Ug dGFwLXRvLXpvb20gZ2VzdHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODA0MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTZXQgc3RhcnRTY3JlZW5Qb3MgaW4gbW9jayB0b3VjaCBwb2ludAorCisgICAg ICAgICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5jcHA6CisgICAgICAg IChNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpub3RpZnkpOgorICAgICAgICAqIE1pbmlCcm93c2Vy L3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaDoKKyAgICAgICAgKE1pbmlCcm93c2VyQXBwbGlj YXRpb24pOgorCiAyMDEyLTAzLTA2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgQ29weWluZyBvbGQgYmFzZWxpbmVzIHRocm93cyBhbiBlcnJvciBpZiB0aGUgbmV3 IGRpcmVjdG9yeSBkb2Vzbid0IGV4aXN0CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9x dC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlC cm93c2VyQXBwbGljYXRpb24uY3BwCmluZGV4IGM2YjNlMzUuLmIxYzZmMGUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCisrKyBiL1Rv b2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCkBAIC0xNTksNiAr MTU5LDcgQEAgYm9vbCBNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpub3RpZnkoUU9iamVjdCogdGFy Z2V0LCBRRXZlbnQqIGV2ZW50KQogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAg ICB0b3VjaFBvaW50LnNldFN0YXRlKFF0OjpUb3VjaFBvaW50UHJlc3NlZCk7CiAgICAgICAgICAg ICAgICAgdG91Y2hUeXBlID0gUUV2ZW50OjpUb3VjaEJlZ2luOworICAgICAgICAgICAgICAgIG1f c3RhcnRTY3JlZW5Qb3MgPSBtb3VzZUV2ZW50LT5zY3JlZW5Qb3MoKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFFFdmVudDo6TW91c2VNb3ZlOgpAQCAt MTkyLDYgKzE5Myw4IEBAIGJvb2wgTWluaUJyb3dzZXJBcHBsaWNhdGlvbjo6bm90aWZ5KFFPYmpl Y3QqIHRhcmdldCwgUUV2ZW50KiBldmVudCkKICAgICAgICAgICAgIFFfQVNTRVJUX1goZmFsc2Us ICJtdWx0aS10b3VjaCBtb2NraW5nIiwgInVuaGFuZGxlZCBldmVudCB0eXBlIik7CiAgICAgICAg IH0KIAorICAgICAgICB0b3VjaFBvaW50LnNldFN0YXJ0U2NlbmVQb3MobV9zdGFydFNjcmVlblBv cyk7CisKICAgICAgICAgLy8gVXBkYXRlIGN1cnJlbnQgdG91Y2gtcG9pbnQKICAgICAgICAgbV90 b3VjaFBvaW50cy5pbnNlcnQodG91Y2hQb2ludC5pZCgpLCB0b3VjaFBvaW50KTsKIApkaWZmIC0t Z2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5oIGIvVG9v bHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5oCmluZGV4IGI1NDMwMDQu LmRkNmY4MzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBw bGljYXRpb24uaAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0 aW9uLmgKQEAgLTExMSw2ICsxMTEsNyBAQCBwcml2YXRlOgogCiAgICAgUVBvaW50RiBtX2xhc3RQ b3M7CiAgICAgUVBvaW50RiBtX2xhc3RTY3JlZW5Qb3M7CisgICAgUVBvaW50RiBtX3N0YXJ0U2Ny ZWVuUG9zOwogCiAgICAgUUhhc2g8aW50LCBRVG91Y2hFdmVudDo6VG91Y2hQb2ludD4gbV90b3Vj aFBvaW50czsKICAgICBRU2V0PGludD4gbV9oZWxkVG91Y2hQb2ludHM7Cg== 130605 2012-03-07 05:28:59 -0800 2012-03-07 08:56:39 -0800 Updated Patch 80425.patch text/plain 2182 dinu.jacob ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2NTZl NDgzLi5mNTZkNjk1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMtMDYgIERpbnUgSmFjb2IgIDxkaW51Lmph Y29iQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIFJFR1JFU1NJT04ocjEwOTU3NSkgQnJva2Ug dGFwLXRvLXpvb20gZ2VzdHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODA0MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTZXQgc3RhcnRTY3JlZW5Qb3MgaW4gbW9jayB0b3VjaCBwb2ludAorCisgICAg ICAgICogTWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXJBcHBsaWNhdGlvbi5jcHA6CisgICAgICAg IChNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpub3RpZnkpOgorICAgICAgICAqIE1pbmlCcm93c2Vy L3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaDoKKyAgICAgICAgKE1pbmlCcm93c2VyQXBwbGlj YXRpb24pOgorCiAyMDEyLTAzLTA2ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgQ29weWluZyBvbGQgYmFzZWxpbmVzIHRocm93cyBhbiBlcnJvciBpZiB0aGUgbmV3 IGRpcmVjdG9yeSBkb2Vzbid0IGV4aXN0CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9x dC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlC cm93c2VyQXBwbGljYXRpb24uY3BwCmluZGV4IGM2YjNlMzUuLjU1M2U3MWIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCisrKyBiL1Rv b2xzL01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uY3BwCkBAIC0xNTksNiAr MTU5LDcgQEAgYm9vbCBNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpub3RpZnkoUU9iamVjdCogdGFy Z2V0LCBRRXZlbnQqIGV2ZW50KQogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAg ICB0b3VjaFBvaW50LnNldFN0YXRlKFF0OjpUb3VjaFBvaW50UHJlc3NlZCk7CiAgICAgICAgICAg ICAgICAgdG91Y2hUeXBlID0gUUV2ZW50OjpUb3VjaEJlZ2luOworICAgICAgICAgICAgICAgIG1f c3RhcnRTY3JlZW5Qb3MgPSBtb3VzZUV2ZW50LT5zY3JlZW5Qb3MoKTsKICAgICAgICAgICAgIH0K ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFFFdmVudDo6TW91c2VNb3ZlOgpAQCAt MTkyLDYgKzE5Myw5IEBAIGJvb2wgTWluaUJyb3dzZXJBcHBsaWNhdGlvbjo6bm90aWZ5KFFPYmpl Y3QqIHRhcmdldCwgUUV2ZW50KiBldmVudCkKICAgICAgICAgICAgIFFfQVNTRVJUX1goZmFsc2Us ICJtdWx0aS10b3VjaCBtb2NraW5nIiwgInVuaGFuZGxlZCBldmVudCB0eXBlIik7CiAgICAgICAg IH0KIAorICAgICAgICAvLyBTZXQgdGhlIHNjcmVlbiBwb3MgYXMgdGhlIHNjZW5lIHBvcyBhcyBj YW52YXMgdHJhbnNsYXRlcyB0aGUgdG91Y2ggZXZlbnRzLgorICAgICAgICB0b3VjaFBvaW50LnNl dFN0YXJ0U2NlbmVQb3MobV9zdGFydFNjcmVlblBvcyk7CisKICAgICAgICAgLy8gVXBkYXRlIGN1 cnJlbnQgdG91Y2gtcG9pbnQKICAgICAgICAgbV90b3VjaFBvaW50cy5pbnNlcnQodG91Y2hQb2lu dC5pZCgpLCB0b3VjaFBvaW50KTsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQv TWluaUJyb3dzZXJBcHBsaWNhdGlvbi5oIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvTWluaUJyb3dz ZXJBcHBsaWNhdGlvbi5oCmluZGV4IGI1NDMwMDQuLmRkNmY4MzEgMTAwNjQ0Ci0tLSBhL1Rvb2xz L01pbmlCcm93c2VyL3F0L01pbmlCcm93c2VyQXBwbGljYXRpb24uaAorKysgYi9Ub29scy9NaW5p QnJvd3Nlci9xdC9NaW5pQnJvd3NlckFwcGxpY2F0aW9uLmgKQEAgLTExMSw2ICsxMTEsNyBAQCBw cml2YXRlOgogCiAgICAgUVBvaW50RiBtX2xhc3RQb3M7CiAgICAgUVBvaW50RiBtX2xhc3RTY3Jl ZW5Qb3M7CisgICAgUVBvaW50RiBtX3N0YXJ0U2NyZWVuUG9zOwogCiAgICAgUUhhc2g8aW50LCBR VG91Y2hFdmVudDo6VG91Y2hQb2ludD4gbV90b3VjaFBvaW50czsKICAgICBRU2V0PGludD4gbV9o ZWxkVG91Y2hQb2ludHM7Cg==