80377 2012-03-05 22:18:51 -0800 [BlackBerry] function rename issue after MediaPlayerPrivateBlackBerry.[cpp\h] upstream 2012-03-06 04:59:58 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jonathan.dong.webkit webkit-unassigned charles.wei leoyang.webkit rwlbuis tonikitoo webkit.review.bot oldest_to_newest 571477 0 jonathan.dong.webkit 2012-03-05 22:18:51 -0800 As some of the function names changed in class MediaPlayerPrivate with the upstream of MediaPlayerPrivateBlackBerry.[cpp|h], we should update WebKit/blackberry/Api/WebPage.cpp which uses these functions accordingly. renamed functions in MediaPlayerPrivate: windowGet() -> getWindow() windowPositionGet() -> getWindowPosition() mmrContextNameGet() -> mmrContextName() 571490 1 130294 jonathan.dong.webkit 2012-03-05 22:28:30 -0800 Created attachment 130294 Patch 571729 2 130294 rwlbuis 2012-03-06 04:41:39 -0800 Comment on attachment 130294 Patch LGTM. But maybe window() instead of windowGet(), this would be more webkit style. 571748 3 130294 webkit.review.bot 2012-03-06 04:59:53 -0800 Comment on attachment 130294 Patch Clearing flags on attachment: 130294 Committed r109907: <http://trac.webkit.org/changeset/109907> 571749 4 webkit.review.bot 2012-03-06 04:59:58 -0800 All reviewed patches have been landed. Closing bug. 130294 2012-03-05 22:28:30 -0800 2012-03-06 04:59:53 -0800 Patch bug-80377-20120306142828.patch text/plain 2147 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzNGQ3ZDViODA1MmU1OGYwMTYzNWE0OTQ0MTg2Njg2NDQ4ZDMwNDUyLi44MWU3Y2NkODM3 Zjc4OGZhMjI4YTcyYTVlMjRjYmRjZTNjYWIwM2Q0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wMy0wNSAgSm9uYXRoYW4gRG9uZyAgPGpvbmF0 aGFuLmRvbmdAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBmdW5j dGlvbiByZW5hbWUgaXNzdWUgYWZ0ZXIgTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5bY3Bw XGhdIHVwc3RyZWFtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MDM3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFzIHNvbWUgb2YgdGhlIGZ1bmN0aW9uIG5hbWVzIGNoYW5nZWQgaW4gY2xhc3MgTWVkaWFQ bGF5ZXJQcml2YXRlCisgICAgICAgIHdpdGggdGhlIHVwc3RyZWFtIG9mIE1lZGlhUGxheWVyUHJp dmF0ZUJsYWNrQmVycnkuW2NwcHxoXSwgd2UKKyAgICAgICAgc2hvdWxkIHVwZGF0ZSBXZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgd2hpY2ggdXNlcyB0aGVzZQorICAgICAgICBmdW5j dGlvbnMgYWNjb3JkaW5nbHkuCisgICAgICAgIFJlbmFtZWQgZnVuY3Rpb25zIGluIGNsYXNzIE1l ZGlhUGxheWVyUHJpdmF0ZToKKyAgICAgICAgd2luZG93R2V0KCkgLT4gZ2V0V2luZG93KCkKKyAg ICAgICAgd2luZG93UG9zaXRpb25HZXQoKSAtPiBnZXRXaW5kb3dQb3NpdGlvbigpCisgICAgICAg IG1tckNvbnRleHROYW1lR2V0KCkgLT4gbW1yQ29udGV4dE5hbWUoKQorCisgICAgICAgICogQXBp L1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0 ZTo6ZW50ZXJGdWxsc2NyZWVuRm9yTm9kZSk6CisKIDIwMTItMDMtMDUgIEVsaSBGaWRsZXIgIDxl ZmlkbGVyQHJpbS5jb20+CiAKICAgICAgICAgVGhlIG1pbmltdW0gZm9udCBzaXplIFdlYlNldHRp bmcgc2hvdWxkIGFjdHVhbGx5IGNoYW5nZSB0aGUgTE9HSUNBTCBmb250IHNpemUgaW4gV2ViQ29y ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDUzNzY5MjBm YjUwM2Y1ODkzZDU4NDNlZmRmNDUwZmRiMzJjYzFkNmUuLjU5MzQzOTE3NThiYzBjNmMxMjgzMTZk NGMzMTJlYjc5YzBjMmUyYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdl LmNwcApAQCAtNTQxNCwxNCArNTQxNCwxNCBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjplbnRlckZ1 bGxzY3JlZW5Gb3JOb2RlKE5vZGUqIG5vZGUpCiAgICAgaWYgKCFtbXJQbGF5ZXIpCiAgICAgICAg IHJldHVybjsKIAotICAgIFBsYXRmb3JtOjpHcmFwaGljczo6V2luZG93KiB3aW5kb3cgPSBtbXJQ bGF5ZXItPndpbmRvd0dldCgpOworICAgIFBsYXRmb3JtOjpHcmFwaGljczo6V2luZG93KiB3aW5k b3cgPSBtbXJQbGF5ZXItPmdldFdpbmRvdygpOwogICAgIGlmICghd2luZG93KQogICAgICAgICBy ZXR1cm47CiAKICAgICB1bnNpZ25lZCB4LCB5LCB3aWR0aCwgaGVpZ2h0OwotICAgIG1tclBsYXll ci0+d2luZG93UG9zaXRpb25HZXQoeCwgeSwgd2lkdGgsIGhlaWdodCk7CisgICAgbW1yUGxheWVy LT5nZXRXaW5kb3dQb3NpdGlvbih4LCB5LCB3aWR0aCwgaGVpZ2h0KTsKIAotICAgIGNvbnN0IGNo YXIqIGNvbnRleHROYW1lID0gbW1yUGxheWVyLT5tbXJDb250ZXh0TmFtZUdldCgpOworICAgIGNv bnN0IGNoYXIqIGNvbnRleHROYW1lID0gbW1yUGxheWVyLT5tbXJDb250ZXh0TmFtZSgpOwogICAg IGlmICghY29udGV4dE5hbWUpCiAgICAgICAgIHJldHVybjsKIAo=