80371 2012-03-05 20:04:16 -0800 Checks for dead variables are not sufficient when fixing the expected values in DFG OSR entry 2012-03-05 22:13:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yuqiang.xian webkit-unassigned barraclough fpizlo oldest_to_newest 571400 0 yuqiang.xian 2012-03-05 20:04:16 -0800 A dead variable should be identified when there's no corresponding node in the block referencing it. But we currently failed to catch the case where there are some nodes referencing a variable but those nodes are actually not referenced by others so will be ignored in code generation. In such case we should also consider that variable to be a dead variable in the block and fix the expected values. This would fix the performance regression mentioned in bug 80365. 571419 1 130277 yuqiang.xian 2012-03-05 20:25:01 -0800 Created attachment 130277 proposed patch 571468 2 yuqiang.xian 2012-03-05 22:13:04 -0800 Landed as http://trac.webkit.org/changeset/109859 130277 2012-03-05 20:25:01 -0800 2012-03-05 22:03:47 -0800 proposed patch 80371.patch text/plain 2513 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA5ODM5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDEyLTAzLTA1ICBZdXFpYW5nIFhpYW4gIDx5dXFpYW5nLnhpYW5AaW50ZWwuY29tPgorCisg ICAgICAgIENoZWNrcyBmb3IgZGVhZCB2YXJpYWJsZXMgYXJlIG5vdCBzdWZmaWNpZW50IHdoZW4g Zml4aW5nIHRoZSBleHBlY3RlZAorICAgICAgICB2YWx1ZXMgaW4gREZHIE9TUiBlbnRyeQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAzNzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGRlYWQgdmFyaWFi bGUgc2hvdWxkIGJlIGlkZW50aWZpZWQgd2hlbiB0aGVyZSdzIG5vIG5vZGUgcmVmZXJlbmNpbmcg aXQuCisgICAgICAgIEJ1dCB3ZSBjdXJyZW50bHkgZmFpbGVkIHRvIGNhdGNoIHRoZSBjYXNlIHdo ZXJlIHRoZXJlIGFyZSBzb21lIG5vZGVzCisgICAgICAgIHJlZmVyZW5jaW5nIGEgdmFyaWFibGUg YnV0IHRob3NlIG5vZGVzIGFyZSBhY3R1YWxseSBub3QgcmVmZXJlbmNlZCBieQorICAgICAgICBv dGhlcnMgc28gd2lsbCBiZSBpZ25vcmVkIGluIGNvZGUgZ2VuZXJhdGlvbi4gSW4gc3VjaCBjYXNl IHdlIHNob3VsZAorICAgICAgICBhbHNvIGNvbnNpZGVyIHRoYXQgdmFyaWFibGUgdG8gYmUgYSBk ZWFkIHZhcmlhYmxlIGluIHRoZSBibG9jayBhbmQgZml4CisgICAgICAgIHRoZSBleHBlY3RlZCB2 YWx1ZXMuCisgICAgICAgIFRoaXMgaXMgcGVyZm9ybWFuY2UgbmV1dHJhbCBvbiBTdW5TcGlkZXIs IFY4IGFuZCBLcmFrZW4uCisKKyAgICAgICAgKiBkZmcvREZHSklUQ29tcGlsZXIuaDoKKyAgICAg ICAgKEpTQzo6REZHOjpKSVRDb21waWxlcjo6bm90aWNlT1NSRW50cnkpOgorCiAyMDEyLTAzLTA1 ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBVcGRhdGUgSmF2YVNj cmlwdENvcmUgZmlsZXMgdG8gdXNlIGZ1bGx5LXF1YWxpZmllZCBXVEYgaW5jbHVkZSBwYXRocwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuaAkocmV2aXNp b24gMTA5ODM5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5o CSh3b3JraW5nIGNvcHkpCkBAIC0yOTcsMTIgKzI5NywxMyBAQCBwdWJsaWM6CiAgICAgICAgIC8v IHZhbHVlIG9mIChOb25lLCBbXSkuIEJ1dCB0aGUgb2xkIEpJVCBtYXkgc3Rhc2ggc29tZSB2YWx1 ZXMgdGhlcmUuIFNvIHdlIHJlYWxseQogICAgICAgICAvLyBuZWVkIChUb3AsIFRPUCkuCiAgICAg ICAgIGZvciAoc2l6ZV90IGFyZ3VtZW50ID0gMDsgYXJndW1lbnQgPCBiYXNpY0Jsb2NrLnZhcmlh Ymxlc0F0SGVhZC5udW1iZXJPZkFyZ3VtZW50cygpOyArK2FyZ3VtZW50KSB7Ci0gICAgICAgICAg ICBpZiAoYmFzaWNCbG9jay52YXJpYWJsZXNBdEhlYWQuYXJndW1lbnQoYXJndW1lbnQpID09IE5v Tm9kZSkKKyAgICAgICAgICAgIE5vZGVJbmRleCBub2RlSW5kZXggPSBiYXNpY0Jsb2NrLnZhcmlh Ymxlc0F0SGVhZC5hcmd1bWVudChhcmd1bWVudCk7CisgICAgICAgICAgICBpZiAobm9kZUluZGV4 ID09IE5vTm9kZSB8fCAhbV9ncmFwaFtub2RlSW5kZXhdLnNob3VsZEdlbmVyYXRlKCkpCiAgICAg ICAgICAgICAgICAgZW50cnktPm1fZXhwZWN0ZWRWYWx1ZXMuYXJndW1lbnQoYXJndW1lbnQpLm1h a2VUb3AoKTsKICAgICAgICAgfQogICAgICAgICBmb3IgKHNpemVfdCBsb2NhbCA9IDA7IGxvY2Fs IDwgYmFzaWNCbG9jay52YXJpYWJsZXNBdEhlYWQubnVtYmVyT2ZMb2NhbHMoKTsgKytsb2NhbCkg ewogICAgICAgICAgICAgTm9kZUluZGV4IG5vZGVJbmRleCA9IGJhc2ljQmxvY2sudmFyaWFibGVz QXRIZWFkLmxvY2FsKGxvY2FsKTsKLSAgICAgICAgICAgIGlmIChub2RlSW5kZXggPT0gTm9Ob2Rl KQorICAgICAgICAgICAgaWYgKG5vZGVJbmRleCA9PSBOb05vZGUgfHwgIW1fZ3JhcGhbbm9kZUlu ZGV4XS5zaG91bGRHZW5lcmF0ZSgpKQogICAgICAgICAgICAgICAgIGVudHJ5LT5tX2V4cGVjdGVk VmFsdWVzLmxvY2FsKGxvY2FsKS5tYWtlVG9wKCk7CiAgICAgICAgICAgICBlbHNlIGlmIChtX2dy YXBoW25vZGVJbmRleF0udmFyaWFibGVBY2Nlc3NEYXRhKCktPnNob3VsZFVzZURvdWJsZUZvcm1h dCgpKQogICAgICAgICAgICAgICAgIGVudHJ5LT5tX2xvY2Fsc0ZvcmNlZERvdWJsZS5zZXQobG9j YWwpOwo=