80369 2012-03-05 19:52:46 -0800 [BlackBerry] Don't suspend accel comp when backgrounding a page 2012-03-06 09:10:16 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED http://www.webkit.org/blog-files/3d-transforms/poster-circle.html P2 Normal --- 1 jpetsovits jpetsovits anilsson manyoso tonikitoo webkit.review.bot oldest_to_newest 571388 0 jpetsovits 2012-03-05 19:52:46 -0800 When WebPage::notifyPageBackground() is called, it calls WebPagePrivate::suspendRootLayerCommit() in turn, which not only turns off root layer commits but also frees resources for accelerated compositing. Those resources are not being recreated until WebPagePrivate::resumeRootLayerCommit() is called. Completely suspending root layer commits is wrong, because just because the page has been backgrounded doesn't mean it's not visible anymore, or doesn't have to be redrawn in some cases. Rotation being the prime example when we have to redraw everything. With the current code, a page that's not active is able to redraw backingstore-rendered content, but not composited content. That's something we should fix. 571399 1 130272 jpetsovits 2012-03-05 20:02:59 -0800 Created attachment 130272 Patch: Don't suspend accel comp when backgrounding a page This is the straightforward solution, which just avoids suspending the compositor. It results in accelerated contents being rendered (as in, 'at all'), but I've seen occasional misrenderings for bottom-fixed elements on rotation as well as incorrect rendering in other areas. Not sure if they are a different issue or if this patch is not as correct as it should be. I checked and animations don't show up on screen, but I didn't yet check whether they still occur behind the scenes. In any case, it's an improvement over the current state which is just plain incorrect. 571900 2 130272 webkit.review.bot 2012-03-06 09:10:12 -0800 Comment on attachment 130272 Patch: Don't suspend accel comp when backgrounding a page Clearing flags on attachment: 130272 Committed r109926: <http://trac.webkit.org/changeset/109926> 571901 3 webkit.review.bot 2012-03-06 09:10:16 -0800 All reviewed patches have been landed. Closing bug. 130272 2012-03-05 20:02:59 -0800 2012-03-06 09:10:11 -0800 Patch: Don't suspend accel comp when backgrounding a page bug-80369-20120305230301.patch text/plain 1871 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzNGQ3ZDViODA1MmU1OGYwMTYzNWE0OTQ0MTg2Njg2NDQ4ZDMwNDUyLi5iY2RiNTkwYjZh MjYwYmJiMmYzN2VhMWZlNThlNDI1NTlhZWRkZjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wMy0wNSAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEb24ndCBzdXNwZW5kIGFj Y2VsIGNvbXAgd2hlbiBiYWNrZ3JvdW5kaW5nIGEgcGFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMzY5CisgICAgICAgIFJJTSBQUjogMTM3NjA5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCBi ZWNhdXNlIHRoZSBwYWdlIGlzIGluIHRoZSBiYWNrZ3JvdW5kIGRvZXNuJ3QgbWVhbgorICAgICAg ICBpdCdzIGludmlzaWJsZSwgZG9lc24ndCBtZWFuIGl0IHdvbid0IGhhdmUgdG8gYmUgcmVkcmF3 bgorICAgICAgICBhdCBzb21lIHBvaW50IC0gb24gcm90YXRpb24sIGZvciBpbnN0YW5jZS4KKwor ICAgICAgICBXZSBzdGlsbCBzdXNwZW5kIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG9uIHNldFZp c2libGUoZmFsc2UpLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpub3RpZnlQYWdlQmFja2dyb3VuZCk6CisgICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6Om5vdGlmeVBhZ2VGb3JlZ3JvdW5kKToKKwog MjAxMi0wMy0wNSAgRWxpIEZpZGxlciAgPGVmaWRsZXJAcmltLmNvbT4KIAogICAgICAgICBUaGUg bWluaW11bSBmb250IHNpemUgV2ViU2V0dGluZyBzaG91bGQgYWN0dWFsbHkgY2hhbmdlIHRoZSBM T0dJQ0FMIGZvbnQgc2l6ZSBpbiBXZWJDb3JlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAKaW5kZXggNTM3NjkyMGZiNTAzZjU4OTNkNTg0M2VmZGY0NTBmZGIzMmNjMWQ2 ZS4uMDdlYThiODk5ZDY0ZWY5MjUyYTY3MmJmNGE3ZjZlZjY3ODRkZTUwYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC00OTA4LDIwICs0OTA4LDEyIEBAIHZv aWQgV2ViUGFnZTo6bm90aWZ5UGFnZVJlc3VtZSgpCiAKIHZvaWQgV2ViUGFnZTo6bm90aWZ5UGFn ZUJhY2tncm91bmQoKQogewotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBk LT5zdXNwZW5kUm9vdExheWVyQ29tbWl0KCk7Ci0jZW5kaWYKLQogICAgIEZPUl9FQUNIX1BMVUdJ TlZJRVcoZC0+bV9wbHVnaW5WaWV3cykKICAgICAgICAgKCppdCktPmhhbmRsZUJhY2tncm91bmRF dmVudCgpOwogfQogCiB2b2lkIFdlYlBhZ2U6Om5vdGlmeVBhZ2VGb3JlZ3JvdW5kKCkKIHsKLSNp ZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgZC0+cmVzdW1lUm9vdExheWVyQ29t bWl0KCk7Ci0jZW5kaWYKLQogICAgIEZPUl9FQUNIX1BMVUdJTlZJRVcoZC0+bV9wbHVnaW5WaWV3 cykKICAgICAgICAgKCppdCktPmhhbmRsZUZvcmVncm91bmRFdmVudCgpOwogfQo=