80344 2012-03-05 16:29:15 -0800 GCActivityCallback timer should vary with the length of the previous GC 2012-03-06 13:32:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg ggaren oldest_to_newest 571154 0 mhahnenberg 2012-03-05 16:29:15 -0800 Currently our GC callback timer has a fixed length of 2 seconds. We should change it to be vary based on the length of the previous GC. This will allow us to control at a more fine-grained level exactly how much garbage collection should/is going on at a particular time. 571369 1 130267 mhahnenberg 2012-03-05 19:20:41 -0800 Created attachment 130267 Patch 571916 2 130267 ggaren 2012-03-06 09:44:33 -0800 Comment on attachment 130267 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130267&action=review r=me > Source/JavaScriptCore/heap/Heap.cpp:332 > + , m_lastGCStartTime(0) > + , m_lastGCEndTime(0) These two should just be local variables inside collect(). 572107 3 mhahnenberg 2012-03-06 13:32:38 -0800 Committed r109956: <http://trac.webkit.org/changeset/109956> 130267 2012-03-05 19:20:41 -0800 2012-03-06 09:44:33 -0800 Patch bug-80344-20120305192040.patch text/plain 4206 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5ODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NzQzOGVhZmNhNjkzZjY1NmUwZjYwNDcyYWNkODMxMTM1ZDk1NTUzLi4yZmE0NDkxMGRkZTgyYzBk YjQxNTc1YWFjMzAzMzU5MDgxNTY5ZDA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMi0wMy0wNSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBw bGUuY29tPgorCisgICAgICAgIEdDQWN0aXZpdHlDYWxsYmFjayB0aW1lciBzaG91bGQgdmFyeSB3 aXRoIHRoZSBsZW5ndGggb2YgdGhlIHByZXZpb3VzIEdDCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDM0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDogR2F2ZSBIZWFwIHRoZSBh YmlsaXR5IHRvIGtlZXAgdHJhY2sgb2YgdGhlIGxlbmd0aCBvZiBpdHMgbGFzdCAKKyAgICAgICAg R0MgbGVuZ3RoIHNvIHRoYXQgdGhlIEdDIEFjdGl2aXR5IENhbGxiYWNrIGNhbiB1c2UgaXQuCisg ICAgICAgIChKU0M6OkhlYXA6OkhlYXApOgorICAgICAgICAoSlNDOjpIZWFwOjpjb2xsZWN0KToK KyAgICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAgICAgKEpTQzo6SGVhcDo6bGFzdEdDTGVuZ3Ro KToKKyAgICAgICAgKEhlYXApOgorICAgICAgICAqIHJ1bnRpbWUvR0NBY3Rpdml0eUNhbGxiYWNr Q0YuY3BwOgorICAgICAgICAoSlNDKToKKyAgICAgICAgKEpTQzo6RGVmYXVsdEdDQWN0aXZpdHlD YWxsYmFjazo6b3BlcmF0b3IoKSk6IFVzZSB0aGUgbGVuZ3RoIG9mIHRoZSBIZWFwJ3MgbGFzdCAK KyAgICAgICAgR0MgdG8gZGV0ZXJtaW5lIHRoZSBsZW5ndGggb2Ygb3VyIHRpbWVyIHRyaWdnZXIg KGN1cnJlbnRseSBzZXQgYXQgMTAweCB0aGUgZHVyYXRpb24gCisgICAgICAgIG9mIHRoZSBsYXN0 IEdDKS4KKwogMjAxMi0wMy0wNSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIEFkZCBzdXBwb3J0IGZvciBob3N0aW5nIGxheWVycyBpbiB0aGUgd2luZG93IHNlcnZlciBp biBXZWJLaXQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCmluZGV4IDEzMzNjN2IyYzJj Y2Q5YTBiZjNlNjMzMTJiOWJlYWM5ODc3MzQwM2YuLjkyZmMzMGIzZWJlNTA4ODhmNTMxNDY3M2I3 NmMzM2Q5YjFjYjMwMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hl YXAuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCkBAIC0zMjgs NiArMzI4LDkgQEAgSGVhcDo6SGVhcChKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEsIEhlYXBTaXpl IGhlYXBTaXplKQogICAgICwgbV9oYW5kbGVIZWFwKGdsb2JhbERhdGEpCiAgICAgLCBtX2lzU2Fm ZVRvQ29sbGVjdChmYWxzZSkKICAgICAsIG1fZ2xvYmFsRGF0YShnbG9iYWxEYXRhKQorICAgICwg bV9sYXN0R0NTdGFydFRpbWUoMCkKKyAgICAsIG1fbGFzdEdDRW5kVGltZSgwKQorICAgICwgbV9s YXN0R0NMZW5ndGgoMCkKIHsKICAgICAoKm1fYWN0aXZpdHlDYWxsYmFjaykoKTsKICAgICBtX251 bWJlck9mRnJlZUJsb2NrcyA9IDA7CkBAIC03ODEsNiArNzg0LDcgQEAgdm9pZCBIZWFwOjpjb2xs ZWN0KFN3ZWVwVG9nZ2xlIHN3ZWVwVG9nZ2xlKQogICAgIEFTU0VSVChnbG9iYWxEYXRhKCktPmlk ZW50aWZpZXJUYWJsZSA9PSB3dGZUaHJlYWREYXRhKCkuY3VycmVudElkZW50aWZpZXJUYWJsZSgp KTsKICAgICBBU1NFUlQobV9pc1NhZmVUb0NvbGxlY3QpOwogICAgIEpBVkFTQ1JJUFRDT1JFX0dD X0JFR0lOKCk7CisgICAgbV9sYXN0R0NTdGFydFRpbWUgPSBXVEY6OmN1cnJlbnRUaW1lKCk7CiAj aWYgRU5BQkxFKEdHQykKICAgICBib29sIGZ1bGxHQyA9IHN3ZWVwVG9nZ2xlID09IERvU3dlZXA7 CiAgICAgaWYgKCFmdWxsR0MpCkBAIC04MzUsNiArODM5LDggQEAgdm9pZCBIZWFwOjpjb2xsZWN0 KFN3ZWVwVG9nZ2xlIHN3ZWVwVG9nZ2xlKQogICAgICAgICBtX2xhc3RGdWxsR0NTaXplID0gbmV3 U2l6ZTsKICAgICAgICAgc2V0SGlnaFdhdGVyTWFyayhtYXgocHJvcG9ydGlvbmFsQnl0ZXMsIG1f bWluQnl0ZXNQZXJDeWNsZSkpOwogICAgIH0KKyAgICBtX2xhc3RHQ0VuZFRpbWUgPSBXVEY6OmN1 cnJlbnRUaW1lKCk7CisgICAgbV9sYXN0R0NMZW5ndGggPSBtX2xhc3RHQ0VuZFRpbWUgLSBtX2xh c3RHQ1N0YXJ0VGltZTsKICAgICBKQVZBU0NSSVBUQ09SRV9HQ19FTkQoKTsKIAogICAgICgqbV9h Y3Rpdml0eUNhbGxiYWNrKSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oCmluZGV4IGY4YjA3 ZmU0Yzc4NzRkZjQ2Zjc1OTU3NGU5NzBjZGE0ZDJiM2I1ZDAuLmQwZDBjOTRjNWU0MTM1MDE0N2Y1 NTUzYWYwZjk2M2RkMzAzM2QxZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgKQEAgLTEz OCw2ICsxMzgsOCBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICB2b2lkIGdldENvbnNlcnZh dGl2ZVJlZ2lzdGVyUm9vdHMoSGFzaFNldDxKU0NlbGwqPiYgcm9vdHMpOwogCisgICAgICAgIGRv dWJsZSBsYXN0R0NMZW5ndGgoKSB7IHJldHVybiBtX2xhc3RHQ0xlbmd0aDsgfQorCiAgICAgcHJp dmF0ZToKICAgICAgICAgZnJpZW5kIGNsYXNzIENvZGVCbG9jazsKICAgICAgICAgZnJpZW5kIGNs YXNzIExMSW50T2Zmc2V0c0V4dHJhY3RvcjsKQEAgLTIzNiw2ICsyMzgsOSBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICAgICAgYm9vbCBtX2lzU2FmZVRvQ29sbGVjdDsKIAogICAgICAgICBKU0dsb2Jh bERhdGEqIG1fZ2xvYmFsRGF0YTsKKyAgICAgICAgZG91YmxlIG1fbGFzdEdDU3RhcnRUaW1lOwor ICAgICAgICBkb3VibGUgbV9sYXN0R0NFbmRUaW1lOworICAgICAgICBkb3VibGUgbV9sYXN0R0NM ZW5ndGg7CiAgICAgfTsKIAogICAgIGJvb2wgSGVhcDo6aXNCdXN5KCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFja0NGLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFja0NGLmNwcAppbmRl eCAyZTg3OGJmZTNkNmQyNDY0YWVhY2Q2NmJiMDgyNGJjMWZlYmI2OTA4Li43ZjQ1ZjA3NDY3ZWE3 NDA0YTgwZTNiMDE2Nzg2NzAwY2MwYmVjODQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9HQ0FjdGl2aXR5Q2FsbGJhY2tDRi5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvR0NBY3Rpdml0eUNhbGxiYWNrQ0YuY3BwCkBAIC01Myw3ICs1Myw2 IEBAIHN0cnVjdCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrUGxhdGZvcm1EYXRhIHsKIH07CiAK IGNvbnN0IENGVGltZUludGVydmFsIGRlY2FkZSA9IDYwICogNjAgKiAyNCAqIDM2NSAqIDEwOwot Y29uc3QgQ0ZUaW1lSW50ZXJ2YWwgdHJpZ2dlckludGVydmFsID0gMjsgLy8gc2Vjb25kcwogCiB2 b2lkIERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2tQbGF0Zm9ybURhdGE6OnRyaWdnZXIoQ0ZSdW5M b29wVGltZXJSZWYgdGltZXIsIHZvaWQgKmluZm8pCiB7CkBAIC05NSw2ICs5NCw3IEBAIHZvaWQg RGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6Y29tbW9uQ29uc3RydWN0b3IoSGVhcCogaGVhcCwg Q0ZSdW5Mb29wUmVmIHJ1bkxvCiAKIHZvaWQgRGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6b3Bl cmF0b3IoKSgpCiB7CisgICAgQ0ZUaW1lSW50ZXJ2YWwgdHJpZ2dlckludGVydmFsID0gc3RhdGlj X2Nhc3Q8SGVhcCo+KGQtPmNvbnRleHQuaW5mbyktPmxhc3RHQ0xlbmd0aCgpICogMTAwLjA7IAog ICAgIENGUnVuTG9vcFRpbWVyU2V0TmV4dEZpcmVEYXRlKGQtPnRpbWVyLmdldCgpLCBDRkFic29s dXRlVGltZUdldEN1cnJlbnQoKSArIHRyaWdnZXJJbnRlcnZhbCk7CiB9CiAK