<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>8032</bug_id>
          
          <creation_ts>2006-03-28 07:21:35 -0800</creation_ts>
          <short_desc>REGRESSION: Focus ring not completely redrawn after a Delete changes its size</short_desc>
          <delta_ts>2006-04-03 09:24:53 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>420+</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Justin Garcia">justin.garcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>darin</cc>
    
    <cc>Graham.Dennis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>37776</commentid>
    <comment_count>0</comment_count>
    <who name="Justin Garcia">justin.garcia</who>
    <bug_when>2006-03-28 07:21:35 -0800</bug_when>
    <thetext>This was caused by a change made between r12899 and r12934.  I think that points to the fix for:
&lt;http://bugzilla.opendarwin.org/show_bug.cgi?id=6831&gt;
contentEditable outline darkens as caret moves

See the attached test case.  

The farthest I could reduce this an unstyled div inside a contenteditable div with left padding. 

I can only produce the redraw problem by manually deleting the line break, I can&apos;t produce it with document.execCommand(&quot;Delete&quot;) or by removing the line break with JS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>37777</commentid>
    <comment_count>1</comment_count>
      <attachid>7360</attachid>
    <who name="Justin Garcia">justin.garcia</who>
    <bug_when>2006-03-28 07:22:31 -0800</bug_when>
    <thetext>Created attachment 7360
testcase</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>37807</commentid>
    <comment_count>2</comment_count>
    <who name="Graham Dennis">Graham.Dennis</who>
    <bug_when>2006-03-28 15:42:05 -0800</bug_when>
    <thetext>Before the patch to 6831, outlines did not obey clip rects. After the patch, they do. So the problem is that the clip rect generated when deleting doesn&apos;t go far enough left to cover the rest of the contentEditable div.

Before the patch, the outline would ignore the clip rect and would be drawn in its entirety (but over part of the outline that wasn&apos;t cleared), and after, it&apos;s not drawn at all outside the clip rect.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>37808</commentid>
    <comment_count>3</comment_count>
    <who name="Graham Dennis">Graham.Dennis</who>
    <bug_when>2006-03-28 15:52:20 -0800</bug_when>
    <thetext>Oops. It looks like the repaint rect does extend over the entire width of the div, it just doesn&apos;t seem to go down far enough to cover the outline.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38172</commentid>
    <comment_count>4</comment_count>
      <attachid>7438</attachid>
    <who name="Graham Dennis">Graham.Dennis</who>
    <bug_when>2006-04-01 05:16:33 -0800</bug_when>
    <thetext>Created attachment 7438
patch

When an element changes size, only part of the element is redrawn. The part that is redrawn is the difference between the old and the new rectangles taking into account borders that need to be redrawn. However, this code was not also taking into account outlines that may need to be redrawn. This patch fixes this.

The reason that the original testcase attached with this patch could not be reproduced by adding document.execCommand(&quot;Delete&quot;); to the end of the &lt;script&gt; tag is that the document has not been rendered by this point, and so the document is rendered only once, and hence correctly.

I modified the testcase (I will attach) uses setTimeout(&quot;document.execCommand(&apos;Delete&apos;)&quot;, 0); to do the work, however, DumpRenderTree does a pixel dump before the timeout has been reached, and the test doesn&apos;t work in the LayoutTests. I don&apos;t know how else to cover this bug with a layout test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38173</commentid>
    <comment_count>5</comment_count>
      <attachid>7439</attachid>
    <who name="Graham Dennis">Graham.Dennis</who>
    <bug_when>2006-04-01 05:18:13 -0800</bug_when>
    <thetext>Created attachment 7439
modified (kinda automatic) testcase

Testcase that doesn&apos;t work with DumpRenderTree (the png output displays the same as the first test case before pressing delete)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38198</commentid>
    <comment_count>6</comment_count>
      <attachid>7438</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-04-01 13:33:05 -0800</bug_when>
    <thetext>Comment on attachment 7438
patch

Looks great! Needs a test. Perhaps ask Mitz for advice on how to make one since he&apos;s made tests for similar changes recently.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38251</commentid>
    <comment_count>7</comment_count>
      <attachid>7454</attachid>
    <who name="Graham Dennis">Graham.Dennis</who>
    <bug_when>2006-04-01 21:52:42 -0800</bug_when>
    <thetext>Created attachment 7454
patch 2

This is the same patch as before, but it includes a manual testcase. Mitz mentioned that this bug is the outline version of the border repaint bug 6301. The manual testcase for this bug is pretty much a copy of the testcase for 6301 with &apos;border&apos; replaced with outline.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>38285</commentid>
    <comment_count>8</comment_count>
      <attachid>7454</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2006-04-02 12:50:23 -0700</bug_when>
    <thetext>Comment on attachment 7454
patch 2

r=me</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>7360</attachid>
            <date>2006-03-28 07:22:31 -0800</date>
            <delta_ts>2006-03-28 07:22:31 -0800</delta_ts>
            <desc>testcase</desc>
            <filename>8032.html</filename>
            <type>text/html</type>
            <size>382</size>
            <attacher name="Justin Garcia">justin.garcia</attacher>
            
              <data encoding="base64">PHA+SGl0IGRlbGV0ZS4gJ2ZvbycgYW5kICdiYXInIHNob3VsZCBlbmQgdXAgb24gdGhlIHNhbWUg
bGluZS4gIE5vdGljZSB0aGUgbG93ZXIgbGVmdCBoYW5kIGNvcm5lciBvZiB0aGUgZm9jdXMgcmlu
ZyBpc24ndCByZWRyYXduLjwvcD4KPGRpdiBzdHlsZT0icGFkZGluZy1sZWZ0OiAyZW07IiBjb250
ZW50ZWRpdGFibGU9InRydWUiPjxkaXYgaWQ9ImlubmVyZGl2Ij5mb288YnI+YmFyPC9kaXY+PC9k
aXY+Cgo8c2NyaXB0Pgp2YXIgZGl2ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlubmVyZGl2
Iik7CnZhciBzZWwgPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CmRpdi5mb2N1cygpOwpzZWwuc2V0
QmFzZUFuZEV4dGVudChkaXYsIDIsIGRpdiwgMik7Cjwvc2NyaXB0Pg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>7438</attachid>
            <date>2006-04-01 05:16:33 -0800</date>
            <delta_ts>2006-04-01 21:52:42 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch.diff</filename>
            <type>text/plain</type>
            <size>2414</size>
            <attacher name="Graham Dennis">Graham.Dennis</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMTM1MzYpCisrKyBX
ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQw
LDE4ICsxNDQwLDE5IEBAIGJvb2wgUmVuZGVyT2JqZWN0OjpyZXBhaW50QWZ0ZXJMYXlvdXRJZk4K
IAogICAgIC8vIFdlIGRpZG4ndCBtb3ZlLCBidXQgd2UgZGlkIGNoYW5nZSBzaXplLiAgSW52YWxp
ZGF0ZSB0aGUgZGVsdGEsIHdoaWNoIHdpbGwgY29uc2lzdCBvZiBwb3NzaWJseSAKICAgICAvLyB0
d28gcmVjdGFuZ2xlcyAoYnV0IHR5cGljYWxseSBvbmx5IG9uZSkuCisgICAgaW50IG93ID0gc3R5
bGUoKSA/IHN0eWxlKCktPm91dGxpbmVTaXplKCkgOiAwOwogICAgIGludCB3aWR0aCA9IGFicyhu
ZXdCb3VuZHMud2lkdGgoKSAtIG9sZEJvdW5kcy53aWR0aCgpKTsKICAgICBpZiAod2lkdGgpCi0g
ICAgICAgIGMtPnJlcGFpbnRWaWV3UmVjdGFuZ2xlKEludFJlY3Qoa01pbihuZXdCb3VuZHMueCgp
ICsgbmV3Qm91bmRzLndpZHRoKCksIG9sZEJvdW5kcy54KCkgKyBvbGRCb3VuZHMud2lkdGgoKSkg
LSBib3JkZXJSaWdodCgpLAorICAgICAgICBjLT5yZXBhaW50Vmlld1JlY3RhbmdsZShJbnRSZWN0
KGtNaW4obmV3Qm91bmRzLngoKSArIG5ld0JvdW5kcy53aWR0aCgpLCBvbGRCb3VuZHMueCgpICsg
b2xkQm91bmRzLndpZHRoKCkpIC0gYm9yZGVyUmlnaHQoKSAtIG93LAogICAgICAgICAgICAgbmV3
Qm91bmRzLnkoKSwKLSAgICAgICAgICAgIHdpZHRoICsgYm9yZGVyUmlnaHQoKSwKKyAgICAgICAg
ICAgIHdpZHRoICsgYm9yZGVyUmlnaHQoKSArIG93LAogICAgICAgICAgICAga01heChuZXdCb3Vu
ZHMuaGVpZ2h0KCksIG9sZEJvdW5kcy5oZWlnaHQoKSkpKTsKICAgICBpbnQgaGVpZ2h0ID0gYWJz
KG5ld0JvdW5kcy5oZWlnaHQoKSAtIG9sZEJvdW5kcy5oZWlnaHQoKSk7CiAgICAgaWYgKGhlaWdo
dCkKICAgICAgICAgYy0+cmVwYWludFZpZXdSZWN0YW5nbGUoSW50UmVjdChuZXdCb3VuZHMueCgp
LAotICAgICAgICAgICAga01pbihuZXdCb3VuZHMuYm90dG9tKCksIG9sZEJvdW5kcy5ib3R0b20o
KSkgLSBib3JkZXJCb3R0b20oKSwKKyAgICAgICAgICAgIGtNaW4obmV3Qm91bmRzLmJvdHRvbSgp
LCBvbGRCb3VuZHMuYm90dG9tKCkpIC0gYm9yZGVyQm90dG9tKCkgLSBvdywKICAgICAgICAgICAg
IGtNYXgobmV3Qm91bmRzLndpZHRoKCksIG9sZEJvdW5kcy53aWR0aCgpKSwKLSAgICAgICAgICAg
IGhlaWdodCArIGJvcmRlckJvdHRvbSgpKSk7CisgICAgICAgICAgICBoZWlnaHQgKyBib3JkZXJC
b3R0b20oKSArIG93KSk7CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCkluZGV4OiBXZWJDb3JlL0No
YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTM2MjYp
CisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisy
MDA2LTA0LTAxICBHcmFoYW0gRGVubmlzICA8R3JhaGFtLkRlbm5pc0BnbWFpbC5jb20+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBmaXggaHR0cDov
L2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD04MDMyCisgICAgICAgICAg
UkVHUkVTU0lPTjogRm9jdXMgcmluZyBub3QgY29tcGxldGVseSByZWRyYXduIGFmdGVyIGEgRGVs
ZXRlIGNoYW5nZXMgaXRzIHNpemUKKyAgICAgICAgICAKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu
ZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6cmVwYWludEFm
dGVyTGF5b3V0SWZOZWVkZWQpOiBXaGVuIGFuIGVsZW1lbnQgY2hhbmdlcyBzaXplLCB0aGUKKyAg
ICAgICAgZGVsdGEgcmVjdGFuZ2xlcyB0aGF0IG5lZWQgdG8gYmUgaW52YWxpZGF0ZWQgbXVzdCBi
ZSBpbmZsYXRlZCBieSB0aGUgb3V0bGluZSBzaXplIHRvIGVuc3VyZQorICAgICAgICB0aGF0IHRo
ZSBwcmV2aW91cyBvdXRsaW5lIGlzIGVyYXNlZCwgYW5kIHRoZSBzcGFjZSB3aGVyZSB0aGUgbmV3
IG91dGxpbmUgaXMgdG8gYmUgZHJhd24gaXMKKyAgICAgICAgYWxzbyBpbnZhbGlkYXRlZC4gVGhp
cyBiZWhhdmlvdXIgaXMgaWRlbnRpY2FsIHRvIHRoZSBiZWhhdmlvdXIgb2YgYm9yZGVycy4KKwog
MjAwNi0wMy0zMSAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IEFkZWxlLgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>7439</attachid>
            <date>2006-04-01 05:18:13 -0800</date>
            <delta_ts>2006-04-01 05:18:13 -0800</delta_ts>
            <desc>modified (kinda automatic) testcase</desc>
            <filename>outline-auto-redraw.html</filename>
            <type>text/html</type>
            <size>460</size>
            <attacher name="Graham Dennis">Graham.Dennis</attacher>
            
              <data encoding="base64">PGh0bWw+Cjxib2R5Pgo8cD5IaXQgZGVsZXRlLiAnZm9vJyBhbmQgJ2Jhcicgc2hvdWxkIGVuZCB1
cCBvbiB0aGUgc2FtZSBsaW5lLiAgTm90aWNlIHRoZSBsb3dlciBsZWZ0IGhhbmQgY29ybmVyIG9m
IHRoZSBmb2N1cyByaW5nIGlzbid0IHJlZHJhd24uPC9wPgo8ZGl2IHN0eWxlPSJwYWRkaW5nLWxl
ZnQ6IDJlbTsiIGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSI+PGRpdiBpZD0iaW5uZXJkaXYiPmZvbzxi
cj5iYXI8L2Rpdj48L2Rpdj4KCjxzY3JpcHQ+CnZhciBkaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50
QnlJZCgiaW5uZXJkaXYiKTsKdmFyIHNlbCA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsKZGl2LmZv
Y3VzKCk7CnNlbC5zZXRCYXNlQW5kRXh0ZW50KGRpdiwgMiwgZGl2LCAyKTsKc2V0VGltZW91dCgi
ZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0RlbGV0ZScpIiwwKTsKPC9zY3JpcHQ+CjwvYm9keT4KPC9o
dG1sPg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>7454</attachid>
            <date>2006-04-01 21:52:42 -0800</date>
            <delta_ts>2006-04-02 12:50:23 -0700</delta_ts>
            <desc>patch 2</desc>
            <filename>patch2.diff</filename>
            <type>text/plain</type>
            <size>4798</size>
            <attacher name="Graham Dennis">Graham.Dennis</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvbWFudWFsLXRlc3RzL291dGxpbmUtcmVwYWludC1nbGl0Y2guaHRtbAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9vdXRsaW5lLXJlcGFpbnQtZ2xpdGNo
Lmh0bWwJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL21hbnVhbC10ZXN0cy9vdXRsaW5lLXJlcGFp
bnQtZ2xpdGNoLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDQgQEAKKzwhRE9DVFlQRSBI
VE1MIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0LjAxLy9FTiIKKyAgICAgICAgImh0dHA6Ly93
d3cudzMub3JnL1RSL2h0bWw0L3N0cmljdC5kdGQiPgorPGh0bWwgbGFuZz0iZW4iPgorPGhlYWQ+
Cis8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorICAgIGRpdi50ZXN0IHsgd2lkdGg6IDIwMHB4OyBo
ZWlnaHQ6IDEyMHB4OyBib3JkZXI6IDFweCBzb2xpZCBibHVlOyBwYWRkaW5nOiAxMHB4OyB9Cis8
L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8cD48Yj5CVUcgSUQ6PC9iPiA8YSBocmVmPSJodHRw
Oi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTgwMzIiPkJ1Z3ppbGxh
IGJ1ZyA4MDMyPC9hPiBSRUdSRVNTSU9OOiBGb2N1cyByaW5nIG5vdCBjb21wbGV0ZWx5IHJlZHJh
d24gYWZ0ZXIgYSBEZWxldGUgY2hhbmdlcyBpdHMgc2l6ZTwvcD4KKworPHA+IE5vdGUgdGhhdCB0
aGlzIGJ1ZyAoYW5kIHRoZSB0ZXN0KSBhcmUganVzdCBvdXRsaW5lIHZlcnNpb25zIG9mIDxhIGhy
ZWY9Imh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjMwMSI+
QnVnemlsbGEgYnVnIDYzMDE8L2E+IGFuZCB0ZXN0IDxhIGhyZWY9ImJvcmRlci1yZXBhaW50LWds
aXRjaC5odG1sIj5ib3JkZXItcmVwYWludC1nbGl0Y2guaHRtbDwvYT4KKworPHAgaWQ9InRlc3Qi
IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnNreWJsdWU7IHBhZGRpbmc6M3B4OyI+PGI+U1RFUFMg
VE8gVEVTVDo8L2I+IAorQ2xpY2sgZWFjaCBUZXN0IGJ1dHRvbiBvbmNlLgorPC9wPgorCis8cCBp
ZD0ic3VjY2VzcyIgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6cGFsZWdyZWVuOyBwYWRkaW5nOjNw
eDsiPjxiPlRFU1QgUEFTUzo8L2I+IAorVGhlIGJveGVzIHdpbGwgcmVzaXplLCBtYWludGFpbmlu
ZyB0aGVpciBzb2xpZCByZWQgcmVjdGFuZ3VsYXIgb3V0bGluZXMuCis8L3A+CisKKzxwIGlkPSJm
YWlsdXJlIiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjojRkYzMzAwOyBwYWRkaW5nOjNweDsiPjxi
PlRFU1QgRkFJTDo8L2I+ICAKK1RoZSBib3hlcyB3aWxsIHJlc2l6ZSwgYnV0IHRoZSBvdXRsaW5l
cyB3aWxsIGJyZWFrLiBUaGUgZmlyc3QgYm94IHdpbGwgYmUgbWlzc2luZworc21hbGwgc2VnbWVu
dHMgZnJvbSBlaXRoZXIgc2lkZSBvZiBpdHMgYm90dG9tIG91dGxpbmUuIFRoZSBzZWNvbmQgYm94
IHdpbGwgaGF2ZQorc21hbGwgcmVkIGhvcml6b250YWwgc2VnbWVudHMgcHJvdHJ1ZGluZyBpbndh
cmRzIGZyb20gYm90aCBzaWRlcyBvZiB0aGUgb3V0bGluZSwKK3doZXJlIHRoZSBib3R0b20gb3V0
bGluZSB3YXMgYmVmb3JlLgorPC9wPgorCis8ZGl2IGNsYXNzPSJ0ZXN0Ij4KKyAgICA8YnV0dG9u
IG9uY2xpY2s9ImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhJykuc3R5bGUuaGVpZ2h0ID0gJzQw
cHgnIj5UZXN0PC9idXR0b24+CisgICAgPGRpdiBzdHlsZT0iYmFja2dyb3VuZDogdGVhbDsgcGFk
ZGluZzogMDsgb3V0bGluZTogc29saWQgcmVkIDRweDsiPgorICAgICAgICA8ZGl2IGlkPSJhIiBz
dHlsZT0iaGVpZ2h0OiA2MHB4OyBtYXJnaW46IDEwcHg7IGJhY2tncm91bmQ6c2lsdmVyOyI+PC9k
aXY+CisgICAgPC9kaXY+Cis8L2Rpdj4KKzxicj4KKzxkaXYgY2xhc3M9InRlc3QiPgorICAgIDxi
dXR0b24gb25jbGljaz0iZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2InKS5zdHlsZS5oZWlnaHQg
PSAnNjBweCciPlRlc3Q8L2J1dHRvbj4KKyAgICA8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kOiB0ZWFs
OyBwYWRkaW5nOiAwOyBvdXRsaW5lOiBzb2xpZCByZWQgNHB4OyI+CisgICAgICAgIDxkaXYgaWQ9
ImIiIHN0eWxlPSJoZWlnaHQ6IDQwcHg7IG1hcmdpbjogMTBweDsgYmFja2dyb3VuZDpzaWx2ZXI7
Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKzwvZGl2PgorCis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBX
ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv
cmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDEzNTM2KQorKysgV2ViQ29yZS9y
ZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ0MCwxOCArMTQ0
MCwxOSBAQCBib29sIFJlbmRlck9iamVjdDo6cmVwYWludEFmdGVyTGF5b3V0SWZOCiAKICAgICAv
LyBXZSBkaWRuJ3QgbW92ZSwgYnV0IHdlIGRpZCBjaGFuZ2Ugc2l6ZS4gIEludmFsaWRhdGUgdGhl
IGRlbHRhLCB3aGljaCB3aWxsIGNvbnNpc3Qgb2YgcG9zc2libHkgCiAgICAgLy8gdHdvIHJlY3Rh
bmdsZXMgKGJ1dCB0eXBpY2FsbHkgb25seSBvbmUpLgorICAgIGludCBvdyA9IHN0eWxlKCkgPyBz
dHlsZSgpLT5vdXRsaW5lU2l6ZSgpIDogMDsKICAgICBpbnQgd2lkdGggPSBhYnMobmV3Qm91bmRz
LndpZHRoKCkgLSBvbGRCb3VuZHMud2lkdGgoKSk7CiAgICAgaWYgKHdpZHRoKQotICAgICAgICBj
LT5yZXBhaW50Vmlld1JlY3RhbmdsZShJbnRSZWN0KGtNaW4obmV3Qm91bmRzLngoKSArIG5ld0Jv
dW5kcy53aWR0aCgpLCBvbGRCb3VuZHMueCgpICsgb2xkQm91bmRzLndpZHRoKCkpIC0gYm9yZGVy
UmlnaHQoKSwKKyAgICAgICAgYy0+cmVwYWludFZpZXdSZWN0YW5nbGUoSW50UmVjdChrTWluKG5l
d0JvdW5kcy54KCkgKyBuZXdCb3VuZHMud2lkdGgoKSwgb2xkQm91bmRzLngoKSArIG9sZEJvdW5k
cy53aWR0aCgpKSAtIGJvcmRlclJpZ2h0KCkgLSBvdywKICAgICAgICAgICAgIG5ld0JvdW5kcy55
KCksCi0gICAgICAgICAgICB3aWR0aCArIGJvcmRlclJpZ2h0KCksCisgICAgICAgICAgICB3aWR0
aCArIGJvcmRlclJpZ2h0KCkgKyBvdywKICAgICAgICAgICAgIGtNYXgobmV3Qm91bmRzLmhlaWdo
dCgpLCBvbGRCb3VuZHMuaGVpZ2h0KCkpKSk7CiAgICAgaW50IGhlaWdodCA9IGFicyhuZXdCb3Vu
ZHMuaGVpZ2h0KCkgLSBvbGRCb3VuZHMuaGVpZ2h0KCkpOwogICAgIGlmIChoZWlnaHQpCiAgICAg
ICAgIGMtPnJlcGFpbnRWaWV3UmVjdGFuZ2xlKEludFJlY3QobmV3Qm91bmRzLngoKSwKLSAgICAg
ICAgICAgIGtNaW4obmV3Qm91bmRzLmJvdHRvbSgpLCBvbGRCb3VuZHMuYm90dG9tKCkpIC0gYm9y
ZGVyQm90dG9tKCksCisgICAgICAgICAgICBrTWluKG5ld0JvdW5kcy5ib3R0b20oKSwgb2xkQm91
bmRzLmJvdHRvbSgpKSAtIGJvcmRlckJvdHRvbSgpIC0gb3csCiAgICAgICAgICAgICBrTWF4KG5l
d0JvdW5kcy53aWR0aCgpLCBvbGRCb3VuZHMud2lkdGgoKSksCi0gICAgICAgICAgICBoZWlnaHQg
KyBib3JkZXJCb3R0b20oKSkpOworICAgICAgICAgICAgaGVpZ2h0ICsgYm9yZGVyQm90dG9tKCkg
KyBvdykpOwogICAgIHJldHVybiBmYWxzZTsKIH0KIApJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjM0KQorKysgV2Vi
Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAwNi0wNC0j
IyAgR3JhaGFtIERlbm5pcyAgPEdyYWhhbS5EZW5uaXNAZ21haWwuY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxs
YS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAzMgorICAgICAgICAgIFJFR1JFU1NJ
T046IEZvY3VzIHJpbmcgbm90IGNvbXBsZXRlbHkgcmVkcmF3biBhZnRlciBhIERlbGV0ZSBjaGFu
Z2VzIGl0cyBzaXplCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6cmVwYWludEFmdGVyTGF5b3V0SWZOZWVkZWQp
OiBXaGVuIGFuIGVsZW1lbnQgY2hhbmdlcyBzaXplLCB0aGUKKyAgICAgICAgZGVsdGEgcmVjdGFu
Z2xlcyB0aGF0IG5lZWQgdG8gYmUgaW52YWxpZGF0ZWQgbXVzdCBiZSBpbmZsYXRlZCBieSB0aGUg
b3V0bGluZSBzaXplIHRvIGVuc3VyZQorICAgICAgICB0aGF0IHRoZSBwcmV2aW91cyBvdXRsaW5l
IGlzIGVyYXNlZCwgYW5kIHRoZSBzcGFjZSB3aGVyZSB0aGUgbmV3IG91dGxpbmUgaXMgdG8gYmUg
ZHJhd24gaXMKKyAgICAgICAgYWxzbyBpbnZhbGlkYXRlZC4gVGhpcyBiZWhhdmlvdXIgaXMgaWRl
bnRpY2FsIHRvIHRoZSBiZWhhdmlvdXIgb2YgYm9yZGVycyB0aGF0IHdhcyBmaXhlZCBpbgorICAg
ICAgICBidWcgNjMwMS4KKyAgICAgICAgKiBtYW51YWwtdGVzdHMvb3V0bGluZS1yZXBhaW50LWds
aXRjaC5odG1sOiBBZGRlZC4gTWFudWFsIHRlc3RjYXNlLgorICAgICAgICBUaGlzIGlzIGp1c3Qg
YW4gb3V0bGluZSB2ZXJzaW9uIG9mIGJvcmRlci1yZXBhaW50LWdsaXRjaC5odG1sCisKIDIwMDYt
MDQtMDEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk
IGJ5IEVyaWMuCg==
</data>
<flag name="review"
          id="2024"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>