80313 2012-03-05 12:15:36 -0800 MiniBrowser --window-size 480x800 www.nytimes.com doesn't paint bottom tiles. 2012-03-06 13:43:31 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hugo.lima hugo.lima ahf kenneth menard rafael.lobo webkit.review.bot zoltan oldest_to_newest 570934 0 hugo.lima 2012-03-05 12:15:36 -0800 The problem can be reproduced with the HTML file above and "MiniBrowser --window-size 480x800": <html> <head></head> <style type="text/css"> div { height: 500px; background-color: grey; font-size: 72px; text-align: center; line-height: 500px; } div.odd { background-color: silver; } </style> <body> <div class="odd">Huge square 1/8</div> <div>Huge square 2/8</div> <div class="odd">Huge square 3/8</div> <div>Huge square 4/8</div> <div class="odd">Huge square 5/8</div> <div>Huge square 6/8</div> <div class="odd">Huge square 7/8</div> <div>Huge square 8/8</div> </body> </html> 570943 1 130181 hugo.lima 2012-03-05 12:24:03 -0800 Created attachment 130181 Patch 571061 2 130181 kenneth 2012-03-05 14:45:58 -0800 Comment on attachment 130181 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130181&action=review > Source/WebKit2/ChangeLog:8 > + Map pageView boundingRect to the same coordinate system of webView boundingRect I would just write "page view" and "web view", ie. use more natural language > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:662 > - QRect alignedVisibleContentRect = visibleRectInCSSCoordinates.toAlignedRect(); > + const QRectF pageViewRectInCSSCoordinates = q->mapRectToWebContent(pageView->boundingRect()); > + const QRectF webViewRectInCSSCoordinates = q->mapRectToWebContent(q->boundingRect()); > + const QRect alignedVisibleContentRect(webViewRectInCSSCoordinates.intersected(pageViewRectInCSSCoordinates).toAlignedRect()); > + Our names are confusing :/ So we have QScopedPointer<QQuickWebPage> pageView; which is our item. The view is a bit confusing there. So isn't q->mapRectToWebContent(pageView->boundingRect()); the same as the actual web contents? Maybe there is an easier way to get that without transforming anyway, the name "const QRectF contentsRectInCSSCoordinates" might be more clear. Anyway, why not do this differently Intersect the rect of the pageItem with the view and then map the result? const QRectF visibleRectInCSSCoordinates = q->mapRectToWebContent(q->boundingRect().intersected(pageView->boundingRect())); You could also make a methods like QQuickWebViewPrivate::visibleContentsRect() as we are doing this multiple places (you are only fixing one here). { const QRectF viewportRect = q->boundingRect(); const QRectF contentsRect = pageView->boundingRect(); return q->mapRectToWebContent(viewportRect.intersected(contentsRect)).toAlignedRect(); } 571087 3 hugo.lima 2012-03-05 15:19:11 -0800 You are right, I can avoid multiple transformations before doing the intersection. I'll improve and re-upload the patch (probably tomorrow). Thanks for the feedback =] 571971 4 130404 hugo.lima 2012-03-06 10:42:21 -0800 Created attachment 130404 Patch 572118 5 130404 webkit.review.bot 2012-03-06 13:43:26 -0800 Comment on attachment 130404 Patch Clearing flags on attachment: 130404 Committed r109957: <http://trac.webkit.org/changeset/109957> 572119 6 webkit.review.bot 2012-03-06 13:43:31 -0800 All reviewed patches have been landed. Closing bug. 130181 2012-03-05 12:24:03 -0800 2012-03-06 10:42:12 -0800 Patch bug-80313-20120305172302.patch text/plain 2006 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2U1M2ZkYjIzMjQ5MzVh MzllOTNjMzIwNjlhZGZmNDE4MzY3NGU4NC4uODEyNmZlZDZlNDRhNDU1NmY1MWRkOGZiOTMzODg5 NTU5ODdhNDkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTA1ICBIdWdv IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIE1pbmlC cm93c2VyIC0td2luZG93LXNpemUgNDgweDgwMCB3d3cubnl0aW1lcy5jb20gZG9lc24ndCBwYWlu dCBib3R0b20gdGlsZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MDMxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1hcCBwYWdlVmlldyBib3VuZGluZ1JlY3QgdG8gdGhlIHNhbWUgY29vcmRpbmF0ZSBz eXN0ZW0gb2Ygd2ViVmlldyBib3VuZGluZ1JlY3QKKyAgICAgICAgYmVmb3JlIGNhbGN1bGF0ZSB0 aGUgaW50ZXJzZWN0aW9uIHJlY3RhbmdsZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6X3FfY29t bWl0UG9zaXRpb25DaGFuZ2UpOgorCiAyMDEyLTAzLTA1ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MTA5NzQ4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVp Y2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vi dmlldy5jcHAKaW5kZXggYjdhMGI0OGM2ZGM3NGEwZTkwNmViOWMyYWUxZTYwZDkwOWQzNzUyMC4u YTNmZTE0MzgzM2VlN2VlMTQxOWVmMTNlNDY0MTNlMjRjZGViMTE1ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC02NTUsOSAr NjU1LDExIEBAIHZvaWQgUVF1aWNrV2ViVmlld1ByaXZhdGU6Ol9xX2NvbW1pdFBvc2l0aW9uQ2hh bmdlKGNvbnN0IFFQb2ludEYmIHRyYWplY3RvcnlWZWN0CiAgICAgICAgIHJldHVybjsKIAogICAg IFFfUShRUXVpY2tXZWJWaWV3KTsKLSAgICBjb25zdCBRUmVjdEYgdmlzaWJsZVJlY3RJbkNTU0Nv b3JkaW5hdGVzID0gcS0+bWFwUmVjdFRvV2ViQ29udGVudChxLT5ib3VuZGluZ1JlY3QoKSkuaW50 ZXJzZWN0ZWQocGFnZVZpZXctPmJvdW5kaW5nUmVjdCgpKTsKIAotICAgIFFSZWN0IGFsaWduZWRW aXNpYmxlQ29udGVudFJlY3QgPSB2aXNpYmxlUmVjdEluQ1NTQ29vcmRpbmF0ZXMudG9BbGlnbmVk UmVjdCgpOworICAgIGNvbnN0IFFSZWN0RiBwYWdlVmlld1JlY3RJbkNTU0Nvb3JkaW5hdGVzID0g cS0+bWFwUmVjdFRvV2ViQ29udGVudChwYWdlVmlldy0+Ym91bmRpbmdSZWN0KCkpOworICAgIGNv bnN0IFFSZWN0RiB3ZWJWaWV3UmVjdEluQ1NTQ29vcmRpbmF0ZXMgPSBxLT5tYXBSZWN0VG9XZWJD b250ZW50KHEtPmJvdW5kaW5nUmVjdCgpKTsKKyAgICBjb25zdCBRUmVjdCBhbGlnbmVkVmlzaWJs ZUNvbnRlbnRSZWN0KHdlYlZpZXdSZWN0SW5DU1NDb29yZGluYXRlcy5pbnRlcnNlY3RlZChwYWdl Vmlld1JlY3RJbkNTU0Nvb3JkaW5hdGVzKS50b0FsaWduZWRSZWN0KCkpOworCiAgICAgZHJhd2lu Z0FyZWEtPnNldFZpc2libGVDb250ZW50c1JlY3RGb3JQYW5uaW5nKGFsaWduZWRWaXNpYmxlQ29u dGVudFJlY3QsIHRyYWplY3RvcnlWZWN0b3IpOwogCiAgICAgaWYgKCF0cmFqZWN0b3J5VmVjdG9y LmlzTnVsbCgpKQo= 130404 2012-03-06 10:42:21 -0800 2012-03-06 13:43:26 -0800 Patch bug-80313-20120306154120.patch text/plain 4428 hugo.lima U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTI4NGJjZGU3YzRlNDEy ZjMwMzEyMTkzOWMyMzgyN2EyYzA5Y2RjZi4uZDkxMGM0ODFlZGU4MWM3MTMyNGEyNjIwNzVkMDZm OWIyNDBhNzJhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTA1ICBIdWdv IFBhcmVudGUgTGltYSAgPGh1Z28ubGltYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIE1pbmlC cm93c2VyIC0td2luZG93LXNpemUgNDgweDgwMCB3d3cubnl0aW1lcy5jb20gZG9lc24ndCBwYWlu dCBib3R0b20gdGlsZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MDMxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCB0aGUgbWF0aCB0byBnZXQgdGhlIHZpc2libGUgcmVjdGFuZ2xlIGFuZCBhZGQg YSBtZXRob2QgdG8gZ2V0IGl0LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3 ZWJ2aWV3LmNwcDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjp2aXNpYmxlQ29udGVu dHNSZWN0KToKKyAgICAgICAgKFFRdWlja1dlYlZpZXdGbGlja2FibGVQcml2YXRlOjpfcV9jb21t aXRTY2FsZUNoYW5nZSk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6X3FfY29tbWl0 UG9zaXRpb25DaGFuZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmll d19wX3AuaDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlKToKKwogMjAxMi0wMy0wNiAg U2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0 XSBNYWtlIFFRdWlja1dlYlZpZXcncyB1cmwgcHJvcGVydHkgd29yayB3aXRoIGEgZmxpY2thYmxl IHdlYnZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dl YnZpZXcuY3BwCmluZGV4IDI1ODkxZjg0ODA3NjYxODFhNDhmMmY0ZTE0YjhiMjU5NTJkZDI3ZTcu LmYwMWNlMDJiMmRiMGZkZGVmZjJmMzMxZWM0ZTZiMWE3ZGUxMGJjZWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtNDYwLDYg KzQ2MCwxNCBAQCB2b2lkIFFRdWlja1dlYlZpZXdQcml2YXRlOjpzZXROYXZpZ2F0b3JRdE9iamVj dEVuYWJsZWQoYm9vbCBlbmFibGVkKQogICAgIGNvbnRleHQtPnNldE5hdmlnYXRvclF0T2JqZWN0 RW5hYmxlZCh3ZWJQYWdlUHJveHkuZ2V0KCksIGVuYWJsZWQpOwogfQogCitRUmVjdCBRUXVpY2tX ZWJWaWV3UHJpdmF0ZTo6dmlzaWJsZUNvbnRlbnRzUmVjdCgpIGNvbnN0Cit7CisgICAgUV9RKGNv bnN0IFFRdWlja1dlYlZpZXcpOworICAgIGNvbnN0IFFSZWN0RiB2aXNpYmxlUmVjdChxLT5ib3Vu ZGluZ1JlY3QoKS5pbnRlcnNlY3RlZChwYWdlVmlldy0+Ym91bmRpbmdSZWN0KCkpKTsKKworICAg IHJldHVybiBxLT5tYXBSZWN0VG9XZWJDb250ZW50KHZpc2libGVSZWN0KS50b0FsaWduZWRSZWN0 KCk7Cit9CisKIFdlYkNvcmU6OkludFNpemUgUVF1aWNrV2ViVmlld1ByaXZhdGU6OnZpZXdTaXpl KCkgY29uc3QKIHsKICAgICByZXR1cm4gV2ViQ29yZTo6SW50U2l6ZShwYWdlVmlldy0+d2lkdGgo KSwgcGFnZVZpZXctPmhlaWdodCgpKTsKQEAgLTYzOCwxNiArNjQ2LDE0IEBAIHZvaWQgUVF1aWNr V2ViVmlld0ZsaWNrYWJsZVByaXZhdGU6Ol9xX2NvbW1pdFNjYWxlQ2hhbmdlKCkKICAgICAgICAg cmV0dXJuOwogCiAgICAgUV9RKFFRdWlja1dlYlZpZXcpOwotICAgIGNvbnN0IFFSZWN0RiB2aXNp YmxlUmVjdEluQ1NTQ29vcmRpbmF0ZXMgPSBxLT5tYXBSZWN0VG9XZWJDb250ZW50KHEtPmJvdW5k aW5nUmVjdCgpKS5pbnRlcnNlY3RlZChwYWdlVmlldy0+Ym91bmRpbmdSZWN0KCkpOwotICAgIGZs b2F0IHNjYWxlID0gcGFnZVZpZXctPmNvbnRlbnRzU2NhbGUoKTsKLQogICAgIC8vIFRoaXMgaXMg b25seSBmb3Igb3VyIFFNTCBWaWV3cG9ydEluZm8gZGVidWdnaW5nIEFQSS4KICAgICBxLT5leHBl cmltZW50YWwoKS0+dmlld3BvcnRJbmZvKCktPmRpZFVwZGF0ZUN1cnJlbnRTY2FsZSgpOwogCi0g ICAgUVJlY3QgYWxpZ25lZFZpc2libGVDb250ZW50UmVjdCA9IHZpc2libGVSZWN0SW5DU1NDb29y ZGluYXRlcy50b0FsaWduZWRSZWN0KCk7Ci0gICAgZHJhd2luZ0FyZWEtPnNldFZpc2libGVDb250 ZW50c1JlY3RGb3JTY2FsaW5nKGFsaWduZWRWaXNpYmxlQ29udGVudFJlY3QsIHNjYWxlKTsKKyAg ICBjb25zdCBRUmVjdCB2aXNpYmxlUmVjdCh2aXNpYmxlQ29udGVudHNSZWN0KCkpOworICAgIGZs b2F0IHNjYWxlID0gcGFnZVZpZXctPmNvbnRlbnRzU2NhbGUoKTsKIAotICAgIHdlYlBhZ2VQcm94 eS0+c2V0Rml4ZWRWaXNpYmxlQ29udGVudFJlY3QoYWxpZ25lZFZpc2libGVDb250ZW50UmVjdCk7 CisgICAgZHJhd2luZ0FyZWEtPnNldFZpc2libGVDb250ZW50c1JlY3RGb3JTY2FsaW5nKHZpc2li bGVSZWN0LCBzY2FsZSk7CisgICAgd2ViUGFnZVByb3h5LT5zZXRGaXhlZFZpc2libGVDb250ZW50 UmVjdCh2aXNpYmxlUmVjdCk7CiB9CiAKIHZvaWQgUVF1aWNrV2ViVmlld1ByaXZhdGU6Ol9xX2Nv bW1pdFBvc2l0aW9uQ2hhbmdlKGNvbnN0IFFQb2ludEYmIHRyYWplY3RvcnlWZWN0b3IpCkBAIC02 NTYsMTYgKzY2MiwxMyBAQCB2b2lkIFFRdWlja1dlYlZpZXdQcml2YXRlOjpfcV9jb21taXRQb3Np dGlvbkNoYW5nZShjb25zdCBRUG9pbnRGJiB0cmFqZWN0b3J5VmVjdAogICAgIGlmICghZHJhd2lu Z0FyZWEpCiAgICAgICAgIHJldHVybjsKIAotICAgIFFfUShRUXVpY2tXZWJWaWV3KTsKLSAgICBj b25zdCBRUmVjdEYgdmlzaWJsZVJlY3RJbkNTU0Nvb3JkaW5hdGVzID0gcS0+bWFwUmVjdFRvV2Vi Q29udGVudChxLT5ib3VuZGluZ1JlY3QoKSkuaW50ZXJzZWN0ZWQocGFnZVZpZXctPmJvdW5kaW5n UmVjdCgpKTsKLQotICAgIFFSZWN0IGFsaWduZWRWaXNpYmxlQ29udGVudFJlY3QgPSB2aXNpYmxl UmVjdEluQ1NTQ29vcmRpbmF0ZXMudG9BbGlnbmVkUmVjdCgpOwotICAgIGRyYXdpbmdBcmVhLT5z ZXRWaXNpYmxlQ29udGVudHNSZWN0Rm9yUGFubmluZyhhbGlnbmVkVmlzaWJsZUNvbnRlbnRSZWN0 LCB0cmFqZWN0b3J5VmVjdG9yKTsKKyAgICBjb25zdCBRUmVjdCB2aXNpYmxlUmVjdCh2aXNpYmxl Q29udGVudHNSZWN0KCkpOworICAgIGRyYXdpbmdBcmVhLT5zZXRWaXNpYmxlQ29udGVudHNSZWN0 Rm9yUGFubmluZyh2aXNpYmxlUmVjdCwgdHJhamVjdG9yeVZlY3Rvcik7CiAKICAgICBpZiAoIXRy YWplY3RvcnlWZWN0b3IuaXNOdWxsKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHdlYlBhZ2VQ cm94eS0+c2V0Rml4ZWRWaXNpYmxlQ29udGVudFJlY3QoYWxpZ25lZFZpc2libGVDb250ZW50UmVj dCk7CisgICAgd2ViUGFnZVByb3h5LT5zZXRGaXhlZFZpc2libGVDb250ZW50UmVjdCh2aXNpYmxl UmVjdCk7CiB9CiAKIHZvaWQgUVF1aWNrV2ViVmlld0ZsaWNrYWJsZVByaXZhdGU6Ol9xX3N1c3Bl bmQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3 ZWJ2aWV3X3BfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2 aWV3X3BfcC5oCmluZGV4IDVhNjIxNzgzMTVkMzU1MTExOWI0OTE5YWI2N2I5ZmE1ZmEwNWEwMmUu LjNlZDExMDc1YTZiNTRmNTU0MTU3ZWU2MGJjZjcxNTJmNTA1MWEwNDUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKQEAgLTEx Niw2ICsxMTYsOCBAQCBwdWJsaWM6CiAgICAgYm9vbCByZW5kZXJUb09mZnNjcmVlbkJ1ZmZlcigp IGNvbnN0IHsgcmV0dXJuIG1fcmVuZGVyVG9PZmZzY3JlZW5CdWZmZXI7IH0KICAgICB2b2lkIHNl dE5hdmlnYXRvclF0T2JqZWN0RW5hYmxlZChib29sKTsKIAorICAgIFFSZWN0IHZpc2libGVDb250 ZW50c1JlY3QoKSBjb25zdDsKKwogICAgIC8vIFBhZ2VDbGllbnQuCiAgICAgV2ViQ29yZTo6SW50 U2l6ZSB2aWV3U2l6ZSgpIGNvbnN0OwogICAgIHZvaWQgZGlkUmVjZWl2ZU1lc3NhZ2VGcm9tTmF2 aWdhdG9yUXRPYmplY3QoY29uc3QgU3RyaW5nJiBtZXNzYWdlKTsK