80299 2012-03-05 09:43:51 -0800 WebAudio JSC-related fixes 2012-03-06 00:00:22 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abarth crogers eric.carlson jer.noble ojan webkit.review.bot oldest_to_newest 570790 0 pnormand 2012-03-05 09:43:51 -0800 EventTarget is protected by #if defined(V8_BINDING) && V8_BINDING in AudioContext.idl and JavaScriptAudioNode.idl. Any reason why? Also, JSAudioContextConstructor::constructJSAudioContext doesn't wrap the returned value in a DOM wrapper, like the V8 version does. 570791 1 130156 pnormand 2012-03-05 09:46:38 -0800 Created attachment 130156 JSC-related WebAudio fixes 571566 2 130156 pnormand 2012-03-06 00:00:15 -0800 Comment on attachment 130156 JSC-related WebAudio fixes Clearing flags on attachment: 130156 Committed r109870: <http://trac.webkit.org/changeset/109870> 571567 3 pnormand 2012-03-06 00:00:22 -0800 All reviewed patches have been landed. Closing bug. 130156 2012-03-05 09:46:38 -0800 2012-03-06 00:00:14 -0800 JSC-related WebAudio fixes JSC-related-WebAudio-fixes.patch text/plain 3251 pnormand RnJvbSA5YmZiMzA4M2E0OTc2NjZjZDJjMWI3NjQzZjdjMmJiM2VmNzFkYTJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDUgTWFyIDIwMTIgMTg6NDU6MDMgKzAxMDAKU3ViamVjdDogW1BBVENIXSBK U0MtcmVsYXRlZCBXZWJBdWRpbyBmaXhlcwoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIC4uLi9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0Q3VzdG9tLmNwcCAgIHwgICAgMiArLQogU291 cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmlkbCAgICAgICAgICAgfCAgICAyIC0t CiBTb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9KYXZhU2NyaXB0QXVkaW9Ob2RlLmlkbCAgICB8ICAg IDIgLS0KIDQgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggMzI0OWUyOC4uNjdkMmVkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTAzLTA1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBXZWJBdWRpbyBKU0MtcmVsYXRlZCBmaXhlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAyOTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0 Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTQXVkaW9Db250ZXh0Q29uc3RydWN0b3I6 OmNvbnN0cnVjdEpTQXVkaW9Db250ZXh0KToKKyAgICAgICAgV3JhcCB0aGUgYXVkaW8gY29udGV4 dCBpbiBhIERPTSB3cmFwcGVyLgorICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlvQ29udGV4dC5pZGw6 IE5vIG5lZWQgdG8gcHJvdGVjdCBFdmVudFRhcmdldCBieSBWOAorICAgICAgICBndWFyZHMsIEkg dGhpbmsuCisgICAgICAgICogd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5pZGw6IERpdHRv LgorCiAyMDEyLTAzLTA1ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGZpeCBleHRlbnNpb25zLXJlc291cmNlLmh0bWwg dGVzdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db250 ZXh0Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0 Q3VzdG9tLmNwcAppbmRleCBmOGZhYjYyLi42NGU0NGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0F1ZGlvQ29udGV4dEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNBdWRpb0NvbnRleHRDdXN0b20uY3BwCkBAIC0xMDEsNyArMTAx LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBKU0F1ZGlvQ29udGV4dENvbnN0cnVj dG9yOjpjb25zdHJ1Y3RKU0F1ZGlvQ29udGV4dCgKICAgICBpZiAoIWF1ZGlvQ29udGV4dC5nZXQo KSkKICAgICAgICAgcmV0dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVSZWZlcmVuY2VFcnJv cihleGVjLCAiRXJyb3IgY3JlYXRpbmcgQXVkaW9Db250ZXh0IikpOwogCi0gICAgcmV0dXJuIEpT VmFsdWU6OmVuY29kZShhc09iamVjdCh0b0pTKGV4ZWMsIGpzQ29uc3RydWN0b3ItPmdsb2JhbE9i amVjdCgpLCBhdWRpb0NvbnRleHQuZ2V0KCkpKSk7CisgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29k ZShDUkVBVEVfRE9NX1dSQVBQRVIoZXhlYywganNDb25zdHJ1Y3Rvci0+Z2xvYmFsT2JqZWN0KCks IEF1ZGlvQ29udGV4dCwgYXVkaW9Db250ZXh0LmdldCgpKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQ29udGV4 dC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0NvbnRleHQuaWRsCmluZGV4IDZm MDIzMjkuLmMxZmY4YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlv Q29udGV4dC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9Db250ZXh0Lmlk bApAQCAtMzAsOSArMzAsNyBAQCBtb2R1bGUgd2ViYXVkaW8gewogICAgICAgICBDdXN0b21Db25z dHJ1Y3RvciwKICAgICAgICAgQ29uc3RydWN0b3JQYXJhbWV0ZXJzPTAsCiAgICAgICAgIEpTQ3Vz dG9tTWFya0Z1bmN0aW9uLAotI2lmIGRlZmluZWQoVjhfQklORElORykgJiYgVjhfQklORElORwog ICAgICAgICBFdmVudFRhcmdldAotI2VuZGlmICAgICAgICAKICAgICBdIEF1ZGlvQ29udGV4dCB7 CiAgICAgICAgIC8vIEFsbCByZW5kZXJlZCBhdWRpbyB1bHRpbWF0ZWx5IGNvbm5lY3RzIHRvIGRl c3RpbmF0aW9uLCB3aGljaCByZXByZXNlbnRzIHRoZSBhdWRpbyBoYXJkd2FyZS4KICAgICAgICAg cmVhZG9ubHkgYXR0cmlidXRlIEF1ZGlvRGVzdGluYXRpb25Ob2RlIGRlc3RpbmF0aW9uOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5pZGwg Yi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9KYXZhU2NyaXB0QXVkaW9Ob2RlLmlkbAppbmRleCA4 M2UzZTYyLi45N2RhMGMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9KYXZh U2NyaXB0QXVkaW9Ob2RlLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9KYXZhU2Ny aXB0QXVkaW9Ob2RlLmlkbApAQCAtMjgsOSArMjgsNyBAQCBtb2R1bGUgYXVkaW8gewogICAgICAg ICBDb25kaXRpb25hbD1XRUJfQVVESU8sCiAgICAgICAgIEpTR2VuZXJhdGVUb0pTT2JqZWN0LAog ICAgICAgICBKU0N1c3RvbU1hcmtGdW5jdGlvbiwKLSNpZiBkZWZpbmVkKFY4X0JJTkRJTkcpICYm IFY4X0JJTkRJTkcKICAgICAgICAgRXZlbnRUYXJnZXQKLSNlbmRpZgogICAgIF0gSmF2YVNjcmlw dEF1ZGlvTm9kZSA6IEF1ZGlvTm9kZSB7CiAgICAgICAgIC8vIFJlbmRlcmluZyBjYWxsYmFjawog ICAgICAgICBhdHRyaWJ1dGUgRXZlbnRMaXN0ZW5lciBvbmF1ZGlvcHJvY2VzczsKLS0gCjEuNy45 LjE=