80290 2012-03-05 08:06:11 -0800 [chromium] Remove old cleanupResources() code 2012-03-05 12:06:03 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer cc-bugs enne jamesr piman webkit.review.bot oldest_to_newest 570707 0 danakj 2012-03-05 08:06:11 -0800 [chromium] Remove old cleanupResources() code 570709 1 130139 danakj 2012-03-05 08:08:39 -0800 Created attachment 130139 Patch 570718 2 danakj 2012-03-05 08:18:24 -0800 cleanupResources() is called from destructors, primarily to call cleanupResources on the layer's RenderSurface. That surface is held by an OwnPtr, so its destructor will be called anyways. And RS::cleanupResources is used to clear OwnPtrs within the surface. Basically, this function is redundant with destructors now, though I imagine it served some larger purpose in the past, which has been solved with OwnPtrs now. 570834 3 130139 enne 2012-03-05 10:48:16 -0800 Comment on attachment 130139 Patch Nice cleanup! :) 570923 4 130139 webkit.review.bot 2012-03-05 12:05:59 -0800 Comment on attachment 130139 Patch Clearing flags on attachment: 130139 Committed r109781: <http://trac.webkit.org/changeset/109781> 570924 5 webkit.review.bot 2012-03-05 12:06:03 -0800 All reviewed patches have been landed. Closing bug. 130139 2012-03-05 08:08:39 -0800 2012-03-05 12:05:59 -0800 Patch bug-80290-20120305110838.patch text/plain 6619 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmE2MjUzZThiNjdmNGUy ZDRjNTllMmFhNjAyMmEzZDI5OGJiMTI4NC4uODVjNzQ3Mzc0ZTIxYWU2NDFjODM4NDQxZGFkOGZk YmY2YWU2YzAxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTAzLTA1ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIG9sZCBjbGVhbnVwUmVzb3VyY2VzKCkgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODAyOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBjbGVhbnVwUmVzb3VyY2VzKCkgaXMgb25seSBjYWxsZWQg YnkgZGVzdHJ1Y3RvcnMsIGFuZCBhZGRzIG5vCisgICAgICAgIHZhbHVlLCBhbnkgbW9yZSwgYmV5 b25kIHRoZSBkZXN0cnVjdG9ycyB0aGVtc2VsdmVzLCBidXQgY29tcGxpY2F0ZXMKKyAgICAgICAg dGhlIGNvZGUgcGF0aC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuY3BwOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmg6Cisg ICAgICAgIChDQ0xheWVySW1wbCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NQbHVnaW5MYXllckltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NQbHVnaW5M YXllckltcGw6On5DQ1BsdWdpbkxheWVySW1wbCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NQbHVnaW5MYXllckltcGwuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2UuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Q0NSZW5kZXJTdXJmYWNlOjp+Q0NSZW5kZXJTdXJmYWNlKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2UuaDoKKyAgICAgICAgKENDUmVu ZGVyU3VyZmFjZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NW aWRlb0xheWVySW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1ZpZGVvTGF5ZXJJbXBsOjp+ Q0NWaWRlb0xheWVySW1wbCk6CisKIDIwMTItMDMtMDUgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1h bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY2Fubm90IGJlIGxhdW5j aGVkIHdoZW4gbG9jYWxTdG9yYWdlIGlzIGRpc2FibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5jcHAK aW5kZXggYzAzMDY0YTkyZDk1N2EwY2M3MGM4YmU4ODZiNWI0MTZkNWExYWFkYi4uNmUwYmYyZmU0 MWE5YWE1MjIwNzU1YWZlYzIzNTc4NGEzZGFmNmEwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNw cApAQCAtMTk0LDEyICsxOTQsNiBAQCB2b2lkIENDTGF5ZXJJbXBsOjpzY3JvbGxCeShjb25zdCBJ bnRTaXplJiBzY3JvbGwpCiAgICAgbm90ZUxheWVyUHJvcGVydHlDaGFuZ2VkRm9yU3VidHJlZSgp OwogfQogCi12b2lkIENDTGF5ZXJJbXBsOjpjbGVhbnVwUmVzb3VyY2VzKCkKLXsKLSAgICBpZiAo cmVuZGVyU3VyZmFjZSgpKQotICAgICAgICByZW5kZXJTdXJmYWNlKCktPmNsZWFudXBSZXNvdXJj ZXMoKTsKLX0KLQogY29uc3QgSW50UmVjdCBDQ0xheWVySW1wbDo6Z2V0RHJhd1JlY3QoKSBjb25z dAogewogICAgIC8vIEZvcm0gdGhlIG1hdHJpeCB1c2VkIGJ5IHRoZSBzaGFkZXIgdG8gbWFwIHRo ZSBjb3JuZXJzIG9mIHRoZSBsYXllcidzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuaAppbmRleCA3NDUzOGIx MjRiZTBjZTY3ZDQ2N2E0NDRiMTQyZGZmNDM4OTQ3ZWIzLi5mNzBiYjY3YmU3YjdlZTUwMzBlMTQx OTQzMTUwYjg4NmJmN2FhOGIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmgKQEAgLTk3LDggKzk3LDYg QEAgcHVibGljOgogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiBhbnkgb2YgdGhlIGxheWVyJ3MgZGVz Y2VuZGFudHMgaGFzIGNvbnRlbnQgdG8gZHJhdy4KICAgICBib29sIGRlc2NlbmRhbnREcmF3c0Nv bnRlbnQoKTsKIAotICAgIHZvaWQgY2xlYW51cFJlc291cmNlcygpOwotCiAgICAgdm9pZCBzZXRB bmNob3JQb2ludChjb25zdCBGbG9hdFBvaW50Jik7CiAgICAgY29uc3QgRmxvYXRQb2ludCYgYW5j aG9yUG9pbnQoKSBjb25zdCB7IHJldHVybiBtX2FuY2hvclBvaW50OyB9CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUGx1Z2luTGF5 ZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDUGx1Z2luTGF5ZXJJbXBsLmNwcAppbmRleCA1ZTRhY2E2ZDk4YmFiZjExZjQyZGU3ZDI2YmQ1 ZmZhMDUyM2Y5MTUyLi43MzU0YTg0MzA1MDVkZmU2ODJlMTRmOTA3N2FjNGMzMTNjMjFmMzljIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9D Q1BsdWdpbkxheWVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vY2MvQ0NQbHVnaW5MYXllckltcGwuY3BwCkBAIC01Myw3ICs1Myw5IEBAIEND UGx1Z2luTGF5ZXJJbXBsOjpDQ1BsdWdpbkxheWVySW1wbChpbnQgaWQpCiAKIENDUGx1Z2luTGF5 ZXJJbXBsOjp+Q0NQbHVnaW5MYXllckltcGwoKQogewotICAgIGNsZWFudXBSZXNvdXJjZXMoKTsK KyAgICAvLyBGSVhNRTogaXQgc2VlbXMgdGhlcmUgaXMgbm8gbGF5ZXIgcmVuZGVyZXIgLyBHcmFw aGljc0NvbnRleHQzRCBhdmFpbGFibGUgaGVyZS4gSWRlYWxseSB3ZQorICAgIC8vIHdvdWxkIGxp a2UgdG8gZGVsZXRlIG1faW9TdXJmYWNlVGV4dHVyZUlkLgorICAgIG1faW9TdXJmYWNlVGV4dHVy ZUlkID0gMDsKIH0KIAogdm9pZCBDQ1BsdWdpbkxheWVySW1wbDo6d2lsbERyYXcoTGF5ZXJSZW5k ZXJlckNocm9taXVtKiBsYXllclJlbmRlcmVyKQpAQCAtMTExLDEzICsxMTMsNiBAQCB2b2lkIEND UGx1Z2luTGF5ZXJJbXBsOjpzZXRJT1N1cmZhY2VQcm9wZXJ0aWVzKGludCB3aWR0aCwgaW50IGhl aWdodCwgdWludDMyX3QgaQogICAgIG1faW9TdXJmYWNlSWQgPSBpb1N1cmZhY2VJZDsKIH0KIAot dm9pZCBDQ1BsdWdpbkxheWVySW1wbDo6Y2xlYW51cFJlc291cmNlcygpCi17Ci0gICAgLy8gRklY TUU6IGl0IHNlZW1zIHRoZXJlIGlzIG5vIGxheWVyIHJlbmRlcmVyIC8gR3JhcGhpY3NDb250ZXh0 M0QgYXZhaWxhYmxlIGhlcmUuIElkZWFsbHkgd2UKLSAgICAvLyB3b3VsZCBsaWtlIHRvIGRlbGV0 ZSBtX2lvU3VyZmFjZVRleHR1cmVJZC4KLSAgICBtX2lvU3VyZmFjZVRleHR1cmVJZCA9IDA7Ci19 Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIFVTRShBQ0NFTEVSQVRFRF9D T01QT1NJVElORykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDUGx1Z2luTGF5ZXJJbXBsLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1BsdWdpbkxheWVySW1wbC5oCmluZGV4IDlkOWE0ZGQx MDRlOTkyMzgwNDhjYzNjNTZkYjExYzgzOGEwY2NkMGQuLmU1OWRhODg4NWY5ZjlmNWFiMjFjMmFj N2ZiNWNhODE3MTM5ODliMjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDUGx1Z2luTGF5ZXJJbXBsLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NQbHVnaW5MYXllckltcGwuaApAQCAt NjEsOCArNjEsNiBAQCBwcml2YXRlOgogCiAgICAgdmlydHVhbCBjb25zdCBjaGFyKiBsYXllclR5 cGVBc1N0cmluZygpIGNvbnN0IHsgcmV0dXJuICJQbHVnaW5MYXllciI7IH0KIAotICAgIHZvaWQg Y2xlYW51cFJlc291cmNlcygpOwotCiAgICAgdW5zaWduZWQgbV90ZXh0dXJlSWQ7CiAgICAgYm9v bCBtX2ZsaXBwZWQ7CiAgICAgRmxvYXRSZWN0IG1fdXZSZWN0OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NSZW5kZXJTdXJmYWNlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVy U3VyZmFjZS5jcHAKaW5kZXggMDFiNzhiY2Q0MDJhZWM5MzA3ZmU4MzQ2OTE4ZTM5NWI5MDY2ZmNm MC4uNDMwMzI3MTBjZjkyYjc4NDgzZjhkNjY2ZTlkNjhjNDZjZTk5OTRhMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NSZW5kZXJTdXJm YWNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ1JlbmRlclN1cmZhY2UuY3BwCkBAIC01OCwxNSArNTgsNiBAQCBDQ1JlbmRlclN1cmZhY2U6 OkNDUmVuZGVyU3VyZmFjZShDQ0xheWVySW1wbCogb3duaW5nTGF5ZXIpCiAKIENDUmVuZGVyU3Vy ZmFjZTo6fkNDUmVuZGVyU3VyZmFjZSgpCiB7Ci0gICAgY2xlYW51cFJlc291cmNlcygpOwotfQot Ci12b2lkIENDUmVuZGVyU3VyZmFjZTo6Y2xlYW51cFJlc291cmNlcygpCi17Ci0gICAgaWYgKCFt X2NvbnRlbnRzVGV4dHVyZSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgbV9jb250ZW50c1RleHR1 cmUuY2xlYXIoKTsKIH0KIAogRmxvYXRSZWN0IENDUmVuZGVyU3VyZmFjZTo6ZHJhd2FibGVDb250 ZW50UmVjdCgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZS5oCmluZGV4IGU1ZTY4M2E1 MjM2ZWFkNTk1NWE4YjM3ZGYxODdkZTFlZWZmODY3ZDAuLjE0MWVkMmQyNDBlNjQwMGRiNjExYmU5 N2Y3NDAzZjE3ZGUyZmRjODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZS5oCkBAIC01NSw3 ICs1NSw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgcHJlcGFyZUNvbnRlbnRzVGV4dHVyZShMYXll clJlbmRlcmVyQ2hyb21pdW0qKTsKICAgICB2b2lkIHJlbGVhc2VDb250ZW50c1RleHR1cmUoKTsK LSAgICB2b2lkIGNsZWFudXBSZXNvdXJjZXMoKTsKKwogICAgIHZvaWQgZHJhdyhMYXllclJlbmRl cmVyQ2hyb21pdW0qLCBjb25zdCBGbG9hdFJlY3QmIHN1cmZhY2VEYW1hZ2VSZWN0KTsKIAogICAg IFN0cmluZyBuYW1lKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ZpZGVvTGF5ZXJJbXBsLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVmlkZW9MYXllckltcGwuY3BwCmlu ZGV4IDM1ZjI2OWY1MGYxMzc2YWM2MjQ4MWY1NzJiZGY2OGVlMDcwOWY4ZjcuLjNkYmYwZjRkMzg2 NWU1MWQ5NDI2ZjU4OTU1YzllNGFiMTAzM2JjNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVmlkZW9MYXllckltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVmlkZW9MYXll ckltcGwuY3BwCkBAIC04OSw3ICs4OSw2IEBAIENDVmlkZW9MYXllckltcGw6On5DQ1ZpZGVvTGF5 ZXJJbXBsKCkKICAgICB9CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IE1heFBsYW5lczsg KytpKQogICAgICAgICBtX3RleHR1cmVzW2ldLm1fdGV4dHVyZS5jbGVhcigpOwotICAgIGNsZWFu dXBSZXNvdXJjZXMoKTsKIH0KIAogdm9pZCBDQ1ZpZGVvTGF5ZXJJbXBsOjpzdG9wVXNpbmdQcm92 aWRlcigpCg==