80288 2012-03-05 08:01:17 -0800 Make it explicit when we are allowing updates to the actual backing store or the tile buffers 2012-03-06 04:22:22 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf kenneth noam oldest_to_newest 570700 0 ahf 2012-03-05 08:01:17 -0800 We need to make it more clean when we are disallowing updates to either the actual backing store (recreating the tiled region) or to the tile buffers, as this has caused confusions in the past. 570703 1 130136 ahf 2012-03-05 08:04:46 -0800 Created attachment 130136 Patch 570767 2 130136 noam 2012-03-05 09:17:55 -0800 Comment on attachment 130136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=130136&action=review > Source/WebCore/ChangeLog:3 > + Make it explit when we are allowing updates to the actual backing store or the tile buffers you mean explicit? 571718 3 ahf 2012-03-06 04:22:22 -0800 Committed r109897: <http://trac.webkit.org/changeset/109897> 130136 2012-03-05 08:04:46 -0800 2012-03-05 09:17:55 -0800 Patch bug-80288-20120305171245.patch text/plain 3873 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTA5NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM5NjgwYWEyYTI3ZjY2 NGIxNTAyODcwZjIwNTM5Y2ZmNGVmZTAyMC4uYTAyOTY4ZWY5OWNiYTU3YmQ5ZjA0ZDk4NDkzZTM3 MjBhN2YyZjM1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTAzLTA1ICBBbGV4 YW5kZXIgRsOmcsO4eSAgPGFsZXhhbmRlci5mYWVyb3lAbm9raWEuY29tPgogCisgICAgICAgIE1h a2UgaXQgZXhwbGl0IHdoZW4gd2UgYXJlIGFsbG93aW5nIHVwZGF0ZXMgdG8gdGhlIGFjdHVhbCBi YWNraW5nIHN0b3JlIG9yIHRoZSB0aWxlIGJ1ZmZlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwMjg4CisKKyAgICAgICAgUGF0Y2ggYnkgS2VubmV0 aCBSb2hkZSBDaHJpc3RpYW5zZW4gYW5kIEFsZXhhbmRlciBGw6Zyw7h5LgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv VGlsZWRCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRCYWNraW5nU3Rv cmU6OmNyZWF0ZVRpbGVzKToKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkQmFja2luZ1N0b3JlOjpp c0JhY2tpbmdTdG9yZVVwZGF0ZXNTdXNwZW5kZWQpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAg ICAgIChXZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6aXNUaWxlQnVmZmVyVXBkYXRlc1N1c3Bl bmRlZCk6CisgICAgICAgIChXZWJDb3JlOjpUaWxlZEJhY2tpbmdTdG9yZTo6c3RhcnRUaWxlQnVm ZmVyVXBkYXRlVGltZXIpOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRCYWNraW5nU3RvcmU6OnN0 YXJ0VGlsZUNyZWF0aW9uVGltZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1RpbGVk QmFja2luZ1N0b3JlLmg6CisgICAgICAgIChUaWxlZEJhY2tpbmdTdG9yZSk6CisKKzIwMTItMDMt MDUgIEFsZXhhbmRlciBGw6Zyw7h5ICA8YWxleGFuZGVyLmZhZXJveUBub2tpYS5jb20+CisKICAg ICAgICAgUmVtb3ZlIHBvaW50ZXIgdG8gdGltZXIgYW5kIHVzZSB0aGUgdGltZXJzIGRpcmVjdGx5 IGluIHRoZSB0aWxlZCBiYWNraW5nIHN0b3JlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04MDI4MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5jcHAKaW5kZXggYzU1MWVkMWY4M2Mx NmNkYzE0NjIxZTM3ZGQ5MDhkM2FmMTA5MGRmMi4uMzU4N2FlYTU3ODQzODMyMDE1ZjU2MTJiZDk2 NTg1ZGY5N2QyZTUyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvVGlsZWRCYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL1RpbGVkQmFja2luZ1N0b3JlLmNwcApAQCAtMjI4LDcgKzIyOCw5IEBAIGJvb2wgVGls ZWRCYWNraW5nU3RvcmU6OnZpc2libGVBcmVhSXNDb3ZlcmVkKCkgY29uc3QKIAogdm9pZCBUaWxl ZEJhY2tpbmdTdG9yZTo6Y3JlYXRlVGlsZXMoKQogewotICAgIEFTU0VSVCghbV9jb250ZW50c0Zy b3plbik7CisgICAgLy8gR3VhcmQgaGVyZSBhcyBhcyB0aGVzZSBjYW4gY2hhbmdlIGJlZm9yZSB0 aGUgdGltZXIgZmlyZXMuCisgICAgaWYgKGlzQmFja2luZ1N0b3JlVXBkYXRlc1N1c3BlbmRlZCgp KQorICAgICAgICByZXR1cm47CiAKICAgICAvLyBVcGRhdGUgb3VyIGJhY2tpbmcgc3RvcmUgZ2Vv bWV0cnkuCiAgICAgY29uc3QgSW50UmVjdCBwcmV2aW91c1JlY3QgPSBtX3JlY3Q7CkBAIC0zNzEs NiArMzczLDE2IEBAIHZvaWQgVGlsZWRCYWNraW5nU3RvcmU6OmNvbXB1dGVDb3ZlckFuZEtlZXBS ZWN0KGNvbnN0IEludFJlY3QmIHZpc2libGVSZWN0LCBJbnRSCiAgICAgYWRqdXN0Rm9yQ29udGVu dHNSZWN0KGtlZXBSZWN0KTsKIH0KIAorYm9vbCBUaWxlZEJhY2tpbmdTdG9yZTo6aXNCYWNraW5n U3RvcmVVcGRhdGVzU3VzcGVuZGVkKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9jb250ZW50c0Zy b3plbjsKK30KKworYm9vbCBUaWxlZEJhY2tpbmdTdG9yZTo6aXNUaWxlQnVmZmVyVXBkYXRlc1N1 c3BlbmRlZCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fY29udGVudHNGcm96ZW4gfHwgIW1fY2xp ZW50LT50aWxlZEJhY2tpbmdTdG9yZVVwZGF0ZXNBbGxvd2VkKCk7Cit9CisKIGJvb2wgVGlsZWRC YWNraW5nU3RvcmU6OnJlc2l6ZUVkZ2VUaWxlcygpCiB7CiAgICAgYm9vbCB3YXNSZXNpemVkID0g ZmFsc2U7CkBAIC00NzAsNyArNDgyLDcgQEAgVGlsZTo6Q29vcmRpbmF0ZSBUaWxlZEJhY2tpbmdT dG9yZTo6dGlsZUNvb3JkaW5hdGVGb3JQb2ludChjb25zdCBJbnRQb2ludCYgcG9pbnQKIAogdm9p ZCBUaWxlZEJhY2tpbmdTdG9yZTo6c3RhcnRUaWxlQnVmZmVyVXBkYXRlVGltZXIoKQogewotICAg IGlmIChtX3RpbGVCdWZmZXJVcGRhdGVUaW1lci5pc0FjdGl2ZSgpIHx8ICFtX2NsaWVudC0+dGls ZWRCYWNraW5nU3RvcmVVcGRhdGVzQWxsb3dlZCgpIHx8IG1fY29udGVudHNGcm96ZW4pCisgICAg aWYgKG1fdGlsZUJ1ZmZlclVwZGF0ZVRpbWVyLmlzQWN0aXZlKCkgfHwgaXNUaWxlQnVmZmVyVXBk YXRlc1N1c3BlbmRlZCgpKQogICAgICAgICByZXR1cm47CiAgICAgbV90aWxlQnVmZmVyVXBkYXRl VGltZXIuc3RhcnRPbmVTaG90KDApOwogfQpAQCAtNDgyLDcgKzQ5NCw3IEBAIHZvaWQgVGlsZWRC YWNraW5nU3RvcmU6OnRpbGVCdWZmZXJVcGRhdGVUaW1lckZpcmVkKFRpbGVUaW1lciopCiAKIHZv aWQgVGlsZWRCYWNraW5nU3RvcmU6OnN0YXJ0VGlsZUNyZWF0aW9uVGltZXIoKQogewotICAgIGlm IChtX3RpbGVDcmVhdGlvblRpbWVyLmlzQWN0aXZlKCkgfHwgbV9jb250ZW50c0Zyb3plbikKKyAg ICBpZiAobV90aWxlQ3JlYXRpb25UaW1lci5pc0FjdGl2ZSgpIHx8IGlzQmFja2luZ1N0b3JlVXBk YXRlc1N1c3BlbmRlZCgpKQogICAgICAgICByZXR1cm47CiAgICAgbV90aWxlQ3JlYXRpb25UaW1l ci5zdGFydE9uZVNob3QoMCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9UaWxlZEJhY2tpbmdTdG9yZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvVGlsZWRCYWNraW5nU3RvcmUuaAppbmRleCBiYjIzODJmOGY2MWJkMjA4MmVjNzdi ZTc0NGYyYTU5NTg0NzU4YmU0Li5iYmY4OGFkODBiOTQ1YTVkODZmMzNiZjFiYTI1ZWI3NWZiYmVk Nzk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJh Y2tpbmdTdG9yZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1RpbGVk QmFja2luZ1N0b3JlLmgKQEAgLTkwLDYgKzkwLDkgQEAgcHJpdmF0ZToKICAgICB2b2lkIGNyZWF0 ZVRpbGVzKCk7CiAgICAgdm9pZCBjb21wdXRlQ292ZXJBbmRLZWVwUmVjdChjb25zdCBJbnRSZWN0 JiB2aXNpYmxlUmVjdCwgSW50UmVjdCYgY292ZXJSZWN0LCBJbnRSZWN0JiBrZWVwUmVjdCkgY29u c3Q7CiAKKyAgICBib29sIGlzQmFja2luZ1N0b3JlVXBkYXRlc1N1c3BlbmRlZCgpIGNvbnN0Owor ICAgIGJvb2wgaXNUaWxlQnVmZmVyVXBkYXRlc1N1c3BlbmRlZCgpIGNvbnN0OworCiAgICAgdm9p ZCBjb21taXRTY2FsZUNoYW5nZSgpOwogCiAgICAgYm9vbCByZXNpemVFZGdlVGlsZXMoKTsK